November 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: Use config.h with AC_CONFIG_HEADER for defines
by daniel 27 Nov '25

27 Nov '25

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email ) Change subject: Use config.h with AC_CONFIG_HEADER for defines ...................................................................... Use config.h with AC_CONFIG_HEADER for defines Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 --- M configure.ac M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_vty.c M src/xua_asp_fsm.c M stp/stp_main.c 11 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/22/41522/1 diff --git a/configure.ac b/configure.ac index c8f3c91..2f9a352 100644 --- a/configure.ac +++ b/configure.ac @@ -41,6 +41,9 @@ PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.11.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.6.0) +dnl Generate the output +AC_CONFIG_HEADER(config.h) + # TCAP loadsharing AC_ARG_ENABLE([tcap-loadsharing], [AS_HELP_STRING([--enable-tcap-loadsharing], [Build with TCAP loadsharing. Requires libosmo-asn1-tcap [default=no]])], [osmo_ac_tcap="$enableval"],[osmo_ac_tcap="no"]) diff --git a/src/ipa.c b/src/ipa.c index 2a9f7f8..d3999e1 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -20,6 +20,8 @@ * */ +#include "config.h" + #include <stdint.h> #include <errno.h> #include <unistd.h> diff --git a/src/ss7_as.c b/src/ss7_as.c index 808047d..f1c9528 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -21,6 +21,8 @@ * */ +#include "config.h" + #include <string.h> #include <errno.h> #include <unistd.h> diff --git a/src/ss7_as.h b/src/ss7_as.h index b787a92..50df338 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -1,5 +1,7 @@ #pragma once +#include "config.h" + #include <stdint.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/fsm.h> diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index 7878825..f7f3cfe 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -21,6 +21,8 @@ * */ +#include "config.h" + #include <stdlib.h> #include <unistd.h> #include <errno.h> diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 076d91f..161e070 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -21,6 +21,8 @@ * */ +#include "config.h" + #include <string.h> #include <errno.h> #include <unistd.h> diff --git a/src/ss7_asp.h b/src/ss7_asp.h index 5d8002c..da4257a 100644 --- a/src/ss7_asp.h +++ b/src/ss7_asp.h @@ -1,5 +1,7 @@ #pragma once +#include "config.h" + #include <stdint.h> #include <osmocom/core/linuxlist.h> #include <osmocom/core/fsm.h> diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index 9cdaca8..389b02d 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -20,6 +20,8 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. * */ + +#include "config.h" #include <stdlib.h> #include <unistd.h> diff --git a/src/ss7_vty.c b/src/ss7_vty.c index 74ca934..1234c50 100644 --- a/src/ss7_vty.c +++ b/src/ss7_vty.c @@ -20,6 +20,8 @@ * */ +#include "config.h" + #include <stdlib.h> #include <unistd.h> #include <errno.h> diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index b0f26fb..f70e313 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -9,6 +9,8 @@ * osmo-ss7.git */ +#include "config.h" + #include <errno.h> #include <osmocom/core/fsm.h> diff --git a/stp/stp_main.c b/stp/stp_main.c index 2d31ef0..fb5d202 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -18,6 +18,8 @@ * */ +#include "config.h" + #include <stdlib.h> #include <stdio.h> #include <string.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 Gerrit-Change-Number: 41522 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 27 Nov '25

27 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 14: (5 comments) File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fe83ec58_7006e… : PS13, Line 185: > unrelated, since you shouldn't be touching this function in this patch. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d7f68493_31ec0… : PS13, Line 196: as->cfg.loadshare.opc_shift = atoi(argv[5]); > This change looks wrong, should be left untouched? Acknowledged https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/11e85569_18b24… : PS13, Line 214: #ifdef WITH_TCAP_LOADSHARING > This should probably be removed from here, imho tcap routing should be independent of resetting the […] Done File src/tcap_as_loadshare.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/2a6797c1_f9ae8… : PS13, Line 28: struct tcap_range *tcap_range_alloc(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp, > Not blocking, but I think it's good practice to put the _alloc and _free function at the top of all […] fine File tests/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/f428e75c_5d5ea… : PS13, Line 39: VTY_TEST_STP_DEFAULT += osmo_stp_test_tcap.vty > EXTRA_DIST += osmo_stp_test_tcap. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 27 Nov 2025 19:02:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 27 Nov '25

27 Nov '25

Attention is currently required from: laforge, lynxis lazus, pespin. daniel has uploaded a new patch set (#14) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add TCAP based loadsharing/routing ...................................................................... Add TCAP based loadsharing/routing TCAP based loadsharing will share the load based on the TCAP oTID and dTID. Because TCAP are session based, a TCAP session based tracking is implemented, to allow following traffic to forwarded to the same ASP. This TCAP session tracking is similar to IP connection tracking. ASPs within an AS can use the new IPA TCAP ROUTING protocol to register for specific TCAP ranges. TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP), will use the oTID of the `TCAP Begin` to loadshare and select a ASP. Further if the TCAP session was initiated by a `loadshared` ASP, the oTID will be added to the session tracking. Co-authored-by: Harald Welte <laforge(a)osmocom.org> Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu> Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Related: SYS#5423 Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d --- M configure.ac M src/Makefile.am M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.h A src/tcap_as_loadshare.c A src/tcap_as_loadshare.h A src/tcap_trans_tracking.c A src/tcap_trans_tracking.h M src/xua_asp_fsm.c M tests/Makefile.am A tests/tcap/Makefile.am A tests/tcap/tcap_transaction_tracking_test.c A tests/tcap/tcap_transaction_tracking_test.ok M tests/testsuite.at M tests/vty/Makefile.am M tests/vty/osmo_stp_test.vty A tests/vty/osmo_stp_test_tcap.vty 20 files changed, 2,133 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/14 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmocore[master]: Add DLTCAP log category
by daniel 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email ) Change subject: Add DLTCAP log category ...................................................................... Patch Set 2: (1 comment) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/41520/comment/ee1aee84_ff7aaddd?… : PS2, Line 398: .description = "libosmo-sigtran TCAP", > Ack. ```suggestion .description = "TCAP", ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Gerrit-Change-Number: 41520 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 18:44:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: Add DLTCAP log category
by daniel 27 Nov '25

27 Nov '25

daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Add DLTCAP log category ...................................................................... Patch Set 2: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Gerrit-Change-Number: 41520 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 18:42:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: Add DLTCAP log category
by daniel 27 Nov '25

27 Nov '25

daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email ) Change subject: Add DLTCAP log category ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Gerrit-Change-Number: 41520 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 18:41:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmo-sigtran[master]: Split ss7_hmrt.c into mtp3_hm{dc,dt,rt}.c
by pespin 27 Nov '25

27 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41521?usp=email ) Change subject: Split ss7_hmrt.c into mtp3_hm{dc,dt,rt}.c ...................................................................... Split ss7_hmrt.c into mtp3_hm{dc,dt,rt}.c ITU Q.704 (MTP level 3) spec clearly splits the functionality between subsystems/block, and they coordinate through specific events/messages. Let's split our current code base in different files to follow the module split, so it becomes a lot easier to match the spec and extend it with more blocks in the future. The new naming also clarifies this logic happens within the MTP layer3, which communicates with layer2 (MTP2, SCTP in M3UA, etc.) and layer 3 (eg. SCCP). Change-Id: I1b94c1474722b49ce29796681cfbcfce65c95388 --- M src/Makefile.am M src/ipa.c M src/m3ua.c A src/mtp3_hmdc.c A src/mtp3_hmdc.h A src/mtp3_hmdt.c A src/mtp3_hmdt.h A src/mtp3_hmrt.c A src/mtp3_hmrt.h M src/mtp_sap.c D src/ss7_hmrt.c M src/xua_internal.h 12 files changed, 358 insertions(+), 262 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/21/41521/1 diff --git a/src/Makefile.am b/src/Makefile.am index de3d02e..29cf10a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -3,6 +3,9 @@ $(LIBOSMONETIF_CFLAGS) noinst_HEADERS = \ + mtp3_hmdc.h \ + mtp3_hmdt.h \ + mtp3_hmrt.h \ sccp_connection.h \ sccp_scoc_fsm.h \ sccp_instance.h \ @@ -47,6 +50,9 @@ ipa.c \ m3ua.c \ mtp_sap.c \ + mtp3_hmdc.c \ + mtp3_hmdt.c \ + mtp3_hmrt.c \ sccp2sua.c \ sccp_connection.c \ sccp_helpers.c \ @@ -68,7 +74,6 @@ ss7_asp_vty.c \ ss7_asp_peer.c \ ss7_combined_linkset.c \ - ss7_hmrt.c \ ss7_instance.c \ ss7_link.c \ ss7_linkset.c \ diff --git a/src/ipa.c b/src/ipa.c index 2e74414..2083d09 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -37,7 +37,6 @@ //#include <osmocom/netif/stream.h> #include <osmocom/netif/ipa.h> -#include "xua_msg.h" #include <osmocom/sigtran/mtp_sap.h> #include <osmocom/sigtran/sccp_sap.h> @@ -46,11 +45,13 @@ #include <osmocom/sigtran/protocol/sua.h> #include <osmocom/sigtran/protocol/mtp.h> -#include "xua_internal.h" +#include "mtp3_hmdc.h" #include "ss7_as.h" #include "ss7_asp.h" #include "ss7_internal.h" #include "xua_asp_fsm.h" +#include "xua_internal.h" +#include "xua_msg.h" /* generate a msgb containing an IPA CCM PING message */ struct msgb *ipa_gen_ping(void) @@ -344,7 +345,7 @@ /* Pass on as if we had received it from an M3UA ASP. * xua ownership is passed here: */ - rc = m3ua_hmdc_rx_from_l2(asp->inst, xua); + rc = mtp3_hmdc_rx_from_l2(asp->inst, xua); return rc; } diff --git a/src/m3ua.c b/src/m3ua.c index 8e93515..36018e1 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -33,7 +33,6 @@ #include <osmocom/core/socket.h> #include <osmocom/netif/stream.h> -#include "xua_msg.h" #include <osmocom/sigtran/mtp_sap.h> #include <osmocom/sigtran/sccp_sap.h> @@ -41,12 +40,14 @@ #include <osmocom/sigtran/protocol/m3ua.h> #include <osmocom/sigtran/protocol/sua.h> +#include "mtp3_hmdc.h" #include "xua_as_fsm.h" #include "xua_asp_fsm.h" #include "xua_internal.h" #include "ss7_as.h" #include "ss7_asp.h" #include "ss7_internal.h" +#include "xua_msg.h" #define M3UA_MSGB_SIZE 1500 @@ -667,7 +668,7 @@ } /* xua ownership is passed here: */ - return m3ua_hmdc_rx_from_l2(asp->inst, xua); + return mtp3_hmdc_rx_from_l2(asp->inst, xua); ret_free: xua_msg_free(xua); diff --git a/src/mtp3_hmdc.c b/src/mtp3_hmdc.c new file mode 100644 index 0000000..68154a2 --- /dev/null +++ b/src/mtp3_hmdc.c @@ -0,0 +1,52 @@ +/*********************************************************************** + * MTP Level 3 - Message Discrimination (HMDC), ITU Q.704 Figure 24 + ***********************************************************************/ + +/* (C) 2015-2017 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <stdint.h> + +#include <osmocom/core/logging.h> + +#include "mtp3_hmdc.h" +#include "mtp3_hmdt.h" +#include "mtp3_hmrt.h" +#include "ss7_instance.h" +#include "xua_msg.h" + + +/* HMDC: Received Message L2 -> L3; Figure 24/Q.704 */ +/* This means a message was received from L2 and we have to decide if it + * is for the local stack (HMDT) or for routng (HMRT) + * Ownership of xua_msg passed is transferred to this function. */ +int mtp3_hmdc_rx_from_l2(struct osmo_ss7_instance *inst, struct xua_msg *xua) +{ + uint32_t dpc = xua->mtp.dpc; + if (osmo_ss7_pc_is_local(inst, dpc)) { + LOGSS7(inst, LOGL_DEBUG, "%s(): found dpc=%u=%s as local\n", + __func__, dpc, osmo_ss7_pointcode_print(inst, dpc)); + return mtp3_hmdt_message_for_distribution(inst, xua); + } + LOGSS7(inst, LOGL_DEBUG, "%s(): dpc=%u=%s not local, message is for routing\n", + __func__, dpc, osmo_ss7_pointcode_print(inst, dpc)); + return mtp3_hmrt_message_for_routing(inst, xua); +} diff --git a/src/mtp3_hmdc.h b/src/mtp3_hmdc.h new file mode 100644 index 0000000..9f882c5 --- /dev/null +++ b/src/mtp3_hmdc.h @@ -0,0 +1,6 @@ +#pragma once + +#include "ss7_instance.h" +#include "xua_msg.h" + +int mtp3_hmdc_rx_from_l2(struct osmo_ss7_instance *inst, struct xua_msg *xua); diff --git a/src/mtp3_hmdt.c b/src/mtp3_hmdt.c new file mode 100644 index 0000000..a6cf1b3 --- /dev/null +++ b/src/mtp3_hmdt.c @@ -0,0 +1,126 @@ +/*********************************************************************** + * MTP Level 3 - Message Distribution (HMDT), ITU Q.704 Figure 25 + ***********************************************************************/ + +/* (C) 2015-2017 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <osmocom/sigtran/protocol/m3ua.h> +#include <osmocom/sigtran/mtp_sap.h> + +#include "ss7_instance.h" +#include "ss7_user.h" +#include "xua_internal.h" +#include "xua_msg.h" + + +/* convert from M3UA message to MTP-TRANSFER.ind osmo_mtp_prim */ +static struct osmo_mtp_prim *m3ua_to_xfer_ind(struct xua_msg *xua) +{ + struct xua_msg_part *data_ie = xua_msg_find_tag(xua, M3UA_IEI_PROT_DATA); + struct osmo_mtp_prim *prim; + struct m3ua_data_hdr *data_hdr; + + if (!data_ie || data_ie->len < sizeof(*data_hdr)) { + /* FIXME: ERROR message */ + return NULL; + } + data_hdr = (struct m3ua_data_hdr *) data_ie->dat; + + prim = mtp_prim_xfer_ind_alloc(NULL, + data_ie->dat + sizeof(*data_hdr), + data_ie->len - sizeof(*data_hdr)); + m3ua_dh_to_xfer_param(&prim->u.transfer, data_hdr); + + return prim; +} + +/* delivery given XUA message to given SS7 user + * Ownership of xua_msg passed is transferred to this function. + */ +static int deliver_to_mtp_user(const struct osmo_ss7_user *osu, struct xua_msg *xua) +{ + struct osmo_mtp_prim *prim; + int rc; + + /* Create MTP-TRANSFER.ind and feed to user */ + prim = m3ua_to_xfer_ind(xua); + if (!prim) { + rc = -1; + goto ret_free; + } + prim->u.transfer = xua->mtp; + + rc = ss7_user_mtp_sap_prim_up(osu, prim); + +ret_free: + xua_msg_free(xua); + return rc; +} + +/* HMDC -> HMDT: Message for distribution; Figure 25/Q.704 */ +/* This means it is a message we received from remote/L2, and it is to + * be routed to a local user part. + * Ownership of xua_msg passed is transferred to this function. + */ +int mtp3_hmdt_message_for_distribution(struct osmo_ss7_instance *inst, struct xua_msg *xua) +{ + struct m3ua_data_hdr *mdh; + const struct osmo_ss7_user *osu; + uint32_t service_ind; + + switch (xua->hdr.msg_class) { + case M3UA_MSGC_XFER: + switch (xua->hdr.msg_type) { + case M3UA_XFER_DATA: + mdh = data_hdr_from_m3ua(xua); + service_ind = mdh->si & 0xf; + break; + default: + LOGSS7(inst, LOGL_ERROR, "Unknown M3UA XFER Message Type %u\n", xua->hdr.msg_type); + xua_msg_free(xua); + return -1; + } + break; + case M3UA_MSGC_SNM: + /* FIXME */ + /* FIXME: SI = Signalling Network Management -> SRM/SLM/STM */ + /* FIXME: SI = Signalling Network Testing and Maintenance -> SLTC */ + default: + /* Discard Message */ + LOGSS7(inst, LOGL_ERROR, "Unknown M3UA Message Class %u\n", xua->hdr.msg_class); + xua_msg_free(xua); + return -1; + } + + /* "User Part Available?" */ + osu = osmo_ss7_user_find_by_si(inst, service_ind); + if (!osu) { + /* "Discard Message" */ + LOGSS7(inst, LOGL_NOTICE, "No MTP-User for SI %u\n", service_ind); + /* FIXME: User Part Unavailable HMDT -> HMRT */ + xua_msg_free(xua); + return -1; + } + + /* "MTP Transfer indication HMDT→L4" */ + return deliver_to_mtp_user(osu, xua); +} diff --git a/src/mtp3_hmdt.h b/src/mtp3_hmdt.h new file mode 100644 index 0000000..ab8854a --- /dev/null +++ b/src/mtp3_hmdt.h @@ -0,0 +1,6 @@ +#pragma once + +#include "ss7_instance.h" +#include "xua_msg.h" + +int mtp3_hmdt_message_for_distribution(struct osmo_ss7_instance *inst, struct xua_msg *xua); diff --git a/src/mtp3_hmrt.c b/src/mtp3_hmrt.c new file mode 100644 index 0000000..9ab7e33 --- /dev/null +++ b/src/mtp3_hmrt.c @@ -0,0 +1,140 @@ +/*********************************************************************** + * MTP Level 3 - Message Routing (HMRT), ITU Q.704 Figure 26 + ***********************************************************************/ + +/* (C) 2015-2017 by Harald Welte <laforge(a)gnumonks.org> + * (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> + * All Rights Reserved + * + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * + */ + +#include <stdbool.h> +#include <string.h> +#include <errno.h> + +#include <arpa/inet.h> + +#include <osmocom/core/linuxlist.h> +#include <osmocom/core/logging.h> +#include <osmocom/sigtran/mtp_sap.h> +#include <osmocom/sigtran/osmo_ss7.h> +#include <osmocom/sigtran/protocol/m3ua.h> + +#include "mtp3_hmdc.h" +#include "xua_internal.h" +#include "ss7_as.h" +#include "ss7_asp.h" +#include "ss7_linkset.h" +#include "ss7_route.h" +#include "ss7_route_table.h" +#include "ss7_internal.h" +#include "ss7_user.h" + +/* HMDC->HMRT Msg For Routing; Figure 26/Q.704 */ +/* local message was receive d from L4, SRM, SLM, STM or SLTC, or + * remote message received from L2 and HMDC determined msg for routing + * Ownership of xua_msg passed is transferred to this function. + */ +int mtp3_hmrt_message_for_routing(struct osmo_ss7_instance *inst, struct xua_msg *xua) +{ + uint32_t dpc = xua->mtp.dpc; + struct osmo_ss7_route_label rtlabel = { + .opc = xua->mtp.opc, + .dpc = xua->mtp.dpc, + .sls = xua->mtp.sls, + }; + struct osmo_ss7_route *rt; + + /* find route for OPC+DPC+SLS: */ + /* FIXME: unify with gen_mtp_transfer_req_xua() */ + rt = ss7_instance_lookup_route(inst, &rtlabel); + if (rt) { + /* FIXME: DPC SP restart? */ + /* FIXME: DPC Congested? */ + /* FIXME: Select link based on SLS */ + /* FIXME: Transmit over respective Link */ + if (rt->dest.as) { + struct osmo_ss7_as *as = rt->dest.as; + + if (log_check_level(DLSS7, LOGL_DEBUG)) { + /* osmo_ss7_route_name() calls osmo_ss7_pointcode_print() and + * osmo_ss7_pointcode_print2(), guard against its static buffer being + * overwritten. */ + const char *rt_name = osmo_ss7_route_name(rt, false); + LOGSS7(inst, LOGL_DEBUG, "Found route for dpc=%u=%s: %s\n", + dpc, osmo_ss7_pointcode_print(inst, dpc), rt_name); + } + + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TX_MSU_TOTAL); + OSMO_ASSERT(xua->mtp.sls <= 0xf); + rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TX_MSU_SLS_0 + xua->mtp.sls); + + switch (as->cfg.proto) { + case OSMO_SS7_ASP_PROT_M3UA: + LOGSS7(inst, LOGL_DEBUG, "rt->dest.as proto is M3UA for dpc=%u=%s\n", + dpc, osmo_ss7_pointcode_print(inst, dpc)); + return m3ua_tx_xua_as(as, xua); + case OSMO_SS7_ASP_PROT_IPA: + return ipa_tx_xua_as(as, xua); + default: + LOGSS7(inst, LOGL_ERROR, "MTP message for ASP of unknown protocol %u\n", + as->cfg.proto); + break; + } + } else if (rt->dest.linkset) { + if (log_check_level(DLSS7, LOGL_ERROR)) { + /* osmo_ss7_route_name() calls osmo_ss7_pointcode_print() and + * osmo_ss7_pointcode_print2(), guard against its static buffer being + * overwritten. */ + const char *rt_name = osmo_ss7_route_name(rt, false); + LOGSS7(inst, LOGL_ERROR, + "Found route for dpc=%u=%s: %s, but MTP-TRANSFER.req unsupported for linkset.\n", + dpc, osmo_ss7_pointcode_print(inst, dpc), rt_name); + } + } else + OSMO_ASSERT(0); + } else { + LOGSS7(inst, LOGL_ERROR, "MTP-TRANSFER.req for dpc=%u=%s: no route!\n", + dpc, osmo_ss7_pointcode_print(inst, dpc)); + /* DPC unknown HMRT -> MGMT */ + /* Message Received for inaccesible SP HMRT ->RTPC */ + /* Discard Message */ + } + xua_msg_free(xua); + return -1; +} + +/* Figure 26/Q.704 (sheet 1 of 5) "MTP Transfer request L4→L3" */ +int mtp3_hmrt_mtp_xfer_request_l4_to_l3(struct osmo_ss7_instance *inst, const struct osmo_mtp_transfer_param *param, uint8_t *user_data, size_t user_data_len) +{ + struct m3ua_data_hdr data_hdr; + struct xua_msg *xua; + + /* convert from osmo_mtp_prim MTP-TRANSFER.req to xua_msg */ + mtp_xfer_param_to_m3ua_dh(&data_hdr, param); + xua = m3ua_xfer_from_data(&data_hdr, user_data, user_data_len); + OSMO_ASSERT(xua); + xua->mtp = *param; + + /* normally we would call mtp3_hmrt_message_for_routing() here, if we were to follow the state + * diagrams of the ITU-T Q.70x specifications. However, what if a local MTP user sends a + * MTP-TRANSFER.req to a local SSN? This wouldn't work as per the spec, but I believe it + * is a very useful feature (aka "loopback device" in IPv4). So we call + * mtp3_hmdc_rx_from_l2() just like the MTP-TRANSFER had been received from L2. */ + return mtp3_hmdc_rx_from_l2(inst, xua); +} diff --git a/src/mtp3_hmrt.h b/src/mtp3_hmrt.h new file mode 100644 index 0000000..4e51570 --- /dev/null +++ b/src/mtp3_hmrt.h @@ -0,0 +1,12 @@ +#pragma once + +#include <stdint.h> +#include <unistd.h> + +#include <osmocom/sigtran/mtp_sap.h> + +#include "ss7_instance.h" +#include "xua_msg.h" + +int mtp3_hmrt_mtp_xfer_request_l4_to_l3(struct osmo_ss7_instance *inst, const struct osmo_mtp_transfer_param *param, uint8_t *user_data, size_t user_data_len); +int mtp3_hmrt_message_for_routing(struct osmo_ss7_instance *inst, struct xua_msg *xua); diff --git a/src/mtp_sap.c b/src/mtp_sap.c index 8c21f53..69838dd 100644 --- a/src/mtp_sap.c +++ b/src/mtp_sap.c @@ -27,6 +27,7 @@ #include <osmocom/sigtran/osmo_ss7.h> #include <osmocom/sigtran/mtp_sap.h> +#include "mtp3_hmrt.h" #include "ss7_user.h" #include "ss7_internal.h" #include "xua_internal.h" @@ -220,8 +221,8 @@ switch (OSMO_PRIM_HDR(&omp->oph)) { case OSMO_PRIM(OSMO_MTP_PRIM_TRANSFER, PRIM_OP_REQUEST): - rc = hmrt_mtp_xfer_request_l4_to_l3(osu->inst, &omp->u.transfer, - msgb_l2(msg), msgb_l2len(msg)); + rc = mtp3_hmrt_mtp_xfer_request_l4_to_l3(osu->inst, &omp->u.transfer, + msgb_l2(msg), msgb_l2len(msg)); break; default: LOGPSS7U(osu, LOGL_ERROR, "Ignoring unknown primitive %u:%u\n", diff --git a/src/ss7_hmrt.c b/src/ss7_hmrt.c deleted file mode 100644 index 72b26d8..0000000 --- a/src/ss7_hmrt.c +++ /dev/null @@ -1,250 +0,0 @@ -/*********************************************************************** - * MTP Level 3 - Signalling message handling (SMH) Figure 23/Q.704 - ***********************************************************************/ - -/* (C) 2015-2017 by Harald Welte <laforge(a)gnumonks.org> - * All Rights Reserved - * - * SPDX-License-Identifier: GPL-2.0+ - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * - */ - -#include <stdbool.h> -#include <string.h> -#include <errno.h> - -#include <arpa/inet.h> - -#include <osmocom/core/linuxlist.h> -#include <osmocom/core/logging.h> -#include <osmocom/sigtran/mtp_sap.h> -#include <osmocom/sigtran/osmo_ss7.h> -#include <osmocom/sigtran/protocol/m3ua.h> - -#include "xua_internal.h" -#include "ss7_as.h" -#include "ss7_asp.h" -#include "ss7_linkset.h" -#include "ss7_route.h" -#include "ss7_route_table.h" -#include "ss7_internal.h" -#include "ss7_user.h" - -/* convert from M3UA message to MTP-TRANSFER.ind osmo_mtp_prim */ -static struct osmo_mtp_prim *m3ua_to_xfer_ind(struct xua_msg *xua) -{ - struct xua_msg_part *data_ie = xua_msg_find_tag(xua, M3UA_IEI_PROT_DATA); - struct osmo_mtp_prim *prim; - struct m3ua_data_hdr *data_hdr; - - if (!data_ie || data_ie->len < sizeof(*data_hdr)) { - /* FIXME: ERROR message */ - return NULL; - } - data_hdr = (struct m3ua_data_hdr *) data_ie->dat; - - prim = mtp_prim_xfer_ind_alloc(NULL, - data_ie->dat + sizeof(*data_hdr), - data_ie->len - sizeof(*data_hdr)); - m3ua_dh_to_xfer_param(&prim->u.transfer, data_hdr); - - return prim; -} - -/* delivery given XUA message to given SS7 user - * Ownership of xua_msg passed is transferred to this function. - */ -static int deliver_to_mtp_user(const struct osmo_ss7_user *osu, struct xua_msg *xua) -{ - struct osmo_mtp_prim *prim; - int rc; - - /* Create MTP-TRANSFER.ind and feed to user */ - prim = m3ua_to_xfer_ind(xua); - if (!prim) { - rc = -1; - goto ret_free; - } - prim->u.transfer = xua->mtp; - - rc = ss7_user_mtp_sap_prim_up(osu, prim); - -ret_free: - xua_msg_free(xua); - return rc; -} - -/* HMDC -> HMDT: Message for distribution; Figure 25/Q.704 */ -/* This means it is a message we received from remote/L2, and it is to - * be routed to a local user part. - * Ownership of xua_msg passed is transferred to this function. - */ -static int hmdt_message_for_distribution(struct osmo_ss7_instance *inst, struct xua_msg *xua) -{ - struct m3ua_data_hdr *mdh; - const struct osmo_ss7_user *osu; - uint32_t service_ind; - - switch (xua->hdr.msg_class) { - case M3UA_MSGC_XFER: - switch (xua->hdr.msg_type) { - case M3UA_XFER_DATA: - mdh = data_hdr_from_m3ua(xua); - service_ind = mdh->si & 0xf; - break; - default: - LOGSS7(inst, LOGL_ERROR, "Unknown M3UA XFER Message Type %u\n", xua->hdr.msg_type); - xua_msg_free(xua); - return -1; - } - break; - case M3UA_MSGC_SNM: - /* FIXME */ - /* FIXME: SI = Signalling Network Management -> SRM/SLM/STM */ - /* FIXME: SI = Signalling Network Testing and Maintenance -> SLTC */ - default: - /* Discard Message */ - LOGSS7(inst, LOGL_ERROR, "Unknown M3UA Message Class %u\n", xua->hdr.msg_class); - xua_msg_free(xua); - return -1; - } - - /* "User Part Available?" */ - osu = osmo_ss7_user_find_by_si(inst, service_ind); - if (!osu) { - /* "Discard Message" */ - LOGSS7(inst, LOGL_NOTICE, "No MTP-User for SI %u\n", service_ind); - /* FIXME: User Part Unavailable HMDT -> HMRT */ - xua_msg_free(xua); - return -1; - } - - /* "MTP Transfer indication HMDT→L4" */ - return deliver_to_mtp_user(osu, xua); -} - -/* HMDC->HMRT Msg For Routing; Figure 26/Q.704 */ -/* local message was receive d from L4, SRM, SLM, STM or SLTC, or - * remote message received from L2 and HMDC determined msg for routing - * Ownership of xua_msg passed is transferred to this function. - */ -static int hmrt_message_for_routing(struct osmo_ss7_instance *inst, - struct xua_msg *xua) -{ - uint32_t dpc = xua->mtp.dpc; - struct osmo_ss7_route_label rtlabel = { - .opc = xua->mtp.opc, - .dpc = xua->mtp.dpc, - .sls = xua->mtp.sls, - }; - struct osmo_ss7_route *rt; - - /* find route for OPC+DPC+SLS: */ - /* FIXME: unify with gen_mtp_transfer_req_xua() */ - rt = ss7_instance_lookup_route(inst, &rtlabel); - if (rt) { - /* FIXME: DPC SP restart? */ - /* FIXME: DPC Congested? */ - /* FIXME: Select link based on SLS */ - /* FIXME: Transmit over respective Link */ - if (rt->dest.as) { - struct osmo_ss7_as *as = rt->dest.as; - - if (log_check_level(DLSS7, LOGL_DEBUG)) { - /* osmo_ss7_route_name() calls osmo_ss7_pointcode_print() and - * osmo_ss7_pointcode_print2(), guard against its static buffer being - * overwritten. */ - const char *rt_name = osmo_ss7_route_name(rt, false); - LOGSS7(inst, LOGL_DEBUG, "Found route for dpc=%u=%s: %s\n", - dpc, osmo_ss7_pointcode_print(inst, dpc), rt_name); - } - - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TX_MSU_TOTAL); - OSMO_ASSERT(xua->mtp.sls <= 0xf); - rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TX_MSU_SLS_0 + xua->mtp.sls); - - switch (as->cfg.proto) { - case OSMO_SS7_ASP_PROT_M3UA: - LOGSS7(inst, LOGL_DEBUG, "rt->dest.as proto is M3UA for dpc=%u=%s\n", - dpc, osmo_ss7_pointcode_print(inst, dpc)); - return m3ua_tx_xua_as(as, xua); - case OSMO_SS7_ASP_PROT_IPA: - return ipa_tx_xua_as(as, xua); - default: - LOGSS7(inst, LOGL_ERROR, "MTP message for ASP of unknown protocol %u\n", - as->cfg.proto); - break; - } - } else if (rt->dest.linkset) { - if (log_check_level(DLSS7, LOGL_ERROR)) { - /* osmo_ss7_route_name() calls osmo_ss7_pointcode_print() and - * osmo_ss7_pointcode_print2(), guard against its static buffer being - * overwritten. */ - const char *rt_name = osmo_ss7_route_name(rt, false); - LOGSS7(inst, LOGL_ERROR, - "Found route for dpc=%u=%s: %s, but MTP-TRANSFER.req unsupported for linkset.\n", - dpc, osmo_ss7_pointcode_print(inst, dpc), rt_name); - } - } else - OSMO_ASSERT(0); - } else { - LOGSS7(inst, LOGL_ERROR, "MTP-TRANSFER.req for dpc=%u=%s: no route!\n", - dpc, osmo_ss7_pointcode_print(inst, dpc)); - /* DPC unknown HMRT -> MGMT */ - /* Message Received for inaccesible SP HMRT ->RTPC */ - /* Discard Message */ - } - xua_msg_free(xua); - return -1; -} - -/* HMDC: Received Message L2 -> L3; Figure 24/Q.704 */ -/* This means a message was received from L2 and we have to decide if it - * is for the local stack (HMDT) or for routng (HMRT) - * Ownership of xua_msg passed is transferred to this function. */ -int m3ua_hmdc_rx_from_l2(struct osmo_ss7_instance *inst, struct xua_msg *xua) -{ - uint32_t dpc = xua->mtp.dpc; - if (osmo_ss7_pc_is_local(inst, dpc)) { - LOGSS7(inst, LOGL_DEBUG, "%s(): found dpc=%u=%s as local\n", - __func__, dpc, osmo_ss7_pointcode_print(inst, dpc)); - return hmdt_message_for_distribution(inst, xua); - } else { - LOGSS7(inst, LOGL_DEBUG, "%s(): dpc=%u=%s not local, message is for routing\n", - __func__, dpc, osmo_ss7_pointcode_print(inst, dpc)); - return hmrt_message_for_routing(inst, xua); - } -} - -/* Figure 26/Q.704 (sheet 1 of 5) "MTP Transfer request L4→L3" */ -int hmrt_mtp_xfer_request_l4_to_l3(struct osmo_ss7_instance *inst, const struct osmo_mtp_transfer_param *param, uint8_t *user_data, size_t user_data_len) -{ - struct m3ua_data_hdr data_hdr; - struct xua_msg *xua; - - /* convert from osmo_mtp_prim MTP-TRANSFER.req to xua_msg */ - mtp_xfer_param_to_m3ua_dh(&data_hdr, param); - xua = m3ua_xfer_from_data(&data_hdr, user_data, user_data_len); - OSMO_ASSERT(xua); - xua->mtp = *param; - - /* normally we would call hmrt_message_for_routing() here, if we were to follow the state - * diagrams of the ITU-T Q.70x specifications. However, what if a local MTP user sends a - * MTP-TRANSFER.req to a local SSN? This wouldn't work as per the spec, but I believe it - * is a very useful feature (aka "loopback device" in IPv4). So we call - * m3ua_hmdc_rx_from_l2() just like the MTP-TRANSFER had been received from L2. */ - return m3ua_hmdc_rx_from_l2(inst, xua); -} diff --git a/src/xua_internal.h b/src/xua_internal.h index 54172ff..a1023c1 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -39,7 +39,6 @@ struct xua_msg *sua_gen_cldr(const struct xua_msg *xua_in, uint32_t route_ctx, uint32_t ret_cause); -int m3ua_hmdc_rx_from_l2(struct osmo_ss7_instance *inst, struct xua_msg *xua); struct msgb *m3ua_to_msg(struct xua_msg *xua); int m3ua_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua); void m3ua_tx_snm_available(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, @@ -73,9 +72,6 @@ const struct m3ua_data_hdr *mdh); void mtp_xfer_param_to_m3ua_dh(struct m3ua_data_hdr *mdh, const struct osmo_mtp_transfer_param *param); -int hmrt_mtp_xfer_request_l4_to_l3(struct osmo_ss7_instance *inst, - const struct osmo_mtp_transfer_param *param, - uint8_t *user_data, size_t user_data_len); extern const struct xua_msg_class m3ua_msg_class_mgmt; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41521?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I1b94c1474722b49ce29796681cfbcfce65c95388 Gerrit-Change-Number: 41521 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: Add DLTCAP log category
by fixeria 27 Nov '25

27 Nov '25

Attention is currently required from: daniel. fixeria has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email ) Change subject: Add DLTCAP log category ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/41520/comment/87f44504_dce09c57?… : PS2, Line 398: .description = "libosmo-sigtran TCAP", > I would maybe remove libosmo-sigtran from here, maybe we can use it in libosmo-asn1-tcap for instanc […] Ack. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Gerrit-Change-Number: 41520 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 18:07:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 27 Nov 2025 18:05:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Add rate counters for loadshare-tcap
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, lynxis lazus, osmith. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email ) Change subject: Add rate counters for loadshare-tcap ...................................................................... Patch Set 13: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id67704991feacf54e3123f76e9506dd323b2498b Gerrit-Change-Number: 41310 Gerrit-PatchSet: 13 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 27 Nov 2025 18:04:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025