November 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by pespin 28 Nov '25

28 Nov '25

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 28 Nov 2025 08:22:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: Add DLTCAP log category
by fixeria 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, pespin. fixeria has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email ) Change subject: Add DLTCAP log category ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I004dddeeb7db3b47d373bb6281708f33d6e8148f Gerrit-Change-Number: 41520 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 19:54:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Use config.h with AC_CONFIG_HEADER for defines
by daniel 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Use config.h with AC_CONFIG_HEADER for defines ...................................................................... Use config.h with AC_CONFIG_HEADER for defines Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 --- M configure.ac M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_vty.c M src/xua_asp_fsm.c M stp/stp_main.c M tests/ss7/ss7_test.c M tests/vty/ss7_asp_vty_test.c 13 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/22/41522/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 Gerrit-Change-Number: 41522 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Use config.h with AC_CONFIG_HEADER for defines
by Jenkins Builder 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, pespin. Jenkins Builder has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email ) Change subject: Use config.h with AC_CONFIG_HEADER for defines ...................................................................... Patch Set 2: (2 comments) File src/ss7_asp_vty.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522/comment/41a94e02_d0291… : PS2, Line 23: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522/comment/f1566eb0_fb063… : PS2, Line 23: please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 Gerrit-Change-Number: 41522 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 19:45:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: Use DLTCAP for TCAP log messages
by daniel 27 Nov '25

27 Nov '25

daniel has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email ) Change subject: Use DLTCAP for TCAP log messages ...................................................................... Use DLTCAP for TCAP log messages Depends: libosmocore.git Change-Id I004dddeeb7db3b47d373bb6281708f33d6e8148f Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df --- M src/tcap_as_loadshare.c M src/tcap_trans_tracking.c 2 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/23/41523/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df Gerrit-Change-Number: 41523 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[M] Change in libosmo-sigtran[master]: Add VTY command to list TCAP ranges for an AS
by daniel 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, lynxis lazus, pespin. daniel has uploaded a new patch set (#15) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified-1 by Jenkins Builder Change subject: Add VTY command to list TCAP ranges for an AS ...................................................................... Add VTY command to list TCAP ranges for an AS Show the list of all tcap ranges and ASP for an AS: OsmoSTP# show cs7 instance 0 as name as-ipa-loadshare-0 tcap-ranges Tid Min Tid Max SSN PC ASP Name ------- ------- --- ------------- ------------ 300 599 0 (no PC) asp-ipa-loadshare-0-1 0 299 0 (no PC) asp-ipa-loadshare-0-0 Show the tcap range and ASP for specific TCAP Id: OsmoSTP# show cs7 instance 0 as name as-ipa-loadshare-0 tcap-ranges tid 15 Tid Min Tid Max SSN PC ASP Name ------- ------- --- ------------- ------------ 0 299 0 (no PC) asp-ipa-loadshare-0-0 Related: SYS#5423 Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf --- M src/Makefile.am M src/ss7_vty.c A src/tcap_as_loadshare_vty.c A src/tcap_as_loadshare_vty.h M tests/vty/osmo_stp_test.vty M tests/vty/osmo_stp_test_tcap.vty 6 files changed, 165 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/41311/15 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8026248d9897aadab5bf13a425269ec1e948dfdf Gerrit-Change-Number: 41311 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XL] Change in libosmo-sigtran[master]: Add TCAP based loadsharing/routing
by daniel 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, laforge, lynxis lazus, pespin. daniel has uploaded a new patch set (#15) to the change originally created by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Add TCAP based loadsharing/routing ...................................................................... Add TCAP based loadsharing/routing TCAP based loadsharing will share the load based on the TCAP oTID and dTID. Because TCAP are session based, a TCAP session based tracking is implemented, to allow following traffic to forwarded to the same ASP. This TCAP session tracking is similar to IP connection tracking. ASPs within an AS can use the new IPA TCAP ROUTING protocol to register for specific TCAP ranges. TCAP sessions initiated by a peer (traffic towards such loadsharing AS/ASP), will use the oTID of the `TCAP Begin` to loadshare and select a ASP. Further if the TCAP session was initiated by a `loadshared` ASP, the oTID will be added to the session tracking. Co-authored-by: Harald Welte <laforge(a)osmocom.org> Co-authored-by: Alexander Couzens <lynxis(a)fe80.eu> Co-authored-by: Pau Espin Pedrol <pespin(a)sysmocom.de> Related: SYS#5423 Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d --- M configure.ac M src/Makefile.am M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.h A src/tcap_as_loadshare.c A src/tcap_as_loadshare.h A src/tcap_trans_tracking.c A src/tcap_trans_tracking.h M src/xua_asp_fsm.c M tests/Makefile.am A tests/tcap/Makefile.am A tests/tcap/tcap_transaction_tracking_test.c A tests/tcap/tcap_transaction_tracking_test.ok M tests/testsuite.at M tests/vty/Makefile.am M tests/vty/osmo_stp_test.vty A tests/vty/osmo_stp_test_tcap.vty 20 files changed, 1,980 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/41309/15 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: Use config.h with AC_CONFIG_HEADER for defines
by daniel 27 Nov '25

27 Nov '25

Attention is currently required from: daniel, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Use config.h with AC_CONFIG_HEADER for defines ...................................................................... Use config.h with AC_CONFIG_HEADER for defines Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 --- M configure.ac M src/ipa.c M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/ss7_asp.c M src/ss7_asp.h M src/ss7_asp_vty.c M src/ss7_vty.c M src/xua_asp_fsm.c M stp/stp_main.c M tests/ss7/ss7_test.c M tests/vty/ss7_asp_vty_test.c 13 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/22/41522/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 Gerrit-Change-Number: 41522 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: Use DLTCAP for TCAP log messages
by daniel 27 Nov '25

27 Nov '25

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email ) Change subject: Use DLTCAP for TCAP log messages ...................................................................... Use DLTCAP for TCAP log messages Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df --- M src/tcap_as_loadshare.c M src/tcap_trans_tracking.c 2 files changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/23/41523/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index ea735c1..32e9f54 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -76,7 +76,7 @@ asn_rc = ber_decode(0, &asn_DEF_TCAP_TCMessage, (void **)&tcapmsg, data, len); if (asn_rc.code != RC_OK) { - LOGPAS(as, DLSS7, LOGL_DEBUG, "Error decoding TCAP message rc: %d, message: %s\n", + LOGPAS(as, DLTCAP, LOGL_DEBUG, "Error decoding TCAP message rc: %d, message: %s\n", asn_rc.code, osmo_hexdump(data, len)); rc = -EINVAL; goto free_asn; @@ -287,7 +287,7 @@ int rc; struct xua_msg *sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to parse SCCP message\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP message\n"); return -1; } @@ -297,14 +297,14 @@ rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); return -3; } /* retrieve + decode destination address */ rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); return -4; } @@ -332,11 +332,11 @@ rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); if (rc <= 0) { - LOGPAS(as, DLSS7, LOGL_ERROR, "TCAP: failed get otid/dtid.\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Failed get TCAP otid/dtid.\n"); return -7; } - LOGPAS(as, DLSS7, LOGL_INFO, "TCAP: Looking up transaction for type 0x%02x, otid=%u dtid=%u\n", parsed.present, parsed.otid, parsed.dtid); + LOGPAS(as, DLTCAP, LOGL_INFO, "Looking up transaction for type 0x%02x, otid=%u dtid=%u\n", parsed.present, parsed.otid, parsed.dtid); /* TCAP messages towards the IPAC nodes */ switch (parsed.present) { case TCAP_TCMessage_PR_begin: @@ -414,7 +414,7 @@ if (!sua) return -ENOMEM; - LOGPAS(as, DLSS7, LOGL_INFO, "TCAP: Tx UDTS: %s\n", xua_msg_dump(sua, &xua_dialect_sua)); + LOGPAS(as, DLTCAP, LOGL_INFO, "Tx UDTS: %s\n", xua_msg_dump(sua, &xua_dialect_sua)); msg = osmo_sua_to_sccp(sua); if (!msg) { @@ -458,7 +458,7 @@ /* decode SCCP and convert to a SUA/xUA representation */ sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to parse SCCP message\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP message\n"); rc = -EPROTONOSUPPORT; goto out_free_msgb; } @@ -472,13 +472,13 @@ rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to parse SCCP Source Address\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Source Address\n"); goto out_free_sua; } rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); goto out_free_sua; } @@ -508,11 +508,11 @@ } rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); - LOGPAS(as, DLSS7, LOGL_DEBUG, "TCAP: decoded rc=%d otid=%u dtid=%u\n", rc, parsed.otid, parsed.dtid); + LOGPAS(as, DLTCAP, LOGL_DEBUG, "TCAP decoded rc=%d otid=%u dtid=%u\n", rc, parsed.otid, parsed.dtid); if (rc <= 0) { rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_TCAP_FAILED); - LOGPAS(as, DLSS7, LOGL_ERROR, "TCAP: failed get otid/dtid.\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Failed get TCAP otid/dtid.\n"); rc = -EINVAL; goto out_free_sua; } @@ -539,7 +539,7 @@ else { /* couldn't find a suitable canditate for OTID */ rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FAILED); - LOGPAS(as, DLSS7, LOGL_DEBUG, "TCAP: couldn't find a suitable canditate for otid %u\n", parsed.otid); + LOGPAS(as, DLTCAP, LOGL_DEBUG, "Couldn't find a suitable canditate for otid %u\n", parsed.otid); rc = -ENOKEY; goto out_free_sua; } @@ -620,13 +620,13 @@ * extract the SCCP payload and convert to a msgb */ m3ua_data_ie = xua_msg_find_tag(xua, M3UA_IEI_PROT_DATA); if (!m3ua_data_ie) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Couldn't find M3UA protocol data\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Couldn't find M3UA protocol data\n"); return -EPROTONOSUPPORT; } sccp_msg = msgb_alloc(m3ua_data_ie->len, "loadshare_tcap"); if (!sccp_msg) { - LOGPAS(as, DLSS7, LOGL_ERROR, "Unable to allocate SCCP message buffer\n"); + LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to allocate SCCP message buffer\n"); return -ENOMEM; } cur = msgb_put(sccp_msg, m3ua_data_ie->len); @@ -717,7 +717,7 @@ enum ipa_tcap_routing_msg_types routing_msg; if (!as) { - LOGPASP(asp, DLSS7, LOGL_ERROR, "Rx message for IPA ASP without AS?!\n"); + LOGPASP(asp, DLTCAP, LOGL_ERROR, "Rx message for IPA ASP without AS?!\n"); rc = -ENOENT; goto out; } @@ -725,7 +725,7 @@ /* pull the IPA and OSMO_EXT header */ hdr = (struct ipa_tcap_routing_hdr *) msgb_data(msg); if (msgb_length(msg) < sizeof(struct ipa_tcap_routing_hdr)) { - LOGPASP(asp, DLSS7, LOGL_ERROR, "TCAP routing message too short\n"); + LOGPASP(asp, DLTCAP, LOGL_ERROR, "TCAP routing message too short\n"); rc = -EINVAL; goto out; } @@ -737,10 +737,10 @@ struct ipa_tcap_routing_add_range tcar = {}; if (!as->cfg.loadshare.tcap.enabled || as->cfg.mode != OSMO_SS7_AS_TMOD_LOADSHARE) - LOGPASP(asp, DLSS7, LOGL_NOTICE, "Wrong traffic mode %s on AS %s will not use TCAP Ranges\n", osmo_ss7_as_traffic_mode_name(as->cfg.mode), as->cfg.name); + LOGPASP(asp, DLTCAP, LOGL_NOTICE, "Wrong traffic mode %s on AS %s will not use TCAP Ranges\n", osmo_ss7_as_traffic_mode_name(as->cfg.mode), as->cfg.name); if (msgb_length(msg) < sizeof(*hdr) + sizeof(struct ipa_tcap_routing_add_range)) { - LOGPASP(asp, DLSS7, LOGL_ERROR, "TCAP routing message is too small\n"); + LOGPASP(asp, DLTCAP, LOGL_ERROR, "TCAP routing message is too small\n"); rc = -EINVAL; goto out; } @@ -752,11 +752,11 @@ tcar.pc = msgb_pull_u32(msg); tcar.ssn = msgb_pull_u8(msg); - LOGPASP(asp, DLSS7, LOGL_INFO, "Rx: TCAP Add Range command: seq: %u pc: %u ssn: %u [%u-%u]\n", osmo_ntohl(hdr->seq), tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); + LOGPASP(asp, DLTCAP, LOGL_INFO, "Rx: TCAP Add Range command: seq: %u pc: %u ssn: %u [%u-%u]\n", osmo_ntohl(hdr->seq), tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); tcrng = tcap_overlap_tid(as, tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); if (tcrng) { - LOGPASP(asp, DLSS7, LOGL_ERROR, "New TCAP Range overlaps with existing range to ASP %s [%u-%u]. Rejecting Add Range Command seq: %u pc: %u ssn: %u [%u-%u]\n", + LOGPASP(asp, DLTCAP, LOGL_ERROR, "New TCAP Range overlaps with existing range to ASP %s [%u-%u]. Rejecting Add Range Command seq: %u pc: %u ssn: %u [%u-%u]\n", tcrng->asp->cfg.name, tcrng->tid_start, tcrng->tid_end, osmo_ntohl(hdr->seq), tcar.pc, tcar.ssn, tcar.tid_start, tcar.tid_end); rc = ipa_tx_tcap_routing_nack(asp, osmo_ntohl(hdr->seq), NACK_ERR_EALREADY); goto out; @@ -764,7 +764,7 @@ tcrng = tcap_range_alloc(as, asp, tcar.tid_start, tcar.tid_end, tcar.pc, tcar.ssn); if (!tcrng) { - LOGPASP(asp, DLSS7, LOGL_ERROR, "TCAP Add Range: failed to allocate memory\n"); + LOGPASP(asp, DLTCAP, LOGL_ERROR, "TCAP Add Range: failed to allocate memory\n"); rc = ipa_tx_tcap_routing_nack(asp, osmo_ntohl(hdr->seq), NACK_ERR_SYS_FAILURE); goto out; } diff --git a/src/tcap_trans_tracking.c b/src/tcap_trans_tracking.c index 2123b34..a5a0ca6 100644 --- a/src/tcap_trans_tracking.c +++ b/src/tcap_trans_tracking.c @@ -121,7 +121,7 @@ /* TODO: optimisation: add a llist to asp to allow cleaning it up easier */ - LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Creating tcap cache, entry (own) pc/ssn/tid %s/%u/%u -> %s/%u/%u\n", + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Creating tcap cache, entry (own) pc/ssn/tid %s/%u/%u -> %s/%u/%u\n", osmo_ss7_pointcode_print_buf(own_pc, sizeof(own_pc), as->inst, entry->own_addr->pc), entry->own_addr->ssn, entry->own_tid.tid, osmo_ss7_pointcode_print_buf(peer_pc, sizeof(peer_pc), as->inst, entry->peer_addr->pc), @@ -318,7 +318,7 @@ hash_for_each_safe(as->tcap.trans_track_own, i, tmp, entry, own_tid.list) { if (entry->tstamp < expiry) { count++; - LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (expired)\n", entry->own_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (expired)\n", entry->own_tid.tid); tcap_trans_track_entry_free(entry); } } @@ -326,7 +326,7 @@ hash_for_each_safe(as->tcap.trans_track_peer, i, tmp, entry, peer_tid.list) { if (entry->tstamp < expiry) { count++; - LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Remove Cache entry for tcap peer tid %u (expired)\n", entry->peer_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap peer tid %u (expired)\n", entry->peer_tid.tid); tcap_trans_track_entry_free(entry); } } @@ -340,7 +340,7 @@ int counts = tcap_trans_track_garbage_collect(as); if (counts) - LOGPAS(as, DLSS7, LOGL_DEBUG, "Removed %d cache entry (expired)", counts); + LOGPAS(as, DLTCAP, LOGL_DEBUG, "Removed %d cache entry (expired)", counts); osmo_timer_schedule(&as->tcap.gc_timer, as->cfg.loadshare.tcap.timeout_s, 0); } @@ -366,7 +366,7 @@ hash_for_each_safe(as->tcap.trans_track_own, i, tmp, entry, own_tid.list) { if (entry->asp == asp) { count++; - LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)", entry->own_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)", entry->own_tid.tid); tcap_trans_track_entry_free(entry); } } @@ -374,7 +374,7 @@ hash_for_each_safe(as->tcap.trans_track_peer, i, tmp, entry, peer_tid.list) { if (entry->asp == asp) { count++; - LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)", entry->peer_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (asp removed)", entry->peer_tid.tid); tcap_trans_track_entry_free(entry); } } @@ -390,13 +390,13 @@ hash_for_each_safe(as->tcap.trans_track_own, i, tmp, entry, own_tid.list) { count++; - LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)", entry->own_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)", entry->own_tid.tid); tcap_trans_track_entry_free(entry); } hash_for_each_safe(as->tcap.trans_track_peer, i, tmp, entry, peer_tid.list) { count++; - LOGPASP(entry->asp, DLSS7, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)", entry->peer_tid.tid); + LOGPASP(entry->asp, DLTCAP, LOGL_DEBUG, "Remove Cache entry for tcap own tid %u (as removed)", entry->peer_tid.tid); tcap_trans_track_entry_free(entry); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic2fba30208a11d562fc67bb6f5c4586451a275df Gerrit-Change-Number: 41523 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: Use config.h with AC_CONFIG_HEADER for defines
by Jenkins Builder 27 Nov '25

27 Nov '25

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email ) Change subject: Use config.h with AC_CONFIG_HEADER for defines ...................................................................... Patch Set 1: (2 comments) File src/ss7_asp_vty.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522/comment/7e2b6bc1_cac80… : PS1, Line 23: trailing whitespace Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522/comment/0b758acb_6972e… : PS1, Line 23: please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I15c25b04dc7ef62f46e2429042613ff8f7ca9ce9 Gerrit-Change-Number: 41522 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 19:20:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025