Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email ) Change subject: Add TCAP based loadsharing/routing ...................................................................... Patch Set 14: (5 comments) File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/fe83ec58_7006e0... : PS13, Line 185:

unrelated, since you shouldn't be touching this function in this patch. Done

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/d7f68493_31ec0f... : PS13, Line 196: as->cfg.loadshare.opc_shift = atoi(argv[5]);

This change looks wrong, should be left untouched? Acknowledged

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/11e85569_18b24c... : PS13, Line 214: #ifdef WITH_TCAP_LOADSHARING

This should probably be removed from here, imho tcap routing should be independent of resetting the […] Done

File src/tcap_as_loadshare.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/2a6797c1_f9ae89... : PS13, Line 28: struct tcap_range *tcap_range_alloc(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp,

Not blocking, but I think it's good practice to put the _alloc and _free function at the top of all […] fine

File tests/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309/comment/f428e75c_5d5ea9... : PS13, Line 39: VTY_TEST_STP_DEFAULT += osmo_stp_test_tcap.vty

EXTRA_DIST += osmo_stp_test_tcap. […] Done

-- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb48aa0e515ad346f59ddd84b24c6e2c026144d Gerrit-Change-Number: 41309 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 27 Nov 2025 19:02:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>