Attention is currently required from: laforge, lynxis lazus, pespin.

View Change

5 comments:

• File src/ss7_as_vty.c:

  • Patch Set #13, Line 185:

    unrelated, since you shouldn't be touching this function in this patch.

    Done

  • Patch Set #13, Line 196: as->cfg.loadshare.opc_shift = atoi(argv[5]);

    This change looks wrong, should be left untouched?

    Acknowledged

  • Patch Set #13, Line 214: #ifdef WITH_TCAP_LOADSHARING

    This should probably be removed from here, imho tcap routing should be independent of resetting the […]

    Done

• File src/tcap_as_loadshare.h:

  • Patch Set #13, Line 28: struct tcap_range *tcap_range_alloc(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp,

    Not blocking, but I think it's good practice to put the _alloc and _free function at the top of all […]

    fine

• File tests/vty/Makefile.am:

  • Patch Set #13, Line 39: VTY_TEST_STP_DEFAULT += osmo_stp_test_tcap.vty

    EXTRA_DIST += osmo_stp_test_tcap. […]

    Done

To view, visit change 41309. To unsubscribe, or for help writing mail filters, visit settings.