November 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: ASCI: Fix removal of call notification when lchan fails
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, jolly, laforge, neels. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41503?usp=email ) Change subject: ASCI: Fix removal of call notification when lchan fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib5f7fdf8c3b3606002151f86d2bdfaeb33904364 Gerrit-Change-Number: 41503 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 13:38:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by jolly 27 Nov '25

27 Nov '25

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... ASCI: Fix establishment of calls when ciphering is enabled We do not support any VGCS/VBS ciphering. If the CM Service Request indicates VGCS or VBS service, encryption is not enabled for the channel to be set up. There will be no Ciphering Command sent to the ME. Authentication is still performed with the initiator of the call, if authentication is enabled. Only authenticated subscribers will then be able to initiate ASCI calls. Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e --- M src/libvlr/vlr_access_req_fsm.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index 91ff06e..6d4a084 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -301,9 +301,13 @@ LOGPFSM(fi, "%s()\n", __func__); /* Continue with ciphering, if enabled. - * If auth/ciph is optional and the HLR returned no auth info, continue without ciphering. */ + * If auth/ciph is optional and the HLR returned no auth info, continue without ciphering. + * Also continue without ciphering, if ASCI call was requested. According to TS 143.068/069 Clause 7.3 + * ciphering has not been completely specified. The SIM does not support key storage. */ if (!is_cmc_smc_to_be_attempted(par) - || (vsub->sec_ctx == VLR_SEC_CTX_NONE && !par->is_ciphering_required)) { + || (vsub->sec_ctx == VLR_SEC_CTX_NONE && !par->is_ciphering_required) + || par->cm_service_type == GSM48_CMSERV_VGCS + || par->cm_service_type == GSM48_CMSERV_VBS) { _proc_arq_vlr_node2_post_ciph(fi); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: ASCI: Fix removal of call notification when lchan fails
by jolly 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, laforge, neels, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41503?usp=email ) Change subject: ASCI: Fix removal of call notification when lchan fails ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > What if bts pointer is freed (eg bts removed from osmo-bsc config)? BTS cannot be removed. VTY does not allow it. I guess there are hundred other things that would have lost pointers anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41503?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib5f7fdf8c3b3606002151f86d2bdfaeb33904364 Gerrit-Change-Number: 41503 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 13:35:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-hnbgw[master]: Split UPF into its own object
by pespin 27 Nov '25

27 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email ) Change subject: Split UPF into its own object ...................................................................... Split UPF into its own object This allows easily extending per-peer (UPF) functionalities, eg. adding Heartbeat procedure, as well as a step towards supporting a UPF pool in the future. Depends: libosmo-pfcp.git Change-Id I31498c407a8fffd8b47cce8c6bf89dc6e3fcefd2 Related: SYS#7294 Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c --- M TODO-RELEASE M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/hnbgw_pfcp.h M src/osmo-hnbgw/hnbgw_pfcp.c M src/osmo-hnbgw/hnbgw_ranap.c M src/osmo-hnbgw/osmo_hnbgw_main.c M src/osmo-hnbgw/ps_rab_ass_fsm.c M src/osmo-hnbgw/ps_rab_fsm.c 8 files changed, 92 insertions(+), 36 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index a42e798..db15809 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmo-sigtran >2.1.0 osmo_sccp_addr_{create,update}() libosmo-netif >1.6.0 osmo_stream_srv_set_tx_queue_max_length() +libosmo-pfcp >0.5.0 osmo_pfcp_cp_peer_free() diff --git a/include/osmocom/hnbgw/hnbgw.h b/include/osmocom/hnbgw/hnbgw.h index 981b809..36e8943 100644 --- a/include/osmocom/hnbgw/hnbgw.h +++ b/include/osmocom/hnbgw/hnbgw.h @@ -147,9 +147,7 @@ struct { struct osmo_pfcp_endpoint *ep; - struct osmo_pfcp_cp_peer *cp_peer; - /* Running counters for the PFCP conn */ - struct osmo_stat_item_group *statg; + struct hnbgw_upf *upf; } pfcp; struct osmo_timer_list hnb_store_rab_durations_timer; diff --git a/include/osmocom/hnbgw/hnbgw_pfcp.h b/include/osmocom/hnbgw/hnbgw_pfcp.h index 376d144..f077669 100644 --- a/include/osmocom/hnbgw/hnbgw_pfcp.h +++ b/include/osmocom/hnbgw/hnbgw_pfcp.h @@ -1,9 +1,27 @@ #pragma once +#include <osmocom/core/fsm.h> +#include <osmocom/core/socket.h> +#include <osmocom/core/stat_item.h> +#include <osmocom/pfcp/pfcp_endpoint.h> +#include <osmocom/pfcp/pfcp_cp_peer.h> + enum hnbgw_upf_stats { HNBGW_UPF_STAT_ASSOCIATED, }; -#define HNBGW_UPF_STAT_SET(stat, val) osmo_stat_item_set(osmo_stat_item_group_get_item(g_hnbgw->pfcp.statg, (stat)), (val)) +#define HNBGW_UPF_STAT_SET(stat, val) osmo_stat_item_set(osmo_stat_item_group_get_item(g_hnbgw->pfcp.upf->statg, (stat)), (val)) + +struct hnbgw_upf { + struct osmo_pfcp_cp_peer *cp_peer; + /* Running counters for the PFCP conn */ + struct osmo_stat_item_group *statg; +}; + +struct hnbgw_upf *hnbgw_upf_alloc(struct osmo_pfcp_endpoint *ep, const struct osmo_sockaddr *rem_addr); +void hnbgw_upf_free(struct hnbgw_upf *upf); int hnbgw_pfcp_init(void); void hnbgw_pfcp_release(void); + +#define LOGUPF(upf, ss, lvl, fmt, args ...) \ + LOGP(ss, lvl, "UPF(%s) " fmt, osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_cp_peer_get_remote_addr(upf->cp_peer)), ## args) diff --git a/src/osmo-hnbgw/hnbgw_pfcp.c b/src/osmo-hnbgw/hnbgw_pfcp.c index dc82f04..feabae1 100644 --- a/src/osmo-hnbgw/hnbgw_pfcp.c +++ b/src/osmo-hnbgw/hnbgw_pfcp.c @@ -45,7 +45,7 @@ static void pfcp_set_msg_ctx(struct osmo_pfcp_endpoint *ep, struct osmo_pfcp_msg *m, struct osmo_pfcp_msg *req) { if (!m->ctx.peer_fi) - osmo_pfcp_cp_peer_set_msg_ctx(g_hnbgw->pfcp.cp_peer, m); + osmo_pfcp_cp_peer_set_msg_ctx(g_hnbgw->pfcp.upf->cp_peer, m); /* If this is a response to an earlier request, just take the msg context from the request message. * In osmo-hnbgw, a session_fi always points at a ps_rab FSM. */ @@ -79,10 +79,58 @@ static void pfcp_cp_peer_assoc_cb(struct osmo_pfcp_cp_peer *cp_peer, bool associated) { - LOGP(DLPFCP, LOGL_NOTICE, "PFCP Peer associated: %s\n", associated ? "true" : "false"); + struct hnbgw_upf *upf = osmo_pfcp_cp_peer_get_priv(cp_peer); + OSMO_ASSERT(upf); + + LOGUPF(upf, DLPFCP, LOGL_NOTICE, "PFCP Peer associated: %s\n", associated ? "true" : "false"); HNBGW_UPF_STAT_SET(HNBGW_UPF_STAT_ASSOCIATED, associated ? 1 : 0); } +struct hnbgw_upf *hnbgw_upf_alloc(struct osmo_pfcp_endpoint *ep, const struct osmo_sockaddr *upf_addr) +{ + struct hnbgw_upf *upf = talloc_zero(g_hnbgw, struct hnbgw_upf); + OSMO_ASSERT(upf); + + upf->statg = osmo_stat_item_group_alloc(g_hnbgw, &hnbgw_upf_statg_desc, 0); + if (!upf->statg) { + LOGP(DLPFCP, LOGL_ERROR, "Failed creating UPF stats item group\n"); + goto free_ret; + } + + upf->cp_peer = osmo_pfcp_cp_peer_alloc(g_hnbgw, ep, upf_addr); + if (!upf->cp_peer) { + LOGP(DLPFCP, LOGL_ERROR, "Cannot allocate PFCP CP Peer FSM\n"); + goto free_ret; + } + osmo_pfcp_cp_peer_set_priv(upf->cp_peer, upf); + + if (osmo_pfcp_cp_peer_set_associated_cb(upf->cp_peer, pfcp_cp_peer_assoc_cb)) { + LOGUPF(upf, DLPFCP, LOGL_ERROR, "Cannot Set PFCP CP Peer associated callback\n"); + goto free_ret; + } + + if (osmo_pfcp_cp_peer_associate(upf->cp_peer)) { + LOGUPF(upf, DLPFCP, LOGL_ERROR, "Cannot start PFCP CP Peer FSM\n"); + goto free_ret; + } + + return upf; +free_ret: + osmo_pfcp_cp_peer_free(upf->cp_peer); + osmo_stat_item_group_free(upf->statg); + talloc_free(upf); + return NULL; +} + +void hnbgw_upf_free(struct hnbgw_upf *upf) +{ + if (!upf) + return; + + osmo_pfcp_cp_peer_free(upf->cp_peer); + osmo_stat_item_group_free(upf->statg); +} + int hnbgw_pfcp_init(void) { struct osmo_pfcp_endpoint_cfg cfg; @@ -102,12 +150,6 @@ return -1; } - g_hnbgw->pfcp.statg = osmo_stat_item_group_alloc(g_hnbgw, &hnbgw_upf_statg_desc, 0); - if (!g_hnbgw->pfcp.statg) { - LOGP(DLPFCP, LOGL_ERROR, "Failed creating UPF stats item group\n"); - return -1; - } - cfg = (struct osmo_pfcp_endpoint_cfg){ .set_msg_ctx_cb = pfcp_set_msg_ctx, .rx_msg_cb = pfcp_rx_msg, @@ -132,12 +174,6 @@ return -1; } - g_hnbgw->pfcp.ep = ep = osmo_pfcp_endpoint_create(g_hnbgw, &cfg); - if (!ep) { - LOGP(DLPFCP, LOGL_ERROR, "Failed to allocate PFCP endpoint\n"); - return -1; - } - /* Set up remote PFCP address to reach UPF at. First parse the string into upf_addr_str. */ if (osmo_sockaddr_str_from_str(&upf_addr_str, g_hnbgw->config.pfcp.remote_addr, g_hnbgw->config.pfcp.remote_port)) { LOGP(DLPFCP, LOGL_ERROR, "Error in PFCP remote IP: %s\n", @@ -151,6 +187,12 @@ return -1; } + g_hnbgw->pfcp.ep = ep = osmo_pfcp_endpoint_create(g_hnbgw, &cfg); + if (!ep) { + LOGP(DLPFCP, LOGL_ERROR, "Failed to allocate PFCP endpoint\n"); + return -1; + } + /* Start the socket */ if (osmo_pfcp_endpoint_bind(ep)) { LOGP(DLPFCP, LOGL_ERROR, "Cannot bind PFCP endpoint\n"); @@ -158,18 +200,9 @@ } /* Associate with UPF */ - g_hnbgw->pfcp.cp_peer = osmo_pfcp_cp_peer_alloc(g_hnbgw, ep, &upf_addr); - if (!g_hnbgw->pfcp.cp_peer) { - LOGP(DLPFCP, LOGL_ERROR, "Cannot allocate PFCP CP Peer FSM\n"); - return -1; - } - if (osmo_pfcp_cp_peer_set_associated_cb(g_hnbgw->pfcp.cp_peer, pfcp_cp_peer_assoc_cb)) { - LOGP(DLPFCP, LOGL_ERROR, "Cannot Set PFCP CP Peer associated callback\n"); - return -1; - } - - if (osmo_pfcp_cp_peer_associate(g_hnbgw->pfcp.cp_peer)) { - LOGP(DLPFCP, LOGL_ERROR, "Cannot start PFCP CP Peer FSM\n"); + g_hnbgw->pfcp.upf = hnbgw_upf_alloc(ep, &upf_addr); + if (!g_hnbgw->pfcp.upf) { + LOGP(DLPFCP, LOGL_ERROR, "Failed creating UPF\n"); return -1; } @@ -180,5 +213,6 @@ { if (!hnb_gw_is_gtp_mapping_enabled()) return; - osmo_stat_item_group_free(g_hnbgw->pfcp.statg); + hnbgw_upf_free(g_hnbgw->pfcp.upf); + g_hnbgw->pfcp.upf = NULL; } diff --git a/src/osmo-hnbgw/hnbgw_ranap.c b/src/osmo-hnbgw/hnbgw_ranap.c index efa46d4..9cbf8e4 100644 --- a/src/osmo-hnbgw/hnbgw_ranap.c +++ b/src/osmo-hnbgw/hnbgw_ranap.c @@ -37,6 +37,7 @@ #if ENABLE_PFCP #include <osmocom/pfcp/pfcp_cp_peer.h> +#include <osmocom/hnbgw/hnbgw_pfcp.h> #endif #include <osmocom/hnbgw/hnb.h> @@ -655,7 +656,7 @@ if (hnb_gw_is_gtp_mapping_enabled()) { LOG_MAP(map, DCN, LOGL_DEBUG, "RAB Assignment: setting up GTP tunnel mapping via UPF %s\n", - osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_cp_peer_get_remote_addr(g_hnbgw->pfcp.cp_peer))); + osmo_sockaddr_to_str_c(OTC_SELECT, osmo_pfcp_cp_peer_get_remote_addr(g_hnbgw->pfcp.upf->cp_peer))); return hnbgw_gtpmap_rx_rab_ass_req(map, ranap_msg, message); } /* If no UPF is configured, directly forward the message as-is (no GTP mapping). */ diff --git a/src/osmo-hnbgw/osmo_hnbgw_main.c b/src/osmo-hnbgw/osmo_hnbgw_main.c index 34375a9..490d94e 100644 --- a/src/osmo-hnbgw/osmo_hnbgw_main.c +++ b/src/osmo-hnbgw/osmo_hnbgw_main.c @@ -48,7 +48,9 @@ #include <osmocom/hnbgw/hnb.h> #include <osmocom/hnbgw/hnbgw.h> #include <osmocom/hnbgw/hnbgw_cn.h> +#if ENABLE_PFCP #include <osmocom/hnbgw/hnbgw_pfcp.h> +#endif static struct { int daemonize; diff --git a/src/osmo-hnbgw/ps_rab_ass_fsm.c b/src/osmo-hnbgw/ps_rab_ass_fsm.c index c6e8495..9f6441a 100644 --- a/src/osmo-hnbgw/ps_rab_ass_fsm.c +++ b/src/osmo-hnbgw/ps_rab_ass_fsm.c @@ -43,6 +43,7 @@ #include <osmocom/pfcp/pfcp_cp_peer.h> #include <osmocom/hnbgw/hnbgw.h> +#include <osmocom/hnbgw/hnbgw_pfcp.h> #include <osmocom/hnbgw/context_map.h> #include <osmocom/hnbgw/ranap_rab_ass.h> #include <osmocom/hnbgw/ps_rab_ass_fsm.h> @@ -230,7 +231,7 @@ rab_ass->ranap_rab_ass_req_message = message; /* Now rab_ass owns message and will clean it up */ - if (!osmo_pfcp_cp_peer_is_associated(g_hnbgw->pfcp.cp_peer)) { + if (!osmo_pfcp_cp_peer_is_associated(g_hnbgw->pfcp.upf->cp_peer)) { LOG_MAP(map, DLPFCP, LOGL_ERROR, "PFCP is not associated, cannot set up GTP mapping\n"); goto no_rab; } @@ -432,7 +433,7 @@ rab_ass->ranap_rab_ass_resp_msgb = ranap_msg; /* Now rab_ass owns message and will clean it up */ - if (!osmo_pfcp_cp_peer_is_associated(g_hnbgw->pfcp.cp_peer)) { + if (!osmo_pfcp_cp_peer_is_associated(g_hnbgw->pfcp.upf->cp_peer)) { LOG_PS_RAB_ASS(rab_ass, LOGL_ERROR, "PFCP is not associated, cannot set up GTP mapping\n"); goto no_rab; } diff --git a/src/osmo-hnbgw/ps_rab_fsm.c b/src/osmo-hnbgw/ps_rab_fsm.c index caaed84..eb12792 100644 --- a/src/osmo-hnbgw/ps_rab_fsm.c +++ b/src/osmo-hnbgw/ps_rab_fsm.c @@ -23,6 +23,7 @@ #include <osmocom/pfcp/pfcp_cp_peer.h> #include <osmocom/hnbgw/hnbgw.h> +#include <osmocom/hnbgw/hnbgw_pfcp.h> #include <osmocom/hnbgw/context_map.h> #include <osmocom/hnbgw/tdefs.h> #include <osmocom/hnbgw/ps_rab_fsm.h> @@ -143,7 +144,7 @@ static struct osmo_pfcp_msg *ps_rab_new_pfcp_msg_req(struct ps_rab *rab, enum osmo_pfcp_message_type msg_type) { - struct osmo_pfcp_msg *m = osmo_pfcp_cp_peer_new_req(g_hnbgw->pfcp.cp_peer, msg_type); + struct osmo_pfcp_msg *m = osmo_pfcp_cp_peer_new_req(g_hnbgw->pfcp.upf->cp_peer, msg_type); m->h.seid_present = true; m->h.seid = rab->up_f_seid.seid; @@ -320,7 +321,7 @@ m->h.seid = 0; /* Make a new CP-SEID, our local reference for the PFCP session. */ - rab->cp_seid = osmo_pfcp_cp_peer_next_seid(g_hnbgw->pfcp.cp_peer); + rab->cp_seid = osmo_pfcp_cp_peer_next_seid(g_hnbgw->pfcp.upf->cp_peer); cp_f_seid = (struct osmo_pfcp_ie_f_seid){ .seid = rab->cp_seid, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c Gerrit-Change-Number: 41483 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-hnbgw[master]: Split UPF into its own object
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email ) Change subject: Split UPF into its own object ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: merging since several days passed with no objection and 2 people provided +1. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I624bafe2fa150f7480b6fb44433c34e83154e06c Gerrit-Change-Number: 41483 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 13:09:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Split code to sua_gen_cldr() helper function
by pespin 27 Nov '25

27 Nov '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41519?usp=email ) Change subject: Split code to sua_gen_cldr() helper function ...................................................................... Split code to sua_gen_cldr() helper function This will be used to send back UDTS to originator of TCAP msg during TCAP loadshare routing if no ASP serving a given TID is found. Change-Id: I171381991308e3bb54f76afc92ccad3fcae6dcbb --- M src/sccp_sclc.c M src/sua.c M src/xua_internal.h 3 files changed, 51 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/19/41519/1 diff --git a/src/sccp_sclc.c b/src/sccp_sclc.c index 0a47cd9..704c4bb 100644 --- a/src/sccp_sclc.c +++ b/src/sccp_sclc.c @@ -344,47 +344,7 @@ const struct xua_msg *xua_in, uint32_t ret_cause) { - struct xua_msg *xua_out = xua_msg_alloc(); - struct osmo_sccp_addr called; - - xua_out->hdr = XUA_HDR(SUA_MSGC_CL, SUA_CL_CLDR); - xua_msg_add_u32(xua_out, SUA_IEI_ROUTE_CTX, inst->route_ctx); - xua_msg_add_u32(xua_out, SUA_IEI_CAUSE, - SUA_CAUSE_T_RETURN | ret_cause); - /* Swap Calling and Called Party */ - xua_msg_copy_part(xua_out, SUA_IEI_SRC_ADDR, xua_in, SUA_IEI_DEST_ADDR); - xua_msg_copy_part(xua_out, SUA_IEI_DEST_ADDR, xua_in, SUA_IEI_SRC_ADDR); - /* TODO: Optional: Hop Count */ - /* Optional: Importance */ - xua_msg_copy_part(xua_out, SUA_IEI_IMPORTANCE, - xua_in, SUA_IEI_IMPORTANCE); - /* Optional: Message Priority */ - xua_msg_copy_part(xua_out, SUA_IEI_MSG_PRIO, xua_in, SUA_IEI_MSG_PRIO); - /* Optional: Correlation ID */ - xua_msg_copy_part(xua_out, SUA_IEI_CORR_ID, xua_in, SUA_IEI_CORR_ID); - /* Optional: Segmentation */ - xua_msg_copy_part(xua_out, SUA_IEI_SEGMENTATION, - xua_in, SUA_IEI_SEGMENTATION); - /* Optional: Data */ - xua_msg_copy_part(xua_out, SUA_IEI_DATA, xua_in, SUA_IEI_DATA); - - OSMO_ASSERT(sua_addr_parse(&called, xua_out, SUA_IEI_DEST_ADDR) == 0); - - /* Route on PC + SSN ? */ - if (called.ri == OSMO_SCCP_RI_SSN_PC) { - /* if no PC, copy OPC into called addr */ - if (!(called.presence & OSMO_SCCP_ADDR_T_PC)) { - struct osmo_sccp_addr calling; - OSMO_ASSERT(sua_addr_parse(&calling, xua_out, SUA_IEI_SRC_ADDR) == 0); - called.presence |= OSMO_SCCP_ADDR_T_PC; - called.pc = calling.pc; - /* Re-encode / replace called address */ - xua_msg_free_tag(xua_out, SUA_IEI_DEST_ADDR); - xua_msg_add_sccp_addr(xua_out, SUA_IEI_DEST_ADDR, - &called); - } - } - return xua_out; + return sua_gen_cldr(xua_in, inst->route_ctx, ret_cause); } /*! \brief SCRC -> SCLC (Routing Failure diff --git a/src/sua.c b/src/sua.c index e157f31..e81590d 100644 --- a/src/sua.c +++ b/src/sua.c @@ -262,6 +262,54 @@ return xua; } +/* generate a return/refusal message (SUA CLDR == SCCP UDTS) based on + * the incoming message. We need to flip all identities between sender + * and receiver */ +struct xua_msg *sua_gen_cldr(const struct xua_msg *xua_in, uint32_t route_ctx, uint32_t ret_cause) +{ + struct xua_msg *xua_out = xua_msg_alloc(); + struct osmo_sccp_addr called; + + xua_out->hdr = XUA_HDR(SUA_MSGC_CL, SUA_CL_CLDR); + xua_msg_add_u32(xua_out, SUA_IEI_ROUTE_CTX, route_ctx); + xua_msg_add_u32(xua_out, SUA_IEI_CAUSE, + SUA_CAUSE_T_RETURN | ret_cause); + /* Swap Calling and Called Party */ + xua_msg_copy_part(xua_out, SUA_IEI_SRC_ADDR, xua_in, SUA_IEI_DEST_ADDR); + xua_msg_copy_part(xua_out, SUA_IEI_DEST_ADDR, xua_in, SUA_IEI_SRC_ADDR); + /* TODO: Optional: Hop Count */ + /* Optional: Importance */ + xua_msg_copy_part(xua_out, SUA_IEI_IMPORTANCE, + xua_in, SUA_IEI_IMPORTANCE); + /* Optional: Message Priority */ + xua_msg_copy_part(xua_out, SUA_IEI_MSG_PRIO, xua_in, SUA_IEI_MSG_PRIO); + /* Optional: Correlation ID */ + xua_msg_copy_part(xua_out, SUA_IEI_CORR_ID, xua_in, SUA_IEI_CORR_ID); + /* Optional: Segmentation */ + xua_msg_copy_part(xua_out, SUA_IEI_SEGMENTATION, + xua_in, SUA_IEI_SEGMENTATION); + /* Optional: Data */ + xua_msg_copy_part(xua_out, SUA_IEI_DATA, xua_in, SUA_IEI_DATA); + + OSMO_ASSERT(sua_addr_parse(&called, xua_out, SUA_IEI_DEST_ADDR) == 0); + + /* Route on PC + SSN ? */ + if (called.ri == OSMO_SCCP_RI_SSN_PC) { + /* if no PC, copy OPC into called addr */ + if (!(called.presence & OSMO_SCCP_ADDR_T_PC)) { + struct osmo_sccp_addr calling; + OSMO_ASSERT(sua_addr_parse(&calling, xua_out, SUA_IEI_SRC_ADDR) == 0); + called.presence |= OSMO_SCCP_ADDR_T_PC; + called.pc = calling.pc; + /* Re-encode / replace called address */ + xua_msg_free_tag(xua_out, SUA_IEI_DEST_ADDR); + xua_msg_add_sccp_addr(xua_out, SUA_IEI_DEST_ADDR, + &called); + } + } + return xua_out; +} + /*********************************************************************** * Transmitting SUA messages to SCTP ***********************************************************************/ diff --git a/src/xua_internal.h b/src/xua_internal.h index a6cb961..54172ff 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -37,6 +37,8 @@ void sua_tx_dupu(struct osmo_ss7_asp *asp, const uint32_t *rctx, unsigned int num_rctx, uint32_t dpc, uint16_t user, uint16_t cause, const char *info_str); +struct xua_msg *sua_gen_cldr(const struct xua_msg *xua_in, uint32_t route_ctx, uint32_t ret_cause); + int m3ua_hmdc_rx_from_l2(struct osmo_ss7_instance *inst, struct xua_msg *xua); struct msgb *m3ua_to_msg(struct xua_msg *xua); int m3ua_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41519?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I171381991308e3bb54f76afc92ccad3fcae6dcbb Gerrit-Change-Number: 41519 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-gsm-manuals[master]: GSUP: add missing Current RAT Type IE
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email ) Change subject: GSUP: add missing Current RAT Type IE ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 Gerrit-Change-Number: 41518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 11:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-gsm-manuals[master]: GSUP: add missing Current RAT Type IE
by osmith 27 Nov '25

27 Nov '25

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email ) Change subject: GSUP: add missing Current RAT Type IE ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Noticed that this is not documented while reviewing https://github.com/nickvsnetworking/pyhss/pull/283 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 Gerrit-Change-Number: 41518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 27 Nov 2025 11:05:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-gsm-manuals[master]: GSUP: add missing Current RAT Type IE
by osmith 27 Nov '25

27 Nov '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email ) Change subject: GSUP: add missing Current RAT Type IE ...................................................................... GSUP: add missing Current RAT Type IE This IE has been introduced here: https://gerrit.osmocom.org/c/libosmocore/+/12452 Used only by osmo_dia2gsup so far: https://gitea.osmocom.org/erlang/osmo_dia2gsup/commit/388d387dcc9a565b82c70… Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 --- M common/chapters/gsup.adoc 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/18/41518/1 diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index 33d35da..46139f8 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -363,6 +363,7 @@ |26|AUTS|<<gsup-ie-auts>>|C|TLV|18 |20|RAND|<<gsup-ie-rand>>|C|TLV|18 |05|PDP info|<<gsup-ie-pdpinfo>>|C|TLV|2-N +|2a|Current RAT Type|<<gsup-ie-current-rat-type>>|O|TLV|3 |=== The conditional 'AUTS' and 'RAND' IEs are both present in case the SIM @@ -1736,6 +1737,20 @@ This IE indicates why an event is happening on the BSSAP interface. See 3GPP TS 48.008 3.2.2.5 for reference. +[[gsup-ie-current-rat-type]] +==== Current RAT Type + +This IE contains the current RAT Type. + +.Current RAT Type values +[options="header",cols="15%,85%"] +|=== +|Type|Description +|0x01|GERAN +|0x02|UTRAN +|0x03|EUTRAN +|=== + [[gsup-ie-cause-sm]] ==== Session Management Cause -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/41518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iba841856806b7dbd4b6aa3675e0cc6dff2485da0 Gerrit-Change-Number: 41518 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-msc[master]: ASCI: Fix establishment of calls when ciphering is enabled
by pespin 27 Nov '25

27 Nov '25

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 27 Nov 2025 09:22:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log November 2025