jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email ) Change subject: ASCI: Fix establishment of calls when ciphering is enabled ...................................................................... ASCI: Fix establishment of calls when ciphering is enabled We do not support any VGCS/VBS ciphering. If the CM Service Request indicates VGCS or VBS service, encryption is not enabled for the channel to be set up. There will be no Ciphering Command sent to the ME. Authentication is still performed with the initiator of the call, if authentication is enabled. Only authenticated subscribers will then be able to initiate ASCI calls. Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e --- M src/libvlr/vlr_access_req_fsm.c 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index 91ff06e..6d4a084 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -301,9 +301,13 @@ LOGPFSM(fi, "%s()\n", __func__); /* Continue with ciphering, if enabled. - * If auth/ciph is optional and the HLR returned no auth info, continue without ciphering. */ + * If auth/ciph is optional and the HLR returned no auth info, continue without ciphering. + * Also continue without ciphering, if ASCI call was requested. According to TS 143.068/069 Clause 7.3 + * ciphering has not been completely specified. The SIM does not support key storage. */ if (!is_cmc_smc_to_be_attempted(par) - || (vsub->sec_ctx == VLR_SEC_CTX_NONE && !par->is_ciphering_required)) { + || (vsub->sec_ctx == VLR_SEC_CTX_NONE && !par->is_ciphering_required) + || par->cm_service_type == GSM48_CMSERV_VGCS + || par->cm_service_type == GSM48_CMSERV_VBS) { _proc_arq_vlr_node2_post_ciph(fi); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41504?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic59221e6b0f64c9f19508ae31cc3672548d0666e Gerrit-Change-Number: 41504 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de>