November 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: erab_fsm: log the creation event and UID
by pespin 21 Nov '25

21 Nov '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41475?usp=email ) Change subject: erab_fsm: log the creation event and UID ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5746a645d95c9c931c24ebc170ef88cd38311542 Gerrit-Change-Number: 41475 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Nov 2025 09:38:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: move catch-all for SCTP events to handle_event/4
by pespin 21 Nov '25

21 Nov '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41476?usp=email ) Change subject: sctp_proxy: move catch-all for SCTP events to handle_event/4 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8f42a31fdf4a4e01106ace81d87188a340fe7c83 Gerrit-Change-Number: 41476 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Nov 2025 09:38:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format
by falconia 21 Nov '25

21 Nov '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email ) Change subject: trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format ...................................................................... trau_frame: fix de/encoding of TRAU-AMR-8k-6k7 format There exist 3 TRAU frame types (distinguished by sync pattern) for AMR on 8 kbit/s subslots: Low, 6k7 and 7k4. osmo_trau_frame_encode() and osmo_trau_frame_decode_8k() APIs support all 3 TRAU-AMR-8k frame types since the original 2020 implementation - however, encoding and decoding of 6k7 format was incorrect. Fix it. Correctness of the new implementation is verified by unit tests added with the next patch in this series. Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 --- M src/trau/trau_frame.c 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/78/41478/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 896bc20..d8541c5 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1045,15 +1045,15 @@ /* D8 .. D11 */ memcpy(fr->d_bits + d_idx, trau_bits + 2 * 8 + 4, 4); d_idx += 4; - /* D12 .. D39 */ - for (i = 3; i < 7; i++) { + /* D12 .. D32 */ + for (i = 3; i < 6; i++) { int offset = i * 8; - memcpy(fr->d_bits + d_idx, trau_bits + offset + 2, 7); + memcpy(fr->d_bits + d_idx, trau_bits + offset + 1, 7); d_idx += 7; } - /* D40 .. D137 */ - for (i = 7; i < 20; i+= 2) { + /* D33 .. D137 */ + for (i = 6; i < 20; i += 2) { int offset = i * 8; memcpy(fr->d_bits + d_idx, trau_bits + offset + 1, 15); d_idx += 15; @@ -1074,7 +1074,7 @@ trau_bits[3 * 8] = 1; trau_bits[4 * 8] = 1; trau_bits[5 * 8] = 0; - for (i = 5; i < 20; i += 2) + for (i = 6; i < 20; i += 2) trau_bits[i * 8] = 1; /* D1 .. D7 */ @@ -1085,15 +1085,15 @@ /* D8 .. D11 */ memcpy(trau_bits + 2 * 8 + 4, fr->d_bits + d_idx, 4); d_idx += 4; - /* D12 .. D39 */ - for (i = 3; i < 7; i++) { + /* D12 .. D32 */ + for (i = 3; i < 6; i++) { int offset = i * 8; - memcpy(trau_bits + offset + 2, fr->d_bits + d_idx, 7); + memcpy(trau_bits + offset + 1, fr->d_bits + d_idx, 7); d_idx += 7; } - /* D40 .. D137 */ - for (i = 7; i < 20; i+= 2) { + /* D33 .. D137 */ + for (i = 6; i < 20; i += 2) { int offset = i * 8; memcpy(trau_bits + offset + 1, fr->d_bits + d_idx, 15); d_idx += 15; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ibb98b0c189ced5248dca217384ca34b6a5f8b210 Gerrit-Change-Number: 41478 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_{server,proxy}: handle sctp_error messages from gen_sctp
by fixeria 21 Nov '25

21 Nov '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41477?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sctp_{server,proxy}: handle sctp_error messages from gen_sctp ...................................................................... sctp_{server,proxy}: handle sctp_error messages from gen_sctp The `{sctp_error, ...}` message is undocumented, but it does exist, and we have encountered it in production. The logic that generates `{sctp, ...}` and `{sctp_error, ...}` messages resides in Erlang/OTP's inet_drv.c, specifically in packet_binary_message() and sctp_parse_async_event(). Within sctp_parse_async_event(), an error is indicated by replacing the initial `sctp` atom with `sctp_error`. Currently the following SCTP events are treated as errors: * SCTP_SEND_FAILED (becomes #sctp_send_failed{}), * SCTP_REMOTE_ERROR (becomes #sctp_remote_error{}), * SCTP_PARTIAL_DELIVERY_EVENT (becomes #sctp_pdapi_event{}). Print more specific messages when the sctp_error is received. Add new metrics for the above-mentioned SCTP events. Change-Id: I38203d915d54dacd4e9bbf158ab86f8936585a34 Related: SYS#7738 --- M include/s1gw_metrics.hrl M src/s1gw_metrics.erl M src/sctp_common.erl M src/sctp_proxy.erl M src/sctp_server.erl 5 files changed, 41 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/77/41477/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I38203d915d54dacd4e9bbf158ab86f8936585a34 Gerrit-Change-Number: 41477 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in ...osmo-s1gw[master]: sctp_{server,proxy}: handle sctp_error messages from gen_sctp
by fixeria 21 Nov '25

21 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41477?usp=email ) Change subject: sctp_{server,proxy}: handle sctp_error messages from gen_sctp ...................................................................... sctp_{server,proxy}: handle sctp_error messages from gen_sctp The `{sctp_error, ...}` message is undocumented, but it does exist, and we have encountered it in production. The logic that generates `{sctp, ...}` and `{sctp_error, ...}` messages resides in Erlang/OTP's inet_drv.c, specifically in packet_binary_message() and sctp_parse_async_event(). Within sctp_parse_async_event(), an error is indicated by replacing the initial `sctp` atom with `sctp_error`. Currently the following SCTP events are treated as errors: * SCTP_SEND_FAILED (becomes #sctp_send_failed{}), * SCTP_REMOTE_ERROR (becomes #sctp_remote_error{}), * SCTP_PARTIAL_DELIVERY_EVENT (becomes #sctp_pdapi_event{}). Print more specific messages when the sctp_error is received. Add new metrics for the above-mentioned SCTP events. Change-Id: I38203d915d54dacd4e9bbf158ab86f8936585a34 Related: SYS#7738 --- M include/s1gw_metrics.hrl M src/s1gw_metrics.erl M src/sctp_common.erl M src/sctp_proxy.erl M src/sctp_server.erl 5 files changed, 48 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/77/41477/1 diff --git a/include/s1gw_metrics.hrl b/include/s1gw_metrics.hrl index 5afbff0..385b5fa 100644 --- a/include/s1gw_metrics.hrl +++ b/include/s1gw_metrics.hrl @@ -40,6 +40,12 @@ -define(S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ALL, [ctr, s1ap, proxy, out_pkt, reply, all]). -define(S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP, [ctr, s1ap, proxy, out_pkt, reply, erab_setup_rsp]). +%% SCTP related metrics +-define(S1GW_CTR_SCTP_ERROR_ALL, [ctr, sctp, error, all]). +-define(S1GW_CTR_SCTP_ERROR_SEND_FAILED, [ctr, sctp, error, send_failed]). +-define(S1GW_CTR_SCTP_ERROR_PDAPI_EVENT, [ctr, sctp, error, pdapi_event]). +-define(S1GW_CTR_SCTP_ERROR_REMOTE_ERROR, [ctr, sctp, error, remote_error]). + %% per-eNB counters %% NOTE: these counters shall not be listed in ?S1GW_COUNTERS, %% but created dynamically for each connecting eNB. diff --git a/src/s1gw_metrics.erl b/src/s1gw_metrics.erl index 7ca3352..bb4bd97 100644 --- a/src/s1gw_metrics.erl +++ b/src/s1gw_metrics.erl @@ -95,7 +95,13 @@ ?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_PROC, %% forwarded: processed ?S1GW_CTR_S1AP_PROXY_OUT_PKT_FWD_UNMODIFIED, %% forwarded: unmodified ?S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ALL, %% replied: total - ?S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP %% replied: E-RAB SETUP.rsp + ?S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP, %% replied: E-RAB SETUP.rsp + + %% SCTP related counters + ?S1GW_CTR_SCTP_ERROR_ALL, %% total number of SCTP errors + ?S1GW_CTR_SCTP_ERROR_SEND_FAILED, %% send operation failed + ?S1GW_CTR_SCTP_ERROR_PDAPI_EVENT, %% partial delivery failure + ?S1GW_CTR_SCTP_ERROR_REMOTE_ERROR %% remote error ]). -define(S1GW_GAUGES, [ diff --git a/src/sctp_common.erl b/src/sctp_common.erl index 296dbff..9b86b50 100644 --- a/src/sctp_common.erl +++ b/src/sctp_common.erl @@ -35,12 +35,14 @@ -module(sctp_common). -export([parse_addr/1, + report_error/1, send_data/2, shutdown/1]). -include_lib("kernel/include/logger.hrl"). -include_lib("kernel/include/inet_sctp.hrl"). +-include("s1gw_metrics.hrl"). -include("s1ap.hrl"). @@ -68,6 +70,20 @@ end. +-spec report_error(term()) -> term(). +report_error(Error) -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_ALL), + case Error of + #sctp_send_failed{} -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_SEND_FAILED); + #sctp_pdapi_event{} -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_PDAPI_EVENT); + #sctp_remote_error{} -> + s1gw_metrics:ctr_inc(?S1GW_CTR_SCTP_ERROR_REMOTE_ERROR); + _ -> ok + end. + + -spec send_data(sock_aid(), binary()) -> ok | {error, term()}. send_data({Sock, Aid}, Data) -> gen_sctp:send(Sock, #sctp_sndrcvinfo{stream = ?S1AP_SCTP_STREAM, diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 594b286..3aa67d8 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -225,6 +225,12 @@ [State, MmeAddr, MmePort, AncData, Data]), keep_state_and_data; +handle_event(State, info, {sctp_error, _Socket, MmeAddr, MmePort, {_, Error}}, _S) -> + ?LOG_ERROR("Rx SCTP error in state ~p (~p:~p): ~p", + [State, MmeAddr, MmePort, Error]), + sctp_common:report_error(Error), + keep_state_and_data; + handle_event(State, Event, EventData, _S) -> ?LOG_ERROR("Unexpected event ~p in state ~p: ~p", [Event, State, EventData]), keep_state_and_data. diff --git a/src/sctp_server.erl b/src/sctp_server.erl index d194ce4..46c352b 100644 --- a/src/sctp_server.erl +++ b/src/sctp_server.erl @@ -158,6 +158,10 @@ S1 = sctp_recv({FromAddr, FromPort, AncData, Data}, S0), {noreply, S1}; +handle_info({sctp_error, _Socket, FromAddr, FromPort, {_, Error}}, S0) -> + S1 = sctp_error({FromAddr, FromPort, Error}, S0), + {noreply, S1}; + %% Handle termination events of the child processes handle_info({'EXIT', Pid, Reason}, #server_state{sock = Sock, clients = Clients} = S0) -> @@ -245,6 +249,15 @@ S. +%% SCTP error handler +sctp_error({FromAddr, FromPort, Error}, + #server_state{} = S) -> + ?LOG_ERROR("Rx SCTP error (~p:~p): ~p", + [FromAddr, FromPort, Error]), + sctp_common:report_error(Error), + S. + + %% Add a new client to the list, spawning a handler process client_add(Aid, FromAddr, FromPort, #server_state{clients = Clients, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I38203d915d54dacd4e9bbf158ab86f8936585a34 Gerrit-Change-Number: 41477 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: move catch-all for SCTP events to handle_event/4
by fixeria 21 Nov '25

21 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41476?usp=email ) Change subject: sctp_proxy: move catch-all for SCTP events to handle_event/4 ...................................................................... sctp_proxy: move catch-all for SCTP events to handle_event/4 Reduce code duplication and prepare for handing of sctp_error. Change-Id: I8f42a31fdf4a4e01106ace81d87188a340fe7c83 Related: SYS#7738 --- M src/sctp_proxy.erl 1 file changed, 6 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/76/41476/1 diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 4ed3cb8..594b286 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -149,13 +149,6 @@ {stop, {shutdown, conn_est_fail}} end; -%% Catch-all for other kinds of SCTP events -connecting(info, {sctp, _Socket, MmeAddr, MmePort, - {AncData, Data}}, S) -> - ?LOG_DEBUG("Unhandled SCTP event (~p:~p): ~p, ~p", - [MmeAddr, MmePort, AncData, Data]), - {keep_state, S}; - connecting(Event, EventData, S) -> handle_event(?FUNCTION_NAME, Event, EventData, S). @@ -213,13 +206,6 @@ end, {keep_state, S}; -%% Catch-all for other kinds of SCTP events -connected(info, {sctp, _Socket, MmeAddr, MmePort, - {AncData, Data}}, S) -> - ?LOG_DEBUG("Unhandled SCTP event (~p:~p): ~p, ~p", - [MmeAddr, MmePort, AncData, Data]), - {keep_state, S}; - connected(Event, EventData, S) -> handle_event(?FUNCTION_NAME, Event, EventData, S). @@ -233,6 +219,12 @@ ?LOG_ERROR("Unexpected call in state ~p: ~p", [State, EventData]), {keep_state_and_data, {reply, From, {error, {unexpected_call, State}}}}; +%% Catch-all for unhandled SCTP events +handle_event(State, info, {sctp, _Socket, MmeAddr, MmePort, {AncData, Data}}, _S) -> + ?LOG_DEBUG("Unhandled SCTP event in state ~p (~p:~p): ~p, ~p", + [State, MmeAddr, MmePort, AncData, Data]), + keep_state_and_data; + handle_event(State, Event, EventData, _S) -> ?LOG_ERROR("Unexpected event ~p in state ~p: ~p", [Event, State, EventData]), keep_state_and_data. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8f42a31fdf4a4e01106ace81d87188a340fe7c83 Gerrit-Change-Number: 41476 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: erab_fsm: log the creation event and UID
by fixeria 21 Nov '25

21 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41475?usp=email ) Change subject: erab_fsm: log the creation event and UID ...................................................................... erab_fsm: log the creation event and UID When looking at GSMTAP logging, it's oftentimes useful to see the beginning of a lifecycle of an E-RAB FSM. Change-Id: I5746a645d95c9c931c24ebc170ef88cd38311542 Related: SYS#7738 --- M src/erab_fsm.erl 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/75/41475/1 diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl index 49a26ca..213a3c1 100644 --- a/src/erab_fsm.erl +++ b/src/erab_fsm.erl @@ -232,6 +232,7 @@ init([UID]) -> set_logging_prefix(UID), + ?LOG_DEBUG("Creating E-RAB FSM (UID ~p)", [UID]), %% request a unieue SEID for this E-RAB FSM {ok, SEID} = pfcp_peer:seid_alloc(), {ok, erab_wait_setup_req, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41475?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5746a645d95c9c931c24ebc170ef88cd38311542 Gerrit-Change-Number: 41475 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-shell: re-organize Card Key Provider related options
by dexter 20 Nov '25

20 Nov '25

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41468?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-shell: re-organize Card Key Provider related options ...................................................................... pySim-shell: re-organize Card Key Provider related options As we plan to support other formats as data source for the Card Key Provider soon, the more commandline options may be added and it makes sense to group the Card Key Provider options in a dedicated group. Let's also rename the option "--csv-column-key" to just "--column-key". The column encryption is a generic concept and not CSV format specific. (let's silently keep the "--csv-column-key" argument so maintain backward compatibility) Related: SYS#7725 Change-Id: I5093f8383551f8c9b84342ca6674c1ebdbbfc19c --- M pySim-shell.py 1 file changed, 14 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/68/41468/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5093f8383551f8c9b84342ca6674c1ebdbbfc19c Gerrit-Change-Number: 41468 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: upf: Use Node ID already generated in g_pars
by pespin 20 Nov '25

20 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email ) Change subject: upf: Use Node ID already generated in g_pars ...................................................................... upf: Use Node ID already generated in g_pars Change-Id: I432cbeee0adf912884b7990bcb40cc2800648056 --- M upf/UPF_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 434e4f4..f9c0186 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -875,7 +875,7 @@ private function f_session_est(inout PFCP_session s, PFCP_Ruleset rules) runs on CPF_ConnHdlr { log("f_session_est: rules = ", rules); - PFCP.send(ts_PFCP_Session_Est_Req(ts_PFCP_Node_ID_ipv4(f_inet_addr(g_pars.local_addr)), + PFCP.send(ts_PFCP_Session_Est_Req(g_pars.local_node_id, ts_PFCP_F_SEID_ipv4(f_inet_addr(g_pars.local_addr), s.cp_seid), rules.pdr, rules.far)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I432cbeee0adf912884b7990bcb40cc2800648056 Gerrit-Change-Number: 41469 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: upf: Use Node ID already generated in g_pars
by pespin 20 Nov '25

20 Nov '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email ) Change subject: upf: Use Node ID already generated in g_pars ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I432cbeee0adf912884b7990bcb40cc2800648056 Gerrit-Change-Number: 41469 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Nov 2025 15:04:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2025