Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39427?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: erab_fsm: add pretty printer for F-TEID
......................................................................
erab_fsm: add pretty printer for F-TEID
This patch makes log messages like this one:
Rx E-RAB SETUP Req (U2C {1454164620,<<"\n?-?">>})
a lot more readable:
Rx E-RAB SETUP Req (U2C 0x56acca8c(a)10.199.45.249)
Change-Id: I8c47abffd554a23e22ae8fd768c390c549334fd3
---
M src/erab_fsm.erl
1 file changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/27/39427/3
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39427?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8c47abffd554a23e22ae8fd768c390c549334fd3
Gerrit-Change-Number: 39427
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email )
Change subject: Improve logging reading packets from gtp device
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/osmo-upf/upf_gtpu_echo.c:
https://gerrit.osmocom.org/c/osmo-upf/+/39419/comment/ec17cf62_03bda400?usp… :
PS1, Line 219: return 0;
You're changing the logic: before your patch it would return `-1`, but now it's returning `0` -- is this fine?
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8
Gerrit-Change-Number: 39419
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Jan 2025 19:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39427?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: erab_fsm: add pretty printer for F-TEID
......................................................................
erab_fsm: add pretty printer for F-TEID
This patch makes log messages like this one:
Rx E-RAB SETUP Req (U2C {1454164620,<<"\n?-?">>})
a lot more readable:
Rx E-RAB SETUP Req (U2C 0x56acca8c(a)10.199.45.249)
Change-Id: I8c47abffd554a23e22ae8fd768c390c549334fd3
---
M src/erab_fsm.erl
1 file changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/27/39427/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39427?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8c47abffd554a23e22ae8fd768c390c549334fd3
Gerrit-Change-Number: 39427
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>