January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-asf4-dfu[master]: gitgnore

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39431?usp=email ) Change subject: gitgnore ...................................................................... gitgnore Change-Id: I95af162a01fb35656e0f9ccc9ce46b59a15c8c34 --- M .gitignore 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/31/39431/1 diff --git a/.gitignore b/.gitignore index ad0fce7..48b2a29 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,9 @@ *.map .gdb_history NOTES +gcc/.cache/* +gcc/compile_commands.json +gcc/crctool +install/* +**/compile_commands.json +.cache/* \ No newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39431?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I95af162a01fb35656e0f9ccc9ce46b59a15c8c34 Gerrit-Change-Number: 39431 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-asf4-dfu[master]: errata 2.6.10

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435?usp=email ) Change subject: errata 2.6.10 ...................................................................... errata 2.6.10 set wdt urow bits to ensure nvm cache is clear Change-Id: Ifbc6a3dfe91462029fce50ed42f20440debaa552 --- M gcc/gcc/startup_same54.c M hpl/nvmctrl/hpl_nvmctrl.c M usb_flash_main.c 3 files changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/35/39435/1 diff --git a/gcc/gcc/startup_same54.c b/gcc/gcc/startup_same54.c index 7d8015e..b943e54 100644 --- a/gcc/gcc/startup_same54.c +++ b/gcc/gcc/startup_same54.c @@ -627,7 +627,7 @@ * \brief This is the code that gets called on processor reset. * To initialize the device, and call the main() routine. */ -void Reset_Handler(void) +void _Reset_Handler(void) { uint32_t *pSrc, *pDest; @@ -668,6 +668,19 @@ ; } +__attribute__((naked,noreturn)) void Reset_Handler(void) +{ +// errata 2.6.10, do not remove this, ever. +// WDT->CTRLA.reg = 0; + __asm volatile ( + "movs r0, #0\n" + "ldr r1, =0x40002000\n" + "strb r0, [r1]\n" + "bl _Reset_Handler\n" + ::: "r0", "r1", "memory" + ); +} + /** * \brief Default interrupt handler for unused IRQs. */ diff --git a/hpl/nvmctrl/hpl_nvmctrl.c b/hpl/nvmctrl/hpl_nvmctrl.c index 63f6145..05db578 100644 --- a/hpl/nvmctrl/hpl_nvmctrl.c +++ b/hpl/nvmctrl/hpl_nvmctrl.c @@ -74,6 +74,10 @@ ASSERT(device && (hw == NVMCTRL)); + // errata 2.6.10, do not remove this, ever. + hri_nvmctrl_set_CTRLA_CACHEDIS1_bit(hw); + hri_nvmctrl_clear_CTRLA_CACHEDIS1_bit(hw); + device->hw = hw; ctrla = hri_nvmctrl_read_CTRLA_reg(hw); ctrla &= ~(NVMCTRL_CTRLA_CACHEDIS0 | NVMCTRL_CTRLA_CACHEDIS1 | NVMCTRL_CTRLA_PRM_Msk); diff --git a/usb_flash_main.c b/usb_flash_main.c index 518cf2d..b057d0a 100644 --- a/usb_flash_main.c +++ b/usb_flash_main.c @@ -131,6 +131,14 @@ str_to_usb_desc(sernr_buf, sizeof(sernr_buf), sernr_buf_descr, sizeof(sernr_buf_descr)); #endif + // errata 2.6.10, do not remove this, ever. + bool chiprev_lower_revG = ((DSU->DID.reg >> 8) & 0xf) < 0x6; + bool startup_wdt_inactive = _user_area_read_bits((void*)NVMCTRL_USER, 62, 1) != 1; + if (chiprev_lower_revG && startup_wdt_inactive) + { + _user_area_write_bits((void*)NVMCTRL_USER, 50, 0, 4); + _user_area_write_bits((void*)NVMCTRL_USER, 62, 1, 1); + } // set bootprot bits for (15-13)=2 x8192 byte // hri_nvmctrl_write_CTRLB_reg(NVMCTRL, NVMCTRL_CTRLB_CMD_SBPDIS | NVMCTRL_CTRLB_CMDEX_KEY); -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ifbc6a3dfe91462029fce50ed42f20440debaa552 Gerrit-Change-Number: 39435 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[L] Change in osmo-asf4-dfu[master]: add fw update crcstub

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email ) Change subject: add fw update crcstub ...................................................................... add fw update crcstub Adds a crc stub that lives in front of the dfu bl updater app and checks it. The whole process is somewhat complicated to ensure we end up not just with a firmware file that contains the right crc for the right offsets, but the elf file is updated as well, to ensure the result is debuggable as-is. The stub is built as part of the firmware code, and ends up in its own section. Linker script padding and alignment ensures that this works. Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed --- A crc_code.c A crc_params.c M gcc/Makefile M gcc/gcc/same54p20a_dfu.ld M gcc/gcc/same54p20a_flash.ld M gcc/gcc/startup_same54.c M usb_flash_main.c 7 files changed, 218 insertions(+), 101 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/37/39437/1 diff --git a/crc_code.c b/crc_code.c new file mode 100644 index 0000000..62031a1 --- /dev/null +++ b/crc_code.c @@ -0,0 +1,120 @@ +#include <stdint.h> +#ifndef HOST_TOOL +#include "atmel_start.h" + +#ifdef __clang__ +#define OPTNONE optnone +#else +#define OPTNONE optimize(0) +#endif + +extern void _Reset_Handler(void); + +__attribute__((used, section(".crc_code"))) +#endif +static uint32_t +calculate_crc(const uint8_t *data, uint32_t length) { + uint32_t crc = 0xFFFFFFFF; + for (uint32_t i = 0; i < length; i++) { + crc ^= data[i]; + for (uint8_t j = 0; j < 8; j++) { + crc = (crc & 1) ? (crc >> 1) ^ 0xEDB88320 : crc >> 1; + } + } + return ~crc; +} + +#ifndef HOST_TOOL +__attribute__((used, section(".crc_code"), OPTNONE)) void Reset_Handler(void) { + extern uint32_t __CRC_Checksum; + extern uint32_t __CRC_Start; + extern uint32_t __CRC_End; + extern int main(void); + + /* + the old BL will unfortunately enable usb even when booting and not doing dfu.. + we must reset it here, or the host will get really unhappy trying to talk to the "attached" + dev and reset the bus... + */ + USB->DEVICE.CTRLA.reg = 0x1; + + uint32_t length = (uint32_t)&__CRC_End - (uint32_t)&__CRC_Start; + uint32_t calculated_crc = calculate_crc((uint8_t *)&__CRC_Start, length); + uint32_t expected_crc = *(uint32_t *)&__CRC_Checksum; + + if (calculated_crc != expected_crc) { + static volatile uint32_t *dfu_magic = (uint32_t *)HSRAM_ADDR; + *dfu_magic = 0x44465521; + + /* Reset the device if CRC does not match */ + __DSB(); + SCB->AIRCR = (uint32_t)((0x5FAUL << SCB_AIRCR_VECTKEY_Pos) | (SCB->AIRCR & SCB_AIRCR_PRIGROUP_Msk) | + SCB_AIRCR_SYSRESETREQ_Msk); + __DSB(); + } + + /* Proceed to main application */ + // main(); + _Reset_Handler(); + + /* Infinite loop if main returns */ + while (1) + ; +} +#endif + +#ifdef HOST_TOOL +#include <stdio.h> +#include <stdlib.h> + +/* Usage: ./tool <binary_file> <start_offset_hex> <length_hex> + - start_offset_hex and length_hex are hex values indicating where to calculate the CRC. +*/ +int main(int argc, char *argv[]) { + if (argc != 4) { + fprintf(stderr, "Usage: %s <binary_file> <start_offset_hex> <length_hex>\n", argv[0]); + return 1; + } + + const char *filename = argv[1]; + // uint32_t start_offset = strtoul(argv[2], NULL, 16); + // uint32_t length = strtoul(argv[3], NULL, 16); + uint32_t start_offset = strtoul(argv[2], NULL, 10); + uint32_t length = strtoul(argv[3], NULL, 10); + + FILE *f = fopen(filename, "rb"); + if (!f) { + perror("fopen"); + return 1; + } + + // Seek to start_offset + if (fseek(f, (long)start_offset, SEEK_SET) != 0) { + perror("fseek"); + fclose(f); + return 1; + } + + uint8_t *buf = (uint8_t *)malloc(length); + if (!buf) { + fprintf(stderr, "Memory allocation error\n"); + fclose(f); + return 1; + } + + size_t read_bytes = fread(buf, 1, length, f); + fclose(f); + + if (read_bytes != length) { + fprintf(stderr, "Error reading file or not enough data\n"); + free(buf); + return 1; + } + + uint32_t crc = calculate_crc(buf, length); + free(buf); + + printf("%08X\n", crc); + return 0; +} +#endif diff --git a/crc_params.c b/crc_params.c new file mode 100644 index 0000000..032c71e --- /dev/null +++ b/crc_params.c @@ -0,0 +1,5 @@ +#include <stdint.h> + +__attribute__((used, section(".crc_par"))) const uint32_t __CRC_Checksum = 0xFFFFFFFF; /* Placeholder */ +// __attribute__((used, section(".crc_par"))) const uint32_t __CRC_Start = 0xFFFFFFFF; /* Placeholder */ +// __attribute__((used, section(".crc_par"))) const uint32_t __CRC_End = 0xFFFFFFFF; /* Placeholder */ diff --git a/gcc/Makefile b/gcc/Makefile index 2df931e..9c32616 100644 --- a/gcc/Makefile +++ b/gcc/Makefile @@ -1,62 +1,18 @@ -################################################################################ -# User configuration. Can be edited -################################################################################ - -# Set for which board the bootloader should be compiled -# run `make clean` for the change to be effective # possible values: SAME54_XPLAINED_PRO, SYSMOOCTSIM +SHELL := /bin/bash BOARD ?= SYSMOOCTSIM +CROSSCC ?= arm-none-eabi- +SILENT ?= @ +ROOT_DIR:=$(shell dirname $(realpath $(firstword $(MAKEFILE_LIST)))) + +#DBGFLGS = -fdebug-prefix-map=..=$(readlink -f .) +DBGFLGS = -fdebug-prefix-map=..=$(ROOT_DIR)/.. -fno-omit-frame-pointer -ggdb3 -Os # -fdata-sections -fno-common -Wl,--no-undefined -Wl,--strip-discarded #-Wl,--gc-debuginfo GIT_VERSION=$(shell ../git-version-gen $(TOP)/.tarvers) +DBGFLGS += -DGIT_VERSION=\"$(GIT_VERSION)\" -################################################################################ -# Automatically-generated file. Do not edit! -################################################################################ +MK_DIR = mkdir -p -ifdef SystemRoot - SHELL = cmd.exe - MK_DIR = mkdir -else - ifeq ($(shell uname), Linux) - MK_DIR = mkdir -p - endif - - ifeq ($(shell uname | cut -d _ -f 1), CYGWIN) - MK_DIR = mkdir -p - endif - - ifeq ($(shell uname | cut -d _ -f 1), MINGW32) - MK_DIR = mkdir -p - endif - - ifeq ($(shell uname | cut -d _ -f 1), MINGW64) - MK_DIR = mkdir -p - endif -endif - -# List the subdirectories for creating object files -SUB_DIRS += \ - \ -hpl/pm \ -gcc \ -hpl/osc32kctrl \ -hpl/ramecc \ -hpl/dmac \ -usb/class/dfu/device \ -hal/src \ -hpl/mclk \ -usb \ -hal/utils/src \ -hpl/gclk \ -usb/device \ -hpl/oscctrl \ -gcc/gcc \ -hpl/nvmctrl \ -hpl/usb \ -hpl/core \ -hpl/cmcc - -# List the object files OBJS += \ hal/src/hal_io.o \ hpl/core/hpl_core_m4.o \ @@ -92,6 +48,18 @@ usb/device/usbdc.o \ hal/src/hal_atomic.o +SRC_hosttools = crc_code.c +SRC_dfu = usb_dfu_main.c crc_code.c crc_params.c +SRC_flash = usb_flash_main.c + +OBJ_dfu := $(SRC_dfu:.c=.o) +OBJ_flash := $(SRC_flash:.c=.o) + +DFU_DEPS := $(OBJ_dfu:.o=.d) +FLASH_DEPS := $(OBJ_flash:.o=.d) + + +SUB_DIRS := $(sort $(dir $(OBJS))) DEPS := $(OBJS:%.o=%.d) OBJS_AS_ARGS = $(patsubst %,"%",$(OBJS)) DEPS_AS_ARGS = $(patsubst %,"%",$(DEPS)) @@ -99,64 +67,81 @@ BOARD_LC := $(shell echo $(BOARD) | tr A-Z a-z) OUTPUT_FILE_NAME := bootloader-$(BOARD_LC)-$(GIT_VERSION) QUOTE := " -# OUTPUT_FILE_PATH +=$(OUTPUT_FILE_NAME).elf -#OUTPUT_FILE_PATH_AS_ARGS +=$(OUTPUT_FILE_NAME).elf -BLSIZE_DEF := -D$(QUOTE)$(shell sed 's/;//g' gcc/blsize.ld | tr -d ' ')$(QUOTE) - -# .PHONY MAIN_dfu MAIN_flash -# MAIN_%: -# = usb_dfu_main.o +BLSZ = $(shell sed 's/;//g' gcc/blsize.ld | tr -d ' ' | cut -d '=' -f2) +CALC_BLSZ = $(shell echo $$(( $(BLSZ) ))) +$(info blsize is $(CALC_BLSZ)) +BLSIZE_DEF := -D$(QUOTE)BL_SIZE_BYTE=$(CALC_BLSZ)$(QUOTE) vpath %.c ../ vpath %.s ../ vpath %.S ../ -.PHONY: clean-dfu clean-flash +.PHONY: clean-dfu clean-flash hosttools -all: $(SUB_DIRS) dfu-merge +all: $(SUB_DIRS) hosttools dfu-merge + +hosttools: + $(CC) -DHOST_TOOL ../$(SRC_hosttools) -o crctool dfu-merge: $(OUTPUT_FILE_NAME)-dfu $(OUTPUT_FILE_NAME)-dfu: $(OUTPUT_FILE_NAME)-flash -# Linker target - -$(OUTPUT_FILE_NAME)-%: $(OBJS) usb_%_main.o - @echo Building target: $@ +.SECONDEXPANSION: +$(OUTPUT_FILE_NAME)-%: $(OBJS) $$(OBJ_$$*) + @echo Building target: $@ $^ @echo Invoking: ARM/GNU Linker - $(QUOTE)arm-none-eabi-gcc$(QUOTE) -o $(OUTPUT_FILE_NAME)-$*.elf $(OBJS_AS_ARGS) "usb_$*_main.o" \ - -Wl,--no-undefined -Wl,--print-memory-usage -Wl,--strip-discarded -Wl,--start-group -lm -Wl,--end-group -mthumb \ + $(SILENT)$(QUOTE)$(CROSSCC)gcc$(QUOTE) -o $(OUTPUT_FILE_NAME)-$*.elf $(OBJS_AS_ARGS) $(OBJ_$*) \ + $(DBGFLGS) -Wl,--no-undefined -Wl,--print-memory-usage -Wl,--strip-discarded -Wl,--start-group -lm -Wl,--end-group -mthumb \ -Wl,-Map="$(OUTPUT_FILE_NAME)-$*.map" --specs=nano.specs -Wl,--gc-sections -mcpu=cortex-m4 \ -T"../gcc/gcc/same54p20a_$*.ld" \ -L"../gcc/gcc" @echo Finished building target: $@ - "arm-none-eabi-objcopy" -O binary "$(OUTPUT_FILE_NAME)-$*.elf" "$(OUTPUT_FILE_NAME)-$*.bin" -# "arm-none-eabi-objcopy" -O ihex -R .eeprom -R .fuse -R .lock -R .signature "$(OUTPUT_FILE_NAME)-$*.elf" "$(OUTPUT_FILE_NAME)-$*.hex" -# "arm-none-eabi-objcopy" -j .eeprom --set-section-flags=.eeprom=alloc,load --change-section-lma .eeprom=0 --no-change-warnings -O binary "$(OUTPUT_FILE_NAME)-$*.elf" "$(OUTPUT_FILE_NAME)-$*.eep" || exit 0 - "arm-none-eabi-objdump" -h -S "$(OUTPUT_FILE_NAME)-$*.elf" > "$(OUTPUT_FILE_NAME)-$*.lss" - "arm-none-eabi-size" "$(OUTPUT_FILE_NAME)-$*.elf" - ln -sf $(OUTPUT_FILE_NAME)-$*.bin bootloader-$(BOARD_LC)-$*.bin - ln -sf $(OUTPUT_FILE_NAME)-$*.elf bootloader-$(BOARD_LC)-$*.elf + $(SILENT)"$(CROSSCC)objcopy" -O binary "$(OUTPUT_FILE_NAME)-$*.elf" "$(OUTPUT_FILE_NAME)-$*.bin" +# $(SILENT)"$(CROSSCC)objcopy" -O ihex -R .eeprom -R .fuse -R .lock -R .signature "$(OUTPUT_FILE_NAME)-$*.elf" "$(OUTPUT_FILE_NAME)-$*.hex" +# $(SILENT)"$(CROSSCC)objcopy" -j .eeprom --set-section-flags=.eeprom=alloc,load --change-section-lma .eeprom=0 --no-change-warnings -O binary "$(OUTPUT_FILE_NAME)-$*.elf" "$(OUTPUT_FILE_NAME)-$*.eep" || exit 0 + $(SILENT)"$(CROSSCC)objdump" -h -S "$(OUTPUT_FILE_NAME)-$*.elf" > "$(OUTPUT_FILE_NAME)-$*.lss" + $(SILENT)"$(CROSSCC)size" "$(OUTPUT_FILE_NAME)-$*.elf" + $(SILENT)ln -sf $(OUTPUT_FILE_NAME)-$*.bin bootloader-$(BOARD_LC)-$*.bin + $(SILENT)ln -sf $(OUTPUT_FILE_NAME)-$*.elf bootloader-$(BOARD_LC)-$*.elf .PHONY: dfu-merge dfu-merge: $(info updating updater section with padded bootloader file..) - $(SILENT)dd if=/dev/zero bs=16384 count=1 of=dfu-flash-padded.bin - $(SILENT)dd if=$(OUTPUT_FILE_NAME)-flash.bin conv=notrunc of=dfu-flash-padded.bin - $(SILENT)"arm-none-eabi-objcopy" --update-section .blupdate=dfu-flash-padded.bin $(OUTPUT_FILE_NAME)-dfu.elf - $(SILENT)"arm-none-eabi-objcopy" -O binary $(OUTPUT_FILE_NAME)-dfu.elf $(OUTPUT_FILE_NAME)-dfu.bin - rm dfu-flash-padded.bin + #$(SILENT)dd status=none if=/dev/zero bs=$(CALC_BLSZ) count=1 of=dfu-flash-padded.bin + #$(SILENT)dd status=none if=$(OUTPUT_FILE_NAME)-flash.bin conv=notrunc of=dfu-flash-padded.bin + $(SILENT)cp -a $(OUTPUT_FILE_NAME)-flash.bin dfu-flash-padded.bin + $(SILENT)truncate -s $(CALC_BLSZ) dfu-flash-padded.bin + $(SILENT)"$(CROSSCC)objcopy" --update-section .blupdate=dfu-flash-padded.bin $(OUTPUT_FILE_NAME)-dfu.elf + $(SILENT)"$(CROSSCC)objcopy" -O binary $(OUTPUT_FILE_NAME)-dfu.elf $(OUTPUT_FILE_NAME)-dfu.bin + $(SILENT)rm dfu-flash-padded.bin + + @FLASH_START_ADDR=0x$$($(CROSSCC)nm $(OUTPUT_FILE_NAME)-dfu.elf | grep ' _sfixed$$' | cut -d' ' -f1); \ + CRC_START_ADDR=0x$$($(CROSSCC)nm $(OUTPUT_FILE_NAME)-dfu.elf | grep ' __CRC_Start$$' | cut -d' ' -f1); \ + CRC_END_ADDR=0x$$($(CROSSCC)nm $(OUTPUT_FILE_NAME)-dfu.elf | grep ' _etext$$' | cut -d' ' -f1); \ + CRC_CHECKSUM_ADDR=0x$$($(CROSSCC)nm $(OUTPUT_FILE_NAME)-dfu.elf | grep ' __CRC_Checksum$$' | cut -d' ' -f1); \ + echo $$CRC_START_ADDR $$CRC_END_ADDR $$CRC_CHECKSUM_ADDR; \ + CRC_START_OFFSET=$$(($$CRC_START_ADDR - $$FLASH_START_ADDR)); \ + CRC_END_OFFSET=$$(($$CRC_END_ADDR - $$FLASH_START_ADDR)); \ + CRC_CHECKSUM_OFFSET=$$(($$CRC_CHECKSUM_ADDR - $$FLASH_START_ADDR)); \ + LENGTH=$$(($$CRC_END_OFFSET - $$CRC_START_OFFSET)); \ + CRC_HEX=$$(./crctool $(OUTPUT_FILE_NAME)-dfu.bin $$CRC_START_OFFSET $$LENGTH ); \ + echo len $$LENGTH : $$CRC_START_OFFSET-$$CRC_END_OFFSET, crco: $$CRC_CHECKSUM_OFFSET, start: $$CRC_START_ADDR crcval: $$CRC_HEX; \ + [ $$(($$CRC_START_OFFSET - $$CRC_CHECKSUM_OFFSET)) -ne 4 ] && exit 1; \ + printf $$CRC_HEX | xxd -r -p | xxd -e | xxd -r | dd of=$(OUTPUT_FILE_NAME)-dfu.bin bs=1 seek=$$CRC_CHECKSUM_OFFSET conv=notrunc 2>/dev/null; \ + xxd -s $$(($$CRC_START_ADDR - $$FLASH_START_ADDR -4)) -l 4 -g 1 $(OUTPUT_FILE_NAME)-dfu.bin; \ + "$(CROSSCC)objcopy" -O binary --only-section=.text $(OUTPUT_FILE_NAME)-dfu.elf section_text.bin; \ + printf $$CRC_HEX | xxd -r -p | xxd -e | xxd -r | dd of=section_text.bin bs=1 seek=$$CRC_CHECKSUM_OFFSET conv=notrunc 2>/dev/null; \ + xxd -s $$(($$CRC_START_ADDR - $$FLASH_START_ADDR -4)) -l 4 -g 1 section_text.bin; \ + "$(CROSSCC)objcopy" --update-section .text=section_text.bin $(OUTPUT_FILE_NAME)-dfu.elf; + # Compiler targets - - - - %.o: %.c @echo Building file: $< @echo ARM/GNU C Compiler - $(QUOTE)arm-none-eabi-gcc$(QUOTE) -x c -mthumb -DDEBUG -Os -ffunction-sections -mlong-calls -g3 -Wall -c -std=gnu99 \ + $(QUOTE)$(CROSSCC)gcc$(QUOTE) $(DBGFLGS) -x c -Wstringop-truncation -Wformat-truncation -mthumb -DDEBUG -ffunction-sections -mlong-calls -Wall -c -std=gnu99 \ $(BLSIZE_DEF) -D__SAME54P19A__ -D$(BOARD) -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 \ -I"../" -I"../config" -I"../hal/include" -I"../hal/utils/include" -I"../hpl/cmcc" -I"../hpl/core" -I"../hpl/dmac" -I"../hpl/gclk" -I"../hpl/mclk" -I"../hpl/nvmctrl" -I"../hpl/osc32kctrl" -I"../hpl/oscctrl" -I"../hpl/pm" -I"../hpl/port" -I"../hpl/ramecc" -I"../hpl/usb" -I"../hri" -I"../" -I"../config" -I"../usb" -I"../usb/class/dfu" -I"../usb/class/dfu/device" -I"../usb/device" -I"../" -I"../CMSIS/Include" -I"../include" \ -MD -MP -MF "$(@:%.o=%.d)" -MT"$(@:%.o=%.d)" -MT"$(@:%.o=%.o)" -o "$@" "$<" @@ -165,7 +150,7 @@ %.o: %.s @echo Building file: $< @echo ARM/GNU Assembler - $(QUOTE)arm-none-eabi-as$(QUOTE) -x c -mthumb -DDEBUG -Os -ffunction-sections -mlong-calls -g3 -Wall -c -std=gnu99 \ + $(QUOTE)$(CROSSCC)as$(QUOTE) $(DBGFLGS) -x c -mthumb -DDEBUG -ffunction-sections -mlong-calls -Wall -c -std=gnu99 \ $(BLSIZE_DEF) -D__SAME54P19A__ -D$(BOARD) -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 \ -I"../" -I"../config" -I"../hal/include" -I"../hal/utils/include" -I"../hpl/cmcc" -I"../hpl/core" -I"../hpl/dmac" -I"../hpl/gclk" -I"../hpl/mclk" -I"../hpl/nvmctrl" -I"../hpl/osc32kctrl" -I"../hpl/oscctrl" -I"../hpl/pm" -I"../hpl/port" -I"../hpl/ramecc" -I"../hpl/usb" -I"../hri" -I"../" -I"../config" -I"../usb" -I"../usb/class/dfu" -I"../usb/class/dfu/device" -I"../usb/device" -I"../" -I"../CMSIS/Include" -I"../include" \ -MD -MP -MF "$(@:%.o=%.d)" -MT"$(@:%.o=%.d)" -MT"$(@:%.o=%.o)" -o "$@" "$<" @@ -174,7 +159,7 @@ %.o: %.S @echo Building file: $< @echo ARM/GNU Preprocessing Assembler - $(QUOTE)arm-none-eabi-gcc$(QUOTE) -x c -mthumb -DDEBUG -Os -ffunction-sections -mlong-calls -g3 -Wall -c -std=gnu99 \ + $(QUOTE)$(CROSSCC)gcc$(QUOTE) $(DBGFLGS) -x c -mthumb -DDEBUG -ffunction-sections -mlong-calls -Wall -c -std=gnu99 \ $(BLSIZE_DEF) -D__SAME54P19A__ -D$(BOARD) -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 \ -I"../" -I"../config" -I"../hal/include" -I"../hal/utils/include" -I"../hpl/cmcc" -I"../hpl/core" -I"../hpl/dmac" -I"../hpl/gclk" -I"../hpl/mclk" -I"../hpl/nvmctrl" -I"../hpl/osc32kctrl" -I"../hpl/oscctrl" -I"../hpl/pm" -I"../hpl/port" -I"../hpl/ramecc" -I"../hpl/usb" -I"../hri" -I"../" -I"../config" -I"../usb" -I"../usb/class/dfu" -I"../usb/class/dfu/device" -I"../usb/device" -I"../" -I"../CMSIS/Include" -I"../include" \ -MD -MP -MF "$(@:%.o=%.d)" -MT"$(@:%.o=%.d)" -MT"$(@:%.o=%.o)" -o "$@" "$<" @@ -184,7 +169,8 @@ ifneq ($(MAKECMDGOALS),clean) ifneq ($(strip $(DEPS)),) -include $(DEPS) --include usb_flash_main.d usb_dfu_main.d +-include $(DFU_DEPS) +-include $(FLASH_DEPS) endif endif @@ -192,20 +178,13 @@ $(MK_DIR) "$@" clean-%: - rm -f $(OBJS_AS_ARGS) - # rm -f $(OUTPUT_FILE_PATH) - rm -f $(DEPS_AS_ARGS) rm -f $(OUTPUT_FILE_NAME)-$*.a $(OUTPUT_FILE_NAME)-$*.hex $(OUTPUT_FILE_NAME)-$*.bin \ $(OUTPUT_FILE_NAME)-$*.lss $(OUTPUT_FILE_NAME)-$*.eep $(OUTPUT_FILE_NAME)-$*.map \ $(OUTPUT_FILE_NAME)-$*.srec bootloader-$(BOARD_LC)-$*.bin bootloader-$(BOARD_LC)-$*.elf clean: clean-dfu clean-flash rm -f $(OBJS_AS_ARGS) - # rm -f $(OUTPUT_FILE_PATH) rm -f $(DEPS_AS_ARGS) - # rm -f $(OUTPUT_FILE_NAME).a $(OUTPUT_FILE_NAME).hex $(OUTPUT_FILE_NAME).bin \ - # $(OUTPUT_FILE_NAME).lss $(OUTPUT_FILE_NAME).eep $(OUTPUT_FILE_NAME).map \ - # $(OUTPUT_FILE_NAME).srec bootloader-$(BOARD_LC).bin bootloader-$(BOARD_LC).elf mrproper: clean rm -f *.o *.d *.a *.elf *.bin *.hex *.ihex *.eep *.lss *.map *.srec diff --git a/gcc/gcc/same54p20a_dfu.ld b/gcc/gcc/same54p20a_dfu.ld index becba88..9a3ff73 100644 --- a/gcc/gcc/same54p20a_dfu.ld +++ b/gcc/gcc/same54p20a_dfu.ld @@ -54,6 +54,10 @@ . = ALIGN(4); _sfixed = .; KEEP(*(.vectors .vectors.*)) + KEEP(*(.crc_code)) /* CRC checking code */ + KEEP(*(.crc_par)) /* CRC parameters */ + . = ALIGN(4); + __CRC_Start = ORIGIN(rom) + .; *(.text .text.* .gnu.linkonce.t.*) *(.glue_7t) *(.glue_7) *(.rodata .rodata* .gnu.linkonce.r.*) @@ -96,14 +100,14 @@ . = ALIGN(4); _efixed = .; /* End of text section */ - } > rom + } > rom = 0xff /* .ARM.exidx is sorted, so has to go in its own output section. */ PROVIDE_HIDDEN (__exidx_start = .); .ARM.exidx : { *(.ARM.exidx* .gnu.linkonce.armexidx.*) - } > rom + } > rom = 0xff PROVIDE_HIDDEN (__exidx_end = .); .blupdate : @@ -112,10 +116,11 @@ _blupdate_start = .; KEEP(*(.fwupdate .fwupdate.*)); _blupdate_end = .; - } > rom + } > rom = 0xff . = ALIGN(4); _etext = .; + __CRC_End = .; .relocate : AT (_etext) { diff --git a/gcc/gcc/same54p20a_flash.ld b/gcc/gcc/same54p20a_flash.ld index f2c5124..354105b 100644 --- a/gcc/gcc/same54p20a_flash.ld +++ b/gcc/gcc/same54p20a_flash.ld @@ -96,14 +96,14 @@ . = ALIGN(4); _efixed = .; /* End of text section */ - } > rom + } > rom = 0xff /* .ARM.exidx is sorted, so has to go in its own output section. */ PROVIDE_HIDDEN (__exidx_start = .); .ARM.exidx : { *(.ARM.exidx* .gnu.linkonce.armexidx.*) - } > rom + } > rom = 0xff PROVIDE_HIDDEN (__exidx_end = .); . = ALIGN(4); @@ -162,4 +162,11 @@ . = ALIGN(4); _end = . ; + + /DISCARD/ : + { + *(.crc_code*) + *(.crc_par*) + } + } diff --git a/gcc/gcc/startup_same54.c b/gcc/gcc/startup_same54.c index b943e54..4796f30 100644 --- a/gcc/gcc/startup_same54.c +++ b/gcc/gcc/startup_same54.c @@ -668,7 +668,7 @@ ; } -__attribute__((naked,noreturn)) void Reset_Handler(void) +__attribute__((naked,noreturn,weak)) void Reset_Handler(void) { // errata 2.6.10, do not remove this, ever. // WDT->CTRLA.reg = 0; diff --git a/usb_flash_main.c b/usb_flash_main.c index b057d0a..dd2523f 100644 --- a/usb_flash_main.c +++ b/usb_flash_main.c @@ -20,6 +20,7 @@ */ #include <errno.h> +#include <stdio.h> #include "atmel_start.h" #include "atmel_start_pins.h" #include "hpl_user_area.h" -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-asf4-dfu[master]: ver in usb prod desc

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39438?usp=email ) Change subject: ver in usb prod desc ...................................................................... ver in usb prod desc previously: [Wed Jan 29 17:26:19 2025] usb 3-1: Product: sysmoOCTSIM (osmo-ASF4-DFU) now, just like the main app with ver: [Wed Jan 29 18:41:19 2025] usb 3-1: Product: sysmoOCTSIM DFU-0.1.16-9852 Change-Id: I1f183695a3e458db2668e9950f859c936a821dc8 --- M usb_flash_main.c M usb_start.c 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/38/39438/1 diff --git a/usb_flash_main.c b/usb_flash_main.c index dd2523f..c944771 100644 --- a/usb_flash_main.c +++ b/usb_flash_main.c @@ -120,8 +120,9 @@ } char sernr_buf[16*2+1]; -//unicode for descriptor -uint8_t sernr_buf_descr[1+1+16*2*2]; +char product_buf[] = "sysmoOCTSIM DFU-"GIT_VERSION; +uint8_t __attribute__ ((aligned (16))) sernr_buf_descr[1+1+16*2*2]; +uint8_t __attribute__ ((aligned (16))) product_buf_descr[1+1+(sizeof(product_buf)-1)*2]; #endif int main(void) @@ -130,6 +131,7 @@ #if defined(SYSMOOCTSIM) get_chip_unique_serial_str(sernr_buf, sizeof(sernr_buf)); str_to_usb_desc(sernr_buf, sizeof(sernr_buf), sernr_buf_descr, sizeof(sernr_buf_descr)); + str_to_usb_desc(product_buf, sizeof(product_buf)-1, product_buf_descr, sizeof(product_buf_descr)); #endif // errata 2.6.10, do not remove this, ever. diff --git a/usb_start.c b/usb_start.c index dacd325..86b396e 100644 --- a/usb_start.c +++ b/usb_start.c @@ -72,6 +72,8 @@ } extern uint8_t sernr_buf_descr[]; +extern uint8_t product_buf_descr[]; + /* call-back for every control EP request */ static int32_t string_req_cb(uint8_t ep, struct usb_req *req, enum usb_ctrl_stage stage) { @@ -101,6 +103,8 @@ switch (index) { case CONF_USB_DFUD_ISERIALNUM: return send_str_desc(ep, req, stage, sernr_buf_descr); + case CONF_USB_DFUD_IPRODUCT: + return send_str_desc(ep, req, stage, product_buf_descr); default: return ERR_NOT_FOUND; } -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1f183695a3e458db2668e9950f859c936a821dc8 Gerrit-Change-Number: 39438 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: GMM: rework PDP context status

by lynxis lazus

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39241?usp=email ) Change subject: GMM: rework PDP context status ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/39241/comment/65095ff6_ac95f971?us… : PS2, Line 11: mobilty this could change). It resynchronize the UE with the SGSN > Not done done. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I12d3110c9365132f96ef7ff8a1be22a431682c81 Gerrit-Change-Number: 39241 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 17:58:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim/transport: add abstract get_atr method to LinkBase

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/39424?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim/transport: add abstract get_atr method to LinkBase ...................................................................... pySim/transport: add abstract get_atr method to LinkBase The implementations that inheret from the LinkBase class are expected to implement a get_atr method. This method is mandatory, since it is one of the most basic functionalities of pySim to display an ATR. Also the ATR is sometimes needed to distinguish between different card models. The modem_atcmd and calypso implementation completely lack the get_atr method. Apparantly it is not possible to get an ATR in those environments, so lets add a dummy method there. Related: OS#6322 Change-Id: I4fc020ca45658af78e495a5c1b985213f83cbb50 --- M pySim/transport/__init__.py M pySim/transport/calypso.py M pySim/transport/modem_atcmd.py 3 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/39424/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc020ca45658af78e495a5c1b985213f83cbb50 Gerrit-Change-Number: 39424 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for read completion

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for read completion ...................................................................... tests/osmo_io: Introduce small sleeps waiting for read completion Sometimes test_file() fails during jenkins run because it finished the main loop iterations without having received a read complete cb. This may be due to filesystem delays due to system load, it's difficult to say since it only happens sporadically. Add some small sleeps under each loop iteration (which can end up waiting up to 10s after full set of iterations) to make sure we receive the read callback in a timely fashion. Related: OS#6708 Change-Id: If27e3885aa17edbb7f2428cf6b5b30fb0f987d7d --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index 95d78b0..553368c 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -126,6 +126,7 @@ if (file_bytes_read == sizeof(TESTDATA) && file_eof_read) break; osmo_select_main(1); + usleep(100 * 1000); } fflush(stdout); OSMO_ASSERT(file_bytes_read == sizeof(TESTDATA)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If27e3885aa17edbb7f2428cf6b5b30fb0f987d7d Gerrit-Change-Number: 39430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-upf[master]: Improve logging reading packets from gtp device

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email ) Change subject: Improve logging reading packets from gtp device ...................................................................... Improve logging reading packets from gtp device Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8 --- M src/osmo-upf/upf_gtpu_echo.c 1 file changed, 19 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/osmo-upf/upf_gtpu_echo.c b/src/osmo-upf/upf_gtpu_echo.c index f4bbb76..ae370e6 100644 --- a/src/osmo-upf/upf_gtpu_echo.c +++ b/src/osmo-upf/upf_gtpu_echo.c @@ -13,8 +13,12 @@ #define GTP1U_PORT 2152 enum gtp1u_msgt { - GTP1U_MSGTYPE_ECHO_REQ = 1, - GTP1U_MSGTYPE_ECHO_RSP = 2, + GTP1U_MSGTYPE_ECHO_REQ = 1, + GTP1U_MSGTYPE_ECHO_RSP = 2, + GTP1U_MSGTYPE_ERRR_IND = 26, + GTP1U_MSGTYPE_SUPP_EXT_HDR_NOTIF = 31, + GTP1U_MSGTYPE_END_MARKER = 254, + GTP1U_MSGTYPE_GPDU = 255, }; enum gtp1u_iei { @@ -159,7 +163,7 @@ return rc; } -int upf_gtpu_echo_read_cb(struct osmo_fd *ofd, unsigned int what) +int upf_gtpu_read_cb(struct osmo_fd *ofd, unsigned int what) { struct upf_gtp_dev *dev = ofd->data; @@ -208,8 +212,18 @@ case GTP1U_MSGTYPE_ECHO_RSP: rx_echo_resp(dev, &remote, h, sz); return 0; + case GTP1U_MSGTYPE_ERRR_IND: + /* 3GPP TS 29.281 7.3.1: Log "Tunnel Endpoint Identifier Data I" and "GTP-U Peer Address" */ + LOG_GTP_DEV(dev, LOGL_NOTICE, "%s rx: GTPv1-U Error Indication not supported\n", + osmo_sockaddr_to_str(&remote)); + return 0; + case GTP1U_MSGTYPE_GPDU: + LOG_GTP_DEV(dev, LOGL_NOTICE, "%s rx: GTPv1-U PDU TEID=0x%08x over slow path not supported\n", + osmo_sockaddr_to_str(&remote), osmo_load32be(&h->tei)); + return 0; default: - LOG_GTP_DEV(dev, LOGL_ERROR, "rx: GTPv1-U message type %u not supported\n", h->msg_type); + LOG_GTP_DEV(dev, LOGL_ERROR, "%s rx: GTPv1-U message type %u not supported\n", + osmo_sockaddr_to_str(&remote), h->msg_type); return -1; } } @@ -226,7 +240,7 @@ /* make sure there is no cb yet that this would be replacing. */ OSMO_ASSERT(dev->gtpv1.ofd.cb == NULL); - dev->gtpv1.ofd.cb = upf_gtpu_echo_read_cb; + dev->gtpv1.ofd.cb = upf_gtpu_read_cb; dev->gtpv1.ofd.data = dev; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8 Gerrit-Change-Number: 39419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-msc[master]: include SM-RP-UI in outgoing GSUP message when presesnt

by pespin

Attention is currently required from: dotsimon, fixeria, lynxis lazus. pespin has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: I'd welcome if you could share the related spec talking about SM-RP-UI here, plus add a bit of rationale in the commit description. File src/libmsc/gsm_04_11_gsup.c: https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/c8e60483_ac56433d?usp… : PS2, Line 187: int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr, uint8_t *ui) I'd say better pass the len as a separate param here, and pass the buffer as &(ui[1]) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 2 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 29 Jan 2025 11:51:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for read completion

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for read completion ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If27e3885aa17edbb7f2428cf6b5b30fb0f987d7d Gerrit-Change-Number: 39430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 11:49:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025