January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for read completion

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for read completion ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If27e3885aa17edbb7f2428cf6b5b30fb0f987d7d Gerrit-Change-Number: 39430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 11:48:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for read completion

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for read completion ...................................................................... tests/osmo_io: Introduce small sleeps waiting for read completion Sometimes test_file() fails during jenkins run because it finished the main loop iterations without having received a read complete cb. This may be due to filesystem delays due to system load, it's difficult to say since it only happens sporadically. Add some small sleeps under each loop iteration (which can end up waiting up to 10s after full set of iterations) to make sure we receive the read callback in a timely fashion. Related: OS#6708 Change-Id: If27e3885aa17edbb7f2428cf6b5b30fb0f987d7d --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/30/39430/1 diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index 95d78b0..553368c 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -126,6 +126,7 @@ if (file_bytes_read == sizeof(TESTDATA) && file_eof_read) break; osmo_select_main(1); + usleep(100 * 1000); } fflush(stdout); OSMO_ASSERT(file_bytes_read == sizeof(TESTDATA)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If27e3885aa17edbb7f2428cf6b5b30fb0f987d7d Gerrit-Change-Number: 39430 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: ATR: use lowercase hex strings without spaces as ATR constants

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/39429?usp=email ) Change subject: ATR: use lowercase hex strings without spaces as ATR constants ...................................................................... ATR: use lowercase hex strings without spaces as ATR constants The ATR constants are the only hex string constants where the hex bytes digits are separated with spaces. Also the hex digits are in lowercase. Let's use a lowercase string without spaces here like we do in many other code locations. Related: OS#6322 Change-Id: I95118115b02523ed262a2fbe4369ace3996cd8f5 --- M pySim/legacy/cards.py M pySim/sysmocom_sja2.py 2 files changed, 19 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/39429/1 diff --git a/pySim/legacy/cards.py b/pySim/legacy/cards.py index 1f5db8a..ab69eed 100644 --- a/pySim/legacy/cards.py +++ b/pySim/legacy/cards.py @@ -781,7 +781,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 99 18 00 11 88 22 33 44 55 66 77 60"): + if scc.get_atr() == toBytes("3b991800118822334455667760"): return kls(scc) except: return None @@ -826,7 +826,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 7D 94 00 00 55 55 53 0A 74 86 93 0B 24 7C 4D 54 68"): + if scc.get_atr() == toBytes("3b7d9400005555530a7486930b247c4d5468"): return kls(scc) except: return None @@ -904,7 +904,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 96 80 1F C7 80 31 A0 73 BE 21 13 67 43 20 07 18 00 00 01 A5"): + if scc.get_atr() == toBytes("3b9f96801fc78031a073be21136743200718000001a5"): return kls(scc) except: return None @@ -1032,7 +1032,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 96 80 1F C7 80 31 A0 73 BE 21 13 67 44 22 06 10 00 00 01 A9"): + if scc.get_atr() == toBytes("3b9f96801fc78031a073be21136744220610000001a9"): return kls(scc) except: return None @@ -1166,7 +1166,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 95 80 1F C3 80 31 E0 73 FE 21 13 57 86 81 02 86 98 44 18 A8"): + if scc.get_atr() == toBytes("3b9f95801fc38031e073fe21135786810286984418a8"): return kls(scc) except: return None @@ -1215,7 +1215,7 @@ def autodetect(kls, scc): try: # Look for ATR - if scc.get_atr() == toBytes("3B 9F 95 80 1F C7 80 31 E0 73 F6 21 13 67 4D 45 16 00 43 01 00 8F"): + if scc.get_atr() == toBytes("3b9f95801fc78031e073f62113674d4516004301008f"): return kls(scc) except: return None @@ -1305,17 +1305,17 @@ def autodetect(kls, scc): try: # Try card model #1 - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 30 34 05 4B A9" + atr = "3b9f96801f878031e073fe211b674a4c753034054ba9" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #2 - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 31 33 02 51 B2" + atr = "3b9f96801f878031e073fe211b674a4c7531330251b2" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #3 - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 52 75 31 04 51 D5" + atr = "3b9f96801f878031e073fe211b674a4c5275310451d5" if scc.get_atr() == toBytes(atr): return kls(scc) except: @@ -1554,15 +1554,15 @@ def autodetect(kls, scc): try: # Try card model #1 (9FJ) - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 51 CC" + atr = "3b9f96801f878031e073fe211b674a357530350251cc" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #2 (SLM17) - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 65 F8" + atr = "3b9f96801f878031e073fe211b674a357530350265f8" if scc.get_atr() == toBytes(atr): return kls(scc) # Try card model #3 (9FV) - atr = "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 59 C4" + atr = "3b9f96801f878031e073fe211b674a357530350259c4" if scc.get_atr() == toBytes(atr): return kls(scc) except: @@ -1592,7 +1592,7 @@ def autodetect(cls, scc): try: # Look for ATR - if scc.get_atr() == toBytes('3B 9F 95 80 1F C7 80 31 A0 73 B6 A1 00 67 CF 32 15 CA 9C D7 09 20'): + if scc.get_atr() == toBytes('3b9f95801fc78031a073b6a10067cf3215ca9cd70920'): return cls(scc) except: return None diff --git a/pySim/sysmocom_sja2.py b/pySim/sysmocom_sja2.py index bef955a..c145f0f 100644 --- a/pySim/sysmocom_sja2.py +++ b/pySim/sysmocom_sja2.py @@ -298,9 +298,9 @@ class SysmocomSJA2(CardModel): - _atrs = ["3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 30 34 05 4B A9", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 75 31 33 02 51 B2", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 4C 52 75 31 04 51 D5"] + _atrs = ["3b9f96801f878031e073fe211b674a4c753034054ba9", + "3b9f96801f878031e073fe211b674a4c7531330251b2", + "3b9f96801f878031e073fe211b674a4c5275310451d5"] @classmethod def add_files(cls, rs: RuntimeState): @@ -329,9 +329,9 @@ isim_adf.add_files(files_adf_isim) class SysmocomSJA5(CardModel): - _atrs = ["3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 51 CC", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 65 F8", - "3B 9F 96 80 1F 87 80 31 E0 73 FE 21 1B 67 4A 35 75 30 35 02 59 C4"] + _atrs = ["3b9f96801f878031e073fe211b674a357530350251cc", + "3b9f96801f878031e073fe211b674a357530350265f8", + "3b9f96801f878031e073fe211b674a357530350259c4"] @classmethod def add_files(cls, rs: RuntimeState): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95118115b02523ed262a2fbe4369ace3996cd8f5 Gerrit-Change-Number: 39429 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-upf[master]: Improve logging reading packets from gtp device

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email ) Change subject: Improve logging reading packets from gtp device ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8 Gerrit-Change-Number: 39419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 08:43:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-msc[master]: include SM-RP-UI in outgoing GSUP message when presesnt

by dotsimon

Attention is currently required from: dotsimon. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... include SM-RP-UI in outgoing GSUP message when presesnt Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce --- M include/osmocom/msc/gsm_04_11_gsup.h M src/libmsc/gsm_04_11.c M src/libmsc/gsm_04_11_gsup.c 3 files changed, 26 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/28/39428/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 2 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dotsimon <implorable-herd(a)yahoo.com>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-msc[master]: include SM-RP-UI in outgoing GSUP message when presesnt

by dotsimon

dotsimon has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I tested both cases using a local network (LimeSDR, retail device and SIM) with SIM RFM PoR (proof of receipt) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 1 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Jan 2025 19:58:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-msc[master]: include SM-RP-UI in outgoing GSUP message when presesnt

by Jenkins Builder

Jenkins Builder has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 1: (2 comments) File src/libmsc/gsm_04_11_gsup.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21243): https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/7890cec9_83840a05?usp… : PS1, Line 206: if (ui) { suspect code indent for conditional statements (8, 10) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21243): https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/5dd9e566_26036b4b?usp… : PS1, Line 237: if (ui) { suspect code indent for conditional statements (8, 10) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 1 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Jan 2025 19:54:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-msc[master]: include SM-RP-UI in outgoing GSUP message when presesnt

by dotsimon

dotsimon has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... include SM-RP-UI in outgoing GSUP message when presesnt Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce --- M include/osmocom/msc/gsm_04_11_gsup.h M src/libmsc/gsm_04_11.c M src/libmsc/gsm_04_11_gsup.c 3 files changed, 26 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/28/39428/1 diff --git a/include/osmocom/msc/gsm_04_11_gsup.h b/include/osmocom/msc/gsm_04_11_gsup.h index 4034f5e..e9f1a34 100644 --- a/include/osmocom/msc/gsm_04_11_gsup.h +++ b/include/osmocom/msc/gsm_04_11_gsup.h @@ -12,8 +12,8 @@ int gsm411_gsup_mo_fwd_sm_req(struct gsm_trans *trans, struct msgb *msg, uint8_t sm_rp_mr, uint8_t *sm_rp_da, uint8_t sm_rp_da_len); -int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr); +int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr, uint8_t *ui); int gsm411_gsup_mt_fwd_sm_err(struct gsm_trans *trans, - uint8_t sm_rp_mr, uint8_t cause); + uint8_t sm_rp_mr, uint8_t cause, uint8_t *ui); int gsm411_gsup_rx(struct gsup_client_mux *gcm, void *data, const struct osmo_gsup_message *gsup_msg); diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 6536d0b..cc91988 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -852,7 +852,10 @@ if (trans->net->sms_over_gsup) { /* Forward towards SMSC via GSUP */ - return gsm411_gsup_mt_fwd_sm_res(trans, rph->msg_ref); + uint8_t *ui = NULL; + if (rph->len > 2 && rph->data[0] == GSM411_IE_RP_USER_DATA) + ui = &(rph->data[1]); + return gsm411_gsup_mt_fwd_sm_res(trans, rph->msg_ref, ui); } if (!sms) { @@ -893,7 +896,12 @@ if (trans->net->sms_over_gsup) { /* Forward towards SMSC via GSUP */ - return gsm411_gsup_mt_fwd_sm_err(trans, rph->msg_ref, cause); + uint8_t *ui = NULL; + uint8_t ui_iei_pos = cause_len + 1; + + if (rph->len > (ui_iei_pos + 2) && rph->data[ui_iei_pos] == GSM411_IE_RP_USER_DATA) + ui = &(rph->data[ui_iei_pos + 1]); + return gsm411_gsup_mt_fwd_sm_err(trans, rph->msg_ref, cause, ui); } if (!sms) { diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index 96fdbc6..877172c 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -184,7 +184,7 @@ return -EINVAL; } -int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr) +int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr, uint8_t *ui) { struct osmo_gsup_message gsup_msg; @@ -202,11 +202,17 @@ gsup_msg.destination_name_len = trans->sms.gsup_source_name_len; gsup_client_mux_tx_set_source(trans->net->gcm, &gsup_msg); + /* include optional SM-RP-UI field if present */ + if (ui) { + gsup_msg.sm_rp_ui_len = ui[0]; + gsup_msg.sm_rp_ui = &(ui[1]); + } + return gsup_client_mux_tx(trans->net->gcm, &gsup_msg); } int gsm411_gsup_mt_fwd_sm_err(struct gsm_trans *trans, - uint8_t sm_rp_mr, uint8_t cause) + uint8_t sm_rp_mr, uint8_t cause, uint8_t *ui) { struct osmo_gsup_message gsup_msg; @@ -227,7 +233,12 @@ /* SM-RP-Cause value */ gsup_msg.sm_rp_cause = &cause; - /* TODO: include optional SM-RP-UI field if present */ + /* include optional SM-RP-UI field if present */ + if (ui) { + gsup_msg.sm_rp_ui_len = ui[0]; + gsup_msg.sm_rp_ui = &(ui[1]); + } + return gsup_client_mux_tx(trans->net->gcm, &gsup_msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 1 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-upf[master]: Improve logging reading packets from gtp device

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email ) Change subject: Improve logging reading packets from gtp device ...................................................................... Patch Set 1: (1 comment) File src/osmo-upf/upf_gtpu_echo.c: https://gerrit.osmocom.org/c/osmo-upf/+/39419/comment/69498832_c061b5d1?usp… : PS1, Line 219: return 0; > It's just a regular ofd cb, the return code is not really used unless you pass -EBADF. […] Fine then. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8 Gerrit-Change-Number: 39419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jan 2025 19:07:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-upf[master]: Improve logging reading packets from gtp device

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email ) Change subject: Improve logging reading packets from gtp device ...................................................................... Patch Set 1: (1 comment) File src/osmo-upf/upf_gtpu_echo.c: https://gerrit.osmocom.org/c/osmo-upf/+/39419/comment/3a4e0337_36fe3819?usp… : PS1, Line 219: return 0; > You're changing the logic: before your patch it would return `-1`, but now it's returning `0` -- is […] It's just a regular ofd cb, the return code is not really used unless you pass -EBADF. I changed it because imho it's just fine returning 0 since it's a expected code path (even if we are not yet doing anything with it other than logging). -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39419?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic3d9ea319122acbaf99ca7d6ff615b5812a085f8 Gerrit-Change-Number: 39419 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jan 2025 19:04:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025