January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for write completion

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for write completion ...................................................................... tests/osmo_io: Introduce small sleeps waiting for write completion Sometimes test_file() fails during jenkins run because it finished the main loop iterations without having received a write complete cb. This may be due to filesystem delays due to system load, it's difficult to say since it only happens sporadically. Add some small sleeps under each loop iteration (which can end up waiting up to 10s after full set of iterations) to make sure we receive the write callback in a timely fashion. Related: OS#6708 Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index d072ebe..95d78b0 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -108,6 +108,7 @@ if (file_bytes_write_compl == sizeof(TESTDATA)) break; osmo_select_main(1); + usleep(100 * 1000); } fflush(stdout); OSMO_ASSERT(file_bytes_write_compl == sizeof(TESTDATA)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 Gerrit-Change-Number: 39423 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for write completion

by osmith

Attention is currently required from: daniel, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for write completion ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > explaining why this likely fixes it in the commit message would be useful thanks! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 Gerrit-Change-Number: 39423 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jan 2025 13:20:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for write completion

by osmith

Attention is currently required from: daniel, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for write completion ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 Gerrit-Change-Number: 39423 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jan 2025 13:20:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for write completion

by pespin

Attention is currently required from: daniel, osmith, pespin. Hello Jenkins Builder, daniel, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith Change subject: tests/osmo_io: Introduce small sleeps waiting for write completion ...................................................................... tests/osmo_io: Introduce small sleeps waiting for write completion Sometimes test_file() fails during jenkins run because it finished the main loop iterations without having received a write complete cb. This may be due to filesystem delays due to system load, it's difficult to say since it only happens sporadically. Add some small sleeps under each loop iteration (which can end up waiting up to 10s after full set of iterations) to make sure we receive the write callback in a timely fashion. Related: OS#6708 Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/39423/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 Gerrit-Change-Number: 39423 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for write completion

by osmith

Attention is currently required from: daniel, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for write completion ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: explaining why this likely fixes it in the commit message would be useful -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 Gerrit-Change-Number: 39423 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jan 2025 12:46:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix path to _update_src_copy.sh

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email ) Change subject: gen_makefile: fix path to _update_src_copy.sh ...................................................................... gen_makefile: fix path to _update_src_copy.sh The directory structure looks like this: osmo-dev ├── gen_makefile.py └── src └── _update_src_copy.sh Fix that _update_src_copy.sh cannot be found if src != args.src_dir. Fixes: OS#6712 Change-Id: I05daf5e008648d9cb1c272539e97efbf2b9043fc --- M gen_makefile.py 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved osmith: Verified diff --git a/gen_makefile.py b/gen_makefile.py index 3130940..548137d 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -424,8 +424,12 @@ def gen_update_src_copy_cmd(proj, src_dir, make_dir): if not is_src_copy_needed(proj): return "" + + src_dir_script = os.path.join(topdir, "src") + src_dir_script = os.path.relpath(src_dir_script, make_dir) + ret = "@sh -e " - ret += os.path.join(os.path.relpath(args.src_dir, make_dir), "_update_src_copy.sh") + ret += os.path.join(src_dir_script, "_update_src_copy.sh") ret += f" {shlex.quote(src_dir)}" ret += f" {shlex.quote(proj)}" ret += " $(TIME_START)" -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I05daf5e008648d9cb1c272539e97efbf2b9043fc Gerrit-Change-Number: 39422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: tests/osmo_io: Introduce small sleeps waiting for write completion

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email ) Change subject: tests/osmo_io: Introduce small sleeps waiting for write completion ...................................................................... tests/osmo_io: Introduce small sleeps waiting for write completion Related: OS#6708 Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 --- M tests/osmo_io/osmo_io_test.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/39423/1 diff --git a/tests/osmo_io/osmo_io_test.c b/tests/osmo_io/osmo_io_test.c index d072ebe..95d78b0 100644 --- a/tests/osmo_io/osmo_io_test.c +++ b/tests/osmo_io/osmo_io_test.c @@ -108,6 +108,7 @@ if (file_bytes_write_compl == sizeof(TESTDATA)) break; osmo_select_main(1); + usleep(100 * 1000); } fflush(stdout); OSMO_ASSERT(file_bytes_write_compl == sizeof(TESTDATA)); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637f9a5a5f633843b09d4677a0fff48bb75672e9 Gerrit-Change-Number: 39423 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix path to _update_src_copy.sh

by fixeria

Attention is currently required from: lynxis lazus, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email ) Change subject: gen_makefile: fix path to _update_src_copy.sh ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I05daf5e008648d9cb1c272539e97efbf2b9043fc Gerrit-Change-Number: 39422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 28 Jan 2025 12:21:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix path to _update_src_copy.sh

by pespin

Attention is currently required from: fixeria, lynxis lazus, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email ) Change subject: gen_makefile: fix path to _update_src_copy.sh ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I05daf5e008648d9cb1c272539e97efbf2b9043fc Gerrit-Change-Number: 39422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 28 Jan 2025 12:19:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix path to _update_src_copy.sh

by osmith

Attention is currently required from: fixeria, lynxis lazus, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email ) Change subject: gen_makefile: fix path to _update_src_copy.sh ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/39422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I05daf5e008648d9cb1c272539e97efbf2b9043fc Gerrit-Change-Number: 39422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 28 Jan 2025 12:18:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025