January 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ccid-firmware[master]: fix usb usb reset handling by delayed soft reset

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email ) Change subject: fix usb usb reset handling by delayed soft reset ...................................................................... fix usb usb reset handling by delayed soft reset Requires BL clock init, not compatible with old bootloaders! Will always reboot to DFU mode with old bootloader/wrong clocks. Change-Id: I0939930a42f3009abf7e670561a123963bbd3845 --- M sysmoOCTSIM/atmel_start.c M sysmoOCTSIM/hpl/core/hpl_init.c M sysmoOCTSIM/hpl/usb/hpl_usb.c M sysmoOCTSIM/main.c M sysmoOCTSIM/usb_start.c 5 files changed, 35 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/45/39445/1 diff --git a/sysmoOCTSIM/atmel_start.c b/sysmoOCTSIM/atmel_start.c index d6304fa..4d52d0d 100644 --- a/sysmoOCTSIM/atmel_start.c +++ b/sysmoOCTSIM/atmel_start.c @@ -9,5 +9,4 @@ #ifdef ENABLE_DBG_UART7 stdio_redirect_init(); #endif - usb_init(); } diff --git a/sysmoOCTSIM/hpl/core/hpl_init.c b/sysmoOCTSIM/hpl/core/hpl_init.c index be0db93..e6997a3 100644 --- a/sysmoOCTSIM/hpl/core/hpl_init.c +++ b/sysmoOCTSIM/hpl/core/hpl_init.c @@ -54,13 +54,13 @@ { hri_nvmctrl_set_CTRLA_RWS_bf(NVMCTRL, CONF_NVM_WAIT_STATE); - _osc32kctrl_init_sources(); - _oscctrl_init_sources(); - _mclk_init(); -#if _GCLK_INIT_1ST - _gclk_init_generators_by_fref(_GCLK_INIT_1ST); -#endif - _oscctrl_init_referenced_generators(); + // _osc32kctrl_init_sources(); + // _oscctrl_init_sources(); + // _mclk_init(); +// #if _GCLK_INIT_1ST +// _gclk_init_generators_by_fref(_GCLK_INIT_1ST); +// #endif +// _oscctrl_init_referenced_generators(); _gclk_init_generators_by_fref(_GCLK_INIT_LAST); #if CONF_DMAC_ENABLE diff --git a/sysmoOCTSIM/hpl/usb/hpl_usb.c b/sysmoOCTSIM/hpl/usb/hpl_usb.c index 99e4606..8508842 100644 --- a/sysmoOCTSIM/hpl/usb/hpl_usb.c +++ b/sysmoOCTSIM/hpl/usb/hpl_usb.c @@ -44,6 +44,7 @@ /* save previous setup state to allow device reset when receving usb reset after the device * was previously properly configured, i.e. when powered externally and usb is disconnected and reconnected */ volatile bool address_was_set = false; +volatile bool delayed_usb_reset = false; /** * \brief Dummy callback function @@ -981,13 +982,8 @@ _usb_d_dev_reset_epts(); if(address_was_set == true) { - _usb_d_dev_detach(); address_was_set = 0; - delay_ms(100); - __disable_irq(); - __DMB(); - __DSB(); - NVIC_SystemReset(); + delayed_usb_reset = true; } dev_inst.callbacks.event(USB_EV_RESET, 0); diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 2dfc255..191d4ae 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -66,7 +66,6 @@ * (there are 8 inputs + traces to drive!) */ hri_port_set_PINCFG_DRVSTR_bit(PORT, 0, 11); - ccid_app_init(); } /*********************************************************************** @@ -467,6 +466,16 @@ char rstcause_buf[RSTCAUSE_STR_SIZE]; +void do_usb_res(void){ + hri_usbdevice_set_CTRLA_SWRST_bit(USB); + uint32_t* application_start_address = (uint32_t*)(16384); + __set_MSP(*application_start_address); + __DSB(); + __ISB(); + asm("bx %0"::"r"(*(application_start_address + 1))); +} + +extern volatile bool delayed_usb_reset; int main(void) { @@ -494,18 +503,23 @@ #endif - atmel_start_init(); + // return to dfu on mismatched old BL with improper clock config. + if(hri_gclk_read_GENCTRL_SRC_bf(GCLK, 0) == GCLK_GENCTRL_SRC_XOSC1_Val){ + *(uint32_t*)HSRAM_ADDR = 0x44465521; + NVIC_SystemReset(); + } + get_chip_unique_serial_str(sernr_buf, sizeof(sernr_buf)); str_to_usb_desc(sernr_buf, sizeof(sernr_buf), sernr_buf_descr, sizeof(sernr_buf_descr)); str_to_usb_desc(product_buf, sizeof(product_buf)-1, product_buf_descr, sizeof(product_buf_descr)); get_rstcause_str(rstcause_buf); - - - usb_start(); - + atmel_start_init(); board_init(); + usb_init(); + usb_start(); + ccid_app_init(); #ifdef WITH_DEBUG_CDC command_init("sysmoOCTSIM> "); @@ -562,6 +576,8 @@ // command_print_prompt(); while (true) { // main loop + if(delayed_usb_reset) + do_usb_res(); command_try_recv(); poll_card_detect(); submit_next_irq(); diff --git a/sysmoOCTSIM/usb_start.c b/sysmoOCTSIM/usb_start.c index d4057be..6946126 100644 --- a/sysmoOCTSIM/usb_start.c +++ b/sysmoOCTSIM/usb_start.c @@ -10,13 +10,13 @@ #include "usb_descriptors.h" #define CDCD_ECHO_BUF_SIZ CONF_USB_CDCD_ACM_DATA_BULKIN_MAXPKSZ - +#ifdef WITH_DEBUG_CDC /** Buffers to receive and echo the communication bytes. */ static uint32_t usbd_cdc_buffer[CDCD_ECHO_BUF_SIZ / 4]; - +#endif /** Ctrl endpoint buffer */ static uint8_t ctrl_buffer[64]; - +#ifdef WITH_DEBUG_CDC /** * \brief Callback invoked when bulk OUT data received */ @@ -56,7 +56,7 @@ /* No error. */ return false; } - +#endif extern const struct usbd_descriptors usb_descs[]; /* transmit given string descriptor */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39445?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I0939930a42f3009abf7e670561a123963bbd3845 Gerrit-Change-Number: 39445 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: usb desc: use smart card dev class instead of CDC

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39446?usp=email ) Change subject: usb desc: use smart card dev class instead of CDC ...................................................................... usb desc: use smart card dev class instead of CDC Change-Id: I9d4f88b973f0c16d2c1241343d416496b35019a0 --- M sysmoOCTSIM/usb_descriptors.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/46/39446/1 diff --git a/sysmoOCTSIM/usb_descriptors.c b/sysmoOCTSIM/usb_descriptors.c index 94a473e..52537f8 100644 --- a/sysmoOCTSIM/usb_descriptors.c +++ b/sysmoOCTSIM/usb_descriptors.c @@ -31,7 +31,7 @@ .bLength = sizeof(struct usb_dev_desc), .bDescriptorType = USB_DT_DEVICE, .bcdUSB = USB_V2_0, - .bDeviceClass = 0x02, + .bDeviceClass = 0x0B, .bDeviceSubClass = 0, .bDeviceProtocol = 0, .bMaxPacketSize0 = CONF_USB_CDCD_ACM_BMAXPKSZ0, -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39446?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9d4f88b973f0c16d2c1241343d416496b35019a0 Gerrit-Change-Number: 39446 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: fix some warnings and add some warning flags

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39448?usp=email ) Change subject: fix some warnings and add some warning flags ...................................................................... fix some warnings and add some warning flags Change-Id: I55e1de7fe8428a5c6cdf741cdc0ae7c47aa7c8d8 --- M ccid_common/ccid_slot_fsm.c M sysmoOCTSIM/gcc/Makefile M sysmoOCTSIM/main.c 3 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/48/39448/1 diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index 788e3ae..eb0c145 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -22,6 +22,9 @@ #include <errno.h> #include <string.h> +#ifdef OCTSIMFWBUILD +#include "hal/include/hal_delay.h" +#endif #include <osmocom/core/msgb.h> #include <osmocom/core/timer.h> #include <osmocom/core/logging.h> diff --git a/sysmoOCTSIM/gcc/Makefile b/sysmoOCTSIM/gcc/Makefile index a465287..0f2a909 100644 --- a/sysmoOCTSIM/gcc/Makefile +++ b/sysmoOCTSIM/gcc/Makefile @@ -11,7 +11,8 @@ CFLAGS_CPU=-D__SAME54N19A__ -mcpu=cortex-m4 -mfloat-abi=softfp -mfpu=fpv4-sp-d16 CFLAGS=-x c -mthumb -DDEBUG -Os -ffunction-sections -fdata-sections -mlong-calls \ - -g3 -Wall -c -std=gnu99 $(CFLAGS_CPU) -DOCTSIMFWBUILD -DDISABLE_DFU_DETACH=$(DISABLE_DFU_DETACH) -Wno-discarded-qualifiers -Werror=strict-prototypes + -fno-omit-frame-pointer -ggdb3 -Wall -c -std=gnu99 $(CFLAGS_CPU) -DOCTSIMFWBUILD -DDISABLE_DFU_DETACH=$(DISABLE_DFU_DETACH) -Wno-discarded-qualifiers -Werror=strict-prototypes -fno-common -Wno-unused-variable -Wno-unused-function -Wlarger-than=512 -Wstack-usage=255 + CFLAGS += -DLIBOSMOCORE_NO_LOGGING diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 7fd6ee7..5115743 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -17,9 +17,9 @@ */ #include <stdlib.h> -#include <inttypes.h> +// #include <inttypes.h> #include <stdio.h> -#include <math.h> +// #include <math.h> #include <parts.h> #include <errno.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39448?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I55e1de7fe8428a5c6cdf741cdc0ae7c47aa7c8d8 Gerrit-Change-Number: 39448 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-asf4-dfu[master]: tame the linter

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39439?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tame the linter ...................................................................... tame the linter Change-Id: I745b741dedf2c2ed5679c289e70adcb01c750e4d --- A .checkpatch.conf 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/39/39439/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39439?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I745b741dedf2c2ed5679c289e70adcb01c750e4d Gerrit-Change-Number: 39439 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[L] Change in osmo-asf4-dfu[master]: add fw update crcstub

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email ) Change subject: add fw update crcstub ...................................................................... Patch Set 6: (9 comments) File crc_code.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/51af20d7_2e6ac36… : PS6, Line 36: for (uint32_t i = 0; i < length; i++) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7a68d3ea_cf21473… : PS6, Line 38: for (uint8_t j = 0; j < 8; j++) { suspect code indent for conditional statements (4, 6) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/9aaf83a3_dda7d8a… : PS6, Line 63: if (calculated_crc != expected_crc) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/cf766053_f61dc46… : PS6, Line 79: while (1) suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/981383f2_744ed92… : PS6, Line 92: if (argc != 4) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7e8cabbf_14618b2… : PS6, Line 104: if (!f) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/97fd2ceb_c1acf5f… : PS6, Line 110: if (fseek(f, (long)start_offset, SEEK_SET) != 0) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/adf5f90e_4f713cf… : PS6, Line 117: if (!buf) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21287): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/6012fab3_84e5078… : PS6, Line 126: if (read_bytes != length) { suspect code indent for conditional statements (2, 4) -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 19:22:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[XL] Change in osmo-asf4-dfu[master]: bl updater app

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bl updater app ...................................................................... bl updater app This builds a second binary that will be flashed like the main firmware and will then update the bootloader, just like the st2. It additionaly aligns the cmsis + config with the main app, and ensures the hw is mostly completely initalized before the main app starts, which allows skipping the init in the main fw. Main changes: * bl freq 12/48Mhz -> 120Mhz * ext 32khz disabled * "proper" init time for xosc * no usb init unless DFU mode is actually used * errata 2.13.1 clock init/lock fixups * no guessing according to f++&%! bootprog flags where the main app is Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772 --- A CMSIS/Include/cmsis_version.h M atmel_start.c M atmel_start_pins.h M config/hpl_cmcc_config.h M config/hpl_gclk_config.h M config/hpl_osc32kctrl_config.h M config/hpl_oscctrl_config.h A config/hpl_rtc_config.h A config/hpl_sercom_config.h M config/peripheral_clk_config.h M gcc/Makefile M gcc/system_same54.c M hpl/core/hpl_core_m4.c M hpl/oscctrl/hpl_oscctrl.c A hpl/sercom/hpl_sercom.c M usb_dfu_main.c A usb_flash_main.c M usb_start.c 18 files changed, 6,239 insertions(+), 319 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/34/39434/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772 Gerrit-Change-Number: 39434 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[L] Change in osmo-asf4-dfu[master]: add fw update crcstub

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add fw update crcstub ...................................................................... add fw update crcstub Adds a crc stub that lives in front of the dfu bl updater app and checks it. The whole process is somewhat complicated to ensure we end up not just with a firmware file that contains the right crc for the right offsets, but the elf file is updated as well, to ensure the result is debuggable as-is. The stub is built as part of the firmware code, and ends up in its own section. Linker script padding and alignment ensures that this works. Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed --- A crc_code.c A crc_params.c M gcc/Makefile M gcc/gcc/same54p20a_dfu.ld M gcc/gcc/same54p20a_flash.ld M gcc/gcc/startup_same54.c M usb_flash_main.c 7 files changed, 236 insertions(+), 101 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/37/39437/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[L] Change in osmo-asf4-dfu[master]: add fw update crcstub

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email ) Change subject: add fw update crcstub ...................................................................... Patch Set 5: (9 comments) File crc_code.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ff340844_b7fe43d… : PS5, Line 18: for (uint32_t i = 0; i < length; i++) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/46e4804a_1e9ba11… : PS5, Line 20: for (uint8_t j = 0; j < 8; j++) { suspect code indent for conditional statements (4, 6) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ac95337b_3ee43f0… : PS5, Line 45: if (calculated_crc != expected_crc) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/85a5e7c0_d460d96… : PS5, Line 61: while (1) suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/063505c2_3138e5b… : PS5, Line 74: if (argc != 4) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/1a40183c_3876a99… : PS5, Line 86: if (!f) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/f5ef2d54_2fa6082… : PS5, Line 92: if (fseek(f, (long)start_offset, SEEK_SET) != 0) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/90dab0dd_305d0f7… : PS5, Line 99: if (!buf) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7d6613cb_3ba918f… : PS5, Line 108: if (read_bytes != length) { suspect code indent for conditional statements (2, 4) -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 19:15:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-asf4-dfu[master]: tame the linter

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39439?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tame the linter ...................................................................... tame the linter Change-Id: I745b741dedf2c2ed5679c289e70adcb01c750e4d --- A .checkpatch.conf 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/39/39439/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39439?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I745b741dedf2c2ed5679c289e70adcb01c750e4d Gerrit-Change-Number: 39439 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XL] Change in osmo-asf4-dfu[master]: bl updater app

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email ) Change subject: bl updater app ...................................................................... Patch Set 4: (19 comments) File usb_dfu_main.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8c50954c_94d4aa8… : PS4, Line 44: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/be716502_7e5db9e… : PS4, Line 48: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/99310423_6a5dbf3… : PS4, Line 51: volatile uint32_t *src = (uint32_t *)data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8cc916a7_bfddaf1… : PS4, Line 53: for (uint32_t i = 0; i < (NVMCTRL_PAGE_SIZE / sizeof(uint32_t)); i++) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/737d5a27_2684ee4… : PS4, Line 54: dst[i] = src[i]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3c057103_de0b923… : PS4, Line 55: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/20a37da3_32e1408… : PS4, Line 57: NVMCTRL->ADDR.reg = address; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/1eba64e8_ae53be3… : PS4, Line 58: NVMCTRL->CTRLB.reg = NVMCTRL_CTRLB_CMD_WP | NVMCTRL_CTRLB_CMDEX_KEY; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/8919cae6_8bfb350… : PS4, Line 59: while (!NVMCTRL->INTFLAG.bit.DONE) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/514f261a_21b9619… : PS4, Line 60: while (!NVMCTRL->STATUS.bit.READY) {} please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/accef3a9_4191981… : PS4, Line 105: uint32_t address = 0; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/7a054b03_2a6ae9d… : PS4, Line 106: uint8_t *data_ptr = (uint8_t *)bl_update_data; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/50b965da_a7bc60b… : PS4, Line 107: uint32_t remaining = BLSZ_BYTE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5e4dd0d8_b67b008… : PS4, Line 109: while (remaining >= NVMCTRL_PAGE_SIZE) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/5a1c6c29_ee02f25… : PS4, Line 110: same54_flash_write_page(address, data_ptr); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/f1e542cd_fa439af… : PS4, Line 111: address += NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/b0fdc5c0_fb55d9a… : PS4, Line 112: data_ptr += NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/3a7a1b66_fae988a… : PS4, Line 113: remaining -= NVMCTRL_PAGE_SIZE; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21273): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434/comment/ebc8d373_c93a315… : PS4, Line 114: } please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I1403d35497cdea41ea5bed2c94b9e729ca352772 Gerrit-Change-Number: 39434 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 19:10:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025