January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: fix up usb version string, not 0 terminated, align

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39442?usp=email ) Change subject: fix up usb version string, not 0 terminated, align ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39442?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I198f0a55c5c5853ea58f20ad4124a909952a3074 Gerrit-Change-Number: 39442 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:53:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ccid-firmware[master]: tame the linter

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email ) Change subject: tame the linter ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: do we really want all of that for the entire code base? Shouldn't this relaxed linker (like trailing whitespace/ spacing / ...) only apply to those portions of the code that were auto-generated or imported from other sources? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I84f8637b47047bb9b8c217b0869a486ceee7243f Gerrit-Change-Number: 39441 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:52:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ccid-firmware[master]: gitignore

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39440?usp=email ) Change subject: gitignore ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39440?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: If3af97ed7fb8c600144dfd194f80c35a76c91e09 Gerrit-Change-Number: 39440 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:51:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: ATR: align get_atr() return value type

by laforge

Attention is currently required from: laforge. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/39293?usp=email ) Change subject: ATR: align get_atr() return value type ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01b247dad40ec986cf199302f8e92d16848bd499 Gerrit-Change-Number: 39293 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:50:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: ATR: use lowercase hex strings without spaces as ATR constants

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39429?usp=email ) Change subject: ATR: use lowercase hex strings without spaces as ATR constants ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95118115b02523ed262a2fbe4369ace3996cd8f5 Gerrit-Change-Number: 39429 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:50:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-msc[master]: Include SM-RP-UI in outgoing GSUP message when presesnt

by pespin

Attention is currently required from: dotsimon, lynxis lazus. pespin has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: Include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I have same comments as fixeria, once those are merged +1 from me. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 3 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:27:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim/transport: add abstract get_atr method to LinkBase

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39424?usp=email ) Change subject: pySim/transport: add abstract get_atr method to LinkBase ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39424?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4fc020ca45658af78e495a5c1b985213f83cbb50 Gerrit-Change-Number: 39424 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:23:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: ATR: use lowercase hex strings without spaces as ATR constants

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39429?usp=email ) Change subject: ATR: use lowercase hex strings without spaces as ATR constants ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I95118115b02523ed262a2fbe4369ace3996cd8f5 Gerrit-Change-Number: 39429 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 11:20:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-msc[master]: Include SM-RP-UI in outgoing GSUP message when presesnt

by fixeria

Attention is currently required from: dotsimon, lynxis lazus, pespin. fixeria has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: Include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 3: Code-Review+1 (4 comments) Patchset: PS3: Thanks for the patch! Looks good to me. Just a few nitpicks... File include/osmocom/msc/gsm_04_11_gsup.h: https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/eea6a8c9_384784cb?usp… : PS3, Line 15: uint8_t *ui_buf `const` https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/db150c7d_ba86916d?usp… : PS3, Line 15: uint8_t ui_len, uint8_t *ui_buf To keep it consistent with existing API (e.g. `gsm411_gsup_mo_fwd_sm_req()`), let's please have `const uint8_t *ui_buf` first followed by `uint8_t ui_buf_len` (swap them). https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/02c82ca0_429feca8?usp… : PS3, Line 17: uint8_t *ui_buf `const` -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 3 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Jan 2025 10:54:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-msc[master]: Include SM-RP-UI in outgoing GSUP message when presesnt

by dotsimon

Attention is currently required from: fixeria, lynxis lazus, pespin. dotsimon has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email ) Change subject: Include SM-RP-UI in outgoing GSUP message when presesnt ...................................................................... Patch Set 3: (1 comment) File src/libmsc/gsm_04_11_gsup.c: https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/a06f4de7_281c057a?usp… : PS2, Line 187: int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr, uint8_t *ui) > Ok sure. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I90a607900ac7c86b200c79b7e8c460d4cbb3c3ce Gerrit-Change-Number: 39428 Gerrit-PatchSet: 3 Gerrit-Owner: dotsimon <implorable-herd(a)yahoo.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 29 Jan 2025 21:37:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dotsimon <implorable-herd(a)yahoo.com> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025