January 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-upf[master]: Simplify up_session_choose_f_teid() with early returns

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-upf/+/39450?usp=email ) Change subject: Simplify up_session_choose_f_teid() with early returns ...................................................................... Simplify up_session_choose_f_teid() with early returns Change-Id: I6e8c64d093588157c86bb3acaaeed458ff73132d --- M src/osmo-upf/up_session.c 1 file changed, 36 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/50/39450/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39450?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I6e8c64d093588157c86bb3acaaeed458ff73132d Gerrit-Change-Number: 39450 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-upf[master]: Simplify up_session_choose_f_teid() with early returns

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39450?usp=email ) Change subject: Simplify up_session_choose_f_teid() with early returns ...................................................................... Simplify up_session_choose_f_teid() with early returns Change-Id: I6e8c64d093588157c86bb3acaaeed458ff73132d --- M src/osmo-upf/up_session.c 1 file changed, 36 insertions(+), 33 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/50/39450/1 diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c index 928db0b..c870358 100644 --- a/src/osmo-upf/up_session.c +++ b/src/osmo-upf/up_session.c @@ -185,43 +185,46 @@ bool choose_id_present, uint8_t choose_id, const char *netinst_name) { - struct chosen_f_teid *chosen = NULL; + struct chosen_f_teid *chosen; + int rc; - if (choose_id_present) + if (choose_id_present) { chosen = chosen_f_teid_find(&session->chosen_f_teids, choose_id); - if (chosen) { - /* Re-use a previous F-TEID */ - *dst = chosen->f_teid; - } else { - int rc; + if (chosen) { + /* Re-use a previous F-TEID */ + *dst = chosen->f_teid; + return OSMO_PFCP_CAUSE_REQUEST_ACCEPTED; + } + /* No previous F-TEID found, allocate a new one below */ + } - *dst = (struct osmo_pfcp_ie_f_teid){ - .choose_flag = false, + *dst = (struct osmo_pfcp_ie_f_teid){ + .choose_flag = false, + }; + + /* Determine local IP address from Network Instance value received in PFCP request */ + rc = up_session_choose_local_ip(session, &dst->fixed.ip_addr, netinst_name); + if (rc) + return rc; + + /* Choose a new TEID */ + dst->fixed.teid = upf_next_local_teid(); + if (dst->fixed.teid == 0) { + LOGPFSML(session->fi, LOGL_ERROR, "Failed to allocate an unused TEID\n"); + return OSMO_PFCP_CAUSE_PFCP_ENTITY_IN_CONGESTION; + } + + LOGPFSML(session->fi, LOGL_INFO, "Allocated new local F-TEID %s\n", + osmo_pfcp_ie_f_teid_to_str_c(OTC_SELECT, dst)); + + /* Save this choice */ + if (choose_id_present) { + chosen = talloc(session, struct chosen_f_teid); + *chosen = (struct chosen_f_teid){ + .f_teid = *dst, + .choose_id = choose_id, }; - - /* Determine local IP address from Network Instance value received in PFCP request */ - rc = up_session_choose_local_ip(session, &dst->fixed.ip_addr, netinst_name); - if (rc) - return rc; - - /* Choose a new TEID */ - dst->fixed.teid = upf_next_local_teid(); - if (dst->fixed.teid == 0) { - LOGPFSML(session->fi, LOGL_ERROR, "Failed to allocate an unused TEID\n"); - return OSMO_PFCP_CAUSE_PFCP_ENTITY_IN_CONGESTION; - } - LOGPFSML(session->fi, LOGL_INFO, "Allocated new local F-TEID %s\n", - osmo_pfcp_ie_f_teid_to_str_c(OTC_SELECT, dst)); - - /* Save this choice */ - if (choose_id_present) { - chosen = talloc(session, struct chosen_f_teid); - *chosen = (struct chosen_f_teid){ - .f_teid = *dst, - .choose_id = choose_id, - }; - llist_add_tail(&chosen->entry, &session->chosen_f_teids); - } + llist_add_tail(&chosen->entry, &session->chosen_f_teids); } return OSMO_PFCP_CAUSE_REQUEST_ACCEPTED; } -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39450?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I6e8c64d093588157c86bb3acaaeed458ff73132d Gerrit-Change-Number: 39450 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: gprs_gmm_util: add parsing of GMM Attach Requests

by lynxis lazus

Attention is currently required from: fixeria, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email ) Change subject: gprs_gmm_util: add parsing of GMM Attach Requests ...................................................................... Patch Set 3: (1 comment) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/c461e435_0207e854?us… : PS3, Line 122: if (len == 0) > Done The comment is a little off. Because it is actually 2 byte. 1 byte Length, 1 byte value. So the check == 0 is correct. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4a82e0c4070da982efd6c2f15fd145393423772b Gerrit-Change-Number: 39246 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Jan 2025 15:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: gprs_gmm_util: add parsing of GMM Attach Requests

by lynxis lazus

Attention is currently required from: fixeria, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email ) Change subject: gprs_gmm_util: add parsing of GMM Attach Requests ...................................................................... Patch Set 3: (6 comments) File src/sgsn/gprs_gmm_util.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/ac78f87d_cbcbb795?us… : PS3, Line 93: l3 pointers must point to gmm > what does this even mean... l3 pointer of msgb must point to the (start of) GMM https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/2147b019_a681bd29?us… : PS3, Line 94: rau_req > (copy-paste) `rau_req` -> `att_req` Acknowledged https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/2c77e7ed_0f9e7052?us… : PS3, Line 97: struct msgb *msg > `const`? you're not modifying it, right? Done https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/c8c3a175_be17578d?us… : PS3, Line 119: 21 > where this magic number is coming from? do we have a define for it? The problem here are the dynamic, but mandatory, IEs in form of LV in GMM. But there are multiple dynamic LV IEs in the Attach Req. So the GMM Attach Req can't be smaller then 25 bytes. After MS Network Capability come at least 21 bytes. https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/c5a33036_62bf4f34?us… : PS3, Line 122: if (len == 0) > "must be at least 2 bytes long" suggests `len < 2`? Done https://gerrit.osmocom.org/c/osmo-sgsn/+/39246/comment/8efafa3b_bd71876f?us… : PS3, Line 143: 12 > likewise See the mention upwards. I wouldn't use a define for a value here. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39246?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4a82e0c4070da982efd6c2f15fd145393423772b Gerrit-Change-Number: 39246 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Jan 2025 14:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sgsn[master]: gprs_gmm_util: add IE GSM48_IE_GMM_UE_NET_CAP

by lynxis lazus

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39245?usp=email ) Change subject: gprs_gmm_util: add IE GSM48_IE_GMM_UE_NET_CAP ...................................................................... Abandoned Obsolete, changes already in master. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8e2630a370f6066f4e3f0ea0d685f1556efac05 Gerrit-Change-Number: 39245 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sgsn[master]: gprs_gmm_util: add IE GSM48_IE_GMM_UE_NET_CAP

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39245?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: gprs_gmm_util: add IE GSM48_IE_GMM_UE_NET_CAP ...................................................................... Patch Set 3: Code-Review-2 (1 comment) Patchset: PS3: obsolete. Already commited. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia8e2630a370f6066f4e3f0ea0d685f1556efac05 Gerrit-Change-Number: 39245 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Jan 2025 14:43:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-upf[master]: Remove unused file up_session_to_gtp.c

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/39449?usp=email ) Change subject: Remove unused file up_session_to_gtp.c ...................................................................... Remove unused file up_session_to_gtp.c Change-Id: Iabdf4855be72759569d1ac254774311f8682a2df --- D include/osmocom/upf/up_session_to_gtp.c 1 file changed, 0 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/49/39449/1 diff --git a/include/osmocom/upf/up_session_to_gtp.c b/include/osmocom/upf/up_session_to_gtp.c deleted file mode 100644 index 161ba80..0000000 --- a/include/osmocom/upf/up_session_to_gtp.c +++ /dev/null @@ -1,23 +0,0 @@ -/* - * (C) 2021-2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> - * All Rights Reserved. - * - * Author: Neels Janosch Hofmeyr <nhofmeyr(a)sysmocom.de> - * - * SPDX-License-Identifier: GPL-2.0+ - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * - */ - -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/39449?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Iabdf4855be72759569d1ac254774311f8682a2df Gerrit-Change-Number: 39449 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by pespin

Attention is currently required from: csaba.sipos, fixeria. pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 3: (3 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/dd51bde8_496c588f?usp… : PS3, Line 617: { 0x01, "BCF" }, /* Base Control Function */ > I assume you would like to see something like in abis_om2000.c […] I see it's done this way already in all value_string already existing in the file, so fine leaving it as is for now. https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/7af618c6_c188a88d?usp… : PS3, Line 638: { 0x0, "Enabled" }, > can we have defines or enum for all of these? […] Done https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/6786c31f_7a22cd21?usp… : PS3, Line 1853: if (find_element > For BTS_ALARM the object id and object state and the object_id_and_state are all optional (but possi […] IN any case, what's the point in doing "if (foobar());" ? There's no point, simply do "foobar();" then... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 31 Jan 2025 12:05:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: csaba.sipos <metro4(a)freemail.hu> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by csaba.sipos

Attention is currently required from: fixeria, pespin. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/14786196_8bbc7b57?usp… : PS3, Line 617: { 0x01, "BCF" }, /* Base Control Function */ > can we have defines or enum for all of these? I assume you would like to see something like in abis_om2000.c To be honest it would be nice to rewrite the whole Nokia part like the Ericsson code base, but it would take an awful lot of time, and likely better C skills than mine. So I kindly ask you to recommend something that is a littlebit less daunting and preferably already present in the code. The goal is to add the missing but necessary attributes and make the state handling a bit more resilient (and up to the spec.). Only a 2-3 attributes are left for that (besides this). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 20:52:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta...

by csaba.sipos

Attention is currently required from: fixeria. csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email ) Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ...................................................................... Patch Set 3: (3 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/936459d4_1b72b5c5?usp… : PS3, Line 1823: if (find_element > Could you please explain the idea of using `if` statement without the actual body? I may be missing […] Acknowledged https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/52968728_bdc62a8d?usp… : PS3, Line 1825: get_object_identity_string(object_id_state[4]), object_id_state[5], get_object_state_string(object_id_state[10])); > Please align this line to the opening brace `(` and make sure to not exceed the line length of 120 c […] Acknowledged https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/54bb03a2_f3f7e31a?usp… : PS3, Line 1853: if (find_element > Again, what's the idea here? If the element must be present according to the protocol specification, […] For BTS_ALARM the object id and object state and the object_id_and_state are all optional (but possible). My problem is the printout: to make the output nice and compact I am using the already available methods, and I have no idea how to do the required extra checks without an awful lot of extra if_else or case. To add to the fun: this "optional" nature likely comes from older BTS models in this family we dont support, as I have never seen an alarm message that does not have them. And making an assert check is a lot less lines 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3 Gerrit-Change-Number: 39416 Gerrit-PatchSet: 3 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Jan 2025 20:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025