September 2024 - gerrit-log - lists.osmocom.org

[S] Change in libasn1c[master]: coverity CID#27223

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37986?usp=email ) Change subject: coverity CID#27223 ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: this shouldn't be fixed here but in the actual asn1c code, and then re-generate the templates here? -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ib4d4d08dde9dc01403a62493ab6ae8b853b8a1ec Gerrit-Change-Number: 37986 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:22:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in libasn1c[master]: coverity CID#27224

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37985?usp=email ) Change subject: coverity CID#27224 ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: this shouldn't be fixed here but in the actual asn1c code, and then re-generate the templates here? -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I6760be87dfa5281d79f6ebfb749b09179192ba3c Gerrit-Change-Number: 37985 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:22:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[S] Change in libasn1c[master]: coverity CID#57681

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email ) Change subject: coverity CID#57681 ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: this shouldn't be fixed here but in the actual asn1c code, and then re-generate the templates here? -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic8e3f5e24541989b79826de2942e5e6560079028 Gerrit-Change-Number: 37984 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in libasn1c[master]: coverity CID#57935

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37983?usp=email ) Change subject: coverity CID#57935 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: this shouldn't be fixed here but in the actual asn1c code, and then re-generate the templates here? -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I23cfbb1cf1fc12ebd4db8e4b58c5e797b2834897 Gerrit-Change-Number: 37983 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: suci-tutorial: add section about SUCI calculation by the USIM

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37947?usp=email ) Change subject: suci-tutorial: add section about SUCI calculation by the USIM ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I45d47f9278b30d99ebde6891de0ba8cc74b1a0a0 Gerrit-Change-Number: 37947 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:18:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[M] Change in pysim[master]: suci-tutorial: add section about SUCI calculation by the USIM

by Jenkins Builder

Attention is currently required from: fixeria. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37947?usp=email ) Change subject: suci-tutorial: add section about SUCI calculation by the USIM ...................................................................... Patch Set 2: (1 comment) File docs/suci-tutorial.rst: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18215): https://gerrit.osmocom.org/c/pysim/+/37947/comment/a9a65f21_9175f3b2?usp=em… : PS2, Line 212: specifiy any file or file format to store the key material. This means the exact 'specifiy' may be misspelled - perhaps 'specify'? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I45d47f9278b30d99ebde6891de0ba8cc74b1a0a0 Gerrit-Change-Number: 37947 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 07:37:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim-shell: do not display 'AIDs:' when there are none

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38000?usp=email ) Change subject: pySim-shell: do not display 'AIDs:' when there are none ...................................................................... pySim-shell: do not display 'AIDs:' when there are none The command cardinfo also displays the AIDs of the card applications. However, on classic GSM sim cards there are no applications. In this case cardinfo will still display the string 'AIDs:', but it will of course not list any AIDs under this string. Related: OS#6531 Change-Id: Ifb111ce43fdebe85d30857dfc61ab570380b68d1 --- M pySim-shell.py 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/00/38000/1 diff --git a/pySim-shell.py b/pySim-shell.py index 02ca217..3a6b053 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -824,8 +824,9 @@ self._cmd.poutput(" ICCID: %s" % self._cmd.rs.identity['ICCID']) self._cmd.poutput(" Class-Byte: %s" % self._cmd.lchan.scc.cla_byte) self._cmd.poutput(" Select-Ctrl: %s" % self._cmd.lchan.scc.sel_ctrl) - self._cmd.poutput(" AIDs:") - for a in self._cmd.rs.mf.applications: + if len(self._cmd.rs.mf.applications) > 0: + self._cmd.poutput(" AIDs:") + for a in self._cmd.rs.mf.applications: self._cmd.poutput(" %s" % a) @with_default_category('ISO7816 Commands') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifb111ce43fdebe85d30857dfc61ab570380b68d1 Gerrit-Change-Number: 38000 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in pysim[master]: pySim-shell: print cardinfo hexstrings in lowercase

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38001?usp=email ) Change subject: pySim-shell: print cardinfo hexstrings in lowercase ...................................................................... pySim-shell: print cardinfo hexstrings in lowercase To ensure consistency, let's print the cardinfo hexstrings in lowercase only. Related: OS#6531 Change-Id: Ia6a8bd0e700c7fd933fb6c1b1050ed9494462d60 --- M pySim-shell.py 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/01/38001/1 diff --git a/pySim-shell.py b/pySim-shell.py index 3a6b053..52e78d4 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -817,17 +817,17 @@ """Display information about the currently inserted card""" self._cmd.poutput("Card info:") self._cmd.poutput(" Name: %s" % self._cmd.card.name) - self._cmd.poutput(" ATR: %s" % self._cmd.rs.identity['ATR']) + self._cmd.poutput(" ATR: %s" % self._cmd.rs.identity['ATR'].lower()) eid = self._cmd.rs.identity.get('EID', None) if eid: - self._cmd.poutput(" EID: %s" % eid) - self._cmd.poutput(" ICCID: %s" % self._cmd.rs.identity['ICCID']) - self._cmd.poutput(" Class-Byte: %s" % self._cmd.lchan.scc.cla_byte) - self._cmd.poutput(" Select-Ctrl: %s" % self._cmd.lchan.scc.sel_ctrl) + self._cmd.poutput(" EID: %s" % eid.lower()) + self._cmd.poutput(" ICCID: %s" % self._cmd.rs.identity['ICCID'].lower()) + self._cmd.poutput(" Class-Byte: %s" % self._cmd.lchan.scc.cla_byte.lower()) + self._cmd.poutput(" Select-Ctrl: %s" % self._cmd.lchan.scc.sel_ctrl.lower()) if len(self._cmd.rs.mf.applications) > 0: self._cmd.poutput(" AIDs:") for a in self._cmd.rs.mf.applications: - self._cmd.poutput(" %s" % a) + self._cmd.poutput(" %s" % a.lower()) @with_default_category('ISO7816 Commands') class Iso7816Commands(CommandSet): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6a8bd0e700c7fd933fb6c1b1050ed9494462d60 Gerrit-Change-Number: 38001 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: tests: move pySim-trace test and its data into a sub directory

by dexter

Attention is currently required from: dexter, fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: tests: move pySim-trace test and its data into a sub directory ...................................................................... tests: move pySim-trace test and its data into a sub directory We currently have the test data for pySim-trace in pysim-testdata. This means we mix the test data with the data from our original pySim integration tests. This is very confusing. Let's put the test data and the testcase for pySim-trace into a dedicated sub directory. Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Related: OS#6531 --- M contrib/jenkins.sh R tests/pySim-trace_test/pySim-trace_test.sh R tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng R tests/pySim-trace_test/pySim-trace_test_gsmtap.pcapng.ok 4 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/22/37822/9 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I565b4268a05c1a1334b5e7d3fbcd9ef2ef0f0c4c Gerrit-Change-Number: 37822 Gerrit-PatchSet: 9 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: suci-tutorial: put download links for specs to the front

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37948?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: suci-tutorial: put download links for specs to the front ...................................................................... suci-tutorial: put download links for specs to the front The section Technical References has direct download links for the relevant specs. Then later in th Key Provisioning section another download link follows and another one is redundant. Let's put all download links into the Technical References section and then only use the spec numbers in the following. This way we have all download links in one location. Related: OS#6531 Change-Id: Ibcbc6bb5d836d32c381922a35afa3b73b5f90621 --- M docs/suci-tutorial.rst 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/48/37948/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibcbc6bb5d836d32c381922a35afa3b73b5f90621 Gerrit-Change-Number: 37948 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024