September 2024 - gerrit-log - lists.osmocom.org

[S] Change in libasn1c[master]: coverity CID#57681

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: coverity CID#57681 ...................................................................... coverity CID#57681 Make sure that bits_unused cannot subtract more bits than present in st->size. Especially when st->size == 0, this ensures that sizeinunits is also 0, and that a st->size == 0 hence never enters the while (sizeinunits) loop. Change-Id: Ic8e3f5e24541989b79826de2942e5e6560079028 --- M src/OCTET_STRING.c 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/84/37984/2 -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic8e3f5e24541989b79826de2942e5e6560079028 Gerrit-Change-Number: 37984 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in libasn1c[master]: coverity CID#57682

by neels

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email ) Change subject: coverity CID#57682 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I am very uncertain about this patch! Not really understanding what the code is doing here, just trying to prevent a possible ct == NULL deref -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I03b831e9e90591fd205e7d0e66314e1ce7061d24 Gerrit-Change-Number: 37990 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 03 Sep 2024 04:09:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358072

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37997?usp=email ) Change subject: coverity CID#358072 ...................................................................... coverity CID#358072 Change-Id: I90b0c73530fa3ba8b0bf74728d5b215957ef7184 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/97/37997/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index ddf40c9..9ed1e46 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -579,7 +579,7 @@ static int hnbgw_rx_ue_register_req(struct hnb_context *ctx, ANY_t *in) { HNBAP_UERegisterRequestIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; char imsi[GSM23003_IMSI_MAX_DIGITS+1]; int rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I90b0c73530fa3ba8b0bf74728d5b215957ef7184 Gerrit-Change-Number: 37997 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358071

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996?usp=email ) Change subject: coverity CID#358071 ...................................................................... coverity CID#358071 Change-Id: I8237bf7d4985e993bb10aaaa9370cde2ece3d812 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/96/37996/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index df4ec9d..ddf40c9 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -648,7 +648,7 @@ static int hnbgw_rx_ue_deregister(struct hnb_context *ctx, ANY_t *in) { HNBAP_UEDe_RegisterIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; int rc; uint32_t ctxid; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8237bf7d4985e993bb10aaaa9370cde2ece3d812 Gerrit-Change-Number: 37996 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358070

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37998?usp=email ) Change subject: coverity CID#358070 ...................................................................... coverity CID#358070 Change-Id: I742e95fa97f41ca4efe77055c5f29f73e48826d6 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/98/37998/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 9ed1e46..1cc79f6 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -475,7 +475,7 @@ char identity_str[256]; const char *cell_id_str; struct timespec tp; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; struct osmo_sockaddr cur_osa = {}; socklen_t len = sizeof(cur_osa); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37998?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I742e95fa97f41ca4efe77055c5f29f73e48826d6 Gerrit-Change-Number: 37998 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358069

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37999?usp=email ) Change subject: coverity CID#358069 ...................................................................... coverity CID#358069 Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 --- M src/osmo-hnbgw/hnbgw_hnbap.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/99/37999/1 diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index 1cc79f6..e373600 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -446,7 +446,7 @@ static int hnbgw_rx_hnb_deregister(struct hnb_context *ctx, ANY_t *in) { HNBAP_HNBDe_RegisterIEs_t ies; - HNBAP_Cause_t cause; + HNBAP_Cause_t cause = {}; int rc; rc = hnbap_decode_hnbde_registeries(&ies, in); -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 Gerrit-Change-Number: 37999 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-sccp[master]: coverity CID#216830

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email ) Change subject: coverity CID#216830 ...................................................................... coverity CID#216830 sanity-check par->len received on the wire. Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 --- M src/sua.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/95/37995/1 diff --git a/src/sua.c b/src/sua.c index 9e281e0..d4c8b29 100644 --- a/src/sua.c +++ b/src/sua.c @@ -436,7 +436,11 @@ par = (struct xua_parameter_hdr *) &param->dat[pos]; par_tag = ntohs(par->tag); par_len = ntohs(par->len); - par_datalen = par_len - sizeof(*par); + /* sanity: check par->len received on the wire, make sure the subtraction does not wrap past zero */ + if (par_len >= sizeof(*par)) + par_datalen = par_len - sizeof(*par); + else + par_datalen = 0; LOGP(DLSUA, LOGL_DEBUG, "SUA IEI 0x%04x pos %hu/%hu: subpart tag 0x%04x, len %hu\n", param->tag, pos, param->len, par_tag, par_len); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 37995 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-sccp[master]: coverity CID#272968 CID#272939

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37994?usp=email ) Change subject: coverity CID#272968 CID#272939 ...................................................................... coverity CID#272968 CID#272939 properly bounds-check received value (offset) before calculating msgb_l2len(msgb) - offset. Change-Id: Ic6823cf077ef15ef1f6e209bf53384913911f93e --- M src/sccp.c 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/94/37994/1 diff --git a/src/sccp.c b/src/sccp.c index 85bea6d..c348b9e 100644 --- a/src/sccp.c +++ b/src/sccp.c @@ -158,9 +158,15 @@ static int _sccp_parse_optional_data(const int offset, struct msgb *msgb, struct sccp_optional_data *data) { - uint16_t room = msgb_l2len(msgb) - offset; + uint16_t room; uint16_t read = 0; + /* sanity: make sure no optional_start value received on the wire (that callers typically pass as 'offset' + * argument) takes us past the message buffer boundaries (CID#272968 and others) */ + if (offset >= msgb_l2len(msgb)) + return 0; + + room = msgb_l2len(msgb) - offset; while (room > read) { uint8_t type = msgb->l2h[offset + read]; if (type == SCCP_PNC_END_OF_OPTIONAL) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic6823cf077ef15ef1f6e209bf53384913911f93e Gerrit-Change-Number: 37994 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in libasn1c[master]: coverity CID#57681

by Jenkins Builder

Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email ) Change subject: coverity CID#57681 ...................................................................... Patch Set 1: (11 comments) File src/OCTET_STRING.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/cfe36650_82216edb?usp… : PS1, Line 1862: unsigned int unused; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/97fe6402_a5a4218f?usp… : PS1, Line 1862: unsigned int unused; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/1d859f03_3be2b060?usp… : PS1, Line 1892: sizeinunits = st->size * 8; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/f291d748_ebc022db?usp… : PS1, Line 1892: sizeinunits = st->size * 8; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/0a25fb0a_a54146ff?usp… : PS1, Line 1893: /* make sure sizeinunits cannot wrap past zero (especially when st->size == 0). */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/03ac5c4f_0c61fd60?usp… : PS1, Line 1894: unused = st->bits_unused & 0x07; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/efddbfdd_fc46ebe9?usp… : PS1, Line 1894: unused = st->bits_unused & 0x07; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/720a0055_527b6e6d?usp… : PS1, Line 1895: if (unused <= sizeinunits) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/bc07808d_f3dfc870?usp… : PS1, Line 1895: if (unused <= sizeinunits) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/c8e8d0ae_fd282527?usp… : PS1, Line 1896: sizeinunits -= unused; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18195): https://gerrit.osmocom.org/c/libasn1c/+/37984/comment/c8ed72c3_425cf2ec?usp… : PS1, Line 1896: sizeinunits -= unused; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: Ic8e3f5e24541989b79826de2942e5e6560079028 Gerrit-Change-Number: 37984 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 03 Sep 2024 04:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

[S] Change in libasn1c[master]: coverity CID#57682

by Jenkins Builder

Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email ) Change subject: coverity CID#57682 ...................................................................... Patch Set 1: (2 comments) File src/constr_CHOICE.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18192): https://gerrit.osmocom.org/c/libasn1c/+/37990/comment/98415094_62bee956?usp… : PS1, Line 1142: if(specs->ext_start == -1) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18192): https://gerrit.osmocom.org/c/libasn1c/+/37990/comment/6f4cd07f_f3d968f2?usp… : PS1, Line 1148: if(aper_open_type_put(elm->type, elm->per_constraints, memb_ptr, po)) space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Change-Id: I03b831e9e90591fd205e7d0e66314e1ce7061d24 Gerrit-Change-Number: 37990 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 03 Sep 2024 04:03:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024