Attention is currently required from: neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email )
Change subject: coverity CID#313611
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-pfcp/pfcp_msg.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993/comment/7c64151e_bb53180d… :
PS1, Line 589: struct osmo_fsm_inst *fi = m ? (m->ctx.session_fi ?: m->ctx.peer_fi) : NULL;
Checking `m` against `NULL` below and returning early makes these ternary checks redundant. I suggest moving the variable assignments below the if-block you're adding.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ic5c87e029fe761b24ef9dcf801376da7b5a8d290
Gerrit-Change-Number: 37993
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2024 05:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email )
Change subject: coverity CID#272974
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/37981/comment/43c25f65_81aa18c5?… :
PS1, Line 7: coverity CID#272974
> Would be nice to have a brief problem description in the commit message, at least for reviewers to u […]
Ok, I see most of your patches fix the same kind of issue with partly initialized struct fields.
Then it's not super critical.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5633c3218067685036b79fd8d827031eede1eaa0
Gerrit-Change-Number: 37981
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2024 05:16:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email )
Change subject: coverity CID#272974
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/37981/comment/b78a5528_aef86129?… :
PS1, Line 7: coverity CID#272974
Would be nice to have a brief problem description in the commit message, at least for reviewers to understand what kind of issue a given patch is fixing without having to open slow-as-hell Coverity web UI and look-up themselves.
Can be copy-pasted from Coverity, e.g.
```
>>> CID 273001: Insecure data handling (TAINTED_SCALAR)
>>> Passing tainted expression "needed" to "recv", which uses it as an offset.
1444 rc = recv(fd, msg->tail, needed, 0);
```
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37981?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5633c3218067685036b79fd8d827031eede1eaa0
Gerrit-Change-Number: 37981
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Sep 2024 05:11:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email )
Change subject: coverity CID#57682
......................................................................
Patch Set 2:
(2 comments)
File src/constr_CHOICE.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18208):
https://gerrit.osmocom.org/c/libasn1c/+/37990/comment/ee67d129_b4a424d3?usp… :
PS2, Line 1142: if(specs->ext_start == -1)
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18208):
https://gerrit.osmocom.org/c/libasn1c/+/37990/comment/67320313_939f1a8e?usp… :
PS2, Line 1148: if(aper_open_type_put(elm->type, elm->per_constraints, memb_ptr, po))
space required before the open parenthesis '('
--
To view, visit https://gerrit.osmocom.org/c/libasn1c/+/37990?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-Change-Id: I03b831e9e90591fd205e7d0e66314e1ce7061d24
Gerrit-Change-Number: 37990
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 03 Sep 2024 04:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
