September 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Allow running without VTY support

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980?usp=email ) Change subject: StatsD_Checker: Allow running without VTY support ...................................................................... Patch Set 2: Code-Review+1 (3 comments) File library/StatsD_Checker.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980/comment/16c21a10_bb4b… : PS1, Line 163: PESPIN > debugging leftovers Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980/comment/7e5ce751_825d… : PS1, Line 167: PESPIN > debugging leftovers Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980/comment/8b3b6124_2c27… : PS1, Line 180: var default t; > unused? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie1180a5b674504864309c3b9b11bfcf5256d9178 Gerrit-Change-Number: 37980 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 09:09:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Simplify by getting rid of StatsDExpectPriv

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37979?usp=email ) Change subject: StatsD_Checker: Simplify by getting rid of StatsDExpectPriv ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib14c838c5f0647d050249853327671542182636f Gerrit-Change-Number: 37979 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 09:09:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: StatsD_Checker: Allow building without VTY support

by laforge

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37956?usp=email ) Change subject: StatsD_Checker: Allow building without VTY support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37956?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5421c76e4f303fd16d4db945a1c69910e40ac820 Gerrit-Change-Number: 37956 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 09:09:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: coverity CID#322728

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37991?usp=email ) Change subject: coverity CID#322728 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/37991/comment/f822f919_f70cc4b… : PS1, Line 282: ret = sctp_recvmsg(fd, msg->tail, msgb_tailroom(msg), NULL, NULL, &sinfo, &flags); man sctp_recvmsg is a bit blurry on whether sinfo needs to be initialized, so I think it's fine to be on the safe side here, fine. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia4c6b7c6f16331932e3f584b800e86d422a4f019 Gerrit-Change-Number: 37991 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 09:08:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in libosmo-sccp[master]: coverity CID#216830

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email ) Change subject: coverity CID#216830 ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/37995/comment/97cc6a0b_fb38c8c2… : PS1, Line 443: par_datalen = 0; this indicates a formatting error, I would definitely stop parsing at this point instead of "reinterpreting" the packet. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/37995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I3e6283154268f97a66b2b3f2ec8e3e9631424434 Gerrit-Change-Number: 37995 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 09:06:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358069

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37999?usp=email ) Change subject: coverity CID#358069 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/37999/comment/ea754196_15fd37af?u… : PS1, Line 449: HNBAP_Cause_t cause = {}; same as patches before. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2ed76c1bdae96457f61c2e015846566f100b8d6 Gerrit-Change-Number: 37999 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:40:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358070

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37998?usp=email ) Change subject: coverity CID#358070 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/37998/comment/d9537107_53793438?u… : PS1, Line 478: HNBAP_Cause_t cause = {}; same as patches before. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37998?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I742e95fa97f41ca4efe77055c5f29f73e48826d6 Gerrit-Change-Number: 37998 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358072

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37997?usp=email ) Change subject: coverity CID#358072 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/37997/comment/174744f9_2de2481d?u… : PS1, Line 582: HNBAP_Cause_t cause = {}; same, much more clear if you initialize completely with = { ... } when really needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I90b0c73530fa3ba8b0bf74728d5b215957ef7184 Gerrit-Change-Number: 37997 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:39:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-hnbgw[master]: coverity CID#358071

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996?usp=email ) Change subject: coverity CID#358071 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996/comment/c4e9027e_3d1b760c?u… : PS1, Line 657: cause.present = HNBAP_Cause_PR_protocol; probably better to do here: cause = (HNBAP_Cause_t){ .present = HNBAP_Cause_PR_protocol, .choice.protocol = HNBAP_CauseProtocol_unspecified, }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/37996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I8237bf7d4985e993bb10aaaa9370cde2ece3d812 Gerrit-Change-Number: 37996 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:38:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: coverity CID#272951

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmocore/+/37982?usp=email ) Change subject: coverity CID#272951 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I23f5b9957978bd680182d188271820de2d9d39ad Gerrit-Change-Number: 37982 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Sep 2024 08:36:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024