August 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: filesystem: add export method for ADF files
by dexter 10 Aug '24

10 Aug '24

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: filesystem: add export method for ADF files ...................................................................... filesystem: add export method for ADF files This patch adds an export method to CardADF, which calls the application specific export method in CardApplication class Related: OS#6092 Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 --- M pySim/filesystem.py 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/37642/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 Gerrit-Change-Number: 37642 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: add 'install' target, clean up debian/rules
by fixeria 10 Aug '24

10 Aug '24

Attention is currently required from: fixeria, laforge, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: Makefile: add 'install' target, clean up debian/rules ...................................................................... Makefile: add 'install' target, clean up debian/rules Debian's dh_* scripts execute make commands by default, so we no longer need to override dh_* targets in debian/rules. Related: OS#6148 Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 --- M Makefile D debian/osmo-diameter2gsup.install M debian/rules 3 files changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/27/37727/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-upf[master]: pfcp-tool: fix extra newline in vty_out
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email ) Change subject: pfcp-tool: fix extra newline in vty_out ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37755?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib3bb0795238f251ea5b515fe639280be66542a01 Gerrit-Change-Number: 37755 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:33:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: Makefile: add 'install' target
by fixeria 10 Aug '24

10 Aug '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email ) Change subject: Makefile: add 'install' target ...................................................................... Makefile: add 'install' target Related: SYS#7040 Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 --- M Makefile 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/Makefile b/Makefile index fdf454f..52390d1 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,10 @@ +# config file used by 'run' and 'shell' CONFIG ?= config/sys.config +# arguments passed to eunit, used by 'check' EUNIT_ARGS ?= +# directory paths for 'install' +BINDIR ?= /usr/bin +CONFDIR ?= /etc/osmocom all: build @@ -24,6 +29,12 @@ analyze: $(GEN_FILES) rebar3 dialyzer +install: build + install -Dm0755 _build/default/bin/osmo-s1gw \ + $(DESTDIR)$(BINDIR)/osmo-s1gw + install -Dm0644 config/sys.config \ + $(DESTDIR)$(CONFDIR)/osmo-s1gw.config + clean: # Avoid running rebar3 clean if _build doesn't exist, since it would try # to fetch deps from the Internet and that may not be avaialble when in -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278 Gerrit-Change-Number: 37728 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/osmocom-obs-sync: remove Ubuntu:23.10
by osmith 10 Aug '24

10 Aug '24

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/37771?usp=email ) Change subject: jobs/osmocom-obs-sync: remove Ubuntu:23.10 ...................................................................... jobs/osmocom-obs-sync: remove Ubuntu:23.10 This release is EOL, remove it. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Linux_Distributio… Change-Id: I2a145e2459cc1052e7a532f7e252907f5f6e7835 --- M jobs/osmocom-obs-sync.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/71/37771/1 diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 3776688..7f13e02 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -36,7 +36,6 @@ Raspbian:11 Raspbian:12 Ubuntu:22.04 - Ubuntu:23.10 Ubuntu:24.04 " ./scripts/obs/sync_obs_projects.py \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37771?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2a145e2459cc1052e7a532f7e252907f5f6e7835 Gerrit-Change-Number: 37771 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmo-upf[master]: pfcp_tool: add 'date'
by Jenkins Builder 10 Aug '24

10 Aug '24

Attention is currently required from: neels. Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email ) Change subject: pfcp_tool: add 'date' ...................................................................... Patch Set 2: (1 comment) File src/osmo-pfcp-tool/pfcp_tool_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17587): https://gerrit.osmocom.org/c/osmo-upf/+/37761/comment/69a69e07_ce456227?usp… : PS2, Line 147: vty_out(vty,"%04d-%02d-%02d,%02d:%02d:%02d.%03d%s", space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37761?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I0486cc92ea298bb9926a0e5c26da17ba5970a72c Gerrit-Change-Number: 37761 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 06:21:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-mgw[master]: mgcp_network: add missing ntohs
by dexter 10 Aug '24

10 Aug '24

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/37777?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mgcp_network: add missing ntohs ...................................................................... mgcp_network: add missing ntohs We must use ntohs before passing the RTCP port to osmo_sockaddr_port Related: OS#6527 Change-Id: I9773c7b1fda8c9b429723ef9f0db0b58894b28fe --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 58d85df..fd27e9a 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1251,7 +1251,7 @@ return 0; } else if (!trunk->omit_rtcp) { struct osmo_sockaddr rtcp_addr = rtp_end->addr; - osmo_sockaddr_set_port(&rtcp_addr.u.sa, rtp_end->rtcp_port); + osmo_sockaddr_set_port(&rtcp_addr.u.sa, ntohs(rtp_end->rtcp_port)); LOGPENDP(endp, DRTP, LOGL_DEBUG, "send to %s %s rtp_port:%u rtcp_port:%u\n", dest_name, osmo_sockaddr_ntop(&rtcp_addr.u.sa, ipbuf), -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9773c7b1fda8c9b429723ef9f0db0b58894b28fe Gerrit-Change-Number: 37777 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/testdir: fix typo
by osmith 10 Aug '24

10 Aug '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37768?usp=email ) Change subject: testenv/testdir: fix typo ...................................................................... testenv/testdir: fix typo Change-Id: Id61b770ff3b6fdee0dedcdab6eca3760dddc287a --- M _testenv/testenv/testdir.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/testenv/testdir.py b/_testenv/testenv/testdir.py index f7abe2e..242d17d 100644 --- a/_testenv/testenv/testdir.py +++ b/_testenv/testenv/testdir.py @@ -159,7 +159,7 @@ logging.info(msg) return - logging.debug("Remving empty log dir") + logging.debug("Removing empty log dir") testenv.cmd.run(["rm", "-d", testdir_topdir], no_podman=True) # Remove broken symlink -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id61b770ff3b6fdee0dedcdab6eca3760dddc287a Gerrit-Change-Number: 37768 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: filesystem: add export method for ADF files
by laforge 10 Aug '24

10 Aug '24

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37642?usp=email ) Change subject: filesystem: add export method for ADF files ...................................................................... Patch Set 2: (1 comment) File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/37642/comment/2590ecb7_7b50d3f2?usp=em… : PS2, Line 538: this assumes that every application will have an 'export' method. I believe this is not the case (particularly not with this patch alone)? There's two ways I can see: * have an Application base class export method that does nothing, and then override that method in the ARA-M application to acutally do something, selectively * do a hasattr() here to check if the application has an export method, and only call it in that case. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37642?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8129656096ecaf41b36e5f2afbbfbebcd0587886 Gerrit-Change-Number: 37642 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 14:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: cbc: initial testenv.cfg
by osmith 10 Aug '24

10 Aug '24

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37707?usp=email ) Change subject: cbc: initial testenv.cfg ...................................................................... cbc: initial testenv.cfg Change-Id: I8578bf7a2e627c93cc7480534cc2ddbba3ad6ff1 --- M cbc/CBC_Tests.cfg A cbc/osmo-cbc.cfg A cbc/testenv.cfg 3 files changed, 61 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/cbc/CBC_Tests.cfg b/cbc/CBC_Tests.cfg index 7c2a3ac..2ab0885 100644 --- a/cbc/CBC_Tests.cfg +++ b/cbc/CBC_Tests.cfg @@ -11,6 +11,8 @@ [TESTPORT_PARAMETERS] [MODULE_PARAMETERS] +CBC_Tests.mp_local_host := "127.0.0.100"; +CBC_Tests.mp_cbc_host := "127.0.0.20"; [MAIN_CONTROLLER] diff --git a/cbc/osmo-cbc.cfg b/cbc/osmo-cbc.cfg new file mode 100644 index 0000000..5e8656d --- /dev/null +++ b/cbc/osmo-cbc.cfg @@ -0,0 +1,50 @@ +! +log gsmtap 127.0.0.100 + logging level set-all debug + logging level asn1c info + logging filter all 1 +! +log stderr + logging filter all 1 + logging color 1 + logging print category-hex 0 + logging print category 1 + logging print extended-timestamp 1 + logging print level 1 + logging print file 1 last + logging level set-all info + logging level cbsp debug + logging level sbcap debug + logging level rest debug +! +line vty + no login + bind 127.0.0.20 +! +cbc + unknown-peers reject + ecbe + local-ip 127.0.0.20 + local-port 12345 + cbsp + local-ip 127.0.0.20 + local-port 48049 + sbcap + local-ip 127.0.0.20 + local-port 29168 + peer cbsp ttcn3-bsc-client + mode server + remote-port 15000 + remote-ip 127.0.0.100 + peer cbsp ttcn3-bsc-server + mode client + remote-port 15001 + remote-ip 127.0.0.100 + peer sbcap ttcn3-mme-client + mode server + remote-port 16000 + remote-ip 127.0.0.100 + peer sbcap ttcn3-mme-server + mode client + remote-port 16001 + remote-ip 127.0.0.100 diff --git a/cbc/testenv.cfg b/cbc/testenv.cfg new file mode 100644 index 0000000..1cae33c --- /dev/null +++ b/cbc/testenv.cfg @@ -0,0 +1,9 @@ +[testsuite] +program=CBC_Tests +config=CBC_Tests.cfg + +[cbc] +program=osmo-cbc +make=osmo-cbc +package=osmo-cbc +copy=osmo-cbc.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8578bf7a2e627c93cc7480534cc2ddbba3ad6ff1 Gerrit-Change-Number: 37707 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2024