Attention is currently required from: fixeria.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37741?usp=email )
Change subject: pySim.esim.saip.templates: Add expand_default_value() method
......................................................................
Patch Set 2:
(1 comment)
File pySim/esim/saip/templates.py:
https://gerrit.osmocom.org/c/pysim/+/37741/comment/339c816c_6ee68ec5?usp=em… :
PS2, Line 55: or 100
> just too be sure: is this intentional and coming from some spec. […]
no, it is just a random value. The return value of the below call is not actually used anywhere. All we want to do here is to verify that *if* we later need to actually compute the default value, it will work. So we're just verifying that the pattern from the template can be processed as the comment states below.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37741?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id3eb16910c0bdfa572294e14ca1cd44ca95ca69f
Gerrit-Change-Number: 37741
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2024 15:55:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email
to look at the new patch set (#3).
Change subject: testenv: podman.is_running() -> testenv.args.podman
......................................................................
testenv: podman.is_running() -> testenv.args.podman
Use testenv.args.podman instead of testenv.podman.is_running() in all
places except for testenv.podman.stop().
- testenv.args.podman is always True when --podman is used.
- testenv.podman.is_running() is only True while the container is
currently running.
Most of the time the behavior is the same. But without this patch, when
the container crashes, commands would unexpectedly run outside of the
container (and then fail on jenkins due to missing programs).
Related: OS#6494
Change-Id: Iea634f5e97d14f1f7e777f4609b9593974964d23
---
M _testenv/testenv/cmd.py
M _testenv/testenv/daemons.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/37765/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37765?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iea634f5e97d14f1f7e777f4609b9593974964d23
Gerrit-Change-Number: 37765
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37775?usp=email )
Change subject: filesystem: add placeholder export method in CardFile base class
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37775?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ife2a9bad14750db84a87fab907297028c33f1f7d
Gerrit-Change-Number: 37775
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Aug 2024 14:11:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes