August 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo_dia2gsup[master]: Makefile: add 'install' target, clean up debian/rules

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email ) Change subject: Makefile: add 'install' target, clean up debian/rules ...................................................................... Makefile: add 'install' target, clean up debian/rules Debian's dh_* scripts execute make commands by default, so we no longer need to override dh_* targets in debian/rules. Related: OS#6148 Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 --- M Makefile D debian/osmo-diameter2gsup.install M debian/rules 3 files changed, 10 insertions(+), 9 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/Makefile b/Makefile index 940e06f..f08f388 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,8 @@ +# config file used by 'run' and 'shell' CONFIG ?= examples/sys.config +# directory paths for 'install' +BINDIR ?= /usr/bin +SYSTEMDUNITDIR ?= /lib/systemd/system/ all: build @@ -18,6 +22,12 @@ analyze: rebar3 dialyzer +install: build + install -Dm0755 _build/default/bin/osmo-dia2gsup \ + $(DESTDIR)$(BINDIR)/osmo-dia2gsup + install -Dm0644 contrib/systemd/osmo_dia2gsup.service \ + $(DESTDIR)$(SYSTEMDUNITDIR)/osmo_dia2gsup.service + clean: # Avoid running rebar3 clean if _build doesn't exist, since it would try # to fetch deps from the Internet and that may not be avaialble when in diff --git a/debian/osmo-diameter2gsup.install b/debian/osmo-diameter2gsup.install deleted file mode 100644 index 398a000..0000000 --- a/debian/osmo-diameter2gsup.install +++ /dev/null @@ -1,2 +0,0 @@ -/contrib/systemd/osmo_dia2gsup.service /lib/systemd/system/ -/_build/default/bin/osmo-dia2gsup /usr/bin/ diff --git a/debian/rules b/debian/rules index 69e31ed..ffd896c 100755 --- a/debian/rules +++ b/debian/rules @@ -10,10 +10,3 @@ override_dh_auto_build: if [ -e build_dep.tar.gz ] ; then tar xzf ./build_dep.tar.gz ; fi dh_auto_build - rebar3 compile - rebar3 escriptize - rebar3 eunit - -override_dh_clean: - dh_clean - rm -rf _build _checkouts -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37727?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I0769ca5f922a41f2b0976bf283176040aae4c781 Gerrit-Change-Number: 37727 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[M] Change in pysim[master]: pySim-shell: enable export of DF and ADF files

by dexter

Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/37641?usp=email ) Change subject: pySim-shell: enable export of DF and ADF files ...................................................................... Patch Set 2: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/37641/comment/e9de4b7e_856dc5bd?usp=em… : PS2, Line 602: > what is the rationale of making it conditional? Shouldn't we simply always try to export as much as […] I made it conditionally because I the information from the ADF (ADF.ARA-M in this case) are technically not file contents. I thought that those added commands might cause trouble for some use-cases. In any case, If you think we do not need the --include-df option, then I am happy to remove it. I also think that we should cover the applications that do not have an ADF as well. I will look into the code now and see what we can do there. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3ee661dbae5c11fec23911775f352ac13bc2c6e5 Gerrit-Change-Number: 37641 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Aug 2024 07:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: smlc: initial testenv.cfg

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37706?usp=email ) Change subject: smlc: initial testenv.cfg ...................................................................... smlc: initial testenv.cfg Change-Id: Ib6db49f149e9382b802fceb40b307c5a286f92a1 --- A smlc/testenv.cfg 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/smlc/testenv.cfg b/smlc/testenv.cfg new file mode 100644 index 0000000..127e4d7 --- /dev/null +++ b/smlc/testenv.cfg @@ -0,0 +1,15 @@ +[testsuite] +program=SMLC_Tests +config=SMLC_Tests.cfg + +[stp] +program=osmo-stp +make=libosmo-sccp +package=osmo-stp +copy=osmo-stp.cfg + +[smlc] +program=osmo-smlc +make=osmo-smlc +package=osmo-smlc +copy=osmo-smlc.cfg -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib6db49f149e9382b802fceb40b307c5a286f92a1 Gerrit-Change-Number: 37706 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[M] Change in osmo-hlr[master]: subscriber-create-on-demand: rework configuration

by laforge

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email ) Change subject: subscriber-create-on-demand: rework configuration ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: a File src/hlr_vty.c: https://gerrit.osmocom.org/c/osmo-hlr/+/37779/comment/4933ab0f_d310fea3?usp… : PS1, Line 300: vty_out(vty, " no subscriber-create-on-demand%s", VTY_NEWLINE); > Well, I believe printing a setting explicitly is better than omitting values. […] the point IMHO is less what each of us feel at this point, but more "what is consistent with the existing way how we do things in the vty" -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/37779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ib553172655f83dad1ac0e0254615c8c207d79ca9 Gerrit-Change-Number: 37779 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Aug 2024 14:07:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv/podman: use explicit no_podman=True

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37766?usp=email ) Change subject: testenv/podman: use explicit no_podman=True ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37766?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I41afe6d6b565a8e8c384229ee44f1b75f25c0a4b Gerrit-Change-Number: 37766 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 11:29:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year, 1 month

1
0
0 0

[XS] Change in osmo-upf[master]: vty doc fix

by dexter

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-upf/+/37754?usp=email ) Change subject: vty doc fix ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/37754?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ie1ba8c0a1fb6613b7f21d6889e3c6978288a51e4 Gerrit-Change-Number: 37754 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 13:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year, 1 month

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email ) Change subject: Makefile: install 'sys.config' to /etc/osmocom/osmo-dia2gsup.config ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3b2595ca3d82a2ead8fb5560fcc281091e320aa9 Gerrit-Change-Number: 37717 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 05 Aug 2024 12:40:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 year, 1 month

1
0
0 0

[XS] Change in pysim[master]: pySim-shell: fix typo

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37772?usp=email ) Change subject: pySim-shell: fix typo ...................................................................... pySim-shell: fix typo Change-Id: I1bd995ae9eb59a44a48da62a7b0262faa84a4f2b --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/72/37772/1 diff --git a/pySim-shell.py b/pySim-shell.py index 6e59e58..36cb839 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -373,7 +373,7 @@ first = True while 1: # TODO: Count consecutive failures, if more than N consecutive failures occur, then stop. - # The ratinale is: There may be a problem with the device, we do want to prevent that + # The rationale is: There may be a problem with the device, we do want to prevent that # all remaining cards are fired to the error bin. This is only relevant for situations # with large stacks, probably we do not need this feature right now. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1bd995ae9eb59a44a48da62a7b0262faa84a4f2b Gerrit-Change-Number: 37772 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[S] Change in pysim[master]: filesystem: add placeholder export method in CardFile base class

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/37775?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: filesystem: add placeholder export method in CardFile base class ...................................................................... filesystem: add placeholder export method in CardFile base class We add export methods in subclasses of CardFile but the base class itself lacks an export method. To make the code more readable and to avoid unnecessary exceptions, les's add a default export method that just returns a comment. Related: OS#6092 Change-Id: Ife2a9bad14750db84a87fab907297028c33f1f7d --- M pySim/filesystem.py 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/37775/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37775?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ife2a9bad14750db84a87fab907297028c33f1f7d Gerrit-Change-Number: 37775 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 year, 1 month

1
0
0 0

[XS] Change in ...osmo_dia2gsup[master]: examples/sys.config: add pid, delete time

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37720?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: examples/sys.config: add pid, delete time ...................................................................... examples/sys.config: add pid, delete time pid is useful for understanding which process logs messages. time is not needed, since systemd-journald adds timestamps for us. Related: OS#6450 Change-Id: I1dd98bae69c6d644870d44f8217262669fc20c6d --- M examples/sys.config 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/20/37720/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/37720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I1dd98bae69c6d644870d44f8217262669fc20c6d Gerrit-Change-Number: 37720 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2024