May 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-hnbgw[master]: KPI: Add initial set of DTAP message type rate counters

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email ) Change subject: KPI: Add initial set of DTAP message type rate counters ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3e1ad7a2aa71674a22a27c31512600f2de139032 Gerrit-Change-Number: 36788 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 May 2024 13:33:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[L] Change in libosmocore[master]: Import in46_addr from OsmoGGSN

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36073?usp=email ) Change subject: Import in46_addr from OsmoGGSN ...................................................................... Abandoned not needed for OS#6096, probably not worth finishing up -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36073?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I31078f130ec42aeaa5ead1dde82fdd1eb44d992b Gerrit-Change-Number: 36073 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: kernel-gtp: support IPv6 on outer layer (backwards compatible)

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36072?usp=email ) Change subject: kernel-gtp: support IPv6 on outer layer (backwards compatible) ...................................................................... Abandoned not needed for OS#6096, probably not worth finishing up -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36072?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I4212d847b6e1ad5ce120451a2d8a5578c48b90fe Gerrit-Change-Number: 36072 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gsn: gtp_new: replace calloc with talloc_zero

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36071?usp=email ) Change subject: gtp/gsn: gtp_new: replace calloc with talloc_zero ...................................................................... Abandoned not needed for OS#6096, probably not worth finishing up -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36071?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ie10dd6f32a42513f6d2b5c7dd0dd84b4f0d20afb Gerrit-Change-Number: 36071 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 year, 1 month

1
0
0 0

[L] Change in osmo-ggsn[master]: Move in46_addr to libosmocore

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36070?usp=email ) Change subject: Move in46_addr to libosmocore ...................................................................... Abandoned not needed for OS#6096, probably not worth finishing up -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I8f4d9d78689909a149683583cfe36bcdc3f7cbc7 Gerrit-Change-Number: 36070 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gsna2in46a: move and rename from in46a_from_gsna

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36069?usp=email ) Change subject: gsna2in46a: move and rename from in46a_from_gsna ...................................................................... Abandoned not needed for OS#6096, probably not worth finishing up -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36069?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I54c8a4b1d3a02b71d5983badcd923fa39ce7dd84 Gerrit-Change-Number: 36069 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp/gtp_internal.h: new file

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email ) Change subject: gtp/gtp_internal.h: new file ...................................................................... Patch Set 2: (1 comment) File gtp/gtp_internal.h: https://gerrit.osmocom.org/c/osmo-ggsn/+/36068/comment/c652c097_15c15ffc PS1, Line 3: int gtp_echo_resp(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : int gtp_echo_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : int gtp_echo_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, void *pack, unsigned len); : : int gtp_unsup_req(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : int fd, void *pack, unsigned len); : int gtp_unsup_ind(struct gsn_t *gsn, struct sockaddr_in *peer, : void *pack, unsigned len); : : int gtp_create_pdp_resp(struct gsn_t *gsn, int version, : struct pdp_t *pdp, uint8_t cause); : : int gtp_create_pdp_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : : int gtp_create_pdp_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : void *pack, unsigned len); : : int gtp_update_pdp_req(struct gsn_t *gsn, int version, void *cbp, : struct in_addr *inetaddr, struct pdp_t *pdp); : : int gtp_delete_pdp_req(struct gsn_t *gsn, int version, void *cbp, : struct pdp_t *pdp); : : int gtp_delete_pdp_resp(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len, : struct pdp_t *pdp, struct pdp_t *linked_pdp, : uint8_t cause, int teardown); : : int gtp_delete_pdp_ind(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, int fd, : void *pack, unsigned len); : : int gtp_delete_pdp_conf(struct gsn_t *gsn, int version, : struct sockaddr_in *peer, : void *pack, unsigned len); > why do those gtp_* symbols need to be non-static and declared in any header file at all? It looks t […] right, I've made them static now (see also new commits before this one). -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7 Gerrit-Change-Number: 36068 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 May 2024 13:20:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: libgtp: move includes to osmocom/include/gtp

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email ) Change subject: libgtp: move includes to osmocom/include/gtp ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Commit Message: https://gerrit.osmocom.org/c/osmo-ggsn/+/36066/comment/e379d3b3_b85ff69c PS1, Line 17: Leave stub files in /usr/include/….h that include the files from the new : paths, for backwards compatibility. > oh, that's sad. […] good idea, I've implemented it like that. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If7e01c61168819bf7120667344e40c857da5490b Gerrit-Change-Number: 36066 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 May 2024 13:19:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp: remove conversion functions up

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email ) Change subject: gtp: remove conversion functions up ...................................................................... gtp: remove conversion functions up Move the conversion functions above the first user, so we can make in_addr2gsna static in a follow-up commit and remove the extra declaration. Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 --- M gtp/gtp.c 1 file changed, 47 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/91/36791/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 9442b33..482875d 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -823,6 +823,40 @@ } /* *********************************************************** + * Conversion functions + *************************************************************/ + +/* *********************************************************** + * IP address conversion functions + * There exist several types of address representations: + * - eua: End User Address. (29.060, 7.7.27, message type 128) + * Used for signalling address to mobile station. Supports IPv4 + * IPv6 x.25 etc. etc. + * - gsna: GSN Address. (29.060, 7.7.32, message type 133): IP address + * of GSN. If length is 4 it is IPv4. If length is 16 it is IPv6. + * - in_addr: IPv4 address struct. + * - sockaddr_in: Socket API representation of IP address and + * port number. + *************************************************************/ + +int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna) +{ + memset(dst, 0, sizeof(struct in_addr)); + if (gsna->l != 4) + return EOF; /* Return if not IPv4 */ + memcpy(dst, gsna->v, gsna->l); + return 0; +} + +int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src) +{ + memset(gsna, 0, sizeof(struct ul16_t)); + gsna->l = 4; + memcpy(gsna->v, src, gsna->l); + return 0; +} + +/* *********************************************************** * Session management messages * Messages: create, update and delete PDP context * @@ -3052,40 +3086,6 @@ return 0; } -/* *********************************************************** - * Conversion functions - *************************************************************/ - -/* *********************************************************** - * IP address conversion functions - * There exist several types of address representations: - * - eua: End User Address. (29.060, 7.7.27, message type 128) - * Used for signalling address to mobile station. Supports IPv4 - * IPv6 x.25 etc. etc. - * - gsna: GSN Address. (29.060, 7.7.32, message type 133): IP address - * of GSN. If length is 4 it is IPv4. If length is 16 it is IPv6. - * - in_addr: IPv4 address struct. - * - sockaddr_in: Socket API representation of IP address and - * port number. - *************************************************************/ - -int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna) -{ - memset(dst, 0, sizeof(struct in_addr)); - if (gsna->l != 4) - return EOF; /* Return if not IPv4 */ - memcpy(dst, gsna->v, gsna->l); - return 0; -} - -int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src) -{ - memset(gsna, 0, sizeof(struct ul16_t)); - gsna->l = 4; - memcpy(gsna->v, src, gsna->l); - return 0; -} - /* TS 29.060 has yet again a different encoding for IMSIs than * what we have in other places, so we cannot use the gsm48 * decoding functions. Also, libgtp uses an uint64_t in -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 Gerrit-Change-Number: 36791 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gtp.c: move gtp_create_context_resp down

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36789?usp=email ) Change subject: gtp/gtp.c: move gtp_create_context_resp down ...................................................................... gtp/gtp.c: move gtp_create_context_resp down Move gtp_create_context_resp below gtp_create_pdp_resp, which it calls. In a follow-up commit, we can make gtp_create_pdp_resp static and remove the additional declaration. Change-Id: I34efe7592013a8423f4f280758272d81f24b65fa --- M gtp/gtp.c 1 file changed, 26 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/89/36789/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index bdf7e7d..2d18fab 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -990,19 +990,6 @@ return 0; } -/* API: Application response to context indication */ -int gtp_create_context_resp(struct gsn_t *gsn, struct pdp_t *pdp, int cause) -{ - - /* Now send off a reply to the peer */ - gtp_create_pdp_resp(gsn, pdp->version, pdp, cause); - - if (!gtp_cause_successful(cause)) - gtp_freepdp(gsn, pdp); - - return 0; -} - /* Send Create PDP Context Response */ int gtp_create_pdp_resp(struct gsn_t *gsn, int version, struct pdp_t *pdp, uint8_t cause) @@ -1066,6 +1053,19 @@ pdp->fd, pdp->seq, pdp->tid); } +/* API: Application response to context indication */ +int gtp_create_context_resp(struct gsn_t *gsn, struct pdp_t *pdp, int cause) +{ + + /* Now send off a reply to the peer */ + gtp_create_pdp_resp(gsn, pdp->version, pdp, cause); + + if (!gtp_cause_successful(cause)) + gtp_freepdp(gsn, pdp); + + return 0; +} + /* Handle Create PDP Context Request */ int gtp_create_pdp_ind(struct gsn_t *gsn, int version, struct sockaddr_in *peer, int fd, -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I34efe7592013a8423f4f280758272d81f24b65fa Gerrit-Change-Number: 36789 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024