May 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ggsn[master]: gtp/gtp_internal.h: new file

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gtp/gtp_internal.h: new file ...................................................................... gtp/gtp_internal.h: new file While at it, move internal functions of gtp.h to a separate file too. Make all functions that are only used inside gtp.c static. The following APIs are unexpectedly public: * imsi_gtp2str gets used by pdp.h * gsna2in_addr, gtp_echo_req gets used by osmo-sgsn Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7 --- M ggsn/ggsn.c M ggsn/ggsn_vty.c M ggsn/sgsn.c M gtp/Makefile.am M gtp/gtp.c A gtp/gtp_internal.h M include/osmocom/gtp/gtp.h M sgsnemu/sgsnemu.c 8 files changed, 54 insertions(+), 77 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/36068/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I72c40cbdec33449ca8104fb3cad8df1a9e07dfd7 Gerrit-Change-Number: 36068 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: remove unused conversion functions

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email ) Change subject: gtp: remove unused conversion functions ...................................................................... gtp: remove unused conversion functions Remove ipv42eua and eua2ipv4, which are in the "internal functions" section of gtp.h, but are not used anywhere in the code anymore. This is in preparation of moving the internal functions that are used in multiple .c files into a separate header file, and to make the other internal functions static. (Compiler complains about unused static functions.) Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 --- M gtp/gtp.c M include/osmocom/gtp/gtp.h 2 files changed, 16 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/90/36790/1 diff --git a/gtp/gtp.c b/gtp/gtp.c index 2d18fab..9442b33 100644 --- a/gtp/gtp.c +++ b/gtp/gtp.c @@ -3069,27 +3069,6 @@ * port number. *************************************************************/ -int ipv42eua(struct ul66_t *eua, struct in_addr *src) -{ - eua->v[0] = PDP_EUA_ORG_IETF; - eua->v[1] = PDP_EUA_TYPE_v4; - if (src) { - eua->l = 6; - memcpy(&eua->v[2], src, 4); - } else { - eua->l = 2; - } - return 0; -} - -int eua2ipv4(struct in_addr *dst, struct ul66_t *eua) -{ - if ((eua->l != 6) || (eua->v[0] != PDP_EUA_ORG_IETF) || (eua->v[1] != PDP_EUA_TYPE_v4)) - return -1; /* Not IPv4 address */ - memcpy(dst, &eua->v[2], 4); - return 0; -} - int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna) { memset(dst, 0, sizeof(struct in_addr)); diff --git a/include/osmocom/gtp/gtp.h b/include/osmocom/gtp/gtp.h index 7465cf1..7e6bb55 100644 --- a/include/osmocom/gtp/gtp.h +++ b/include/osmocom/gtp/gtp.h @@ -315,8 +315,6 @@ struct sockaddr_in *peer, void *pack, unsigned len); -extern int ipv42eua(struct ul66_t *eua, struct in_addr *src); -extern int eua2ipv4(struct in_addr *dst, struct ul66_t *eua); extern int gsna2in_addr(struct in_addr *dst, struct ul16_t *gsna); extern int in_addr2gsna(struct ul16_t *gsna, struct in_addr *src); extern const char *imsi_gtp2str(const uint64_t *imsi); -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 Gerrit-Change-Number: 36790 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp/gsn_internal.h: new file

by osmith

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified-1 by Jenkins Builder Change subject: gtp/gsn_internal.h: new file ...................................................................... gtp/gsn_internal.h: new file Change-Id: I999462e39411fc4ec7e50bd0212e870006fbc4f1 --- M gtp/Makefile.am M gtp/gsn.c A gtp/gsn_internal.h M gtp/gtp.c M include/osmocom/gtp/gsn.h 5 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/67/36067/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I999462e39411fc4ec7e50bd0212e870006fbc4f1 Gerrit-Change-Number: 36067 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[M] Change in osmo-hnbgw[master]: KPI: Add initial set of DTAP message type rate counters

by laforge

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: KPI: Add initial set of DTAP message type rate counters ...................................................................... KPI: Add initial set of DTAP message type rate counters From an operational perspective, it may be interesting to know how many LU/RAU/Attach attempts, rejects and accepts are happening in a given hNodeB. Let's add some common infrastructure for DTAP related statistics as well as some initial counters. Related: SYS#6885 Depends: osmo-iuh.git Change-Id I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Change-Id: I3e1ad7a2aa71674a22a27c31512600f2de139032 --- M TODO-RELEASE M include/osmocom/hnbgw/hnbgw.h M include/osmocom/hnbgw/kpi.h M src/osmo-hnbgw/Makefile.am M src/osmo-hnbgw/context_map_rua.c M src/osmo-hnbgw/hnbgw.c A src/osmo-hnbgw/kpi_dtap.c M src/osmo-hnbgw/kpi_ranap.c 8 files changed, 197 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/88/36788/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3e1ad7a2aa71674a22a27c31512600f2de139032 Gerrit-Change-Number: 36788 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[L] Change in osmo-iuh[master]: ranap_common: Implement support for missing procedures

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email ) Change subject: ranap_common: Implement support for missing procedures ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6 Gerrit-Change-Number: 36787 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 13 May 2024 12:23:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in libsmpp34[master]: contrib: remove rpm spec file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/36728?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... contrib: remove rpm spec file Related: https://osmocom.org/news/255 Related: OS#6446 Change-Id: Ia10ffce57cf0c067d370f0f381435cdd439e3dd9 --- M Makefile.am M configure.ac D contrib/libsmpp34.spec.in 3 files changed, 12 insertions(+), 89 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 9f85801..a0de168 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,7 +22,6 @@ README.md \ .version \ debian \ - contrib/libsmpp34.spec.in \ git-version-gen \ $(NULL) diff --git a/configure.ac b/configure.ac index 9454953..0ec1701 100644 --- a/configure.ac +++ b/configure.ac @@ -89,6 +89,5 @@ def_list/Makefile binaries/Makefile test_apps/Makefile - libsmpp34.pc - contrib/libsmpp34.spec]) + libsmpp34.pc]) AC_OUTPUT diff --git a/contrib/libsmpp34.spec.in b/contrib/libsmpp34.spec.in deleted file mode 100644 index eba7dbd..0000000 --- a/contrib/libsmpp34.spec.in +++ /dev/null @@ -1,86 +0,0 @@ -# -# spec file for package libsmpp34 -# -# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany. -# Copyright (c) 2016, Martin Hauke <mardnh(a)gmx.de> -# -# All modifications and additions to the file contributed by third parties -# remain the property of their copyright owners, unless otherwise agreed -# upon. The license for this file, and modifications and additions to the -# file, is the same license as for the pristine package itself (unless the -# license for the pristine package is not an Open Source License, in which -# case the license is the MIT License). An "Open Source License" is a -# license that conforms to the Open Source Definition (Version 1.9) -# published by the Open Source Initiative. - -%define sover 1 -Name: libsmpp34 -Version: @VERSION@ -Release: 0 -Summary: PDU SMPP packaging and unpackaging tool -License: GPL-2.0-or-later AND LGPL-2.1-or-later -Group: Development/Libraries/C and C++ -URL: https://osmocom.org/projects/libsmpp34 -Source: %{name}-%{version}.tar.xz -BuildRequires: autoconf >= 2.57 -BuildRequires: libtool -BuildRequires: pkgconfig >= 0.20 -BuildRequires: pkgconfig(libxml-2.0) - -%description -The library provides the PDU handling of the SMPP-3.4 protocol. - -%package -n libsmpp34-%{sover} -Summary: SMPP-3.4 protocol library -License: LGPL-2.1-or-later -Group: System/Libraries - -%description -n libsmpp34-%{sover} -This library provides the Protocol Data Unit (PDU) handling of the -SMPP-3.4 protocol. SMPP (Short Message Peer-to-Peer) is a protocol -providing a data communication interface for the transfer of short -message data between External Short Messaging Entities, Routing -Entitites and Message Centres. - -%package -n libsmpp34-%{sover}-devel -Summary: Development files for the SMPP-3.4 protocol library -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ -Requires: libsmpp34-%{sover} = %{version} - -%description -n libsmpp34-%{sover}-devel -The library provides the PDU handling of the SMPP-3.4 protocol. - -This subpackage contains libraries and header files for developing -applications that want to make use of libsmpp34. - -%prep -%setup -q - -%build -echo "%{version}" >.tarball-version -autoreconf -fi -%configure --disable-static --includedir="%{_includedir}/%{name}" -make %{?_smp_mflags} - -%install -%make_install -find %{buildroot} -type f -name "*.la" -delete -print - -%check -make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) - -%post -n libsmpp34-%{sover} -p /sbin/ldconfig -%postun -n libsmpp34-%{sover} -p /sbin/ldconfig - -%files -n libsmpp34-%{sover} -%{_libdir}/libsmpp34.so.%{sover}* - -%files -n libsmpp34-%{sover}-devel -%license COPYING -%doc ChangeLog -%{_includedir}/%{name}/ -%{_libdir}/libsmpp34.so -%{_libdir}/pkgconfig/*.pc - -%changelog -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/36728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Ia10ffce57cf0c067d370f0f381435cdd439e3dd9 Gerrit-Change-Number: 36728 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in libsmpp34[master]: contrib: remove rpm spec file

by laforge

Attention is currently required from: daniel, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/36728?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/36728?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: Ia10ffce57cf0c067d370f0f381435cdd439e3dd9 Gerrit-Change-Number: 36728 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 May 2024 12:22:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: contrib: remove rpm spec file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/36724?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... contrib: remove rpm spec file Related: https://osmocom.org/news/255 Related: OS#6446 Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc --- M Makefile.am M configure.ac D contrib/libosmo-gprs.spec.in 3 files changed, 12 insertions(+), 232 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index a1b8003..d45c2b2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -26,7 +26,6 @@ EXTRA_DIST = \ .version \ README.md \ - contrib/libosmo-gprs.spec.in \ git-version-gen \ debian \ $(NULL) diff --git a/configure.ac b/configure.ac index c29012d..cb212cd 100644 --- a/configure.ac +++ b/configure.ac @@ -108,6 +108,5 @@ tests/rlcmac/Makefile tests/sndcp/Makefile tests/sm/Makefile - Makefile - contrib/libosmo-gprs.spec]) + Makefile]) AC_OUTPUT diff --git a/contrib/libosmo-gprs.spec.in b/contrib/libosmo-gprs.spec.in deleted file mode 100644 index ed43968..0000000 --- a/contrib/libosmo-gprs.spec.in +++ /dev/null @@ -1,229 +0,0 @@ -Name: libosmo-gprs -Version: @VERSION@ -Release: 0 -Summary: Osmocom GPRS libraries (CSN.1, RLC/MAC, LLC) -License: GPL-2.0-or-later and AGPL-3.0-or-later -Group: Hardware/Mobile -URL: https://osmocom.org/projects/libosmo-gprs -Source: %{name}-%{version}.tar.xz -BuildRequires: autoconf-archive -BuildRequires: automake >= 1.9 -BuildRequires: libtool >= 2 -BuildRequires: pkgconfig >= 0.20 -BuildRequires: pkgconfig(libosmocore) >= 1.7.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.7.0 -BuildRequires: pkgconfig(talloc) - -%description -Osmocom GPRS libraries (CSN.1, RLC/MAC) - -This package provides Osmocom GPRS libraries used by osmocom-bb, osmo-pcu, -and osmo-sgsn: libosmo-csn1, libosmo-gprs-llc, libosmo-gprs-rlcmac. - -%package -n libosmo-csn1-0 -Summary: CSN.1 (Concrete Syntax Notation 1) codec -License: GPL-2.0-or-later -Group: System/Libraries - -%description -n libosmo-csn1-0 -This package provides facilities for encoding, decoding, and declarative -definition of protocols using CSN.1 (Concrete Syntax Notation 1). This -implementation was originally developed by ST-Ericsson (Jari Sassi) and -later adopted by Wireshark and osmo-pcu. - -%package -n libosmo-csn1-devel -Summary: Development files for libosmo-csn1 -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-csn1-0 = %{version} - -%description -n libosmo-csn1-devel -This package provides development files for compiling a program using -libosmo-csn1 - CSN.1 (Concrete Syntax Notation 1) codec. - -%package -n libosmo-gprs-gmm0 -Summary: Osmocom GPRS GMM library -License: AGPL-3.0-or-later -Group: System/Libraries - -%description -n libosmo-gprs-gmm0 -This package provides GMM (GPRS Mobility Management) layer for (E)GPRS. - -%package -n libosmo-gprs-gmm-devel -Summary: Development files for libosmo-gprs-gmm -License: AGPL-3.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-gprs-gmm0 = %{version} - -%description -n libosmo-gprs-gmm-devel -This package provides development files for compiling a program using -libosmo-gprs-gmm - GMM (GPRS Mobility Management) layer for (E)GPRS. - -%package -n libosmo-gprs-llc0 -Summary: Osmocom GPRS LLC library -License: AGPL-3.0-or-later -Group: System/Libraries - -%description -n libosmo-gprs-llc0 -This package provides LLC (Logical Link Control) layer for (E)GPRS. - -%package -n libosmo-gprs-llc-devel -Summary: Development files for libosmo-gprs-llc -License: AGPL-3.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-gprs-llc0 = %{version} - -%description -n libosmo-gprs-llc-devel -This package provides development files for compiling a program using -libosmo-gprs-llc - LLC (Logical Link Control) layer for (E)GPRS. - -%package -n libosmo-gprs-rlcmac0 -Summary: Osmocom GPRS RLC/MAC library -License: GPL-2.0-or-later -Group: System/Libraries - -%description -n libosmo-gprs-rlcmac0 -This package provides RLC/MAC protocol definitions for (E)GPRS. - -%package -n libosmo-gprs-rlcmac-devel -Summary: Development files for libosmo-gprs-rlcmac -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-gprs-rlcmac0 = %{version} -Requires: libosmo-csn1-devel = %{version} - -%description -n libosmo-gprs-rlcmac-devel -This package provides development files for compiling a program using -libosmo-gprs-rlcmac - RLC/MAC protocol definitions for (E)GPRS. - -%package -n libosmo-gprs-sndcp0 -Summary: Osmocom GPRS SNDCP library -License: AGPL-3.0-or-later -Group: System/Libraries - -%description -n libosmo-gprs-sndcp0 -This package provides SNDCP (Subnetwork Dependent Convergence Protocol) layer for (E)GPRS. - -%package -n libosmo-gprs-sndcp-devel -Summary: Development files for libosmo-gprs-sndcp -License: AGPL-3.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-gprs-sndcp0 = %{version} - -%description -n libosmo-gprs-sndcp-devel -This package provides development files for compiling a program using -libosmo-gprs-sndcp - SNDCP (Subnetwork Dependent Convergence Protocol) layer for (E)GPRS. - -%package -n libosmo-gprs-sm0 -Summary: Osmocom GPRS SM library -License: AGPL-3.0-or-later -Group: System/Libraries - -%description -n libosmo-gprs-sm0 -This package provides SM (Session Management) layer for (E)GPRS. - -%package -n libosmo-gprs-sm-devel -Summary: Development files for libosmo-gprs-sm -License: AGPL-3.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-gprs-sm0 = %{version} - -%description -n libosmo-gprs-sm-devel -This package provides development files for compiling a program using -libosmo-gprs-sm - SM (Session Management) layer for (E)GPRS. - -%prep -%setup -q - -%build -echo "%{version}" >.tarball-version -autoreconf -fi -%configure --disable-static --includedir="%_includedir/%name" -make %{?_smp_mflags} - -%install -%make_install -find "%buildroot/%_libdir" -type f -name "*.la" -delete - -%check -make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) - -%post -n libosmo-csn1-0 -p /sbin/ldconfig -%postun -n libosmo-csn1-0 -p /sbin/ldconfig -%post -n libosmo-gprs-gmm0 -p /sbin/ldconfig -%postun -n libosmo-gprs-gmm0 -p /sbin/ldconfig -%post -n libosmo-gprs-llc0 -p /sbin/ldconfig -%postun -n libosmo-gprs-llc0 -p /sbin/ldconfig -%post -n libosmo-gprs-rlcmac0 -p /sbin/ldconfig -%postun -n libosmo-gprs-rlcmac0 -p /sbin/ldconfig -%post -n libosmo-gprs-sndcp0 -p /sbin/ldconfig -%postun -n libosmo-gprs-sndcp0 -p /sbin/ldconfig -%post -n libosmo-gprs-sm0 -p /sbin/ldconfig -%postun -n libosmo-gprs-sm0 -p /sbin/ldconfig - -%files -n libosmo-csn1-0 -%_libdir/libosmo-csn1.so.0* - -%files -n libosmo-csn1-devel -%dir %_includedir/%name -%dir %_includedir/%name/osmocom -%_includedir/%name/osmocom/csn1 -%_libdir/libosmo-csn1.so -%_libdir/pkgconfig/libosmo-csn1.pc - -%files -n libosmo-gprs-gmm0 -%_libdir/libosmo-gprs-gmm.so.0* - -%files -n libosmo-gprs-gmm-devel -%dir %_includedir/%name -%dir %_includedir/%name/osmocom -%dir %_includedir/%name/osmocom/gprs -%_includedir/%name/osmocom/gprs/gmm -%_libdir/libosmo-gprs-gmm.so -%_libdir/pkgconfig/libosmo-gprs-gmm.pc - -%files -n libosmo-gprs-llc0 -%_libdir/libosmo-gprs-llc.so.0* - -%files -n libosmo-gprs-llc-devel -%dir %_includedir/%name -%dir %_includedir/%name/osmocom -%dir %_includedir/%name/osmocom/gprs -%_includedir/%name/osmocom/gprs/llc -%_libdir/libosmo-gprs-llc.so -%_libdir/pkgconfig/libosmo-gprs-llc.pc - -%files -n libosmo-gprs-rlcmac0 -%_libdir/libosmo-gprs-rlcmac.so.0* - -%files -n libosmo-gprs-rlcmac-devel -%dir %_includedir/%name -%dir %_includedir/%name/osmocom -%dir %_includedir/%name/osmocom/gprs -%_includedir/%name/osmocom/gprs/rlcmac -%_libdir/libosmo-gprs-rlcmac.so -%_libdir/pkgconfig/libosmo-gprs-rlcmac.pc - -%files -n libosmo-gprs-sndcp0 -%_libdir/libosmo-gprs-sndcp.so.0* - -%files -n libosmo-gprs-sndcp-devel -%dir %_includedir/%name -%dir %_includedir/%name/osmocom -%dir %_includedir/%name/osmocom/gprs -%_includedir/%name/osmocom/gprs/sndcp -%_libdir/libosmo-gprs-sndcp.so -%_libdir/pkgconfig/libosmo-gprs-sndcp.pc - -%files -n libosmo-gprs-sm0 -%_libdir/libosmo-gprs-sm.so.0* - -%files -n libosmo-gprs-sm-devel -%dir %_includedir/%name -%dir %_includedir/%name/osmocom -%dir %_includedir/%name/osmocom/gprs -%_includedir/%name/osmocom/gprs/sm -%_libdir/libosmo-gprs-sm.so -%_libdir/pkgconfig/libosmo-gprs-sm.pc - -%changelog -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/36724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc Gerrit-Change-Number: 36724 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[M] Change in libosmo-gprs[master]: contrib: remove rpm spec file

by laforge

Attention is currently required from: daniel, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/36724?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/36724?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iff549b7695512c76514ed8915c4807c455e2bdcc Gerrit-Change-Number: 36724 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 13 May 2024 12:22:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-hlr[master]: contrib: remove rpm spec file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/36738?usp=email ) Change subject: contrib: remove rpm spec file ...................................................................... contrib: remove rpm spec file Related: https://osmocom.org/news/255 Related: OS#6446 Change-Id: Idd67d52ca736c4e145387ea8d4030f9cf4b9596d --- M Makefile.am M configure.ac D contrib/osmo-hlr.spec.in 3 files changed, 11 insertions(+), 211 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index bb3d753..cc62d23 100644 --- a/Makefile.am +++ b/Makefile.am @@ -12,7 +12,6 @@ EXTRA_DIST = \ .version \ README.md \ - contrib/osmo-hlr.spec.in \ debian \ git-version-gen \ $(NULL) diff --git a/configure.ac b/configure.ac index 66bba75..61fcee8 100644 --- a/configure.ac +++ b/configure.ac @@ -203,7 +203,6 @@ contrib/Makefile contrib/systemd/Makefile contrib/dgsm/Makefile - contrib/osmo-hlr.spec tests/Makefile tests/auc/Makefile tests/auc/gen_ts_55_205_test_sets/Makefile diff --git a/contrib/osmo-hlr.spec.in b/contrib/osmo-hlr.spec.in deleted file mode 100644 index ebf6ee6..0000000 --- a/contrib/osmo-hlr.spec.in +++ /dev/null @@ -1,209 +0,0 @@ -# -# spec file for package osmo-hlr -# -# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany. -# Copyright (c) 2016, Martin Hauke <mardnh(a)gmx.de> -# -# All modifications and additions to the file contributed by third parties -# remain the property of their copyright owners, unless otherwise agreed -# upon. The license for this file, and modifications and additions to the -# file, is the same license as for the pristine package itself (unless the -# license for the pristine package is not an Open Source License, in which -# case the license is the MIT License). An "Open Source License" is a -# license that conforms to the Open Source Definition (Version 1.9) -# published by the Open Source Initiative. - -Name: osmo-hlr -Version: @VERSION@ -Release: 0 -Summary: Osmocom Home Location Register for GSUP protocol towards OsmoSGSN and OsmoCSCN -License: AGPL-3.0-or-later AND GPL-2.0-or-later -Group: Productivity/Telephony/Servers -URL: https://osmocom.org/projects/osmo-hlr -Source: %{name}-%{version}.tar.xz -BuildRequires: autoconf -BuildRequires: automake -BuildRequires: libtool -BuildRequires: pkgconfig >= 0.20 -BuildRequires: python3 -%if 0%{?suse_version} -BuildRequires: systemd-rpm-macros -%endif -BuildRequires: pkgconfig(libosmoabis) >= 1.5.0 -BuildRequires: pkgconfig(libosmocore) >= 1.9.0 -BuildRequires: pkgconfig(libosmoctrl) >= 1.9.0 -BuildRequires: pkgconfig(libosmogsm) >= 1.9.0 -BuildRequires: pkgconfig(libosmovty) >= 1.9.0 -BuildRequires: pkgconfig(sqlite3) -BuildRequires: pkgconfig(talloc) >= 2.0.1 -# only needed for populate_hlr_db.pl -Requires: libdbi-drivers-dbd-sqlite3 -%{?systemd_requires} - -%description -The GSUP HLR is a stand-alone HLR (Home Location Register) for SIM -and USIM based subscribers which exposes the GSUP protocol towards -its users. OsmoSGSN supports this protocol. - -osmo-gsup-hlr is still very simplistic. It is a single-threaded -architecture and uses only sqlite3 tables as back-end. It is suitable -for installations of the scale that OsmoNITB was able to handle. It -also lacks various features like fine-grained control of subscribed -services (like supplementary services). - -%package -n libosmo-gsup-client0 -Summary: Osmocom GSUP (General Subscriber Update Protocol) client library -License: GPL-2.0-or-later -Group: System/Libraries - -%description -n libosmo-gsup-client0 -This is a shared library that can be used to implement client programs for -the GSUP protocol. The typical GSUP server is OsmoHLR, with OsmoMSC, OsmoSGSN -and External USSD Entities (EUSEs) using this library to implement clients. - -%package -n libosmo-gsup-client-devel -Summary: Development files for the Osmocom GSUP client library -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-gsup-client0 = %{version} - -%description -n libosmo-gsup-client-devel -This is a shared library that can be used to implement client programs for -the GSUP protocol. The typical GSUP server is OsmoHLR, with OsmoMSC, OsmoSGSN -and External USSD Entities (EUSEs) using this library to implement clients. - -This subpackage contains libraries and header files for developing -applications that want to make use of libosmo-gsup-client. - -%package -n libosmo-mslookup1 -Summary: Osmocom MS lookup library -License: GPL-2.0-or-later -Group: System/Libraries - -%description -n libosmo-mslookup1 -This shared library contains routines for looking up mobile subscribers. - -%package -n libosmo-mslookup-devel -Summary: Development files for the Osmocom MS lookup library -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ -Requires: libosmo-mslookup1 = %{version} - -%description -n libosmo-mslookup-devel -This shared library contains routines for looking up mobile subscribers. - -This subpackage contains libraries and header files for developing -applications that want to make use of libosmo-mslookup. - - -%package -n osmo-mslookup-client -Summary: Standalone program using libosmo-mslookup -License: GPL-2.0-or-later -Group: Development/Libraries/C and C++ - -%description -n osmo-mslookup-client -Standalone program using libosmo-mslookup to easily integrate with programs -that want to connect services (SIP, SMS,...) to the current location of a -subscriber. - -%prep -%setup -q - -%build -echo "%{version}" >.tarball-version -autoreconf -fi -%configure \ - --docdir="%{_docdir}/%{name}" \ - --with-systemdsystemunitdir=%{_unitdir} \ - --enable-shared \ - --disable-static -make V=1 %{?_smp_mflags} - -%install -%make_install -install -d "%{buildroot}/%{_localstatedir}/lib/osmocom" -find %{buildroot} -type f -name "*.la" -delete -print - -%check -make %{?_smp_mflags} check || (find . -name testsuite.log -exec cat {} +) - -%preun -%if 0%{?suse_version} -%service_del_preun %{name}.service -%endif - -%postun -%if 0%{?suse_version} -%service_del_postun %{name}.service -%endif - -%pre -getent group osmocom >/dev/null || groupadd --system osmocom -getent passwd osmocom >/dev/null || useradd --system --gid osmocom --home-dir /var/lib/osmocom \ - --shell /sbin/nologin --comment "Open Source Mobile Communications" osmocom -%if 0%{?suse_version} -%service_add_pre %{name}.service -%endif -exit 0 - -%post -%if 0%{?suse_version} -%service_add_post %{name}.service -%endif -/usr/share/osmocom/osmo-hlr-post-upgrade.sh -chown osmocom:osmocom /etc/osmocom/osmo-hlr.cfg -chmod 0660 /etc/osmocom/osmo-hlr.cfg -chown root:osmocom /etc/osmocom -chmod 2775 /etc/osmocom -mkdir -p /var/lib/osmocom -chown -R osmocom:osmocom /var/lib/osmocom - -%post -n libosmo-gsup-client0 -p /sbin/ldconfig -%postun -n libosmo-gsup-client0 -p /sbin/ldconfig -%post -n libosmo-mslookup1 -p /sbin/ldconfig -%postun -n libosmo-mslookup1 -p /sbin/ldconfig - -%files -%license COPYING -%dir %{_docdir}/%{name} -%dir %{_docdir}/%{name}/examples -%{_docdir}/%{name}/examples/osmo-hlr.cfg -%{_docdir}/%{name}/examples/osmo-hlr-dgsm.cfg -%dir %{_docdir}/%{name}/sql -%{_docdir}/%{name}/sql/hlr.sql -%{_docdir}/%{name}/sql//hlr_data.sql -%dir %{_sysconfdir}/osmocom -%dir %{_localstatedir}/lib/osmocom -%{_bindir}/osmo-hlr -%{_bindir}/osmo-hlr-db-tool -%dir %{_sysconfdir}/osmocom -%config %{_sysconfdir}/osmocom/osmo-hlr.cfg -%{_unitdir}/osmo-hlr.service -%dir %{_datadir}/osmocom -%{_datadir}/osmocom/osmo-hlr-post-upgrade.sh - -%files -n libosmo-gsup-client0 -%{_libdir}/libosmo-gsup-client.so.0* - -%files -n libosmo-gsup-client-devel -%{_bindir}/osmo-euse-demo -%dir %{_includedir}/osmocom -%dir %{_includedir}/osmocom/gsupclient -%{_includedir}/osmocom/gsupclient/*.h -%{_libdir}/libosmo-gsup-client.so -%{_libdir}/pkgconfig/libosmo-gsup-client.pc - -%files -n libosmo-mslookup1 -%{_libdir}/libosmo-mslookup.so.1* - -%files -n libosmo-mslookup-devel -%dir %{_includedir}/osmocom -%dir %{_includedir}/osmocom/mslookup -%{_includedir}/osmocom/mslookup/*.h -%{_libdir}/libosmo-mslookup.so -%{_libdir}/pkgconfig/libosmo-mslookup.pc - -%files -n osmo-mslookup-client -%{_bindir}/osmo-mslookup-client - -%changelog -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/36738?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Idd67d52ca736c4e145387ea8d4030f9cf4b9596d Gerrit-Change-Number: 36738 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024