May 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: contrib/systemd: run as osmocom user

by osmith

Attention is currently required from: fixeria, laforge, lynxis lazus, msuraev. osmith has uploaded a new patch set (#9) to the change originally created by msuraev. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review-1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: contrib/systemd: run as osmocom user ...................................................................... contrib/systemd: run as osmocom user I have verified that with AmbientCapabilities=CAP_SYS_NICE, setting scheduling policy as described in the manual still works as expected. Related: OS#4107 Change-Id: Ibb83c231231b39dc6732c0f375aeb3b21f3938ef --- M contrib/systemd/osmo-mgw.service A debian/postinst 2 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/94/30094/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb83c231231b39dc6732c0f375aeb3b21f3938ef Gerrit-Change-Number: 30094 Gerrit-PatchSet: 9 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian/postinst: don't change /etc/osmocom

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email ) Change subject: debian/postinst: don't change /etc/osmocom ...................................................................... debian/postinst: don't change /etc/osmocom osmo_dia2gsup doesn't have a config file in /etc/osmocom. The path I put there didn't make sense. Fix for: chown: cannot access '/etc/osmocom/osmo_dia2gsup.service': No such file or directory Fixes: 240b43f3 ("contrib/systemd: run as osmocom user") Change-Id: I32a06db20c53fdc136989f41805c78e5d9420b9b --- M debian/postinst 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/debian/postinst b/debian/postinst index f9f64c8..680cb2f 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,10 +16,6 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo_dia2gsup.service - chmod 0660 /etc/osmocom/osmo_dia2gsup.service - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom mkdir -p /var/lib/osmo_dia2gsup chown -R osmocom:osmocom /var/lib/osmo_dia2gsup ;; -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32a06db20c53fdc136989f41805c78e5d9420b9b Gerrit-Change-Number: 36798 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian/postinst: don't change /etc/osmocom

by lynxis lazus

Attention is currently required from: daniel, osmith, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email ) Change subject: debian/postinst: don't change /etc/osmocom ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > it looks like we don't install one currently: […] We need to add a configuration file similar to osmo-epdg. (not in this commit ;) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32a06db20c53fdc136989f41805c78e5d9420b9b Gerrit-Change-Number: 36798 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-Comment-Date: Tue, 14 May 2024 12:24:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: remove unused conversion functions

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email ) Change subject: gtp: remove unused conversion functions ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 Gerrit-Change-Number: 36790 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 11:13:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: remove unused conversion functions

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email ) Change subject: gtp: remove unused conversion functions ...................................................................... Patch Set 3: (1 comment) File TODO-RELEASE: https://gerrit.osmocom.org/c/osmo-ggsn/+/36790/comment/b7af68c9_d94b8d87 PS2, Line 10: libgtp REMOVE remove GTP cause defines of reserved values, ABI change (removed API) > Please put it in a new line so it's easier to revert at any point, plus describe which APIs were rem […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 Gerrit-Change-Number: 36790 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 09:15:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-ggsn[master]: gtp: remove unused conversion functions

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: gtp: remove unused conversion functions ...................................................................... gtp: remove unused conversion functions Remove ipv42eua and eua2ipv4, which are in the "internal functions" section of gtp.h, but are not used anywhere in the code anymore. This is in preparation of moving the internal functions that are used in multiple .c files into a separate header file, and to make the other internal functions static. (Compiler complains about unused static functions.) Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 --- M TODO-RELEASE M gtp/gtp.c M include/osmocom/gtp/gtp.h 3 files changed, 17 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/90/36790/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I90e2750f6a6e3e6122e9c562103fda77d7326932 Gerrit-Change-Number: 36790 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-mgw[master]: contrib/systemd: run as osmocom user

by osmith

Attention is currently required from: fixeria, lynxis lazus, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 8: (1 comment) File debian/postinst: https://gerrit.osmocom.org/c/osmo-mgw/+/30094/comment/c6dde2ff_78976f56 PS8, Line 18: # Fix permissions of previous (root-owned) install (OS#4107) > Please note that changing the user the Osmocom programs run as, from root to the new osmocom user, i […] as discussed in chat, I'll add version checks like: ``` if dpkg --compare-versions "$2" le "2.12.33"; then chown ... fi ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb83c231231b39dc6732c0f375aeb3b21f3938ef Gerrit-Change-Number: 30094 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 May 2024 09:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian/postinst: don't change /etc/osmocom

by osmith

Attention is currently required from: daniel, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email ) Change subject: debian/postinst: don't change /etc/osmocom ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > where's the config file then? because iirc there was a config file? it looks like we don't install one currently: ``` # dpkg -L osmo-diameter2gsup /. /lib /lib/systemd /lib/systemd/system /lib/systemd/system/osmo_dia2gsup.service /usr /usr/bin /usr/bin/osmo-dia2gsup /usr/share /usr/share/doc /usr/share/doc/osmo-diameter2gsup /usr/share/doc/osmo-diameter2gsup/changelog.gz ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32a06db20c53fdc136989f41805c78e5d9420b9b Gerrit-Change-Number: 36798 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-Comment-Date: Tue, 14 May 2024 08:28:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: debian/postinst: don't change /etc/osmocom

by pespin

Attention is currently required from: daniel, lynxis lazus, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email ) Change subject: debian/postinst: don't change /etc/osmocom ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: where's the config file then? because iirc there was a config file? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/36798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32a06db20c53fdc136989f41805c78e5d9420b9b Gerrit-Change-Number: 36798 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <daniel(a)totalueberwachung.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: daniel <daniel(a)totalueberwachung.de> Gerrit-Comment-Date: Tue, 14 May 2024 08:25:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp: move conversion functions up

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email ) Change subject: gtp: move conversion functions up ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I51e6a7c1161320fc54b0e8197ae57e4327976eb1 Gerrit-Change-Number: 36791 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 May 2024 08:15:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2024