Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36328?usp=email )
Change subject: debian/rules: make configure args diff friendly
......................................................................
Patch Set 2:
(1 comment)
File debian/rules:
https://gerrit.osmocom.org/c/osmo-trx/+/36328/comment/b07434ce_cd8446ee
PS1, Line 16: --with-systemdsystemunitdir=/lib/systemd/system \
> I would really put the systemd one separate from the "enable backend" ones.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36328?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I354affacb38958efe70baedc6175aeab525190a6
Gerrit-Change-Number: 36328
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2024 12:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36329?usp=email )
Change subject: debian: add osmo-trx-ms-blade
......................................................................
Patch Set 1:
(1 comment)
File debian/control:
https://gerrit.osmocom.org/c/osmo-trx/+/36329/comment/2ba46d1c_5a7660f3
PS1, Line 19: libbladerf-dev
> I'd say better put the "backend dependency" together with the other ones, aka liblimesuite-dev and l […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36329?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I85d24355975f292610bcde61a8917aec852043ca
Gerrit-Change-Number: 36329
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2024 12:46:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-trx/+/36328?usp=email )
Change subject: debian/rules: make configure args diff friendly
......................................................................
debian/rules: make configure args diff friendly
Have one arg per line, and order it mostly alphabetically while at it
(backends are still together, as recommended in review).
Change-Id: I354affacb38958efe70baedc6175aeab525190a6
---
M debian/rules
1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/28/36328/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36328?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I354affacb38958efe70baedc6175aeab525190a6
Gerrit-Change-Number: 36328
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36329?usp=email )
Change subject: debian: add osmo-trx-ms-blade
......................................................................
Patch Set 1:
(1 comment)
File debian/control:
https://gerrit.osmocom.org/c/osmo-trx/+/36329/comment/a664a722_944dc00f
PS1, Line 19: libbladerf-dev
I'd say better put the "backend dependency" together with the other ones, aka liblimesuite-dev and libusrp-dev.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36329?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I85d24355975f292610bcde61a8917aec852043ca
Gerrit-Change-Number: 36329
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2024 12:40:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36328?usp=email )
Change subject: debian/rules: make configure args diff friendly
......................................................................
Patch Set 1:
(1 comment)
File debian/rules:
https://gerrit.osmocom.org/c/osmo-trx/+/36328/comment/c9493c09_5054ee05
PS1, Line 16: --with-systemdsystemunitdir=/lib/systemd/system \
I would really put the systemd one separate from the "enable backend" ones.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36328?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I354affacb38958efe70baedc6175aeab525190a6
Gerrit-Change-Number: 36328
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2024 12:39:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment