osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/gapk/+/36335?usp=email )
Change subject: debian: initial
......................................................................
debian: initial
Change-Id: I8e9d42fc332c5d426b9074c6bc58bc6efe037fea
---
A debian/changelog
A debian/compat
A debian/control
A debian/copyright
A debian/gapk.install
A debian/libosmogapk-dev.install
A debian/libosmogapk0.install
A debian/rules
A debian/source/format
9 files changed, 93 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/gapk refs/changes/35/36335/1
diff --git a/debian/changelog b/debian/changelog
new file mode 100644
index 0000000..4cbf688
--- /dev/null
+++ b/debian/changelog
@@ -0,0 +1,5 @@
+gapk (1.1) unstable; urgency=medium
+
+ * Initial debian packaging
+
+ -- Oliver Smith <osmith(a)sysmocom.de> Mon, 18 Mar 2024 13:15:22 +0100
diff --git a/debian/compat b/debian/compat
new file mode 100644
index 0000000..f599e28
--- /dev/null
+++ b/debian/compat
@@ -0,0 +1 @@
+10
diff --git a/debian/control b/debian/control
new file mode 100644
index 0000000..556bbf8
--- /dev/null
+++ b/debian/control
@@ -0,0 +1,37 @@
+Source: gapk
+Section: net
+Priority: optional
+Maintainer: Osmocom team <openbsc(a)lists.osmocom.org>
+Build-Depends: debhelper (>= 10),
+ dh-autoreconf,
+ autotools-dev,
+ autoconf,
+ automake,
+ libtool,
+ pkg-config,
+ libasound2-dev,
+ libgsm1-dev,
+ libosmocore-dev (>= 0.3.2)
+Standards-Version: 4.1.4
+Vcs-Browser: https://gitea.osmocom.org/osmocom/gapk
+Vcs-Git: https://gerrit.osmocom.org/gapk
+Homepage: https://osmocom.org/projects/gapk/wiki/Gapk
+
+Package: gapk
+Architecture: any
+Multi-Arch: foreign
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: GSM Audio Pocket Knife converts between GSM related codecs
+
+Package: libosmogapk0
+Architecture: any
+Multi-Arch: same
+Pre-Depends: ${misc:Pre-Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: GSM Audio Pocket Knife converts between GSM related codecs
+
+Package: libosmogapk-dev
+Section: libdevel
+Architecture: any
+Depends: libosmogapk0 (= ${binary:Version}), ${misc:Depends}
+Description: GSM Audio Pocket Knife converts between GSM related codecs
diff --git a/debian/copyright b/debian/copyright
new file mode 100644
index 0000000..8d7bd0c
--- /dev/null
+++ b/debian/copyright
@@ -0,0 +1,23 @@
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Upstream-Name: gapk
+Source: https://gitea.osmocom.org/osmocom/gapk
+
+Files: *
+License: GPL-3.0+
+
+License: GPL-3.0+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+ .
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+ .
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+ .
+ On Debian systems, the complete text of the GNU General Public License
+ Version 3 can be found in `/usr/share/common-licenses/GPL-3'.
diff --git a/debian/gapk.install b/debian/gapk.install
new file mode 100644
index 0000000..1df36c6
--- /dev/null
+++ b/debian/gapk.install
@@ -0,0 +1 @@
+usr/bin/*
diff --git a/debian/libosmogapk-dev.install b/debian/libosmogapk-dev.install
new file mode 100644
index 0000000..ab755d6
--- /dev/null
+++ b/debian/libosmogapk-dev.install
@@ -0,0 +1,3 @@
+usr/include/*
+usr/lib/*/pkgconfig/libosmogapk.pc
+usr/lib/*/*.so
diff --git a/debian/libosmogapk0.install b/debian/libosmogapk0.install
new file mode 100644
index 0000000..3de3b10
--- /dev/null
+++ b/debian/libosmogapk0.install
@@ -0,0 +1 @@
+usr/lib/*/*.so.*
diff --git a/debian/rules b/debian/rules
new file mode 100755
index 0000000..c854d74
--- /dev/null
+++ b/debian/rules
@@ -0,0 +1,12 @@
+#!/usr/bin/make -f
+
+%:
+ dh $@ --with autoreconf
+
+override_dh_auto_configure:
+ touch libgsmhr/.downloaded # Don't fetch 3GPP sources
+ dh_auto_configure
+
+# Print test results in case of a failure
+override_dh_auto_test:
+ dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false)
diff --git a/debian/source/format b/debian/source/format
new file mode 100644
index 0000000..89ae9db
--- /dev/null
+++ b/debian/source/format
@@ -0,0 +1 @@
+3.0 (native)
--
To view, visit https://gerrit.osmocom.org/c/gapk/+/36335?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Change-Id: I8e9d42fc332c5d426b9074c6bc58bc6efe037fea
Gerrit-Change-Number: 36335
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: dexter, fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email )
Change subject: RAB activation/modification/release statistics
......................................................................
Patch Set 2:
(4 comments)
File include/osmocom/hnbgw/context_map.h:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/9bdce008_47b77613
PS2, Line 5: osmocom/core/bitvec.h
> Why do we need this import in a header file? Looks unrelated and unneeded.
thanks. it's anrtifact of an earlier version of the patch, where I used a bit-mask of RABs - however, this turned out to be insufficient as we'd need at least two bits per RAB.
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/a6321af0_89528da6
PS2, Line 173: uint8_t rab_state[256];
> This is something we most probably want to have as some sort of bitmask in the future, eg using 2 bi […]
it actually was a bitmask with one bit in the beginning, but then I had to move to away from that. Using an array is simple and works. In the end, even at e.g. 10000 UE, this is only 2.5 Megabytes of RAM. Nothing to worry about.
What would make more sense is to unify this information with the ps_rabs list and the mgw_fsm further above. So that basically there's one object for per-RAB information and not multiple.
File src/osmo-hnbgw/kpi_ranap.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/6f3aba76_4153dde6
PS2, Line 54: ranap_message *ranap
> `const` like above?
I had that originally, but it sadly doesn't work. I don't recall where it failed, but I think some of the osmo-iuh generated code doesn't permit passing a const structure [even when it should].
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/5c782278_f640df6a
PS2, Line 362: //kpi_ranap_process_dl_iu_rel_cmpl(map, ranap); /* IU RELEASE COMPLETE (8.5) */
> why is this one commented out?
I think I originally thought we'd need to track something here, but then didn't need it after all. Looking at the specs again, it looks like there's a list of released RABs in this message, so we might use that instead of simply assuming all RABs are releaed in the IU RELEASE COMMAND. I'll add a comment to say that.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I198fa37699e22380909764de6a0522ac79aa1d39
Gerrit-Change-Number: 36311
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Mar 2024 12:51:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter, laforge.
Hello Jenkins Builder, dexter, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: RAB activation/modification/release statistics
......................................................................
RAB activation/modification/release statistics
Add rate_ctr based statistics for RAB activation, deactivation and
failures. This requires us to parse RANAP in both uplink and downlink
and to iterate deep into the setup/modify/release/failure lists.
Given the way how the protocol works, the only way to distinguish an
activation from a modification is because sender and recipient know
whether a given RAB is already active at the time of the message. So we
also need to track the activation state of each RAB.
Depends: osmo-iuh.git Change-Id I328819c650fc6cefe735093a846277b4f03e6b29
Change-Id: I198fa37699e22380909764de6a0522ac79aa1d39
---
M include/osmocom/hnbgw/Makefile.am
M include/osmocom/hnbgw/context_map.h
M include/osmocom/hnbgw/hnbgw.h
A include/osmocom/hnbgw/kpi.h
M src/osmo-hnbgw/Makefile.am
M src/osmo-hnbgw/context_map_rua.c
M src/osmo-hnbgw/context_map_sccp.c
M src/osmo-hnbgw/hnbgw.c
A src/osmo-hnbgw/kpi_ranap.c
9 files changed, 504 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/11/36311/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I198fa37699e22380909764de6a0522ac79aa1d39
Gerrit-Change-Number: 36311
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newpatchset