Attention is currently required from: daniel, jolly.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email )
Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
this appears to fail during io_uring_queue_init. So it might again be a docker seccomp or other config issue?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6
Gerrit-Change-Number: 35984
Gerrit-PatchSet: 8
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:37:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter, neels.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email )
Change subject: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16:
what is the status of this patch? do we still need it? for what?
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I523d0fcb020f7d46323c497a4be9ee00d5f242ba
Gerrit-Change-Number: 34404
Gerrit-PatchSet: 16
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:34:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33533?usp=email )
Change subject: common/Makefile.am: comment out 'libbts_la_LDADD = probes.lo'
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> It was Harald in `430954630`, adding him as a reviewer. […]
I guess I must have had some local probes in my 'common' directory, but then the commit that ended up in master only adds probes to osmo-bts-trx.
If you remove the probes.lo here, it might make sense to remove the entire probes.h/probes.d/... systemtap block
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/33533?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I829c63988fd51b481cb9f13a81dfaf5e78beb1b8
Gerrit-Change-Number: 33533
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:32:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28909?usp=email )
Change subject: jobs/ttcn3: add debian nightly + asan jobs
......................................................................
Abandoned
see https://osmocom.org/issues/5301#note-18 for current status
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28909?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I7a0b3f57607ac1e25d98d2fe3d611476c71d7cf7
Gerrit-Change-Number: 28909
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: abandon
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28905?usp=email )
Change subject: obs: build nightly-asan with --enable-sanitize
......................................................................
Abandoned
see https://osmocom.org/issues/5301#note-18 for current status
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28905?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ife826b2c8e1173a2faf292e76815be6f0bd0a62c
Gerrit-Change-Number: 28905
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: abandon
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28906?usp=email )
Change subject: jobs/osmocom-obs-nightly-asan.yml: new file
......................................................................
Abandoned
see https://osmocom.org/issues/5301#note-18 for current status
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28906?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1c8c65bd1829baa29864ad186f3c43e79979d141
Gerrit-Change-Number: 28906
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: abandon
Attention is currently required from: laforge, msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32127?usp=email )
Change subject: contrib/jenkins.sh: build with --enable-external-tests
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
Not sure if this is intentional, but it's actually `0.1s`:
```
87 # possibly the binary hasn't launched yet
88 if debug_tcp_sockets:
89 print("Connecting socket failed, retrying...")
90 time.sleep(.1)
91 continue
```
> So the DH generation would need to take more than 30s for this to trigger the problem?
Taking the above into account, more than 3s. I don't remember all the details, but maybe we can make this sleep value configurable and pass a larger value here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32127?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d37b231510e592198a9de707dfe8f5f2703dce
Gerrit-Change-Number: 32127
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28902?usp=email )
Change subject: debian-bullseye-obs-asan: new container
......................................................................
Abandoned
see https://osmocom.org/issues/5301#note-18 for current status. abandoning this patch, we use bookworm now instead of bullseye.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28902?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d6e7cc401acadbae9156d3e7f3a6230c2fb198
Gerrit-Change-Number: 28902
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: abandon
Attention is currently required from: fixeria, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/32127?usp=email )
Change subject: contrib/jenkins.sh: build with --enable-external-tests
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> So the problem here is that `osmotestconfig. […]
if I reasd the code of obscvty.py _connect_socket() correctly, it retries 30 times in 1s intervals to establish the connection. So the DH generation would need to take more than 30s for this to trigger the problem?
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/32127?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d37b231510e592198a9de707dfe8f5f2703dce
Gerrit-Change-Number: 32127
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:17:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34457?usp=email )
Change subject: gsmtap.h: Add definitions for ISDN PPP sub-type
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> the only relevant difference in the protocol (after the framing) seems to be that the async mode can […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34457?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I17137167b2c74b6c5e53459743b6e140fc1a4386
Gerrit-Change-Number: 34457
Gerrit-PatchSet: 3
Gerrit-Owner: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 09:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: manawyrm <osmocom.account(a)tbspace.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment