March 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: osmo_io_uring: Run check of tests/osmo_io with io_uring also

by jolly

Attention is currently required from: daniel, jolly, laforge. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also ...................................................................... osmo_io_uring: Run check of tests/osmo_io with io_uring also Related: OS#5751 Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 --- M configure.ac M debian/rules M tests/Makefile.am M tests/testsuite.at 4 files changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/84/35984/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 10 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io_uring: Run check of tests/osmo_io with io_uring also

by osmith

Attention is currently required from: daniel, jolly, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email ) Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > ack, this is the same problem as in OS#6405. […] this will be fixed with: * https://gerrit.osmocom.org/c/osmo-ci/+/36368 to run contrib/jenkins.sh only on jenkins nodes that support io_uring * squashing https://paste.sr.ht/~osmith/93e2dd846d7bae4b637e1698c6f9a292bb9d0b2f into this, so the test does not run during debian packaging. this means the debian packaging tests can still run on all jenkins nodes, and it prevents failing in OBS (I think it could fail there as well, we already disable the sctp tests in debian packaging because they fail on OBS too) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 10:29:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/ttcn3: rename io_uring node label

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36367?usp=email ) Change subject: jobs/ttcn3: rename io_uring node label ...................................................................... jobs/ttcn3: rename io_uring node label Rename it from ttcn3-io_uring to io_uring, as it will be used for non-ttcn3 jobs too in the next patch. Related: OS#6405 Change-Id: Icd23a4497771c939f6b988ea244c9dcabfd30e3f --- M jobs/ttcn3-testsuites.yml 1 file changed, 19 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/67/36367/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 71bcb81..90a3aa3 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -207,22 +207,22 @@ # With LIBOSMO_IO_BACKEND=IO_URING (OS#6357) - ttcn3-bsc-test-io_uring: timer: H 11 * * * - node: ttcn3-io_uring + node: io_uring # OS#6405 - ttcn3-msc-test-io_uring: timer: H 11 * * * - node: ttcn3-io_uring + node: io_uring # OS#6405 - ttcn3-hnbgw-test-io_uring: timer: H 11 * * * - node: ttcn3-io_uring + node: io_uring # OS#6405 - ttcn3-gbproxy-test-io_uring: timer: H 11 * * * - node: ttcn3-io_uring + node: io_uring # OS#6405 - ttcn3-sgsn-test-io_uring: timer: H 11 * * * - node: ttcn3-io_uring + node: io_uring # OS#6405 - ttcn3-stp-test-io_uring: timer: H 11 * * * - node: ttcn3-io_uring + node: io_uring # OS#6405 - job-template: name: '{job-name}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icd23a4497771c939f6b988ea244c9dcabfd30e3f Gerrit-Change-Number: 36367 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/gerrit: libosmocore: run on io_uring nodes

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36368?usp=email ) Change subject: jobs/gerrit: libosmocore: run on io_uring nodes ...................................................................... jobs/gerrit: libosmocore: run on io_uring nodes We have at least one node where the io_uring backend does not work. Allow running the osmo_io tests with the io_uring backend in CI by limiting the jenkins nodes used to the ones where we know that io_uring works. Related: libosmocore I82db9a15bc483a5447d86352512afaafa2bcfbb6 Related: OS#6405 Change-Id: I9289e2f84edbff95d81bb4a92863865b9563fc6a --- M jobs/gerrit-verifications.yml 1 file changed, 17 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/68/36368/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 78c25cf..492c06e 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -116,6 +116,7 @@ - libosmo-sccp - libosmocore: + slave_axis: !!python/tuple [io_uring] # OS#6405 a1_name: arch a1: !!python/tuple [arm-none-eabi, amd64] combination_filter: '!(arch=="arm-none-eabi" && label=="FreeBSD_amd64")' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9289e2f84edbff95d81bb4a92863865b9563fc6a Gerrit-Change-Number: 36368 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in docker-playground[master]: openbts-umts: fix apt: use archive.debian.org

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36366?usp=email ) Change subject: openbts-umts: fix apt: use archive.debian.org ...................................................................... openbts-umts: fix apt: use archive.debian.org This helps to get access to Debian 8 repositories in 2024. Change-Id: Ia869476feeb67e2b3313b5d75ca01eaff41597ba --- M openbts-umts/Dockerfile A openbts-umts/sources.list 2 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/66/36366/1 diff --git a/openbts-umts/Dockerfile b/openbts-umts/Dockerfile index 0fee2ff..4c357c6 100644 --- a/openbts-umts/Dockerfile +++ b/openbts-umts/Dockerfile @@ -4,6 +4,9 @@ FROM debian:jessie +# https://unix.stackexchange.com/a/755022 +COPY sources.list /etc/apt/sources.list + RUN apt-get update && \ apt-get install -y --no-install-recommends \ --no-install-suggests \ diff --git a/openbts-umts/sources.list b/openbts-umts/sources.list new file mode 100644 index 0000000..2908463 --- /dev/null +++ b/openbts-umts/sources.list @@ -0,0 +1,4 @@ +# https://unix.stackexchange.com/a/755022 +# Keys Expired But I ~~Want~~ Need To Hold On To The Past +deb [trusted=yes] http://archive.debian.org/debian jessie main +deb [trusted=yes] http://archive.debian.org/debian-security jessie/updates main -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia869476feeb67e2b3313b5d75ca01eaff41597ba Gerrit-Change-Number: 36366 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io_uring: Run check of tests/osmo_io with io_uring also

by osmith

Attention is currently required from: daniel, jolly, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email ) Change subject: osmo_io_uring: Run check of tests/osmo_io with io_uring also ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > this appears to fail during io_uring_queue_init. […] ack, this is the same problem as in OS#6405. I'll add a patch that runs CI only on the nodes where io_uring works, until the issue is resolved. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I82db9a15bc483a5447d86352512afaafa2bcfbb6 Gerrit-Change-Number: 35984 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:56:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Introduce test TC_gy_ccr_update_rejected

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36352?usp=email ) Change subject: pgw: Introduce test TC_gy_ccr_update_rejected ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36352?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie58ae2a5e870b183fa1c56c90c94f5eee56386e0 Gerrit-Change-Number: 36352 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:44:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: pgw: Set Gy CCA Result-Code based on settings

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36344?usp=email ) Change subject: pgw: Set Gy CCA Result-Code based on settings ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2c3b1057908c1c76a55c41a7f45728a0fdee3cf0 Gerrit-Change-Number: 36344 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:44:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: pfcp up_function_features: allow shorter lengths

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email ) Change subject: pfcp up_function_features: allow shorter lengths ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/libosmo-pfcp/pfcp_ies_custom.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/07fe9b28_7f2fce94 PS1, Line 435: * if the peer sends less octets, make do with what we get. */ > "make do" ? https://dictionary.cambridge.org/dictionary/english/make-do https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347/comment/8f2d8350_a4151eef PS1, Line 436: memset(up_function_features->bits, 0, sizeof(up_function_features->bits)); > we can probably avoid memcpying twice. where's the second memcpy? you mean avoiding memset and memcpy'ing the same location? I'm always hoping compilers are smart enough to figure that out during optimization. But I never really tested that "hope". Also, this isn't really a super performance critical code path, so let's not over-optimize. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36347?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I40e255fd0b4770e578aea7a10ba88f5eeba087f4 Gerrit-Change-Number: 36347 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:43:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-pfcp[master]: osmo_gtlv_cfg: fix api doc

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/36346?usp=email ) Change subject: osmo_gtlv_cfg: fix api doc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/36346?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Idcbb10edf384f49bd3f685323a68cdbf8b5d009d Gerrit-Change-Number: 36346 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2024 09:40:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024