Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email )
Change subject: ttcn3-bts-test: abort if missing osmo-config-merge
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-bts-test/Makefile:
https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/ac32e43d_51d…
PS1, Line 15: cfg req-osmo-config-merge
> `cfg` already depends on `req-osmo-config-merge` below, do we also need it here?
PHONY only means that these are not real targets. The order doesn't matter here, but I guess it's slightly nicer to also have rq-osmo-config-merge here first. I've updated it.
https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667
Gerrit-Change-Number: 36446
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Mar 2024 13:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, osmith.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: ttcn3-bts-test: abort if missing osmo-config-merge
......................................................................
ttcn3-bts-test: abort if missing osmo-config-merge
Change-Id: I9cea4affac0b3981c88078581a070f98649da667
---
M ttcn3-bts-test/Makefile
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/46/36446/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667
Gerrit-Change-Number: 36446
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email )
Change subject: ttcn3-bts-test: abort if missing osmo-config-merge
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-bts-test/Makefile:
https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/33e9ef23_22b…
PS1, Line 15: cfg req-osmo-config-merge
`cfg` already depends on `req-osmo-config-merge` below, do we also need it here?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667
Gerrit-Change-Number: 36446
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Mar 2024 13:10:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email )
Change subject: ttcn3-bts-test: abort if missing osmo-config-merge
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-bts-test/Makefile:
https://gerrit.osmocom.org/c/docker-playground/+/36446/comment/39a65e50_6e3…
PS1, Line 15: .PHONY: cfg req-osmo-config-merge
Shouldn't req-osmo-config-merge be put before calling it through cfg?
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36446?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I9cea4affac0b3981c88078581a070f98649da667
Gerrit-Change-Number: 36446
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Mar 2024 13:10:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36447?usp=email )
Change subject: ttcn3-ggsn-test: ignore failure to kill osmo-ggsn
......................................................................
ttcn3-ggsn-test: ignore failure to kill osmo-ggsn
Don't fail if osmo-ggsn can't be killed at the end of a testsuite
run. This happens currently with ttcn3-ggsn-test-kernel-latest-* jobs,
in the v6_only configurations, because osmo-ggsn latest doesn't support
ipv6 yet and exits. The jenkins.sh should keep going and try other
combinations, and exit without error in the end.
Fixes: d8c51cce ("ttcn3-ggsn-test: run with multiple configurations")
Change-Id: I6f3154a9ef114f31bcb5868ee09d1ebc10f35d07
---
M ttcn3-ggsn-test/jenkins.sh
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/47/36447/1
diff --git a/ttcn3-ggsn-test/jenkins.sh b/ttcn3-ggsn-test/jenkins.sh
index f9e7a47..7c9c7ac 100755
--- a/ttcn3-ggsn-test/jenkins.sh
+++ b/ttcn3-ggsn-test/jenkins.sh
@@ -132,5 +132,5 @@
start_ggsn "$i"
start_testsuite "$i"
- docker_kill_wait "$BUILD_TAG"-ggsn
+ docker_kill_wait "$BUILD_TAG"-ggsn || true
done
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36447?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6f3154a9ef114f31bcb5868ee09d1ebc10f35d07
Gerrit-Change-Number: 36447
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36445?usp=email )
Change subject: jobs/ttcn3: add ttcn3-ggsn-test-kernel-pablo-gtp
......................................................................
jobs/ttcn3: add ttcn3-ggsn-test-kernel-pablo-gtp
Add a temporary job to run against the IPv6 patches, until they are
upstreamed.
Related: OS#1952
Change-Id: Idf0e3fd5ba81565ce1626dfdf186c88280232550
---
M jobs/ttcn3-testsuites.yml
1 file changed, 30 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/45/36445/1
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index 74c0a22..8a17e04 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -30,6 +30,14 @@
timer: H 04 * * *
description: |
Test osmo-ggsn master with the Debian kernel.
+ - ttcn3-ggsn-test-kernel-pablo-gtp:
+ timer: H 04 * * *
+ description: |
+ Test osmo-ggsn master with the Linux kernel built from main of
+ <a href="https://git.kernel.org/pub/scm/linux/kernel/git/pablo/gtp.git/">pablo/gtp.git</a>.
+ <br>
+ This is a temporary job, to be removed once the IPv6 related GTP
+ patches are upstreamed (OS#1952).
- ttcn3-ggsn-test-kernel-latest:
timer: H 04 * * *
description: |
@@ -254,6 +262,15 @@
# Run against debian's kernel
export KERNEL_TEST=1
;;
+ ttcn3-ggsn-test-kernel-pablo-gtp)
+ DIR="ttcn3-ggsn-test"
+ export IMAGE_SUFFIX="master"
+ export KERNEL_TEST=1
+ export KERNEL_BUILD=1
+ export KERNEL_URL="https://git.kernel.org/pub/scm/linux/kernel/git/pablo/gtp.git"
+ export KERNEL_REMOTE_NAME="pablo-gtp"
+ export KERNEL_BRANCH="main"
+ ;;
ttcn3-ggsn-test-kernel-latest)
DIR="ttcn3-ggsn-test"
export IMAGE_SUFFIX="latest"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36445?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Idf0e3fd5ba81565ce1626dfdf186c88280232550
Gerrit-Change-Number: 36445
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange