March 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream_cli: Correctly setup and free osmo_io client instance

by jolly

Attention is currently required from: daniel, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email ) Change subject: stream_cli: Correctly setup and free osmo_io client instance ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > today I also saw some io_fd memory leak when running the STP_Tests against osmo-stp. […] The memory leak does happen, if all of my patches in gerrit (libosmo-netif) are applied. The iofd must be freed -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I91a6a76b9ff96034a7b333edf87af27490202932 Gerrit-Change-Number: 35979 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 14:59:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: Forward PGW Address HSS->AAA->ePDG

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36158?usp=email ) Change subject: Forward PGW Address HSS->AAA->ePDG ...................................................................... Forward PGW Address HSS->AAA->ePDG Use subscriber information provided by AAA & HSS regarding PDN-GW address when creating the S2b session. Related: OS#6384 Change-Id: I83a68271ee6548e0e32fc9f0cab385bad5852388 --- M src/aaa_diameter_swm.erl M src/aaa_diameter_swx_cb.erl M src/aaa_ue_fsm.erl M src/epdg_gtpc_s2b.erl M src/epdg_ue_fsm.erl 5 files changed, 122 insertions(+), 27 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/aaa_diameter_swm.erl b/src/aaa_diameter_swm.erl index 7fdc247..0e3fa45 100644 --- a/src/aaa_diameter_swm.erl +++ b/src/aaa_diameter_swm.erl @@ -67,7 +67,8 @@ #swm_session{imsi = Imsi} -> aaa_ue_fsm:ev_swm_auth_compl(Sess#swm_session.pid, Apn); undefined -> - epdg_diameter_swm:auth_compl_response(Imsi, {error, imsi_unknown}) + RC_USER_UNKNOWN=5030, + epdg_diameter_swm:auth_compl_response(Imsi, {error, RC_USER_UNKNOWN}) end, {noreply, State}; diff --git a/src/aaa_diameter_swx_cb.erl b/src/aaa_diameter_swx_cb.erl index bf4a79e..5dd00ef 100644 --- a/src/aaa_diameter_swx_cb.erl +++ b/src/aaa_diameter_swx_cb.erl @@ -77,7 +77,18 @@ #'SAR'{'Server-Assignment-Type' = SAType} = Request, % Retrieve fields from answer: #'SAA'{'Result-Code' = [ResultCode]} = Msg, - aaa_ue_fsm:ev_rx_swx_saa(ReqPid, {SAType, ResultCode}), + case result_code_success(ResultCode) of + ok -> + #'SAA'{'Non-3GPP-User-Data' = N3UA} = Msg, + PGWAddresses = parse_pgw_addr_from_N3UA(N3UA), + case PGWAddresses of + undefined -> ResInfo = #{}; + _ -> ResInfo = maps:put(pgw_address_list, PGWAddresses, #{}) + end, + aaa_ue_fsm:ev_rx_swx_saa(ReqPid, {ok, SAType, ResInfo}); + _ -> + aaa_ue_fsm:ev_rx_swx_saa(ReqPid, {error, SAType, ResultCode}) + end, {ok, Msg}. handle_answer(#diameter_packet{msg = Msg, errors = []}, _Request, _SvcName, Peer) -> lager:info("SWx Rx ~p: ~p~n", [Peer, Msg]), @@ -101,3 +112,33 @@ %% handle_request/3 handle_request(_Packet, _SvcName, _Peer) -> erlang:error({unexpected, ?MODULE, ?LINE}). + +%% ------------------------------------------------------------------ +%% Internal Function Definitions +%% ------------------------------------------------------------------ + +result_code_success(2001) -> ok; +result_code_success(2002) -> ok; +result_code_success(_) -> invalid_result_code. + +parse_pgw_addr_from_MIP6_Agent_Info([]) -> + undefined; +parse_pgw_addr_from_MIP6_Agent_Info([AgentInfo]) -> + #'MIP6-Agent-Info'{'MIP-Home-Agent-Address' = AgentAddrOpt} = AgentInfo, + case AgentAddrOpt of + [] -> undefined; + Res -> Res + end. +parse_pgw_addr_from_APN_Configuration([]) -> + undefined; +parse_pgw_addr_from_APN_Configuration([Head | Tail] = _ApnConfigs) -> + #'APN-Configuration'{'MIP6-Agent-Info' = AgentInfoOpt} = Head, + case parse_pgw_addr_from_MIP6_Agent_Info(AgentInfoOpt) of + undefined -> parse_pgw_addr_from_APN_Configuration(Tail); + Res -> Res + end. +parse_pgw_addr_from_N3UA([]) -> + undefined; +parse_pgw_addr_from_N3UA([N3UA]) -> + #'Non-3GPP-User-Data'{'APN-Configuration' = ApnConfigs} = N3UA, + parse_pgw_addr_from_APN_Configuration(ApnConfigs). \ No newline at end of file diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index 7f70005..fd39061 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -102,10 +102,10 @@ {error, Err} end. -ev_rx_swx_saa(Pid, {SAType, ResultCode}) -> +ev_rx_swx_saa(Pid, Result) -> lager:info("ue_fsm ev_rx_swx_saa~n", []), try - gen_statem:call(Pid, {rx_swx_saa, SAType, ResultCode}) + gen_statem:call(Pid, {rx_swx_saa, Result}) catch exit:Err -> {error, Err} @@ -181,11 +181,16 @@ state_wait_swx_saa(enter, _OldState, Data) -> {keep_state, Data}; -state_wait_swx_saa({call, From}, {rx_swx_saa, _SAType, ResultCode}, Data) -> - lager:info("ue_fsm state_wait_swx_saa event=rx_swx_saa, ~p~n", [Data]), - aaa_diameter_swm:auth_compl_response(Data#ue_fsm_data.imsi, {ok, ResultCode}), - % TODO: don't transit if SAS returned error code. - {next_state, state_authenticated, Data, [{reply,From,ok}]}. +state_wait_swx_saa({call, From}, {rx_swx_saa, Result}, Data) -> + lager:info("ue_fsm state_wait_swx_saa event=rx_swx_saa ~p, ~p~n", [Result, Data]), + case Result of + {error, _SAType, ResultCode} -> + aaa_diameter_swm:auth_compl_response(Data#ue_fsm_data.imsi, {error, ResultCode}), + {next_state, state_new, Data, [{reply,From,ok}]}; + {ok, _SAType, ResInfo} -> + aaa_diameter_swm:auth_compl_response(Data#ue_fsm_data.imsi, {ok, ResInfo}), + {next_state, state_authenticated, Data, [{reply,From,ok}]} + end. state_authenticated(enter, _OldState, Data) -> % Mark ePDG session as active: @@ -256,7 +261,11 @@ state_authenticated_wait_swx_saa(enter, _OldState, Data) -> {keep_state, Data}; -state_authenticated_wait_swx_saa({call, From}, {rx_swx_saa, SAType, ResultCode}, Data) -> +state_authenticated_wait_swx_saa({call, From}, {rx_swx_saa, Result}, Data) -> + case Result of + {error, SAType, ResultCode} -> ResultCode; + {ok, SAType, _ResInfo} -> ResultCode = 2001 + end, lager:info("ue_fsm state_authenticated_wait_swx_saa event=rx_swx_saa SAType=~p ResulCode=~p, ~p~n", [SAType, ResultCode, Data]), case SAType of ?'DIAMETER_CX_SERVER-ASSIGNMENT-TYPE_PGW_UPDATE' -> diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index b0a34bd..a8a42a2 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -48,7 +48,7 @@ %% gen_server Function Exports -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). -export([code_change/3]). --export([create_session_req/3, delete_session_req/1]). +-export([create_session_req/4, delete_session_req/1]). %% Application Definitions -define(SERVER, ?MODULE). @@ -88,6 +88,8 @@ imsi :: binary(), pid :: pid(), apn :: binary(), + raddr_str :: string(), + raddr :: inet:ip_address(), ue_ip :: inet:ip_address(), local_control_tei = 0 :: non_neg_integer(), remote_control_tei = 0 :: non_neg_integer(), @@ -142,15 +144,21 @@ lager:error("GTPv2C UDP socket open error: ~w~n", [Reason]) end. -create_session_req(Imsi, Apn, APCO) -> - gen_server:call(?SERVER, {gtpc_create_session_req, {Imsi, Apn, APCO}}). +create_session_req(Imsi, Apn, APCO, PGWAddrCandidateList) -> + gen_server:call(?SERVER, {gtpc_create_session_req, {Imsi, Apn, APCO, PGWAddrCandidateList}}). delete_session_req(Imsi) -> gen_server:call(?SERVER, {gtpc_delete_session_req, {Imsi}}). -handle_call({gtpc_create_session_req, {Imsi, Apn, APCO}}, {Pid, _Tag} = _From, State0) -> +handle_call({gtpc_create_session_req, {Imsi, Apn, APCO, PGWAddrCandidateList}}, {Pid, _Tag} = _From, State0) -> + RemoteAddrStr = pick_gtpc_remote_address(PGWAddrCandidateList, State0), + lager:debug("Selected PGW Remote Address ~p~n", [RemoteAddrStr]), + {ok, RemoteAddrInet} = inet_parse:address(RemoteAddrStr), {Sess0, State1} = find_or_new_gtp_session(Imsi, - #gtp_session{pid = Pid, apn = list_to_binary(Apn)}, + #gtp_session{pid = Pid, + apn = list_to_binary(Apn), + raddr_str = RemoteAddrInet, + raddr = RemoteAddrInet}, State0), Req = gen_create_session_request(Sess0, APCO, State1), tx_gtp(Req, State1), @@ -352,6 +360,16 @@ find_unused_local_teid(State, State#gtp_state.next_local_data_tei, dec_tei(State#gtp_state.next_local_data_tei)). +pick_gtpc_remote_address(PGWAddrCandidateList, State) -> + case PGWAddrCandidateList of + [] -> + %% Pick default address from configuration: + State#gtp_state .raddr_str; + [Head|_Tail] -> + % TODO: pick a compatible address with .laddr from PGWAddrCandidateList is exists. + Head + end. + %% connect/2 connect(Name, {Socket, RemoteAddr, RemotePort}) -> lager:info("~s connecting to IP ~s port ~p~n", [Name, RemoteAddr, RemotePort]), diff --git a/src/epdg_ue_fsm.erl b/src/epdg_ue_fsm.erl index 291df26..c6358fd 100644 --- a/src/epdg_ue_fsm.erl +++ b/src/epdg_ue_fsm.erl @@ -53,10 +53,11 @@ -record(ue_fsm_data, { imsi, - apn = "internet" :: string(), - tun_pdp_ctx :: epdg_tun_pdp_ctx, - tear_down_gsup_needed = false :: boolean(), %% need to send GSUP PurgeMSResp after STR+STA? - tear_down_gsup_cause = 0 :: integer() + apn = "internet" :: string(), + pgw_rem_addr_list = [] :: list(), + tun_pdp_ctx :: epdg_tun_pdp_ctx, + tear_down_gsup_needed = false :: boolean(), %% need to send GSUP PurgeMSResp after STR+STA? + tear_down_gsup_cause = 0 :: integer() }). get_server_name_by_imsi(Imsi) -> @@ -236,13 +237,22 @@ lager:info("ue_fsm state_authenticating event=lu_request, ~p, ~p~n", [Result, Data]), % Rx "GSUP CEAI LU Req" is our way of saying Rx "Swm Diameter-EAP REQ (DER) with EAP AVP containing successuful auth": case Result of - {ok, _} -> - Ret = ok; - {error, Err} -> - Ret = {error, Err} - end, - gsup_server:lu_response(Data#ue_fsm_data.imsi, Ret), - {next_state, state_authenticated, Data, [{reply,From,Ret}]}. + {ok, ResInfo} -> + % Store PGW Remote address if AAA/HSS signalled them to us: + case maps:find(pdp_info_list, ResInfo) of + error -> + Data1 = Data; + PGWAddrCandidateList -> + Data1 = Data#ue_fsm_data{pgw_rem_addr_list = PGWAddrCandidateList} + end, + Ret = ok, + gsup_server:lu_response(Data1#ue_fsm_data.imsi, Ret), + {next_state, state_authenticated, Data1, [{reply,From,Ret}]}; + {error, Err} -> + Ret = {error, Err}, + gsup_server:lu_response(Data#ue_fsm_data.imsi, Ret), + {next_state, state_new, Data, [{reply,From,Ret}]} + end. state_authenticated(enter, _OldState, Data) -> {keep_state, Data}; @@ -253,7 +263,10 @@ state_authenticated({call, From}, {tunnel_request, PCO}, Data) -> lager:info("ue_fsm state_authenticated event=tunnel_request, ~p~n", [Data]), - epdg_gtpc_s2b:create_session_req(Data#ue_fsm_data.imsi, Data#ue_fsm_data.apn, PCO), + epdg_gtpc_s2b:create_session_req(Data#ue_fsm_data.imsi, + Data#ue_fsm_data.apn, + PCO, + Data#ue_fsm_data.pgw_rem_addr_list), {next_state, state_wait_create_session_resp, Data, [{reply,From,ok}]}; state_authenticated({call, From}, purge_ms_request, Data) -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83a68271ee6548e0e32fc9f0cab385bad5852388 Gerrit-Change-Number: 36158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36170?usp=email ) Change subject: diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004 ...................................................................... diameter_3gpp_ts29_273_swx.dia: Fix missing dependency RFC4004 TS 29.273 SAR contains MIP6-Agent-Info from RFC5447, which in turn contains MIP-Home-Agent-Address from RFC 4004. Related: ffe4e0b0842c75daf8d5c585bffb6bfeb0f75251 Related: OS#6045 Change-Id: Ifaea9ffaec1f50b5ec996a03f3addd70ccd2349f --- M dia/diameter_3gpp_ts29_273_swx.dia 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/dia/diameter_3gpp_ts29_273_swx.dia b/dia/diameter_3gpp_ts29_273_swx.dia index 259e626..aee06d1 100644 --- a/dia/diameter_3gpp_ts29_273_swx.dia +++ b/dia/diameter_3gpp_ts29_273_swx.dia @@ -42,6 +42,7 @@ @inherits diameter_3gpp_ts29_273 @inherits diameter_3gpp_ts32_299 @inherits diameter_etsi_es283_034 +@inherits diameter_rfc4004 @inherits diameter_rfc4006_cc @inherits diameter_rfc5447 @inherits diameter_rfc5580 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ifaea9ffaec1f50b5ec996a03f3addd70ccd2349f Gerrit-Change-Number: 36170 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: Forward PGW Address PGW->AAA->HSS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email ) Change subject: Forward PGW Address PGW->AAA->HSS ...................................................................... Forward PGW Address PGW->AAA->HSS We were missing passing the actual IP address of the PDN-GW when transmitting SAR to the HSS (precisely with the aim of updating that information). Change-Id: Ia99442487fef56c16c4be2fb7f36221d016e55e0 --- M src/aaa_diameter_s6b_cb.erl M src/aaa_diameter_swx.erl M src/aaa_ue_fsm.erl 3 files changed, 32 insertions(+), 17 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/aaa_diameter_s6b_cb.erl b/src/aaa_diameter_s6b_cb.erl index ab15bd6..b3fe209 100644 --- a/src/aaa_diameter_s6b_cb.erl +++ b/src/aaa_diameter_s6b_cb.erl @@ -58,12 +58,13 @@ 'Auth-Application-Id' = AuthAppId, 'Auth-Request-Type' = AuthReqType, 'User-Name' = [UserName], - 'Service-Selection' = [Apn]} = Req, + 'Service-Selection' = [Apn], + 'MIP6-Agent-Info' = AgentInfoOpt } = Req, Imsi = conv:nai_to_imsi(UserName), PidRes = aaa_ue_fsm:get_pid_by_imsi(Imsi), case PidRes of PidRes when is_pid(PidRes) -> - ok = aaa_ue_fsm:ev_rx_s6b_aar(PidRes, Apn), + ok = aaa_ue_fsm:ev_rx_s6b_aar(PidRes, {Apn, AgentInfoOpt}), lager:debug("Waiting for S6b AAA~n", []), receive {aaa, ResultCode} -> lager:debug("Rx AAA with ResultCode=~p~n", [ResultCode]) diff --git a/src/aaa_diameter_swx.erl b/src/aaa_diameter_swx.erl index be301f2..72a360e 100644 --- a/src/aaa_diameter_swx.erl +++ b/src/aaa_diameter_swx.erl @@ -51,7 +51,7 @@ -export([init/1, handle_call/3, handle_cast/2, handle_info/2]). -export([code_change/3]). -export([multimedia_auth_request/7]). --export([server_assignment_request/3]). +-export([server_assignment_request/4]). -export([test/0, test/1]). %% Diameter Application Definitions @@ -146,9 +146,9 @@ gen_server:call(?SERVER, {mar, {IMSI, NumAuthItems, AuthScheme, RAT, CKey, IntegrityKey, PdpTypeNr}}). % APN is optional and should be [] -server_assignment_request(IMSI, Type, APN) -> +server_assignment_request(IMSI, Type, APN, AgentInfoOpt) -> gen_server:call(?SERVER, - {sar, {IMSI, Type, APN}}). + {sar, {IMSI, Type, APN, AgentInfoOpt}}). result_code_success(2001) -> ok; result_code_success(2002) -> ok; @@ -235,8 +235,8 @@ {reply, {error, Err}, State} end; -handle_call({sar, {IMSI, Type, APN}}, {Pid, _Tag} = _From, State) -> - lager:debug("SWx Tx SAR Imsi=~p Type=~p APN=~p~n", [IMSI, Type, APN]), +handle_call({sar, {IMSI, Type, APN, AgentInfoOpt}}, {Pid, _Tag} = _From, State) -> + lager:debug("SWx Tx SAR Imsi=~p Type=~p APN=~p AgentInfoOpt=~p ~n", [IMSI, Type, APN, AgentInfoOpt]), SessionId = diameter:session_id(application:get_env(?ENV_APP_NAME, origin_host, ?ENV_DEFAULT_ORIG_HOST)), SAR = #'SAR'{'Vendor-Specific-Application-Id' = #'Vendor-Specific-Application-Id'{ 'Vendor-Id' = ?VENDOR_ID_3GPP, @@ -245,7 +245,8 @@ 'User-Name' = IMSI, 'Auth-Session-State' = 1, 'Server-Assignment-Type' = Type, - 'Service-Selection' = [APN] + 'Service-Selection' = [APN], + 'MIP6-Agent-Info' = AgentInfoOpt }, Ret = diameter_call(SAR, Pid, State), case Ret of diff --git a/src/aaa_ue_fsm.erl b/src/aaa_ue_fsm.erl index fd39061..9fa868e 100644 --- a/src/aaa_ue_fsm.erl +++ b/src/aaa_ue_fsm.erl @@ -111,10 +111,10 @@ {error, Err} end. -ev_rx_s6b_aar(Pid, Apn) -> - lager:info("ue_fsm ev_rx_s6b_aar: ~p~n", [Apn]), +ev_rx_s6b_aar(Pid, {Apn, AgentInfoOpt}) -> + lager:info("ue_fsm ev_rx_s6b_aar: ~p ~p~n", [Apn, AgentInfoOpt]), try - gen_statem:call(Pid, {rx_s6b_aar, Apn}) + gen_statem:call(Pid, {rx_s6b_aar, Apn, AgentInfoOpt}) catch exit:Err -> {error, Err} @@ -164,7 +164,7 @@ state_new({call, From}, {swm_auth_compl, Apn}, Data) -> lager:info("ue_fsm state_new event=swm_auth_compl, ~p~n", [Data]), - case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, 1, Apn) of + case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, 1, Apn, []) of ok -> {next_state, state_wait_swx_saa, Data, [{reply,From,ok}]}; {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} end. @@ -197,11 +197,11 @@ Data1 = Data#ue_fsm_data{epdg_sess_active = true}, {keep_state, Data1}; -state_authenticated({call, {Pid, _Tag} = From}, {rx_s6b_aar, Apn}, Data) -> - lager:info("ue_fsm state_authenticated event=rx_s6b_aar Apn=~p, ~p~n", [Apn, Data]), +state_authenticated({call, {Pid, _Tag} = From}, {rx_s6b_aar, Apn, AgentInfoOpt}, Data) -> + lager:info("ue_fsm state_authenticated event=rx_s6b_aar Apn=~p AgentInfo=~p, ~p~n", [Apn, AgentInfoOpt, Data]), case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, ?'DIAMETER_CX_SERVER-ASSIGNMENT-TYPE_PGW_UPDATE', - Apn) of + Apn, AgentInfoOpt) of ok -> Data1 = Data#ue_fsm_data{s6b_resp_pid = Pid, apn = Apn}, {next_state, state_authenticated_wait_swx_saa, Data1, [{reply,From,ok}]}; {error, Err} -> {keep_state, Data, [{reply,From,{error, Err}}]} @@ -220,7 +220,7 @@ {true, false} -> %% All sessions will now be gone, trigger SAR Type=USER_DEREGISTRATION case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, ?'DIAMETER_CX_SERVER-ASSIGNMENT-TYPE_USER_DEREGISTRATION', - Data#ue_fsm_data.apn) of + Data#ue_fsm_data.apn, []) of ok -> {next_state, state_authenticated_wait_swx_saa, Data, [{reply,From,ok}]}; {error, _Err} -> DiaRC = 5002, %% UNKNOWN_SESSION_ID @@ -241,7 +241,7 @@ {true, false} -> %% All sessions will now be gone, trigger SAR Type=USER_DEREGISTRATION case aaa_diameter_swx:server_assignment_request(Data#ue_fsm_data.imsi, ?'DIAMETER_CX_SERVER-ASSIGNMENT-TYPE_USER_DEREGISTRATION', - Data#ue_fsm_data.apn) of + Data#ue_fsm_data.apn, []) of ok -> Data1 = Data#ue_fsm_data{s6b_resp_pid = Pid}, {next_state, state_authenticated_wait_swx_saa, Data1, [{reply,From,ok}]}; {error, _Err} -> -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia99442487fef56c16c4be2fb7f36221d016e55e0 Gerrit-Change-Number: 36171 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: Forward PGW Address PGW->AAA->HSS

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email ) Change subject: Forward PGW Address PGW->AAA->HSS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia99442487fef56c16c4be2fb7f36221d016e55e0 Gerrit-Change-Number: 36171 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 12:40:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: Forward PGW Address HSS->AAA->ePDG

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36158?usp=email ) Change subject: Forward PGW Address HSS->AAA->ePDG ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83a68271ee6548e0e32fc9f0cab385bad5852388 Gerrit-Change-Number: 36158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 12:40:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: add testcases for M3UA-over-TCP

by pespin

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email ) Change subject: stp: add testcases for M3UA-over-TCP ...................................................................... Patch Set 4: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150/comment/02dcaccb_7894… PS4, Line 1229: f_sleep(1.0); > > Nagle should IMHO "obviously" be disabled for M3UA over TCP […] Ack, it can still happen without naggle. Can you please add a comment describing why that f_sleep is needed in the test code? (a summary like you wrote in the initial comment in this thread is fine). Otherwise we end up with sleep times which look kinda religious sometimes, with no explanation or rationale on why are they needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e2a887aa22f317783b3207494fd707d7b426439 Gerrit-Change-Number: 36150 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 12:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode

by pespin

Attention is currently required from: daniel, fixeria, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email ) Change subject: xua + ipa: Add support for I/O in OSMO_IO mode ...................................................................... Patch Set 8: (1 comment) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/64fcb402_8d5a567a PS8, Line 833: } > I think all the "msgb_length(msg) == 0" cases are just an ugly workaround for code that doesn't regi […] "@jolly is working on that" means a new patch version solving this regression will be submitted and hence this one must not be merged until then, correct? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369 Gerrit-Change-Number: 35070 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 12:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: Avoid propagating full diameter Swx MAA message to epdg gsup module

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36173?usp=email ) Change subject: Avoid propagating full diameter Swx MAA message to epdg gsup module ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I4a787649cf970fc08e32cfb27e846598515482ef Gerrit-Change-Number: 36173 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 11:19:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: Forward PGW Address PGW->AAA->HSS

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email ) Change subject: Forward PGW Address PGW->AAA->HSS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia99442487fef56c16c4be2fb7f36221d016e55e0 Gerrit-Change-Number: 36171 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 11:19:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024