March 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-epdg[master]: Forward PGW Address HSS->AAA->ePDG

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36158?usp=email ) Change subject: Forward PGW Address HSS->AAA->ePDG ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I83a68271ee6548e0e32fc9f0cab385bad5852388 Gerrit-Change-Number: 36158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 11:19:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: add testcases for M3UA-over-TCP

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email ) Change subject: stp: add testcases for M3UA-over-TCP ...................................................................... Patch Set 4: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150/comment/7faab9b4_f5be… PS4, Line 1229: f_sleep(1.0); > Nagle should IMHO "obviously" be disabled for M3UA over TCP Looking at the code, I see `osmo_stream_cli_set_nodelay(asp->client, true)` being called for both client and server ASP transport roles, regardless of the transport protocol (SCTP or TCP), so it should disabled for osmo-stp. But we do not seem to be disabling it in the testsuite: ``` $ git -C osmo-ttcn3-hacks/ grep -i NODELAY cbc/CBC_Tests.default:*.TCP.noDelay := "yes" // turn off nagle pcap-client/OPCAP_CLIENT_Tests.default:*.TCP.noDelay := "yes" // turn off nagle ``` And this matches what I am observing: the delay is present when the testsuite is sending data to osmo-stp, not vice versa. Even if we disable it in the testsuite, there is still a possibility of one message arriving earlier than the other because those are different sockets. As I said, it's not my own invention and I just copied `f_sleep(1.0)` from the existing code here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e2a887aa22f317783b3207494fd707d7b426439 Gerrit-Change-Number: 36150 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 11:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Workaround some apparent GCC aliasing bug ...

by tnt

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email ) Change subject: icE1usb fw: Workaround some apparent GCC aliasing bug ... ...................................................................... icE1usb fw: Workaround some apparent GCC aliasing bug ... If the code is built either : * without -flto * with -fno-strict-aliasing * with that struct as 'static' (so it's not on the stack) Then all works fine. But in the current situation (without the patch), GCC seems to think there is some aliasing and just plain removed the `notif.bits = 1` bit of code in that functions (no warnings printed ...). Putting the struct as 'static' is the least awful workaround. I didn't bother reporting bug upstream, because I can't reproduce on a small test case and I'm sure I'd just get yelled at and that the compiler is right for some reason ... Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: Ie0a2ce337ce4a9c08c3d27acc4d922a3e5892840 --- M firmware/ice40-riscv/icE1usb/usb_gps.c 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: tnt: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve manawyrm: Looks good to me, but someone else must approve diff --git a/firmware/ice40-riscv/icE1usb/usb_gps.c b/firmware/ice40-riscv/icE1usb/usb_gps.c index f2b09b4..e219cf8 100644 --- a/firmware/ice40-riscv/icE1usb/usb_gps.c +++ b/firmware/ice40-riscv/icE1usb/usb_gps.c @@ -143,7 +143,8 @@ if ((ep_regs->bd[0].csr & USB_BD_STATE_MSK) != USB_BD_STATE_RDY_DATA) { /* Default request */ - struct usb_cdc_notif_serial_state notif = { + /* Put as static to work around gcc aliasing bug ... */ + static struct usb_cdc_notif_serial_state notif = { .hdr = { .bmRequestType = USB_REQ_READ | USB_REQ_TYPE_CLASS | USB_REQ_RCPT_INTF, .bRequest = USB_NOTIF_CDC_SERIAL_STATE, -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie0a2ce337ce4a9c08c3d27acc4d922a3e5892840 Gerrit-Change-Number: 36175 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Workaround some apparent GCC aliasing bug ...

by tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email ) Change subject: icE1usb fw: Workaround some apparent GCC aliasing bug ... ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie0a2ce337ce4a9c08c3d27acc4d922a3e5892840 Gerrit-Change-Number: 36175 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 10:36:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: fix usb cdc notification struct attributes

by tnt

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36174?usp=email ) Change subject: icE1usb fw: fix usb cdc notification struct attributes ...................................................................... icE1usb fw: fix usb cdc notification struct attributes Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I7323c335c7cefe30446fb560b9381a3519b65f12 --- M firmware/ice40-riscv/icE1usb/usb_gps.c 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified tnt: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/firmware/ice40-riscv/icE1usb/usb_gps.c b/firmware/ice40-riscv/icE1usb/usb_gps.c index 7ca89fd..f2b09b4 100644 --- a/firmware/ice40-riscv/icE1usb/usb_gps.c +++ b/firmware/ice40-riscv/icE1usb/usb_gps.c @@ -49,7 +49,7 @@ struct usb_cdc_notif_serial_state { struct usb_ctrl_req hdr; uint16_t bits; -}; +} __attribute__((packed,aligned(4))); static void -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I7323c335c7cefe30446fb560b9381a3519b65f12 Gerrit-Change-Number: 36174 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: fix usb cdc notification struct attributes

by tnt

tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36174?usp=email ) Change subject: icE1usb fw: fix usb cdc notification struct attributes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I7323c335c7cefe30446fb560b9381a3519b65f12 Gerrit-Change-Number: 36174 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 10:36:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: stp: add testcases for M3UA-over-TCP

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email ) Change subject: stp: add testcases for M3UA-over-TCP ...................................................................... Patch Set 4: (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150/comment/7e7b038f_d8cc… PS4, Line 1229: f_sleep(1.0); > There is a chance that the random data sent via `ASP[idx_a]` would reach osmo-stp earlier than the `ASPUP_ACK` we sent for `ASP[idx_b]` -- this is what I was seeing when running `TC_m3ua_tcp_cli_srv`. In this test scenario only `ASP[idx_b]` is using TCP, and there is some delay likely caused by Nagle's algorithm. Nagle should IMHO "obviously" be disabled for M3UA over TCP. IF it is enabled, that's a bug. We're not talking about an interactive telnet session here, where we need to wait for more characters. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36150?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e2a887aa22f317783b3207494fd707d7b426439 Gerrit-Change-Number: 36150 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 10:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[L] Change in libosmo-sccp[master]: xua + ipa: Add support for I/O in OSMO_IO mode

by laforge

Attention is currently required from: daniel, fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email ) Change subject: xua + ipa: Add support for I/O in OSMO_IO mode ...................................................................... Patch Set 8: (3 comments) File src/osmo_ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/e9681e7a_cc2a5ede PS8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb); > So can you name any of them which is not TCP? which is using the exact same header approach used by […] I'm happy to rename it to xua_tcp_segemntation_cb, which is more in line with m3ua_tcp_* names in other places. As I don't want to clash with @jolly: Please rename it in your next patch update, jolly! https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/96bdbf4f_7cf1bc9d PS8, Line 663: osmo_stream_cli_set_read_cb2(asp->client, xua_cli_read_cb); > You probably need to do "osmo_stream_cli_set_segmentation_cb(asp->client, NULL);" here too? good catch. I didn't think of restart/reconfigure. https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/e6854f99_689a9cc0 PS8, Line 833: } > so how are we now calling osmo_stream_srv_destroy() once the socket is detected as closed? […] I think all the "msgb_length(msg) == 0" cases are just an ugly workaround for code that doesn't register a disconnect_cb. So let's do this properly with disconnect_cb, @jolly is working on that AFAICT. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369 Gerrit-Change-Number: 35070 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Mar 2024 10:31:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Workaround some apparent GCC aliasing bug ...

by manawyrm

Attention is currently required from: tnt. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email ) Change subject: icE1usb fw: Workaround some apparent GCC aliasing bug ... ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie0a2ce337ce4a9c08c3d27acc4d922a3e5892840 Gerrit-Change-Number: 36175 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 10:26:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-e1-hardware[master]: icE1usb fw: Workaround some apparent GCC aliasing bug ...

by laforge

Attention is currently required from: tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email ) Change subject: icE1usb fw: Workaround some apparent GCC aliasing bug ... ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/36175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: Ie0a2ce337ce4a9c08c3d27acc4d922a3e5892840 Gerrit-Change-Number: 36175 Gerrit-PatchSet: 1 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 10:26:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024