March 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-trx[master]: doc: Introduce documentation for osmo-trx-ipc and its IPC interface

by pespin

Attention is currently required from: Hoernchen, laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email ) Change subject: doc: Introduce documentation for osmo-trx-ipc and its IPC interface ...................................................................... Patch Set 2: (13 comments) File doc/manuals/chapters/ipc_if.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/991159a7_ebbfb5e5 PS2, Line 42: Once connected, _osmo-trx-ipc_ will submit a `GREETING_REQ` message primitive > (The whole description of the IPC messages could be done with mscgen and diag graphs, like we do in […] Yeah, it can be improved later on. It's not like the whole procedure is super complex anyway. https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/0de3cd0d_23702d30 PS2, Line 113: @closed@ > this gets printed literally as @closed@ in the pdf, I guess it should be monospace `closed` instead? I'll use __ since it's not some keyword in the code. https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/b85b8c1b_a259221b PS2, Line 116: TIP: See > Maybe move this TIP to the start of the section? Then the reader could open it next to this document […] I think it's fine having it at the end, otherwise I have the feeling you are redirecting too much the user when entering a section. But no strong opinion with it though. I think I'll leave it as it is for now. https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/158ec7df_3a7446fd PS2, Line 170: +w > missing space Ack https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/6448d3ca_9a33af92 PS2, Line 171: +w > missing space Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/09410d55_ee9996eb PS2, Line 223: `` > ` Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/e31b8e86_9516cc96 PS2, Line 226: `` > ` Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/4562aa55_9a5779ff PS2, Line 275: `N`` > ``` […] Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/bb215fba_824b5028 PS2, Line 283: . Read `buff->data_len` samples, reset the buffer data (`data_len=0``), : increment `next_read` and if read samples is `<N``, continue with next buffer : until `next_read==next_write``, then block again or if timeout elapsed, then we : reach conditon buffer underflow and `return len < N``. > ``` […] Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/65a6b0ab_d519c183 PS2, Line 290: `N`` > ``` […] Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/89c3ddc6_57c5798d PS2, Line 300: next_write was == next_read > is this written as intended, maybe "next_write prev" would be more clear? Done https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/c1e5c28b_c38e8858 PS2, Line 294: . Write samples to `buff = stream->buffers[next_write]`. If `data_len!=0``, : signal `buffer_overflow`` (increase field in stream object) and probably : increase next_read``. : : . Increase `next_write``. : : . If `next_write was == next_read``, signal the reader through the other : semaphore that it can continue reading. > ``` […] Done File doc/manuals/chapters/trx-backends.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/9edef49b_b30e69e2 PS2, Line 132: * Test and experiment with _osmo-trx-ipc_. : * Write your own IPC _Driver_ connecting to osmo-trx-ipc. > these do not show up as bullet points in the pdf Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id6863731f9398720030b16efaaf559e05f2444ed Gerrit-Change-Number: 36465 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:35:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

3 months

1
0
0 0

[L] Change in osmo-mgw[master]: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io

by pespin

Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email ) Change subject: Convert RTP/RTCP/OSMUX I/O from osmo_fd to osmo_io ...................................................................... Patch Set 4: (6 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/afaf69e5_1474aeb2 PS4, Line 797: void forward_data_tap(struct osmo_io_fd *iofd, struct mgcp_rtp_tap *tap, struct msgb *msg) we can probably constify "msg" in a followup patch here, it would help understand it's being copied and not owned by the function. https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/506d7a95_53ade661 PS4, Line 1047: * \param[in] msg message buffer that holds the data to be send. Please document here: """" * If the function returns success (0), it will take ownership of the msgb and * internally call msgb_free() after the sendto request completes. * In case of an error the msgb needs to be freed by the caller. """" https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/e7790112_b6d99ca9 PS4, Line 1520: .from_addr = (struct osmo_sockaddr *) saddr, I odn't see why the cast is needed here? saddr is already that type. https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/e203edfd_d8e4c80b PS4, Line 1696: if ((end->rtp && osmo_iofd_get_fd(end->rtp) != -1) || You can probably skip the "osmo_iofd_get_fd(end->rtp) != -1" check here, or otherwise make sure you free end->rtp before reassigning it below. Same for RTCP. I don't expect this to be a problem when running, but from a casual reader may look suspicious otherwise. File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/e4d9cea0_8228b325 PS4, Line 526: goto out_free_v4; you may be missing an "osmo_iofd_unregister()" in the section you are going with goto here. Or does osmo_iofd_free() include some sort of unregistering? You are also probably missing close() of ipv4 fd? File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/c/osmo-mgw/+/36363/comment/915e2d65_cccb2977 PS4, Line 661: uint8_t *buf = msgb_data(msg); const -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36363?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8471960d5d8088a70cf105f2f40dfa5d5458169a Gerrit-Change-Number: 36363 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:27:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: fix MGCP_Test.TC_one_crcx_loopback_rtp_implicit expectations

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36466?usp=email ) Change subject: fix MGCP_Test.TC_one_crcx_loopback_rtp_implicit expectations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe2ee59d1ed2c25ffef7e8534c172ac190b4983d Gerrit-Change-Number: 36466 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 12:05:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-iuh[master]: constify {hnbap_rua}_cause_str() argument

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36473?usp=email ) Change subject: constify {hnbap_rua}_cause_str() argument ...................................................................... constify {hnbap_rua}_cause_str() argument ranap_cause_str() already had a const input argument, but the HNBAP and RUA equivalents for some reason had a non-const input. Change-Id: I7db92b51847c282d23d568970dfd2bedecdea486 --- M include/osmocom/hnbap/hnbap_common.h M include/osmocom/rua/rua_common.h M src/hnbap_common.c M src/rua_common.c 4 files changed, 16 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/73/36473/1 diff --git a/include/osmocom/hnbap/hnbap_common.h b/include/osmocom/hnbap/hnbap_common.h index af619e2..75981d9 100644 --- a/include/osmocom/hnbap/hnbap_common.h +++ b/include/osmocom/hnbap/hnbap_common.h @@ -149,6 +149,6 @@ HNBAP_IE_t *hnbap_new_ie(HNBAP_ProtocolIE_ID_t id, HNBAP_Criticality_t criticality, asn_TYPE_descriptor_t *type, void *sptr); -char *hnbap_cause_str(HNBAP_Cause_t *cause); +char *hnbap_cause_str(const HNBAP_Cause_t *cause); void hnbap_set_log_area(int log_area); diff --git a/include/osmocom/rua/rua_common.h b/include/osmocom/rua/rua_common.h index 7967c91..a88c9a2 100644 --- a/include/osmocom/rua/rua_common.h +++ b/include/osmocom/rua/rua_common.h @@ -69,6 +69,6 @@ RUA_IE_t *rua_new_ie(RUA_ProtocolIE_ID_t id, RUA_Criticality_t criticality, asn_TYPE_descriptor_t *type, void *sptr); -char *rua_cause_str(RUA_Cause_t *cause); +char *rua_cause_str(const RUA_Cause_t *cause); void rua_set_log_area(int log_area); diff --git a/src/hnbap_common.c b/src/hnbap_common.c index 67cc30c..10a29fa 100644 --- a/src/hnbap_common.c +++ b/src/hnbap_common.c @@ -78,7 +78,7 @@ { 0, NULL } }; -char *hnbap_cause_str(HNBAP_Cause_t *cause) +char *hnbap_cause_str(const HNBAP_Cause_t *cause) { static char buf[32]; diff --git a/src/rua_common.c b/src/rua_common.c index 37cf3ba..0cb8426 100644 --- a/src/rua_common.c +++ b/src/rua_common.c @@ -67,7 +67,7 @@ { 0, NULL } }; -char *rua_cause_str(RUA_Cause_t *cause) +char *rua_cause_str(const RUA_Cause_t *cause) { static char buf[32]; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36473?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7db92b51847c282d23d568970dfd2bedecdea486 Gerrit-Change-Number: 36473 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: use as_expect_clear() in f_tc_mt_t310()

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36472?usp=email ) Change subject: msc: use as_expect_clear() in f_tc_mt_t310() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8185153502d31163fcb4c718690ee0f1cc912f5b Gerrit-Change-Number: 36472 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 10:00:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix f_tc_mt_crcx_ran_reject(): properly handle Iu-ReleaseCommand

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36470?usp=email ) Change subject: msc: fix f_tc_mt_crcx_ran_reject(): properly handle Iu-ReleaseCommand ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd679bbf720a56a76cf37ab414b1e6d90e53278b Gerrit-Change-Number: 36470 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 10:00:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: as_{iu_release,clear_cmd}_compl_disc: remove no-op timer arguments

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36471?usp=email ) Change subject: msc: as_{iu_release,clear_cmd}_compl_disc: remove no-op timer arguments ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d3dcf4399dccd353702e4d6c53fe8e26e16ea9b Gerrit-Change-Number: 36471 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 09:58:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix missing 'repeat' in as_optional_cc_rel()

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36469?usp=email ) Change subject: msc: fix missing 'repeat' in as_optional_cc_rel() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0143b4d33b1ebe4cce99c09018540524c4626eec Gerrit-Change-Number: 36469 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 09:57:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: fix f_tc_ho_inter_bsc0(): properly patch n_sd

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36467?usp=email ) Change subject: msc: fix f_tc_ho_inter_bsc0(): properly patch n_sd ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iddde391eade716ca5c6c48cb631450ddb543e0d4 Gerrit-Change-Number: 36467 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 09:57:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix f_tc_mt_crcx_ran_reject(): properly handle Iu-ReleaseCommand

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36470?usp=email ) Change subject: msc: fix f_tc_mt_crcx_ran_reject(): properly handle Iu-ReleaseCommand ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd679bbf720a56a76cf37ab414b1e6d90e53278b Gerrit-Change-Number: 36470 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 27 Mar 2024 09:56:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 months

1
0
0 0

2024

2023

2022

gerrit-log March 2024