March 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: msc: as_{iu_release,clear_cmd}_compl_disc: remove no-op timer arguments

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36471?usp=email ) Change subject: msc: as_{iu_release,clear_cmd}_compl_disc: remove no-op timer arguments ...................................................................... msc: as_{iu_release,clear_cmd}_compl_disc: remove no-op timer arguments Change-Id: I1d3dcf4399dccd353702e4d6c53fe8e26e16ea9b --- M library/RAN_Emulation.ttcnpp M msc/BSC_ConnectionHandler.ttcn 2 files changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/36471/1 diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index 25727f3..5b2f190 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -1552,7 +1552,7 @@ #ifdef RAN_EMULATION_RANAP /* expect a IuReleaseCommand; Confirm that; expect SCCP-level N-DISCONNET.ind */ -altstep as_iu_release_compl_disc(float t := 5.0) runs on RAN_ConnHdlr { +altstep as_iu_release_compl_disc() runs on RAN_ConnHdlr { var RANAP_PDU ranap; [] BSSAP.receive(tr_RANAP_IuReleaseCommand(?)) { BSSAP.send(ts_RANAP_IuReleaseComplete); diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index b3d915c..0a30114 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1967,7 +1967,7 @@ } /* expect a clear command */ -altstep as_clear_cmd_compl_disc(float t := 5.0) runs on BSC_ConnHdlr { +altstep as_clear_cmd_compl_disc() runs on BSC_ConnHdlr { var PDU_BSSAP bssap; [] BSSAP.receive(tr_BSSMAP_ClearCommand) { BSSAP.send(ts_BSSMAP_ClearComplete); @@ -1992,8 +1992,8 @@ T.start; alt { - [g_pars.ran_is_geran] as_clear_cmd_compl_disc(t) { } - [not g_pars.ran_is_geran] as_iu_release_compl_disc(t) { } + [g_pars.ran_is_geran] as_clear_cmd_compl_disc() { } + [not g_pars.ran_is_geran] as_iu_release_compl_disc() { } [] T.timeout { setverdict(fail, "Timeout waiting for ClearCommand/Release"); mtc.stop; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1d3dcf4399dccd353702e4d6c53fe8e26e16ea9b Gerrit-Change-Number: 36471 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: cosmetic: fix formatting in altsteps

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36468?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: msc: cosmetic: fix formatting in altsteps ...................................................................... msc: cosmetic: fix formatting in altsteps Change-Id: I14afa9aa076396d48043000e350885384bde4c81 --- M msc/MSC_Tests.ttcn 1 file changed, 27 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/36468/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I14afa9aa076396d48043000e350885384bde4c81 Gerrit-Change-Number: 36468 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: use as_expect_clear() in f_tc_mt_t310()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36472?usp=email ) Change subject: msc: use as_expect_clear() in f_tc_mt_t310() ...................................................................... msc: use as_expect_clear() in f_tc_mt_t310() This testcase is not Iu-compatible yet, but let's make life a bit easier for those trying to make it such in the future. Change-Id: I8185153502d31163fcb4c718690ee0f1cc912f5b --- M msc/MSC_Tests.ttcn 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/36472/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 101d632..52a5c2f 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1850,7 +1850,7 @@ // FIXME: f_create_mgcp_delete_ep(cpars.mgcp_ep); repeat; } - [] as_clear_cmd_compl_disc(); + [] as_expect_clear() { setverdict(pass); } } } testcase TC_mt_t310() runs on MTC_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36472?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8185153502d31163fcb4c718690ee0f1cc912f5b Gerrit-Change-Number: 36472 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 months

1
0
0 0

[L] Change in osmo-trx[master]: doc: Introduce documentation for osmo-trx-ipc and its IPC interface

by osmith

Attention is currently required from: Hoernchen, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email ) Change subject: doc: Introduce documentation for osmo-trx-ipc and its IPC interface ...................................................................... Patch Set 2: (1 comment) File doc/manuals/chapters/ipc_if.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/308fd2b6_de81aac9 PS2, Line 42: Once connected, _osmo-trx-ipc_ will submit a `GREETING_REQ` message primitive (The whole description of the IPC messages could be done with mscgen and diag graphs, like we do in e.g. the GSUP manuals: https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-manuals/src/bran… - IMHO this would make them more similar to other spec files we work with and easier to read... but doing this here would probably be a lot of effort, so feel free to ignore.) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id6863731f9398720030b16efaaf559e05f2444ed Gerrit-Change-Number: 36465 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 09:52:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 months

1
0
0 0

[L] Change in osmo-trx[master]: doc: Introduce documentation for osmo-trx-ipc and its IPC interface

by osmith

Attention is currently required from: Hoernchen, laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email ) Change subject: doc: Introduce documentation for osmo-trx-ipc and its IPC interface ...................................................................... Patch Set 2: (12 comments) File doc/manuals/chapters/ipc_if.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/8e60ad46_b2a8d957 PS2, Line 113: @closed@ this gets printed literally as @closed@ in the pdf, I guess it should be monospace `closed` instead? https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/d2f21c39_a475f018 PS2, Line 116: TIP: See Maybe move this TIP to the start of the section? Then the reader could open it next to this document and look at e.g. "struct ipc_sk_if_greeting" while reading about it in this document. Same with the TIP for "Channel UD Socket". Same with the TIP for "Posix Shared Memory format". https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/003938c4_096b439a PS2, Line 170: +w missing space https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/a7b6efc7_ef7b8b3f PS2, Line 171: +w missing space https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/1a2b098d_51991324 PS2, Line 223: `` ` https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/d1ab9b2d_c364de6e PS2, Line 226: `` ` https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/88257270_caa80d26 PS2, Line 275: `N`` ``` `N` ``` https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/e209df9d_f0402fbb PS2, Line 283: . Read `buff->data_len` samples, reset the buffer data (`data_len=0``), : increment `next_read` and if read samples is `<N``, continue with next buffer : until `next_read==next_write``, then block again or if timeout elapsed, then we : reach conditon buffer underflow and `return len < N``. ``` s/``/`/g ``` https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/8c856724_5d6ef8f3 PS2, Line 290: `N`` ``` `N` ``` https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/bea6bad5_6441c023 PS2, Line 300: next_write was == next_read is this written as intended, maybe "next_write prev" would be more clear? https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/e641b6fa_9730cfdb PS2, Line 294: . Write samples to `buff = stream->buffers[next_write]`. If `data_len!=0``, : signal `buffer_overflow`` (increase field in stream object) and probably : increase next_read``. : : . Increase `next_write``. : : . If `next_write was == next_read``, signal the reader through the other : semaphore that it can continue reading. ``` s/``/`/g ``` File doc/manuals/chapters/trx-backends.adoc: https://gerrit.osmocom.org/c/osmo-trx/+/36465/comment/89812ae4_90b029bb PS2, Line 132: * Test and experiment with _osmo-trx-ipc_. : * Write your own IPC _Driver_ connecting to osmo-trx-ipc. these do not show up as bullet points in the pdf -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/36465?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id6863731f9398720030b16efaaf559e05f2444ed Gerrit-Change-Number: 36465 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 09:47:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix as_clear_cmd_compl_disc(): make it Iu-compatible

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36470?usp=email ) Change subject: msc: fix as_clear_cmd_compl_disc(): make it Iu-compatible ...................................................................... msc: fix as_clear_cmd_compl_disc(): make it Iu-compatible Previous commit [1] uncovers a problem in as_clear_cmd_compl_disc(): this altstep is expecting BSSMAP Clear Command, which is specific to the A-interface (GERAN). In TC_iu_mt_crcx_ran_reject though, we receive RANAP Iu-ReleaseCommand, which is specific to the Iu- interface (UTRAN), but not handled in this altstep. The testcase was passing so far due to a bug in as_optional_cc_rel(), which would unblock the alt-statemtnt on receipt of CC RELEASE, so that we would never respond to RANAP Iu-ReleaseCommand. Modify it to handle RANAP Iu-ReleaseCommand in addition to the BSSMAP Clear Command. Take a change to remove the np-op argument. Change-Id: Idd679bbf720a56a76cf37ab414b1e6d90e53278b Related: [1] I0143b4d33b1ebe4cce99c09018540524c4626eec --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/36470/1 diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index b3d915c..d10e2af 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1967,19 +1967,18 @@ } /* expect a clear command */ -altstep as_clear_cmd_compl_disc(float t := 5.0) runs on BSC_ConnHdlr { +altstep as_clear_cmd_compl_disc() runs on BSC_ConnHdlr { var PDU_BSSAP bssap; - [] BSSAP.receive(tr_BSSMAP_ClearCommand) { + + [g_pars.ran_is_geran] BSSAP.receive(tr_BSSMAP_ClearCommand) { BSSAP.send(ts_BSSMAP_ClearComplete); - alt { - [] BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_IND) { - setverdict(pass); - } - [] BSSAP.receive { - setverdict(fail, "Unexpected BSSMAP while waiting for SCCP Release"); - mtc.stop; - } + BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_IND); + setverdict(pass); } + [not g_pars.ran_is_geran] BSSAP.receive(tr_RANAP_IuReleaseCommand(?)) { + BSSAP.send(ts_RANAP_IuReleaseComplete); + BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_DISC_IND); + setverdict(pass); } [] BSSAP.receive(tr_BSSAP_BSSMAP) -> value bssap { setverdict(fail, "Unexpected BSSMAP while waiting for ClearCommand", bssap); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36470?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd679bbf720a56a76cf37ab414b1e6d90e53278b Gerrit-Change-Number: 36470 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix missing 'repeat' in as_optional_cc_rel()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36469?usp=email ) Change subject: msc: fix missing 'repeat' in as_optional_cc_rel() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0143b4d33b1ebe4cce99c09018540524c4626eec Gerrit-Change-Number: 36469 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 08:35:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: cosmetic: fix formatting in altsteps

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36468?usp=email ) Change subject: msc: cosmetic: fix formatting in altsteps ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I14afa9aa076396d48043000e350885384bde4c81 Gerrit-Change-Number: 36468 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 08:34:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: fix f_tc_ho_inter_bsc0(): properly patch n_sd

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36467?usp=email ) Change subject: msc: fix f_tc_ho_inter_bsc0(): properly patch n_sd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iddde391eade716ca5c6c48cb631450ddb543e0d4 Gerrit-Change-Number: 36467 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 27 Mar 2024 08:34:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: fix missing 'repeat' in as_optional_cc_rel()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36469?usp=email ) Change subject: msc: fix missing 'repeat' in as_optional_cc_rel() ...................................................................... msc: fix missing 'repeat' in as_optional_cc_rel() We do activate() this altstep in several testcases, so that it's kinda "running in background". In reality, the defaults in TTCN-3 are just a syntax suggar, and the following code: ``` var default foo := activate(as_foo_bar()); alt { [] PORT1.receive(tr_Msg1) { repeat; } [] PORT1.receive(tr_Msg2) { setverdict(pass); } } PORT2.receive(tr_Msg3); ``` actually evaluates to: ``` alt { [] PORT1.receive(tr_Msg1) { repeat; } [] PORT1.receive(tr_Msg2) { setverdict(pass); } [] as_foo_bar(); } alt { [] PORT2.receive(tr_Msg3); [] as_foo_bar(); } ``` If as_foo_bar() contains no 'repeat' statement, then whenever it triggers it would efficiently cancel (unblock) the current alt statement, resulting in weird behavior due to messages not being dequeued from ports as expected. And this is exactly what we saw happening in OS#6414. Change-Id: I0143b4d33b1ebe4cce99c09018540524c4626eec Related: OS#6414 --- M msc/MSC_Tests.ttcn 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/36469/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 2b5af7c..7e8f467 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -187,6 +187,7 @@ } BSSAP.send(ts_PDU_DTAP_MO(ts_ML3_MO_CC_REL_COMPL(cpars.transaction_id, tid_remote))); } + repeat; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36469?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0143b4d33b1ebe4cce99c09018540524c4626eec Gerrit-Change-Number: 36469 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 months

1
0
0 0

2024

2023

2022

gerrit-log March 2024