March 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-epdg[master]: Propagate SWx PPR as S6b Re-Auth-Request
by pespin 16 Mar '24

16 Mar '24

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36308?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Propagate SWx PPR as S6b Re-Auth-Request ...................................................................... Propagate SWx PPR as S6b Re-Auth-Request This commit implements the 3GPP TS 29.273 section 9.1.2.5 "Service Authorization Information Update Procedures". Related: OS#6400 Change-Id: I0e263dae37d5b8b3cdce2014787eb82910ed686a --- M src/aaa_diameter_s6b.erl M src/aaa_diameter_s6b_cb.erl M src/aaa_ue_fsm.erl 3 files changed, 96 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/08/36308/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I0e263dae37d5b8b3cdce2014787eb82910ed686a Gerrit-Change-Number: 36308 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
by laforge 16 Mar '24

16 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email ) Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend' ...................................................................... manual: 'Running': tweak, mention 'tunmap' and 'tunend' Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27 --- M doc/manuals/chapters/running.adoc 1 file changed, 18 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc index 683c444..009ec16 100644 --- a/doc/manuals/chapters/running.adoc +++ b/doc/manuals/chapters/running.adoc @@ -85,11 +85,11 @@ OsmoUPF uses two distinct Linux kernel features: -* The GTP module is used for GTP encapsulation/decapsulation from/to +* The GTP module is used for `tunend`: GTP encapsulation/decapsulation from/to "the internet". -* The netfilter module is used for GTP tunnel proxying, also known as - tunnel forwarding or tunnel mapping. +* The netfilter framework and nftables is used for `tunmap`: GTP tunnel proxying, + also known as tunnel forwarding or tunnel mapping. .Linux kernel feature usage [graphviz] @@ -97,8 +97,12 @@ include::upf_gtp_roles.dot[] ---- -GTP kernel module configuration can be omitted for sites that serve only as GTP -forwarding proxy, without encapsulation/decapsulation of GTP payloads. +GTP kernel module configuration in the `tunend` section can be omitted for sites +that serve only as GTP forwarding proxy, without encapsulation/decapsulation of +GTP payloads. + +Likewise, netfilter configuration in the `tunmap` section can be omitted for +sites only serving as GTP tunnel endpoint. [[gtp_module]] === Configure Linux Kernel GTP Module for `tunend` -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27 Gerrit-Change-Number: 35666 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
by laforge 16 Mar '24

16 Mar '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email ) Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend' ...................................................................... Patch Set 2: Verified+1 (1 comment) File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/35666/comment/86f6d8dd_623533e6 PS1, Line 91: The netfilter module > Unrelated, FYI, netfilter is not actually a module. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27 Gerrit-Change-Number: 35666 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: Makefile.am: Remove $(SOURCES) which is not defined anywhere
by fixeria 16 Mar '24

16 Mar '24

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36313?usp=email ) Change subject: Makefile.am: Remove $(SOURCES) which is not defined anywhere ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I44ce77c937fa461445800bab393025f948077d55 Gerrit-Change-Number: 36313 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:17:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'
by laforge 16 Mar '24

16 Mar '24

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email ) Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27 Gerrit-Change-Number: 35666 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:17:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: Makefile.am: Remove $(SOURCES) which is not defined anywhere
by pespin 16 Mar '24

16 Mar '24

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36313?usp=email ) Change subject: Makefile.am: Remove $(SOURCES) which is not defined anywhere ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I44ce77c937fa461445800bab393025f948077d55 Gerrit-Change-Number: 36313 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:16:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-netif[master]: Ensure osmo_stream_{cli,srv}_recv() is used only in osmo_fd mode
by laforge 16 Mar '24

16 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36293?usp=email ) Change subject: Ensure osmo_stream_{cli,srv}_recv() is used only in osmo_fd mode ...................................................................... Ensure osmo_stream_{cli,srv}_recv() is used only in osmo_fd mode The osmo_stream_{cli,srv}_recv() is only for osmo_fd mode users; in case osmo_io mode is used, the read_cb is called with pre-filled message buffers; no need to recv/read directly anymore. Change-Id: Ie96cf1241b2ba4e0a7dda584182d18cad2b4f061 --- M src/stream_cli.c M src/stream_srv.c 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/stream_cli.c b/src/stream_cli.c index 9c3f65a..f19bf98 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -1054,6 +1054,7 @@ int ret; OSMO_ASSERT(cli); OSMO_ASSERT(msg); + OSMO_ASSERT(cli->mode == OSMO_STREAM_MODE_OSMO_FD); switch (cli->sk_domain) { case AF_UNIX: diff --git a/src/stream_srv.c b/src/stream_srv.c index 58ed7ef..b53caab 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -1073,6 +1073,7 @@ int ret; OSMO_ASSERT(conn); OSMO_ASSERT(msg); + OSMO_ASSERT(conn->mode == OSMO_STREAM_MODE_OSMO_FD); switch (conn->srv->sk_domain) { case AF_UNIX: -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36293?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie96cf1241b2ba4e0a7dda584182d18cad2b4f061 Gerrit-Change-Number: 36293 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-netif[master]: docs: Don't export documentation about static (internal) functions
by laforge 16 Mar '24

16 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36292?usp=email ) Change subject: docs: Don't export documentation about static (internal) functions ...................................................................... docs: Don't export documentation about static (internal) functions The generated API documentation should be relevant to the API user, and hence only non-static/public functions are relevant Change-Id: I6fee052ad22877db85fe3207c7eac950d875873b --- M Doxyfile.in 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/Doxyfile.in b/Doxyfile.in index a7fe3ad..001a085 100644 --- a/Doxyfile.in +++ b/Doxyfile.in @@ -328,7 +328,7 @@ # If the EXTRACT_STATIC tag is set to YES all static members of a file # will be included in the documentation. -EXTRACT_STATIC = YES +EXTRACT_STATIC = NO # If the EXTRACT_LOCAL_CLASSES tag is set to YES classes (and structs) # defined locally in source files will be included in the documentation. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36292?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6fee052ad22877db85fe3207c7eac950d875873b Gerrit-Change-Number: 36292 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-netif[master]: docs: Enable AUTOBRIEF feauture in doxygen
by laforge 16 Mar '24

16 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36290?usp=email ) Change subject: docs: Enable AUTOBRIEF feauture in doxygen ...................................................................... docs: Enable AUTOBRIEF feauture in doxygen We have that enabled in libosmcore.git for ages, somehow we missed it here, resulting in missing 'brief' descriptions in the output. Change-Id: I751036baa9a2b30d94a2a302c7072a5487d2c26e --- M Doxyfile.in 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/Doxyfile.in b/Doxyfile.in index 3843f79..a7fe3ad 100644 --- a/Doxyfile.in +++ b/Doxyfile.in @@ -150,7 +150,7 @@ # comments will behave just like regular Qt-style comments # (thus requiring an explicit @brief command for a brief description.) -JAVADOC_AUTOBRIEF = NO +JAVADOC_AUTOBRIEF = YES # If the QT_AUTOBRIEF tag is set to YES then Doxygen will # interpret the first line (until the first dot) of a Qt-style @@ -158,7 +158,7 @@ # will behave just like regular Qt-style comments (thus requiring # an explicit \brief command for a brief description.) -QT_AUTOBRIEF = NO +QT_AUTOBRIEF = YES # The MULTILINE_CPP_IS_BRIEF tag can be set to YES to make Doxygen # treat a multi-line C++ special comment block (i.e. a block of //! or /// -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36290?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I751036baa9a2b30d94a2a302c7072a5487d2c26e Gerrit-Change-Number: 36290 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in libosmo-netif[master]: docs: Use \defgroup and avoid repeated boilerplate text
by laforge 16 Mar '24

16 Mar '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email ) Change subject: docs: Use \defgroup and avoid repeated boilerplate text ...................................................................... docs: Use \defgroup and avoid repeated boilerplate text Change-Id: I1196c3b035f495c5dbaa4d47ce3f79a08d0727f2 --- M include/osmocom/netif/stream.h M src/stream.c M src/stream_cli.c M src/stream_srv.c 4 files changed, 20 insertions(+), 17 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index fe4dd77..96633d6 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -6,8 +6,15 @@ #include <osmocom/core/msgb.h> -/*! \addtogroup stream +/*! \defgroup stream Osmocom Stream Server/Client * @{ + * + * This code is intended to abstract any use of stream-type sockets, + * such as TCP and SCTP. It offers both server and client side + * implementations, fully integrated with the libosmocore select loop + * abstraction. + * + * \file stream.h */ /*! \brief Access SCTP flags from the msgb control buffer */ diff --git a/src/stream.c b/src/stream.c index f4755e0..60a7623 100644 --- a/src/stream.c +++ b/src/stream.c @@ -52,13 +52,8 @@ #include <osmocom/netif/sctp.h> -/*! \addtogroup stream Osmocom Stream Socket +/*! \addtogroup stream * @{ - * - * This code is intended to abstract any use of stream-type sockets, - * such as TCP and SCTP. It offers both server and client side - * implementations, fully integrated with the libosmocore select loop - * abstraction. */ /*! \file stream.c diff --git a/src/stream_cli.c b/src/stream_cli.c index 46ddc89..9c3f65a 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -52,12 +52,8 @@ #include <osmocom/netif/sctp.h> -/*! \addtogroup stream Osmocom Stream Socket (client side) +/*! \addtogroup stream * @{ - * - * This code is intended to abstract any use of stream-type sockets, - * such as TCP and SCTP. It offers client side implementation, - * fully integrated with the libosmocore select loop abstraction. */ /*! \file stream_cli.c diff --git a/src/stream_srv.c b/src/stream_srv.c index da49bad..58ed7ef 100644 --- a/src/stream_srv.c +++ b/src/stream_srv.c @@ -53,12 +53,8 @@ #include <osmocom/netif/sctp.h> -/*! \addtogroup stream Osmocom Stream Socket (server side) +/*! \addtogroup stream * @{ - * - * This code is intended to abstract any use of stream-type sockets, - * such as TCP and SCTP. It offers server side implementation, - * fully integrated with the libosmocore select loop abstraction. */ /*! \file stream_srv.c -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36291?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I1196c3b035f495c5dbaa4d47ce3f79a08d0727f2 Gerrit-Change-Number: 36291 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

2026

2025

2024

2023

2022

gerrit-log March 2024