March 2024 - gerrit-log - lists.osmocom.org

[L] Change in libosmocore[master]: osmo_io: Massive improvement of API documentation

by laforge

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email ) Change subject: osmo_io: Massive improvement of API documentation ...................................................................... Patch Set 4: (2 comments) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/b4e4048a_be564241 PS3, Line 51: relate > related Done https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/2f36cbca_2a51bc80 PS3, Line 156: msgb > `msg` Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c Gerrit-Change-Number: 36288 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:32:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[L] Change in libosmocore[master]: osmo_io: Massive improvement of API documentation

by laforge

Attention is currently required from: fixeria, jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email ) Change subject: osmo_io: Massive improvement of API documentation ...................................................................... Patch Set 3: (4 comments) File include/osmocom/core/osmo_io.h: https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/83314b08_cb49e818 PS3, Line 100: msgb > `msg`, not `msgb` Done https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/d601fc8f_a0dbbb91 PS3, Line 132: msgb > `msg` Done https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/c0d489a6_f7cddb93 PS3, Line 158: msgh > no such param? recvmsg_cb has a 'msgh' parameter! https://gerrit.osmocom.org/c/libosmocore/+/36288/comment/aef250d9_b707db65 PS3, Line 168: msgh > no such param? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c Gerrit-Change-Number: 36288 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:32:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[L] Change in libosmocore[master]: osmo_io: Massive improvement of API documentation

by laforge

Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, jolly, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: osmo_io: Massive improvement of API documentation ...................................................................... osmo_io: Massive improvement of API documentation * introduce a new "Osmocom I/O interface" group to show up in API docs * expand the documentation to turn it into something useful for somebody wanting to write an application using it. Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c --- M include/osmocom/core/osmo_io.h M src/core/osmo_io.c 2 files changed, 235 insertions(+), 52 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/36288/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36288?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6315cfc7ff34a0f8971517edf035e1efcef3ed5c Gerrit-Change-Number: 36288 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Dont use __linux__ but !EMBEDDED

by laforge

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: osmo_io: Dont use __linux__ but !EMBEDDED ...................................................................... osmo_io: Dont use __linux__ but !EMBEDDED osmo_io (unlike its io_uring backend) is not linux specific, so putting it in an "#ifdef __linux__" block is plain wrong. A side-effect is that all our doxygen comments are not processed as __linux__ is not set while doxygen parses the source file. Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8 --- M src/core/osmo_io.c M src/core/osmo_io_poll.c 2 files changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/36287/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8 Gerrit-Change-Number: 36287 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[M] Change in osmo-upf[master]: manual: explain GTP Echo workaround for tunmap

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email ) Change subject: manual: explain GTP Echo workaround for tunmap ...................................................................... Patch Set 1: -Code-Review (4 comments) Patchset: PS1: > I would remove the entire "tunend can be removed for forwarding-only" section. It's misleading. […] I'm not sure what exactly I was reading / referring to at the time. Let's ignore this comment, please. File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/2d7ddd38_fd25f593 PS1, Line 172: netfilter it s a nftables or nft table. "netfilter" is a set of kernel hooks in the network stack that have no tables. various packet filtering techniques (iptables, arptables, ip6tables and last nftables) are packet filter ruleset engines that have tables. https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/053a0cf7_e239e8ff PS1, Line 177: GTP peer is that "GTP peer" a term in the specification? The term I have in memory is "GSN", but that's probably too old-fashioned as it is from the 2G/3G days where we had SGSN/GGSN. I'm worried about "peer" here being interprete as "the remote peer". But we're actually talking about our local UPF node, not a remote peer. https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/44e0c63a_8208db06 PS1, Line 212: netfilter nft / nftables table -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic824fc876d1fad181254cb6894e51464c443b53c Gerrit-Change-Number: 35667 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: docs: Don't export internal structs declared in src files

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36296?usp=email ) Change subject: docs: Don't export internal structs declared in src files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36296?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5db8ce90c1e1e393195c9a146ba617ab980a9390 Gerrit-Change-Number: 36296 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:20:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in libosmo-netif[master]: docs: Split Stream Server and Stream Client into separate groups

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36297?usp=email ) Change subject: docs: Split Stream Server and Stream Client into separate groups ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9e037fedaecb78396f435577b1652284b4951ded Gerrit-Change-Number: 36297 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:20:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: TC_hss_initiated_update_user_profile: test SWx PPR -> S6b RAR p...

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36307?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: epdg: TC_hss_initiated_update_user_profile: test SWx PPR -> S6b RAR propagation ...................................................................... epdg: TC_hss_initiated_update_user_profile: test SWx PPR -> S6b RAR propagation Related: OS#6400 Change-Id: I064ee9e18809a507d0185f640b4a972ee5a2ce3f --- M epdg/EPDG_Tests.ttcn M library/DIAMETER_Templates.ttcn M library/DIAMETER_ts29_273_Templates.ttcn 3 files changed, 125 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/07/36307/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I064ee9e18809a507d0185f640b4a972ee5a2ce3f Gerrit-Change-Number: 36307 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

[S] Change in libosmo-netif[master]: docs: jibuf: Prevent internal #defines being documented

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36298?usp=email ) Change subject: docs: jibuf: Prevent internal #defines being documented ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic3c6e32acb52595875de89f6054a62d9565747f9 Gerrit-Change-Number: 36298 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:19:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in osmo-upf[master]: manual: 'Running': tweak, mention 'tunmap' and 'tunend'

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email ) Change subject: manual: 'Running': tweak, mention 'tunmap' and 'tunend' ...................................................................... Patch Set 2: (1 comment) File doc/manuals/chapters/running.adoc: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15168): https://gerrit.osmocom.org/c/osmo-upf/+/35666/comment/a197aeb0_786a5dfb PS2, Line 91: * The netfilter framework and nftables is used for `tunmap`: GTP tunnel proxying, trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I9760ca214933d0b05080a3e70807b0cd06380a27 Gerrit-Change-Number: 35666 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:18:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024