Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email )
Change subject: osmo-bts-virtual: Port over to osmo_io
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-bts-virtual/osmo_mcast_sock.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-15182):
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/acf4374a_e8b4bd72
PS1, Line 30: mcast_server_sock_setup(void *ctx, const char* tx_mcast_group, uint16_t tx_mcast_port, bool loopback)
"foo* bar" should be "foo *bar"
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c
Gerrit-Change-Number: 36317
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 16 Mar 2024 18:07:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36313?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: Makefile.am: Remove $(SOURCES) which is not defined anywhere
......................................................................
Makefile.am: Remove $(SOURCES) which is not defined anywhere
Change-Id: I44ce77c937fa461445800bab393025f948077d55
---
M Makefile.am
1 file changed, 10 insertions(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/Makefile.am b/Makefile.am
index 3e119b2..f50cd0f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -30,7 +30,7 @@
$(html_DATA): $(top_builddir)/doc/html/index.html
cd $(top_builddir)/doc && tar cf html.tar html
-$(top_builddir)/doc/html/index.html: $(SOURCES) $(top_srcdir)/src/*.c $(top_srcdir)/include/osmocom/netif/*.h Doxyfile
+$(top_builddir)/doc/html/index.html: $(top_srcdir)/src/*.c $(top_srcdir)/include/osmocom/netif/*.h Doxyfile
@rm -rf doc
mkdir -p doc
$(DOXYGEN) Doxyfile
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36313?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I44ce77c937fa461445800bab393025f948077d55
Gerrit-Change-Number: 36313
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email )
Change subject: osmo_io: Dont use __linux__ but !EMBEDDED
......................................................................
osmo_io: Dont use __linux__ but !EMBEDDED
osmo_io (unlike its io_uring backend) is not linux specific, so putting
it in an "#ifdef __linux__" block is plain wrong.
A side-effect is that all our doxygen comments are not processed as
__linux__ is not set while doxygen parses the source file.
Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8
---
M src/core/osmo_io.c
M src/core/osmo_io_poll.c
2 files changed, 19 insertions(+), 4 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index 57eba6c..745d783 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -21,7 +21,7 @@
*/
#include "../config.h"
-#if defined(__linux__)
+#ifndef EMBEDDED
#include <fcntl.h>
#include <stdio.h>
@@ -934,4 +934,4 @@
}
-#endif /* defined(__linux__) */
+#endif /* ifndef(EMBEDDED) */
diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c
index fae552c..c4bb376 100644
--- a/src/core/osmo_io_poll.c
+++ b/src/core/osmo_io_poll.c
@@ -21,7 +21,7 @@
*/
#include "../config.h"
-#if defined(__linux__)
+#ifndef EMBEDDED
#include <errno.h>
#include <stdio.h>
@@ -198,4 +198,4 @@
.notify_connected = iofd_poll_notify_connected,
};
-#endif /* defined(__linux__) */
+#endif /* ifndef EMBEDDED */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36287?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I260443ba3cd0bb81dade434208dea4ea70fe8ad8
Gerrit-Change-Number: 36287
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36315?usp=email )
Change subject: Use same msgb allocation size like before osmo_io introduction
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36315?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I0c6dcff4523e4c04aae43a4585b5e0c3617ef1a6
Gerrit-Change-Number: 36315
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 16 Mar 2024 09:42:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36314?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: introduce osmo_stream_cli_get_iofd() API
......................................................................
introduce osmo_stream_cli_get_iofd() API
Using this, a user can obtain the osmo_io_fd, for example in order to
perform configuration like osmo_iofd_set_alloc_info() or
osmo_iofd_set_txqueue_max_length().
Change-Id: Ie19c8294ddb12dfe5e0fd44e047c47e6f9cbd384
---
M include/osmocom/netif/stream.h
M src/stream_cli.c
M src/stream_srv.c
3 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/14/36314/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36314?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie19c8294ddb12dfe5e0fd44e047c47e6f9cbd384
Gerrit-Change-Number: 36314
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset