March 2024 - gerrit-log - lists.osmocom.org

[L] Change in osmo-hnbgw[master]: RAB activation/modification/release statistics

by fixeria

Attention is currently required from: dexter, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email ) Change subject: RAB activation/modification/release statistics ...................................................................... Patch Set 2: (2 comments) File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/12d44a02_ef14808e PS2, Line 5: osmocom/core/bitvec.h Why do we need this import in a header file? Looks unrelated and unneeded. File src/osmo-hnbgw/kpi_ranap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311/comment/cb416665_d52283fb PS2, Line 54: ranap_message *ranap `const` like above? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I198fa37699e22380909764de6a0522ac79aa1d39 Gerrit-Change-Number: 36311 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Mar 2024 19:28:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-bts[master]: common: Add RTP related rate counters

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36323?usp=email ) Change subject: common: Add RTP related rate counters ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/36323/comment/0232baf2_d6c9f32d PS1, Line 110: received cosmetic: maybe say 'incoming RTP packets'? I find it a bit confusing to read 'received' and 'dropped', both in a single sentence. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide674bde10b0e4b501d6a48947b983090342dfec Gerrit-Change-Number: 36323 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 17 Mar 2024 19:13:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in osmo-bts[master]: osmo-bts-virtual: Port over to osmo_io

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email ) Change subject: osmo-bts-virtual: Port over to osmo_io ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icfe42da00fd446c38090055e2baa5d5e0ae5b70c Gerrit-Change-Number: 36317 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 17 Mar 2024 19:04:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Make {write,sendto,sendmsg} completion callback optional

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36316?usp=email ) Change subject: osmo_io: Make {write,sendto,sendmsg} completion callback optional ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36316?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0c071a29e508884bac331ada5e510bbfcf440bbf Gerrit-Change-Number: 36316 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 17 Mar 2024 18:54:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in mncc-python[master]: Update MNCC with LLC+HLC support

by fixeria

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36321?usp=email ) Change subject: Update MNCC with LLC+HLC support ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ic318656b778ed1ce115d8e60b0dce4ef75ed0a2c Gerrit-Change-Number: 36321 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 17 Mar 2024 18:35:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in mncc-python[master]: update to MNCC V8 support

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36320?usp=email ) Change subject: update to MNCC V8 support ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ia27956e42c6c2f494d59b89f42345462c86b10d2 Gerrit-Change-Number: 36320 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Mar 2024 18:34:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in mncc-python[master]: Initial port from python2 to python3

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email ) Change subject: Initial port from python2 to python3 ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File mncc_test.py: https://gerrit.osmocom.org/c/mncc-python/+/36318/comment/58eea7be_508dd113 PS4, Line 73: nr /= 2 Oh, btw, I didn't notice this earlier, but doing `/=` would convert `nr` from `int` to `float`, what would then result into a `TypeError` exception. ``` >>> nr = 8 >>> nr /= 2 >>> nr 4.0 >>> range(nr) Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: 'float' object cannot be interpreted as an integer ``` In py2, you would get either `int` or `float`, but in py3 you always get `float`. Use `//=` instead. -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ie6ecd37353b35a6ac13c6578585c714c9ab46e06 Gerrit-Change-Number: 36318 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Mar 2024 18:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in mncc-python[master]: Update MNCC with LLC+HLC support

by laforge

Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36321?usp=email ) Change subject: Update MNCC with LLC+HLC support ...................................................................... Patch Set 4: (1 comment) File mncc.h: https://gerrit.osmocom.org/c/mncc-python/+/36321/comment/870552fe_be221cd0 PS3, Line 283: MNCC_F_GCR > This was actually introduced earlier in `c6921e5068`: […] Done -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36321?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ic318656b778ed1ce115d8e60b0dce4ef75ed0a2c Gerrit-Change-Number: 36321 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Mar 2024 17:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[M] Change in mncc-python[master]: Initial port from python2 to python3

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email ) Change subject: Initial port from python2 to python3 ...................................................................... Patch Set 4: (2 comments) File mncc_test.py: https://gerrit.osmocom.org/c/mncc-python/+/36318/comment/9de405a7_b5088d31 PS3, Line 72: return > This is wrong, you need four more spaces. Otherwise the code below in unreachable. Done File rtpsource/Makefile: https://gerrit.osmocom.org/c/mncc-python/+/36318/comment/98b7943b_05fa3d81 PS3, Line 2: lasan > this looks unrelated to the py3 migration? Done -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ie6ecd37353b35a6ac13c6578585c714c9ab46e06 Gerrit-Change-Number: 36318 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Mar 2024 17:49:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

[S] Change in mncc-python[master]: update to MNCC V8 support

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/36320?usp=email ) Change subject: update to MNCC V8 support ...................................................................... Patch Set 3: (1 comment) File mncc.h: https://gerrit.osmocom.org/c/mncc-python/+/36320/comment/4966ff5b_acdc1b78 PS3, Line 320: struct osmo_gcr_parsed gcr; > This does not match the current state of osmo-msc. […] Done -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/36320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ia27956e42c6c2f494d59b89f42345462c86b10d2 Gerrit-Change-Number: 36320 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 17 Mar 2024 17:49:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2024