lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

February 2024

  • 1 participants
  • 1748 discussions
[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... Patch Set 1: (1 comment) File tests/vty/vty_transcript_test.c: https://gerrit.osmocom.org/c/libosmocore/+/35961/comment/a4c53814_f1fd01e8 PS1, Line 210: DEFUN(multi3, multi3_cmd, See my comments in https://gerrit.osmocom.org/c/libosmo-sccp/+/35796 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:56:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
[S] Change in libosmo-sccp[master]: return CMD_WARNING if osmo_ss7_xua_server_create() fails
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email ) Change subject: return CMD_WARNING if osmo_ss7_xua_server_create() fails ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082 Gerrit-Change-Number: 35968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:16:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[M] Change in libosmo-sccp[master]: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email ) Change subject: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: If you see the file, I think I left on purpose all the "lookup" functions which act on the llist of the instance. So to me this function is actually part of the ss7_inst and hence why it's left there. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Gerrit-Change-Number: 35967 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:15:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in libosmo-sccp[master]: return CMD_WARNING if osmo_ss7_xua_server_create() fails
by fixeria 14 Feb '24

14 Feb '24
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email ) Change subject: return CMD_WARNING if osmo_ss7_xua_server_create() fails ...................................................................... return CMD_WARNING if osmo_ss7_xua_server_create() fails Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082 Related: SYS#5424 --- M src/osmo_ss7_vty.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/68/35968/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 1483ac0..486f070 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -491,7 +491,7 @@ if (!xs) { xs = osmo_ss7_xua_server_create(inst, proto, port, NULL); if (!xs) - return CMD_SUCCESS; + return CMD_WARNING; /* Drop first dummy address created automatically by _create(): */ osmo_ss7_xua_server_set_local_hosts(xs, NULL, 0); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082 Gerrit-Change-Number: 35968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[M] Change in libosmo-sccp[master]: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c
by fixeria 14 Feb '24

14 Feb '24
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email ) Change subject: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c ...................................................................... move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Related: SYS#5424 --- M src/osmo_ss7.c M src/osmo_ss7_xua_srv.c 2 files changed, 35 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/67/35967/1 diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index dbbef6b..ef958ae 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -1054,21 +1054,6 @@ return ss7_asp_alloc(inst, name, remote_port, local_port, proto); } -struct osmo_xua_server * -osmo_ss7_xua_server_find(struct osmo_ss7_instance *inst, enum osmo_ss7_asp_protocol proto, - uint16_t local_port) -{ - struct osmo_xua_server *xs; - - OSMO_ASSERT(ss7_initialized); - llist_for_each_entry(xs, &inst->xua_servers, list) { - if (proto == xs->cfg.proto && - local_port == xs->cfg.local.port) - return xs; - } - return NULL; -} - bool osmo_ss7_pc_is_local(struct osmo_ss7_instance *inst, uint32_t pc) { OSMO_ASSERT(ss7_initialized); diff --git a/src/osmo_ss7_xua_srv.c b/src/osmo_ss7_xua_srv.c index 32266ff..5928bae 100644 --- a/src/osmo_ss7_xua_srv.c +++ b/src/osmo_ss7_xua_srv.c @@ -169,6 +169,31 @@ return rc; } +/*! \brief find an xUA server with the given parameters + * \param[in] inst SS7 Instance on which we operate + * \param[in] proto protocol (xUA variant) in use + * \param[in] local_port local port of the server + * \returns \ref osmo_xua_server or NULL (not found) + */ +struct osmo_xua_server * +osmo_ss7_xua_server_find(struct osmo_ss7_instance *inst, + enum osmo_ss7_asp_protocol proto, + uint16_t local_port) +{ + struct osmo_xua_server *xs; + + OSMO_ASSERT(ss7_initialized); + llist_for_each_entry(xs, &inst->xua_servers, list) { + if (proto != xs->cfg.proto) + continue; + if (local_port != xs->cfg.local.port) + continue; + return xs; + } + + return NULL; +} + /*! \brief create a new xUA server configured with given ip/port * \param[in] ctx talloc allocation context * \param[in] proto protocol (xUA variant) to use -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Gerrit-Change-Number: 35967 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in osmo-msc[master]: msc_a_up_call_assignment_complete(): handle all CSD modes
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email ) Change subject: msc_a_up_call_assignment_complete(): handle all CSD modes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I92f7ab11ebc2e53700b27c38e91679c2c6f72050 Gerrit-Change-Number: 35881 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-msc[master]: libsmpputil: fix -Wtautological-constant-out-of-range-compare
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email ) Change subject: libsmpputil: fix -Wtautological-constant-out-of-range-compare ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia71a0b6b9421911dc5113782d2f555a640fd90ed Gerrit-Change-Number: 35966 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 13:00:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-msc[master]: libvlr: fix auth_fsm_term(): use proper value-string for cause
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35964?usp=email ) Change subject: libvlr: fix auth_fsm_term(): use proper value-string for cause ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia0868dce2da5cb78c30cf518870c3d91144499b9 Gerrit-Change-Number: 35964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 12:59:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-msc[master]: libvlr: fix wrong cause value passed to auth_fsm_term()
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35963?usp=email ) Change subject: libvlr: fix wrong cause value passed to auth_fsm_term() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35963?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0b820bb2a8e561682a8158fc51bd9565f5912d56 Gerrit-Change-Number: 35963 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 12:59:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-msc[master]: libvlr: auth_fsm_wait_ai(): cosmetic: drop redundant break
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35962?usp=email ) Change subject: libvlr: auth_fsm_wait_ai(): cosmetic: drop redundant break ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa2962bfe67902f6b4aa944b73fa97db46bc9c54 Gerrit-Change-Number: 35962 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 12:58:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 86
  • 87
  • 88
  • 89
  • 90
  • 91
  • 92
  • ...
  • 175
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.