February 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: pick up all *.vty in EXTRA_DIST

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email ) Change subject: pick up all *.vty in EXTRA_DIST ...................................................................... pick up all *.vty in EXTRA_DIST (Same as osmo-bsc I47c9011b5e0e2886d221e34e6aa281d1dd0495c7) *.vty tests are picked up by the Makefile.am by means of a wildcard -- they are run when they are there. So when you forget to add it to EXTRA_DIST, it will be run in your local build tree, but it will be silently omitted from a distribution tar, and nothing will complain about it gone missing. Instead, also use a *.vty wildcard in EXTRA_DIST. So any *.vty test added to the git source will both be run *and* included in distribution tars implicitly. So far, test_neighbor_ident.vty was missing from the distribution. Change-Id: Id28e020fc59b83d1b4cd0e5b72314a46bea62259 --- M tests/Makefile.am 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index 839e53b..7ab3c37 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -38,7 +38,7 @@ vty_test_runner.py \ ctrl_test_runner.py \ smpp_test_runner.py \ - test_nodes.vty \ + $(srcdir)/*.vty \ $(NULL) TESTSUITE = $(srcdir)/testsuite -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id28e020fc59b83d1b4cd0e5b72314a46bea62259 Gerrit-Change-Number: 35872 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmocom-obs-sync: remove Ubuntu 23.04, Debian Testing

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35945?usp=email ) Change subject: jobs/osmocom-obs-sync: remove Ubuntu 23.04, Debian Testing ...................................................................... jobs/osmocom-obs-sync: remove Ubuntu 23.04, Debian Testing Related: OS#6163 Change-Id: Ief01182755688b2a16fc3ef272601e93d4a25ba1 --- M jobs/osmocom-obs-sync.yml 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/jobs/osmocom-obs-sync.yml b/jobs/osmocom-obs-sync.yml index 53ae0b3..9193edc 100644 --- a/jobs/osmocom-obs-sync.yml +++ b/jobs/osmocom-obs-sync.yml @@ -33,13 +33,11 @@ Debian:11 Debian:12 Debian:Next - Debian:Testing Raspbian:10 Raspbian:11 Raspbian:12 Ubuntu:20.04 Ubuntu:22.04 - Ubuntu:23.04 Ubuntu:23.10 " ./scripts/obs/sync_obs_projects.py \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ief01182755688b2a16fc3ef272601e93d4a25ba1 Gerrit-Change-Number: 35945 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmocom-obs-sync: remove Ubuntu 23.04, Debian Testing

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/35945?usp=email ) Change subject: jobs/osmocom-obs-sync: remove Ubuntu 23.04, Debian Testing ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: trivial, merging with +1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ief01182755688b2a16fc3ef272601e93d4a25ba1 Gerrit-Change-Number: 35945 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Feb 2024 15:27:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul_fsm: Fix wrong cast

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35957?usp=email ) Change subject: tbf_ul_fsm: Fix wrong cast ...................................................................... tbf_ul_fsm: Fix wrong cast Change-Id: I6c68e85cfa7ca8d08ed7c851e31831c30772012e --- M src/tbf_ul_fsm.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/tbf_ul_fsm.c b/src/tbf_ul_fsm.c index 49849ba..7dff359 100644 --- a/src/tbf_ul_fsm.c +++ b/src/tbf_ul_fsm.c @@ -43,7 +43,7 @@ #define tbf_ul_fsm_state_chg(fi, NEXT_STATE) \ osmo_tdef_fsm_inst_state_chg(fi, NEXT_STATE, \ tbf_ul_fsm_timeouts, \ - tbf_ms(((struct tbf_dl_fsm_ctx *)(fi->priv))->tbf)->bts->T_defs_bts, \ + tbf_ms(((struct tbf_ul_fsm_ctx *)(fi->priv))->tbf)->bts->T_defs_bts, \ -1) static void mod_ass_type(struct tbf_ul_fsm_ctx *ctx, uint8_t t, bool set) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6c68e85cfa7ca8d08ed7c851e31831c30772012e Gerrit-Change-Number: 35957 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul_fsm: Fix wrong cast

by fixeria

Attention is currently required from: jolly, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35957?usp=email ) Change subject: tbf_ul_fsm: Fix wrong cast ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6c68e85cfa7ca8d08ed7c851e31831c30772012e Gerrit-Change-Number: 35957 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Feb 2024 11:55:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: config: Do not set up VRF

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35958?usp=email ) Change subject: config: Do not set up VRF ...................................................................... config: Do not set up VRF gtp_u_kmod won't configure the VRF if the node is not present. We don't want to use it for now, so disable it. Change-Id: Ia47a85e2d51e56368cc9940ef0e6faa41afe81e9 --- M config/sys.config 1 file changed, 17 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/58/35958/1 diff --git a/config/sys.config b/config/sys.config index 6119e02..6183daf 100755 --- a/config/sys.config +++ b/config/sys.config @@ -51,11 +51,11 @@ %% Allow binding to an IP address that is nonlocal or does not (yet) exist (IP_FREEBIND): freebind, % Create gtp tundev with role SGSN: - {role, sgsn}, - {vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%, - %%{netdev, "upstream"} - ] - } + {role, sgsn}%, + %{vrf, [{routes, [{{10, 180, 0, 0}, 16}]}%%, + % %%{netdev, "upstream"} + % ] + %} ] }] } -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35958?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ia47a85e2d51e56368cc9940ef0e6faa41afe81e9 Gerrit-Change-Number: 35958 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul_fsm: Fix wrong cast

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35957?usp=email ) Change subject: tbf_ul_fsm: Fix wrong cast ...................................................................... tbf_ul_fsm: Fix wrong cast Change-Id: I6c68e85cfa7ca8d08ed7c851e31831c30772012e --- M src/tbf_ul_fsm.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/35957/1 diff --git a/src/tbf_ul_fsm.c b/src/tbf_ul_fsm.c index 49849ba..7dff359 100644 --- a/src/tbf_ul_fsm.c +++ b/src/tbf_ul_fsm.c @@ -43,7 +43,7 @@ #define tbf_ul_fsm_state_chg(fi, NEXT_STATE) \ osmo_tdef_fsm_inst_state_chg(fi, NEXT_STATE, \ tbf_ul_fsm_timeouts, \ - tbf_ms(((struct tbf_dl_fsm_ctx *)(fi->priv))->tbf)->bts->T_defs_bts, \ + tbf_ms(((struct tbf_ul_fsm_ctx *)(fi->priv))->tbf)->bts->T_defs_bts, \ -1) static void mod_ass_type(struct tbf_ul_fsm_ctx *ctx, uint8_t t, bool set) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I6c68e85cfa7ca8d08ed7c851e31831c30772012e Gerrit-Change-Number: 35957 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to co...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email ) Change subject: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place ...................................................................... cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place All the different procedures are placed in order, except this one. Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e --- M tests/gsup/gsup_test.c 1 file changed, 25 insertions(+), 14 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/tests/gsup/gsup_test.c b/tests/gsup/gsup_test.c index 3d7ea40..fb3708a 100644 --- a/tests/gsup/gsup_test.c +++ b/tests/gsup/gsup_test.c @@ -454,20 +454,6 @@ 0x51, /* GSM0808_CAUSE_INVALID_MESSAGE_CONTENTS */ }; - static const uint8_t send_e_process_access_signalling_req[] = { - 0x40, /* OSMO_GSUP_MSGT_E_PROCESS_ACCESS_SIGNALLING_REQUEST */ - TEST_IMSI_IE, - - /* Session ID and state (continue) */ - 0x30, 0x04, 0xde, 0xad, 0xbe, 0xef, - 0x31, 0x01, 0x02, - - TEST_CLASS_INTER_MSC_IE, - TEST_SOURCE_NAME_IE, - TEST_DESTINATION_NAME_IE, - TEST_AN_APDU_IE, /* (Handover Detect) */ - }; - static const uint8_t send_e_send_end_signal_res[] = { 0x3E, /* OSMO_GSUP_MSGT_E_SEND_END_SIGNAL_RESULT */ TEST_IMSI_IE, @@ -482,6 +468,20 @@ TEST_AN_APDU_IE, /* (Handover Complete) */ }; + static const uint8_t send_e_process_access_signalling_req[] = { + 0x40, /* OSMO_GSUP_MSGT_E_PROCESS_ACCESS_SIGNALLING_REQUEST */ + TEST_IMSI_IE, + + /* Session ID and state (continue) */ + 0x30, 0x04, 0xde, 0xad, 0xbe, 0xef, + 0x31, 0x01, 0x02, + + TEST_CLASS_INTER_MSC_IE, + TEST_SOURCE_NAME_IE, + TEST_DESTINATION_NAME_IE, + TEST_AN_APDU_IE, /* (Handover Detect) */ + }; + static const uint8_t send_e_forward_access_signalling_req [] = { 0x44, /* OSMO_GSUP_MSGT_E_FORWARD_ACCESS_SIGNALLING_REQUEST */ TEST_IMSI_IE, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e Gerrit-Change-Number: 35942 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to co...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email ) Change subject: cosmetic: tests/gsup/gsup_test: Move send_e_send_end_signal_res to correct place ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35942?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If0877deca2bcbf40229c9c61f471112f1e8cdb0e Gerrit-Change-Number: 35942 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Feb 2024 09:08:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-gsm-manuals[master]: gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req ...................................................................... gsup.adoc: Add conditional 'PDP Info' IE to Auth Info Req Change-Id: Iccb397410d1b08c8fbc87fdcad1e787f025a5d9f --- M common/chapters/gsup.adoc 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc index a0023dd..1f70c5b 100644 --- a/common/chapters/gsup.adoc +++ b/common/chapters/gsup.adoc @@ -362,12 +362,17 @@ |28|CN Domain|<<gsup-ie-cndomain>>|O|TLV|3 |26|AUTS|<<gsup-ie-auts>>|C|TLV|18 |20|RAND|<<gsup-ie-rand>>|C|TLV|18 +|05|PDP info|<<gsup-ie-pdpinfo>>|C|TLV|2-N |=== The conditional 'AUTS' and 'RAND' IEs are both present in case the SIM (via UE) requests an UMTS AKA re-synchronization procedure. Either both optional IEs are present, or none of them. +The conditional 'PDP Info' IE is only present in the CEAI interface used by the +ePDG. It should contain the 'PDP Context ID', 'PDP Address' (dynamic addressing) +and 'Access Point Name' IEs. + [[gsup-msg-auth-info-err]] ==== Send Authentication Info Error @@ -446,7 +451,7 @@ |08|MSISDN|<<gsup-ie-msisdn>>|O|TLV|0-9 |09|HLR Number|<<gsup-ie-hlr>>|O|TLV|0-9 |04|PDP info complete|<<gsup-ie-empty>>|O|TLV|2 -|05|PDP info|<<gsup-ie-pdpinfo>>|O|TLV|1-10 +|05|PDP info|<<gsup-ie-pdpinfo>>|O|TLV|2-N |=== If the PDP info complete IE is present, the old PDP info list shall be cleared. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/35899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Iccb397410d1b08c8fbc87fdcad1e787f025a5d9f Gerrit-Change-Number: 35899 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024