lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

February 2024

  • 1 participants
  • 1748 discussions
[S] Change in libgtpnl[master]: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email ) Change subject: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 17:26:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
[S] Change in osmo-ci[master]: jobs/registry-update-base…: remove almalinux8
by osmith 14 Feb '24

14 Feb '24
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/35975?usp=email ) Change subject: jobs/registry-update-base…: remove almalinux8 ...................................................................... jobs/registry-update-base…: remove almalinux8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: If921a5844ce602a7bda84b9e4d1507796c10948f --- M jobs/registry-update-base-images.yml 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/75/35975/1 diff --git a/jobs/registry-update-base-images.yml b/jobs/registry-update-base-images.yml index f3f20e3..b51ae95 100644 --- a/jobs/registry-update-base-images.yml +++ b/jobs/registry-update-base-images.yml @@ -27,7 +27,6 @@ debian:sid centos:centos7 - almalinux:8 " for i in $IMAGES; do src=$i -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If921a5844ce602a7bda84b9e4d1507796c10948f Gerrit-Change-Number: 35975 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in osmo-ci[master]: jobs/repo-install-test: remove centos8
by osmith 14 Feb '24

14 Feb '24
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/35973?usp=email ) Change subject: jobs/repo-install-test: remove centos8 ...................................................................... jobs/repo-install-test: remove centos8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: I311ccfe61b86e467996022107294ad560eee8bdf --- M jobs/repo-install-test.yml 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/73/35973/1 diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index 1340e20..0891e24 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -4,8 +4,6 @@ jobs: - Osmocom-repo-install-{distro} distro: - - centos8: - feeds: !!python/tuple [nightly, latest] # next: disabled (OS#5322) - debian10: feeds: !!python/tuple [nightly, latest] - debian11: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I311ccfe61b86e467996022107294ad560eee8bdf Gerrit-Change-Number: 35973 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in osmo-ci[master]: jobs/gerrit-verifications: remove almalinux8
by osmith 14 Feb '24

14 Feb '24
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/35972?usp=email ) Change subject: jobs/gerrit-verifications: remove almalinux8 ...................................................................... jobs/gerrit-verifications: remove almalinux8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: Ia180ac87251c39d9715276cf23a2663fb917f50a --- M jobs/gerrit-verifications.yml 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/35972/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 2efac00..2998619 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -92,7 +92,7 @@ # Which jobs to run in the pipeline pipeline_build: true pipeline_lint: true - pipeline_binpkgs: "almalinux:8 debian:10 debian:12" + pipeline_binpkgs: "debian:10 debian:12" # in alphabetical order repos: @@ -126,9 +126,7 @@ - libtelnet: pipeline_binpkgs: "" - - libusrp: - # centos8/almalinux doesn't have SDCC (OS#5898) - pipeline_binpkgs: "debian:10 debian:12" + - libusrp - openbsc: a1_name: SMPP @@ -394,7 +392,7 @@ {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-upf: - pipeline_binpkgs: "almalinux:8 debian:11 debian:12" + pipeline_binpkgs: "debian:11 debian:12" - pysim: concurrent: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35972?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia180ac87251c39d9715276cf23a2663fb917f50a Gerrit-Change-Number: 35972 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[M] Change in osmo-ci[master]: jobs/ttcn3-testsuites: remove centos8
by osmith 14 Feb '24

14 Feb '24
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/35974?usp=email ) Change subject: jobs/ttcn3-testsuites: remove centos8 ...................................................................... jobs/ttcn3-testsuites: remove centos8 Related: https://osmocom.org/news/246 Related: SYS#6759 Change-Id: I4142c5ababb85b74a890a0cbfc302bd15d44268e --- M jobs/ttcn3-testsuites.yml 1 file changed, 11 insertions(+), 84 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/74/35974/1 diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index ce18cfb..b367c49 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -202,76 +202,6 @@ - TTCN3-centos7-pcap-client-test-latest: timer: H 10 * * * - # centos8 nightly - - TTCN3-centos-ggsn-test: - timer: H 10 * * * - - TTCN3-centos-msc-test: - timer: H 10 * * * - - TTCN3-centos-pcu-test: - timer: H 10 * * * - - TTCN3-centos-pcu-test-sns: - timer: H 10 * * * - - TTCN3-centos-sgsn-test: - timer: H 11 * * * - - TTCN3-centos-bsc-test: - timer: H 11 * * * - - TTCN3-centos-mgw-test: - timer: H 11 * * * - - TTCN3-centos-hlr-test: - timer: H 11 * * * - - TTCN3-centos-bts-test: - timer: H 11 * * * - - TTCN3-centos-sip-test: - timer: H 11 * * * - - TTCN3-centos-bsc-test-sccplite: - timer: H 11 * * * - - TTCN3-centos-remsim-test: - timer: H 11 * * * - disabled: true - - TTCN3-centos-stp-test: - timer: H 11 * * * - - TTCN3-centos-gbproxy-test: - timer: H 11 * * * - - TTCN3-centos-cbc-test: - timer: H 12 * * * - - # centos8 latest stable - - TTCN3-centos-ggsn-test-latest: - timer: H 12 * * * - - TTCN3-centos-msc-test-latest: - timer: H 12 * * * - - TTCN3-centos-pcu-test-latest: - timer: H 12 * * * - - TTCN3-centos-pcu-test-sns-latest: - timer: H 12 * * * - - TTCN3-centos-sgsn-test-latest: - timer: H 12 * * * - - TTCN3-centos-bsc-test-latest: - timer: H 12 * * * - - TTCN3-centos-mgw-test-latest: - timer: H 12 * * * - - TTCN3-centos-hlr-test-latest: - timer: H 12 * * * - - TTCN3-centos-bts-test-latest: - timer: H 12 * * * - - TTCN3-centos-sip-test-latest: - timer: H 13 * * * - - TTCN3-centos-bsc-test-sccplite-latest: - timer: H 13 * * * - - TTCN3-centos-remsim-test-latest: - timer: H 13 * * * - disabled: true - - TTCN3-centos-stp-test-latest: - timer: H 13 * * * - - TTCN3-centos-smlc-test-latest: - timer: H 13 * * * - - TTCN3-centos-sccp-test-latest: - timer: H 13 * * * - - TTCN3-centos-gbproxy-test-latest: - timer: H 13 * * * - - TTCN3-centos-cbc-test-latest: - timer: H 13 * * * - - job-template: name: '{job-name}' project-type: freestyle @@ -322,24 +252,10 @@ export KERNEL_REMOTE_NAME="torvalds" export KERNEL_BRANCH="master" ;; - TTCN3-centos-*-latest) - DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/ | sed s/\-latest$//)" - export IMAGE_SUFFIX="latest-centos8" - ;; TTCN3-centos7-*-latest) DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/ | sed s/\-latest$//)" export IMAGE_SUFFIX="latest-centos7" ;; - TTCN3-centos-*-20*q*) - export OSMOCOM_REPO_PATH="osmo-maintained" - export OSMOCOM_REPO_VERSION="$(echo "{job-name}" | grep -o -P -- "20\d\dq.*$")" # e.g. "2021q1" - export IMAGE_SUFFIX="$OSMOCOM_REPO_VERSION-centos8" - DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/ | sed s/\-$OSMOCOM_REPO_VERSION$//)" - ;; - TTCN3-centos-*) - DIR="$(echo "{job-name}" | sed s/^TTCN3-centos\-/ttcn3-/)" - export IMAGE_SUFFIX="master-centos8" - ;; TTCN3-centos7-*) DIR="$(echo "{job-name}" | sed s/^TTCN3-centos7\-/ttcn3-/)" export IMAGE_SUFFIX="master-centos7" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4142c5ababb85b74a890a0cbfc302bd15d44268e Gerrit-Change-Number: 35974 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in libgtpnl[master]: tools/gtp-tunnel: pass rc of gtp_add_tunnel
by osmith 14 Feb '24

14 Feb '24
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/35971?usp=email ) Change subject: tools/gtp-tunnel: pass rc of gtp_add_tunnel ...................................................................... tools/gtp-tunnel: pass rc of gtp_add_tunnel Don't exit with 0 if gtp_add_tunnel fails. Change-Id: If11b1fb4487a96dcb7f24d95794fea4e36202203 --- M tools/gtp-tunnel.c 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/71/35971/1 diff --git a/tools/gtp-tunnel.c b/tools/gtp-tunnel.c index b29e386..1fcdee7 100644 --- a/tools/gtp-tunnel.c +++ b/tools/gtp-tunnel.c @@ -77,6 +77,7 @@ uint32_t gtp_ifidx; uint32_t gtp_version; int optidx; + int ret; if (argc < 7 || argc > 8) { add_usage(argv[0]); @@ -118,10 +119,10 @@ set_addr(argv[optidx++], true, t); set_addr(argv[optidx++], false, t); - gtp_add_tunnel(genl_id, nl, t); + ret = gtp_add_tunnel(genl_id, nl, t); gtp_tunnel_free(t); - return 0; + return ret; } static int -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If11b1fb4487a96dcb7f24d95794fea4e36202203 Gerrit-Change-Number: 35971 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in libgtpnl[master]: Makefile.am: remove DIST_SUBDIRS
by osmith 14 Feb '24

14 Feb '24
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email ) Change subject: Makefile.am: remove DIST_SUBDIRS ...................................................................... Makefile.am: remove DIST_SUBDIRS It is the same as SUBDIRS, so it doesn't need to be defined. We don't do this is in other Osmocom projects either. Related: https://www.gnu.org/software/automake/manual/html_node/SUBDIRS-vs-DIST_005f… Change-Id: I35345ba1c6ab6ecc827177dfd6f14a5be6606432 --- M Makefile.am 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/70/35970/1 diff --git a/Makefile.am b/Makefile.am index 1fabe69..c34b6db 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,7 +5,6 @@ ACLOCAL_AMFLAGS = -I m4 SUBDIRS = src include tools -DIST_SUBDIRS = src include tools pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libgtpnl.pc -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I35345ba1c6ab6ecc827177dfd6f14a5be6606432 Gerrit-Change-Number: 35970 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in libgtpnl[master]: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES
by osmith 14 Feb '24

14 Feb '24
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email ) Change subject: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES ...................................................................... configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES Instead of having one file in AC_OUTPUT, and all others in AC_CONFIG_FILES, move all of them to AC_CONFIG_FILES. Sort the files while at it and have one per line. Fix this warning: configure.ac:86: warning: AC_OUTPUT should be used without arguments. Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 --- M configure.ac 1 file changed, 27 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/69/35969/1 diff --git a/configure.ac b/configure.ac index a16f40b..2665b70 100644 --- a/configure.ac +++ b/configure.ac @@ -74,6 +74,14 @@ AC_SUBST([CPPFLAGS]) AC_SUBST([CFLAGS]) -AC_CONFIG_FILES([Makefile src/Makefile include/Makefile include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc]) -AC_OUTPUT( - contrib/libgtpnl.spec) +AC_CONFIG_FILES([ + Makefile + contrib/libgtpnl.spec + include/Makefile + include/libgtpnl/Makefile + include/linux/Makefile + libgtpnl.pc + src/Makefile + tools/Makefile +]) +AC_OUTPUT() -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice
by fixeria 14 Feb '24

14 Feb '24
Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... Patch Set 1: (1 comment) File tests/vty/vty_transcript_test.c: https://gerrit.osmocom.org/c/libosmocore/+/35961/comment/ec7780ec_6a5c2c6a PS1, Line 210: DEFUN(multi3, multi3_cmd, > See my comments in https://gerrit.osmocom. […] This patch is indeed related, but if you look more careful, you would find that here I am showing problems with the approach you suggested in the reference patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 14:03:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice
by pespin 14 Feb '24

14 Feb '24
Attention is currently required from: fixeria, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you maybe create a ticket for this one and provide some feedback on the assert you are hitting? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 14:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 85
  • 86
  • 87
  • 88
  • 89
  • 90
  • 91
  • ...
  • 175
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.