osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email )
Change subject: Makefile.am: remove DIST_SUBDIRS
......................................................................
Makefile.am: remove DIST_SUBDIRS
It is the same as SUBDIRS, so it doesn't need to be defined. We don't do
this is in other Osmocom projects either.
Related: https://www.gnu.org/software/automake/manual/html_node/SUBDIRS-vs-DIST_005f…
Change-Id: I35345ba1c6ab6ecc827177dfd6f14a5be6606432
---
M Makefile.am
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/70/35970/1
diff --git a/Makefile.am b/Makefile.am
index 1fabe69..c34b6db 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -5,7 +5,6 @@
ACLOCAL_AMFLAGS = -I m4
SUBDIRS = src include tools
-DIST_SUBDIRS = src include tools
pkgconfigdir = $(libdir)/pkgconfig
pkgconfig_DATA = libgtpnl.pc
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I35345ba1c6ab6ecc827177dfd6f14a5be6606432
Gerrit-Change-Number: 35970
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email )
Change subject: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES
......................................................................
configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES
Instead of having one file in AC_OUTPUT, and all others in
AC_CONFIG_FILES, move all of them to AC_CONFIG_FILES. Sort the files
while at it and have one per line.
Fix this warning:
configure.ac:86: warning: AC_OUTPUT should be used without arguments.
Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967
---
M configure.ac
1 file changed, 27 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libgtpnl refs/changes/69/35969/1
diff --git a/configure.ac b/configure.ac
index a16f40b..2665b70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -74,6 +74,14 @@
AC_SUBST([CPPFLAGS])
AC_SUBST([CFLAGS])
-AC_CONFIG_FILES([Makefile src/Makefile include/Makefile include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc])
-AC_OUTPUT(
- contrib/libgtpnl.spec)
+AC_CONFIG_FILES([
+ Makefile
+ contrib/libgtpnl.spec
+ include/Makefile
+ include/libgtpnl/Makefile
+ include/linux/Makefile
+ libgtpnl.pc
+ src/Makefile
+ tools/Makefile
+])
+AC_OUTPUT()
--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967
Gerrit-Change-Number: 35969
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email )
Change subject: tests/vty: demonstrate a problem with optional-multi-choice
......................................................................
Patch Set 1:
(1 comment)
File tests/vty/vty_transcript_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/35961/comment/ec7780ec_6a5c2c6a
PS1, Line 210: DEFUN(multi3, multi3_cmd,
> See my comments in https://gerrit.osmocom. […]
This patch is indeed related, but if you look more careful, you would find that here I am showing problems with the approach you suggested in the reference patch.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0
Gerrit-Change-Number: 35961
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Feb 2024 14:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email )
Change subject: tests/vty: demonstrate a problem with optional-multi-choice
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Can you maybe create a ticket for this one and provide some feedback on the assert you are hitting?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0
Gerrit-Change-Number: 35961
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Feb 2024 14:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment