February 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-msc[master]: libvlr: fix wrong cause value passed to auth_fsm_term()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35963?usp=email ) Change subject: libvlr: fix wrong cause value passed to auth_fsm_term() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35963?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0b820bb2a8e561682a8158fc51bd9565f5912d56 Gerrit-Change-Number: 35963 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 18:07:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-msc[master]: libvlr: auth_fsm_wait_ai(): cosmetic: drop redundant break

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35962?usp=email ) Change subject: libvlr: auth_fsm_wait_ai(): cosmetic: drop redundant break ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaa2962bfe67902f6b4aa944b73fa97db46bc9c54 Gerrit-Change-Number: 35962 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 18:06:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libosmo-sccp[master]: return CMD_WARNING if osmo_ss7_xua_server_create() fails

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email ) Change subject: return CMD_WARNING if osmo_ss7_xua_server_create() fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I12bbfd48e16166c0f508ccbf2ed4fa786e786082 Gerrit-Change-Number: 35968 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 17:44:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[M] Change in libosmo-sccp[master]: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email ) Change subject: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: curios: how is this an early patch earlier in the series to introduce TCP support? Almost like the m3ua TCP support would depend on it? But how would the code care in whihc file a public function is? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Gerrit-Change-Number: 35967 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 17:44:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: Makefile.am: remove DIST_SUBDIRS

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email ) Change subject: Makefile.am: remove DIST_SUBDIRS ...................................................................... Makefile.am: remove DIST_SUBDIRS It is the same as SUBDIRS, so it doesn't need to be defined. We don't do this is in other Osmocom projects either. Related: https://www.gnu.org/software/automake/manual/html_node/SUBDIRS-vs-DIST_005f… Change-Id: I35345ba1c6ab6ecc827177dfd6f14a5be6606432 --- M Makefile.am 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/Makefile.am b/Makefile.am index 1fabe69..c34b6db 100644 --- a/Makefile.am +++ b/Makefile.am @@ -5,7 +5,6 @@ ACLOCAL_AMFLAGS = -I m4 SUBDIRS = src include tools -DIST_SUBDIRS = src include tools pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libgtpnl.pc -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I35345ba1c6ab6ecc827177dfd6f14a5be6606432 Gerrit-Change-Number: 35970 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: tools/gtp-tunnel: pass rc of gtp_add_tunnel

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35971?usp=email ) Change subject: tools/gtp-tunnel: pass rc of gtp_add_tunnel ...................................................................... tools/gtp-tunnel: pass rc of gtp_add_tunnel Don't exit with 0 if gtp_add_tunnel fails. Change-Id: If11b1fb4487a96dcb7f24d95794fea4e36202203 --- M tools/gtp-tunnel.c 1 file changed, 14 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tools/gtp-tunnel.c b/tools/gtp-tunnel.c index b29e386..1fcdee7 100644 --- a/tools/gtp-tunnel.c +++ b/tools/gtp-tunnel.c @@ -77,6 +77,7 @@ uint32_t gtp_ifidx; uint32_t gtp_version; int optidx; + int ret; if (argc < 7 || argc > 8) { add_usage(argv[0]); @@ -118,10 +119,10 @@ set_addr(argv[optidx++], true, t); set_addr(argv[optidx++], false, t); - gtp_add_tunnel(genl_id, nl, t); + ret = gtp_add_tunnel(genl_id, nl, t); gtp_tunnel_free(t); - return 0; + return ret; } static int -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If11b1fb4487a96dcb7f24d95794fea4e36202203 Gerrit-Change-Number: 35971 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email ) Change subject: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES ...................................................................... configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES Instead of having one file in AC_OUTPUT, and all others in AC_CONFIG_FILES, move all of them to AC_CONFIG_FILES. Sort the files while at it and have one per line. Fix this warning: configure.ac:86: warning: AC_OUTPUT should be used without arguments. Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 --- M configure.ac 1 file changed, 27 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index a16f40b..2665b70 100644 --- a/configure.ac +++ b/configure.ac @@ -74,6 +74,14 @@ AC_SUBST([CPPFLAGS]) AC_SUBST([CFLAGS]) -AC_CONFIG_FILES([Makefile src/Makefile include/Makefile include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc]) -AC_OUTPUT( - contrib/libgtpnl.spec) +AC_CONFIG_FILES([ + Makefile + contrib/libgtpnl.spec + include/Makefile + include/libgtpnl/Makefile + include/linux/Makefile + libgtpnl.pc + src/Makefile + tools/Makefile +]) +AC_OUTPUT() -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: tools/gtp-tunnel: pass rc of gtp_add_tunnel

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35971?usp=email ) Change subject: tools/gtp-tunnel: pass rc of gtp_add_tunnel ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: If11b1fb4487a96dcb7f24d95794fea4e36202203 Gerrit-Change-Number: 35971 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 17:42:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: Makefile.am: remove DIST_SUBDIRS

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email ) Change subject: Makefile.am: remove DIST_SUBDIRS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35970?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I35345ba1c6ab6ecc827177dfd6f14a5be6606432 Gerrit-Change-Number: 35970 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 17:42:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in libgtpnl[master]: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email ) Change subject: configure.ac: move AC_OUTPUT -> AC_CONFIG_FILES ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/35969?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: Iea782b03c9ede154eedbd0c0e9f0d7359bb49967 Gerrit-Change-Number: 35969 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 17:42:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024