February 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice

by fixeria

Attention is currently required from: neels, pespin. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email to look at the new patch set (#2). Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... tests/vty: demonstrate a problem with optional-multi-choice Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Related: b55f4d2df21b966c3953264d8961f259814f4650 Related: OS#6360 --- M tests/vty/vty_transcript_test.c M tests/vty/vty_transcript_test.vty 2 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/35961/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 4 months

1
0
0 0

[S] Change in libosmocore[master]: tests/vty: demonstrate a problem with optional-multi-choice

by fixeria

Attention is currently required from: neels, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email ) Change subject: tests/vty: demonstrate a problem with optional-multi-choice ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Can you maybe create a ticket for this one and provide some feedback on the assert you are hitting? https://osmocom.org/issues/6360 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6ad93a304ce498ba9d57fc7e2fd238e6c16e29e0 Gerrit-Change-Number: 35961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 21:28:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: epdg: Validate assigned PDP Address and APN

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email ) Change subject: epdg: Validate assigned PDP Address and APN ...................................................................... epdg: Validate assigned PDP Address and APN Change-Id: I440a7379c6dab5448d4c57c498ad9d086d0c456b --- M epdg/EPDG_Tests.ttcn M library/GSUP_Templates.ttcn 2 files changed, 20 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/35977/1 diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn index 89a85f1..2ad1b32 100644 --- a/epdg/EPDG_Tests.ttcn +++ b/epdg/EPDG_Tests.ttcn @@ -605,8 +605,8 @@ /* Expect a positive response back to the translator; */ var template (present) GSUP_IEs pdp_info := { tr_GSUP_IE_PDP_CONTEXT_ID(?), - tr_GSUP_IE_PDP_ADDRESS(?), - tr_GSUP_IE_APN(?), + tr_GSUP_IE_PDP_ADDRESS(tr_GSUP_PDP_Address_IPv4(f_inet_addr(g_pars.ue_ip))), + tr_GSUP_IE_APN(f_enc_dns_hostname(g_pars.apn)), tr_GSUP_IE_PDP_QOS(?), tr_GSUP_IE_Charging_Characteristics(?) }; diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 05b8295..10c682c 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -69,6 +69,15 @@ } template (value) GSUP_PDP_Address ts_EuaIPv4Dyn := ts_GSUP_PDP_Address_IPv4(omit); +template (present) GSUP_PDP_Address tr_GSUP_PDP_Address_IPv4(template OCT4 ip_addr) := { + ipv4 := { + spare := ?, + pdp_typeorg := '0001'B, + pdp_typenum := '21'O, + ipv4_address := ip_addr + } +} + template GSUP_IE ts_GSUP_IE_AuthTuple2G(octetstring rand, octetstring sres, octetstring kc) := { tag := OSMO_GSUP_AUTH_TUPLE_IE, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I440a7379c6dab5448d4c57c498ad9d086d0c456b Gerrit-Change-Number: 35977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[S] Change in docker-playground[master]: epdg: Configure gtpu tunnel

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35646?usp=email ) Change subject: epdg: Configure gtpu tunnel ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifeece08cdcceb378ae1e195cada5bfef54a1e2bd Gerrit-Change-Number: 35646 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 14 Feb 2024 18:25:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in ...osmo-epdg[master]: Send correct APN in GSUP CEAI Tunnel Response

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35976?usp=email ) Change subject: Send correct APN in GSUP CEAI Tunnel Response ...................................................................... Send correct APN in GSUP CEAI Tunnel Response Change-Id: Ifbd78720436690e9ee40688e455ab61d65085738 --- M src/epdg_gtpc_s2b.erl M src/gsup_server.erl 2 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/76/35976/1 diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl index 9b6d9ed..309ed79 100644 --- a/src/epdg_gtpc_s2b.erl +++ b/src/epdg_gtpc_s2b.erl @@ -386,6 +386,7 @@ lager:info("s2b: Updated Session after create_session_response: ~p~n", [Sess2]), State1 = update_gtp_session(Sess0, Sess2, State0), ResInfo = #{ + apn => binary_to_list(Sess0#gtp_session.apn), eua => conv:gtp2_paa_to_epdg_eua(Paa), local_teid => Bearer#gtp_bearer.local_data_tei, remote_teid => RemoteTEID, diff --git a/src/gsup_server.erl b/src/gsup_server.erl index 6930673..6bb98ee 100644 --- a/src/gsup_server.erl +++ b/src/gsup_server.erl @@ -156,10 +156,10 @@ lager:info("tunnel_response for ~p: ~p~n", [Imsi, Result]), Socket = State#gsups_state.socket, case Result of - {ok, #{eua := Eua}} -> + {ok, #{apn := Apn, eua := Eua}} -> PdpInfo = #{pdp_context_id => 0, pdp_address => conv:epdg_eua_to_gsup_pdp_address(Eua), - access_point_name => "foobar.apn", + access_point_name => Apn, quality_of_service => <<0, 0, 0>>, pdp_charging => 0}, Resp = #{message_type => epdg_tunnel_result, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Ifbd78720436690e9ee40688e455ab61d65085738 Gerrit-Change-Number: 35976 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 4 months

1
0
0 0

[M] Change in libosmo-sccp[master]: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email ) Change subject: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Gerrit-Change-Number: 35967 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 year, 4 months

1
0
0 0

[M] Change in libosmo-sccp[master]: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email ) Change subject: move osmo_ss7_xua_server_find() to osmo_ss7_xua_srv.c ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > curios: how is this an early patch earlier in the series to introduce TCP support? Almost like the m […] I was just confused to see the `xua_srv` specific API in a separate file, so I thought I was moving it to the right place. It's just (as I though) an improvement that I submitted meanwhile while working on adding the TCP support, similar to https://gerrit.osmocom.org/c/libosmo-sccp/+/35968. PS1: > If you see the file, I think I left on purpose all the "lookup" functions which act on the llist of […] Ok, I now see that all lookup functions are grouped together. Abandoning this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4fe2a79115bd630fb7d3f0f8677aa274361afebd Gerrit-Change-Number: 35967 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 18:13:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-msc[master]: msc_a_up_call_assignment_complete(): handle all CSD modes

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email ) Change subject: msc_a_up_call_assignment_complete(): handle all CSD modes ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I92f7ab11ebc2e53700b27c38e91679c2c6f72050 Gerrit-Change-Number: 35881 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 18:09:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-msc[master]: libsmpputil: fix -Wtautological-constant-out-of-range-compare

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email ) Change subject: libsmpputil: fix -Wtautological-constant-out-of-range-compare ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia71a0b6b9421911dc5113782d2f555a640fd90ed Gerrit-Change-Number: 35966 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 18:08:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

[S] Change in osmo-msc[master]: libvlr: fix auth_fsm_term(): use proper value-string for cause

by laforge

Attention is currently required from: fixeria, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35964?usp=email ) Change subject: libvlr: fix auth_fsm_term(): use proper value-string for cause ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia0868dce2da5cb78c30cf518870c3d91144499b9 Gerrit-Change-Number: 35964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Feb 2024 18:07:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2024