November 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email ) Change subject: L3_Templates: RAU Request: add support for MS Network Capability ...................................................................... L3_Templates: RAU Request: add support for MS Network Capability The MS Network Capability is important to determine the UMTS auth capability as well the R99 support. Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb --- M library/L3_Templates.ttcn 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/38916/1 diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index be15f57..fd68fcd 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -171,6 +171,22 @@ } } +function ts_GMM_MsNetCapTLV(template (omit) MSNetworkCapabilityV ms_network_cap) return template (omit) MSNetworkCapabilityTLV { + var template (omit) MSNetworkCapabilityTLV ret; + if (istemplatekind(ms_network_cap, "omit")) { + return omit; + } else { + ret := { + elementIdentifier := '31'O, + mSNetworkCapabilityLV := { + lengthIndicator := 0, /* overwritten */ + msNetworkCapabilityV := ms_network_cap + } + } + return ret; + } +} + /* send template for Mobile Identity (TMSI) */ function ts_MI_TMSI_TLV(template (omit) OCT4 tmsi) return template (omit) MobileIdentityTLV { var template (omit) MobileIdentityTLV ret; @@ -2621,6 +2637,7 @@ template (omit) P_TMSI_TypeTV p_tmsi_type := omit, template (omit) MobileIdentityTLV add_p_tmsi := omit, template (omit) RoutingAreaIdentification2TLV add_rai := omit, + template (omit) MSNetworkCapabilityV ms_network_cap := omit ) := { discriminator := '0000'B, /* overwritten */ tiOrSkip := { @@ -2639,7 +2656,7 @@ drxParameter := omit, tmsiStatus := omit, ptmsi := ts_MI_TMSI_TLV(p_tmsi), - mSNetworkCapability := omit, + mSNetworkCapability := ts_GMM_MsNetCapTLV(ms_network_cap), pdpContextStatus := omit, /* TODO */ pC_LCSCapability := omit, mBMS_ContextStatus := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb Gerrit-Change-Number: 38916 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[M] Change in libosmo-netif[master]: stream_cli: Add osmo_stream_cli_set_{ip_dscp,priority}() APIs

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38827?usp=email ) Change subject: stream_cli: Add osmo_stream_cli_set_{ip_dscp,priority}() APIs ...................................................................... Patch Set 5: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/38827/comment/ce7a2edd_7a56783… : PS5, Line 983: %u `%d` here and below? Can it be negative? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie5954fcf7eb1276210a99baf1e445c7ad54e0bb4 Gerrit-Change-Number: 38827 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Nov 2024 19:19:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months

1
0
0 0

[M] Change in libosmo-netif[master]: stream_srv: Add osmo_stream_srv_link_set_{ip_dscp,priority}() APIs

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email ) Change subject: stream_srv: Add osmo_stream_srv_link_set_{ip_dscp,priority}() APIs ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/38894/comment/d35d6f11_23b854a… : PS4, Line 165: %u) `%d`? https://gerrit.osmocom.org/c/libosmo-netif/+/38894/comment/a672b3ec_7042c34… : PS4, Line 258: return 0; Maybe just change to `void`? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iacb6b72a05055820253eaaa04850637dd2fc20e9 Gerrit-Change-Number: 38894 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Nov 2024 19:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[M] Change in libosmo-netif[master]: stream_cli: Add osmo_stream_cli_set_{ip_dscp,priority}() APIs

by fixeria

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38827?usp=email ) Change subject: stream_cli: Add osmo_stream_cli_set_{ip_dscp,priority}() APIs ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie5954fcf7eb1276210a99baf1e445c7ad54e0bb4 Gerrit-Change-Number: 38827 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Nov 2024 19:14:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38416?usp=email ) Change subject: SGSN: TC_attach_pdp_act_pmm_idle: use correct Service Request type ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9301e7a37d96c3f93e77f7618d6c13dfa1fbe46b Gerrit-Change-Number: 38416 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 24 Nov 2024 18:54:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: fix encoding of IMEISV in Auth and Ciphering Response

by fixeria

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email ) Change subject: SGSN: fix encoding of IMEISV in Auth and Ciphering Response ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: Looks like this one should be merged ASAP to fix ttcn3-sgsn-test regressions? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38414?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I79dd79840de58f450c1a05e704fd9bd831455716 Gerrit-Change-Number: 38414 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 24 Nov 2024 18:53:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_cell_change_different_*: always expect the auth

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38404?usp=email ) Change subject: SGSN: f_TC_cell_change_different_*: always expect the auth ...................................................................... Patch Set 6: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38404/comment/466f0d37_6fce… : PS6, Line 9: The new SGSN will always ask for authentication ... while the -latest osmo-sgsn will not, so will these TCs fail? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38404?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I24579b5fc843caf68e035e106cee4e4ec0a3c735 Gerrit-Change-Number: 38404 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 24 Nov 2024 18:52:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_paging_ps: call f_gmm_attach() direct

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38403?usp=email ) Change subject: SGSN: f_TC_paging_ps: call f_gmm_attach() direct ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38403?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I68c75f84b01a0cd673ffd8c19ab5f0a8517c5738 Gerrit-Change-Number: 38403 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 24 Nov 2024 18:50:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: f_TC_hlr_location_cancel_request_withdraw: drop incorrect Updat...

by fixeria

Attention is currently required from: lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38402?usp=email ) Change subject: SGSN: f_TC_hlr_location_cancel_request_withdraw: drop incorrect Update Location response ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38402?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8265416c650b0983d7e85786b334f84191331b2 Gerrit-Change-Number: 38402 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 24 Nov 2024 18:49:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email ) Change subject: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request ...................................................................... Patch Set 6: (1 comment) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401/comment/6872f41c_5fdf… : PS1, Line 653: g_pars.p_tmsi := 'c000004a'O; > Add a comment here explaining that you do an attach with tmsi so that it requests the IMSI. Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef Gerrit-Change-Number: 38401 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 24 Nov 2024 18:49:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024