November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email ) Change subject: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759 Gerrit-Change-Number: 38914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:50:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: msc: fix a race condition in f_mt_call_establish()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38913?usp=email ) Change subject: msc: fix a race condition in f_mt_call_establish() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8b69c3b59ea61e01adb24c71c1376335a5ddde6 Gerrit-Change-Number: 38913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 09:50:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G...

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38915?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G mobility tests ...................................................................... L3_Templates: GMM: Attach Req/RAU Req: add TLVs required for 4G -> 2G mobility tests Change-Id: I0a37b75f6b1a522868cdbff43d99d4b953a4e952 --- M library/L3_Templates.ttcn 1 file changed, 18 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/38915/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a37b75f6b1a522868cdbff43d99d4b953a4e952 Gerrit-Change-Number: 38915 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: L3_Templates: RAU Request: add support for MS Network Capability

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: L3_Templates: RAU Request: add support for MS Network Capability ...................................................................... L3_Templates: RAU Request: add support for MS Network Capability The MS Network Capability is important to determine the UMTS auth capability as well the R99 support. Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb --- M library/L3_Templates.ttcn 1 file changed, 19 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/38916/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id750c84ae1673ac33c98cecea035805e8cb92bcb Gerrit-Change-Number: 38916 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: tr_GTPC_SGSNContextReq: use the same template as MsgType

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email ) Change subject: tr_GTPC_SGSNContextReq: use the same template as MsgType ...................................................................... tr_GTPC_SGSNContextReq: use the same template as MsgType Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a --- M library/GTPv1C_Templates.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/38923/1 diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn index 766870a..7371ab0 100644 --- a/library/GTPv1C_Templates.ttcn +++ b/library/GTPv1C_Templates.ttcn @@ -1402,11 +1402,11 @@ private_extension_gtpc := * } } + template (present) Gtp1cUnitdata tr_GTPC_SGSNContextReq(template (present) Gtp1cPeer peer, - template (present) GTPC_PDUs SGSNContextReqPDU) := { - peer := peer, - gtpc := tr_GTP1C_PDU(sgsnContextRequest, '00000000'O, SGSNContextReqPDU) -} + template (present) GTPC_PDUs SGSNContextReqPDU) + := tr_GTPC_MsgType(peer, sgsnContextRequest, '00000000'O, SGSNContextReqPDU) + template (value) GTPC_PDUs ts_SGSNContextReqPDU(template (value) RoutingAreaIdentity rai, template (value) OCT4 teic, template (value) octetstring sgsn_addr_control, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idd546c3ec387e9c3ea8f1b1a61cf8ca8230db46a Gerrit-Change-Number: 38923 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect auth...

by lynxis lazus

Attention is currently required from: fixeria, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email ) Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ...................................................................... Patch Set 4: (3 comments) Patchset: PS3: > All my comments marked Done, but nothing changed? I think I'ven't yet pushed again. File sgsn/BSSGP_ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/436bc62e_a353… : PS4, Line 358: as_gmm_auth > You're adding this altstep, but not using it? Is it for a follow-up patch? I see there's also `f_gmm […] no it doesn't. f_gmm_auth() requires and expect to get certain parts in a specific way. also it fails if you don't have an auth. On certain tests, the test might not care, if an auth happened, just do an auth, if it is required. f_gmm_auth() requires to have an auth. it can also not used in alt steps. Yes there is an upcoming SGSN Context Request commit, which needs this. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/08d6de13_c0f0… : PS4, Line 363: Ignoring autn for now > TODO? `f_gmm_auth()` does handle AUTN, by the way. Yes, this is copied from the f_gmm_auth(). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ed08160bf5413e3a30d6e90eb947d4d799e1058 Gerrit-Change-Number: 38396 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 24 Nov 2024 22:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

7 months

1
0
0 0

[S] Change in libosmocore[master]: gsm_utils: add gprs_tlli2tmsi()

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... gsm_utils: add gprs_tlli2tmsi() A converter function which converts from a TLLI into a TMSI. Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 --- M include/osmocom/gsm/gsm_utils.h M src/gsm/gsm_utils.c M src/gsm/libosmogsm.map M tests/gprs/gprs_test.c 4 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/38764/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Context Req In: use correct TEID-C

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email ) Change subject: SGSN_Tests: Context Req In: use correct TEID-C ...................................................................... SGSN_Tests: Context Req In: use correct TEID-C For a MS/UE moving from 2G to 4G, the Ctx Acks need to transmit with the correct TEID-C which the SGSN chosen in the Context Response. Change-Id: I84dc7dda8ee1227edd68d1482a4c5bf267c16418 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/38920/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 03a0ebb..2ddeaff 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -3082,12 +3082,16 @@ T.start(2.0); alt { [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextResp(?, ?, ctx_rsp)) -> value gtpc_ud { + var OCT4 remote_teidc := gtpc_ud.gtpc.gtpc_pdu.sgsn_ContextResponse.teidControlPlane.teidControlPlane; + log("Rx SGSN Context Resp from SGSN, sending Ack"); - GTP[GTP_GGSN_IDX].send(ts_GTPC_SGSNContextAck(gtpc_ud.peer, '12345678'O, seq_nr)); + GTP[GTP_GGSN_IDX].send(ts_GTPC_SGSNContextAck(gtpc_ud.peer, remote_teidc, seq_nr)); setverdict(pass); } [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextResp) -> value gtpc_ud { - GTP[GTP_GGSN_IDX].send(ts_GTPC_SGSNContextAck(gtpc_ud.peer, '12345678'O, seq_nr, + var OCT4 remote_teidc := gtpc_ud.gtpc.gtpc_pdu.sgsn_ContextResponse.teidControlPlane.teidControlPlane; + + GTP[GTP_GGSN_IDX].send(ts_GTPC_SGSNContextAck(gtpc_ud.peer, remote_teidc, seq_nr, ts_SGSNContextAckPDU(GTP_CAUSE_INVALID_MSG_FORMAT))); setverdict(fail, "Rx unexpected SGSN Context Resp"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38920?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I84dc7dda8ee1227edd68d1482a4c5bf267c16418 Gerrit-Change-Number: 38920 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: assign random TEID-C to Context Req/Resp/Ack messages

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email ) Change subject: SGSN_Tests: assign random TEID-C to Context Req/Resp/Ack messages ...................................................................... SGSN_Tests: assign random TEID-C to Context Req/Resp/Ack messages Change-Id: Icac28280a810e8d24eeeaaae1fb1a15278fde8da --- M library/GTP_Emulation.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/38921/1 diff --git a/library/GTP_Emulation.ttcn b/library/GTP_Emulation.ttcn index c5ac029..c5e4e24 100644 --- a/library/GTP_Emulation.ttcn +++ b/library/GTP_Emulation.ttcn @@ -337,4 +337,7 @@ } } +function f_gtp_teid_random() return OCT4 { + return f_rnd_octstring(4); +} } diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 2ddeaff..c854b72 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -3037,6 +3037,7 @@ private function f_TC_sgsn_context_req_in(charstring id) runs on BSSGP_ConnHdlr { var integer seq_nr := f_rnd_int(65535); var Gtp1cUnitdata gtpc_ud; + var OCT4 teidc := f_gtp_teid_random(); timer T; var Gtp1cPeer peer := { @@ -3052,7 +3053,7 @@ * The MME requests information about the MS by sending SGSN Context Request. */ var template (value) GTPC_PDUs ctx_req; ctx_req := ts_SGSNContextReqPDU(rai := ts_RoutingAreaIdentity('250'H, 'F99'H, '4242'O, 'DE'O), - teic := '12345678'O, + teic := teidc, sgsn_addr_control := f_inet_addr(mp_ggsn_ip), ptmsi := ts_PTMSI(g_pars.p_tmsi), ptmsi_sig := ts_PTMSI_sig('010203'O)); @@ -3118,6 +3119,7 @@ private function f_TC_sgsn_context_req_out(charstring id) runs on BSSGP_ConnHdlr { var integer seq_nr := f_rnd_int(65535); var Gtp1cUnitdata gtpc_ud; + var OCT4 teidc := f_gtp_teid_random(); timer T; /* The MS goes to GERAN/UTRAN from an LTE cell */ @@ -3164,7 +3166,7 @@ var template (value) GTPC_PDUs ctx_rsp; ctx_rsp := ts_SGSNContextRespPDU(cause := GTP_CAUSE_REQUEST_ACCEPTED, imsi := g_pars.imsi, - teic := '12345678'O, + teic := teidc, mm_context := ts_MM_ContextGSM(kc), pdp_ctx_list := { pdp_ctx }); GTP[GTP_GGSN_IDX].send(ts_GTPC_SGSNContextResp(gtpc_ud.peer, '12345678'O, seq_nr, ctx_rsp)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icac28280a810e8d24eeeaaae1fb1a15278fde8da Gerrit-Change-Number: 38921 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN_Tests: Remove mm context triplets

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38922?usp=email ) Change subject: SGSN_Tests: Remove mm context triplets ...................................................................... SGSN_Tests: Remove mm context triplets Only triplets which hasn't been used should be included. The MME will only request and sent back a single set of tuples. There shouldn't any left overs. Change-Id: I60a3331396cb9905ec9a4df9b1e65a3291a51058 --- M sgsn/SGSN_Tests.ttcn 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/22/38922/1 diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index c854b72..c6c2c0a 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -3068,16 +3068,6 @@ var octetstring sgsn_addr := f_inet_addr(mp_sgsn_gtp_ip); ctx_rsp.sgsn_ContextResponse.sgsn_addr_controlPlane := tr_GsnAddr(sgsn_addr); - /* Match MM Context */ - if (ispresent(g_pars.vec)) { - /* XXX: this is only valid for GERAN */ - var octetstring triplet := g_pars.vec.rand & g_pars.vec.sres & g_pars.vec.kc; - ctx_rsp.sgsn_ContextResponse.mm_Context := tr_MM_ContextGSM(kc := g_pars.vec.kc, - triplet := triplet); - /* TODO: 7.5.4 "The IMEISV shall, if available, be included in the MM Context". - * See also 3GPP TS 29.060, section 7.7.28 and Table 47A */ - } - /* TODO: match PDP Context */ T.start(2.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I60a3331396cb9905ec9a4df9b1e65a3291a51058 Gerrit-Change-Number: 38922 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024