Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email ) Change subject: stream_srv: Add osmo_stream_srv_link_set_{ip_dscp,priority}() APIs ...................................................................... Patch Set 4: Code-Review+1 (2 comments) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/38894/comment/d35d6f11_23b854af... : PS4, Line 165: %u) `%d`? https://gerrit.osmocom.org/c/libosmo-netif/+/38894/comment/a672b3ec_7042c348... : PS4, Line 258: return 0; Maybe just change to `void`? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iacb6b72a05055820253eaaa04850637dd2fc20e9 Gerrit-Change-Number: 38894 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 24 Nov 2024 19:17:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes