November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis
by fixeria 23 Nov '24

23 Nov '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email ) Change subject: tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis ...................................................................... tests/gsm0408: remove outdated comment for bcap_csd_2400_v22bis The problem has been fixed in aec32dbf ("gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4") and the testcase is now passing. Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759 --- M tests/gsm0408/gsm0408_test.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/14/38914/1 diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index 7456ed8..5566b7c 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -131,9 +131,7 @@ static const struct bcap_test bcap_tests[] = { { csd_9600_v110_lv, &bcap_csd_9600_v110, "CSD 9600/V.110/transparent" }, { csd_4800_rlp_lv, &bcap_csd_4800_rlp, "CSD 4800/RLP/non-transparent" }, - { /* XXX: this testcase is expected to fail because octet 4 is not represented in - * 'struct gsm_mncc_bearer_cap' and the encoder unconditionally hard-codes it to 0x88. */ - csd_2400_v22bis_lv, &bcap_csd_2400_v22bis, "CSD 2400/V.22bis/transparent" }, + { csd_2400_v22bis_lv, &bcap_csd_2400_v22bis, "CSD 2400/V.22bis/transparent" }, { speech_all_lv, &bcap_speech_all, "Speech, all codecs" }, { speech_no3a_lv, &bcap_speech_no3a, "Speech, without octet 3a" }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4732cc08a485695e8b4dda47ed602046352c5759 Gerrit-Change-Number: 38914 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: msc: fix a race condition in f_mt_call_establish()
by fixeria 23 Nov '24

23 Nov '24

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38913?usp=email ) Change subject: msc: fix a race condition in f_mt_call_establish() ...................................................................... msc: fix a race condition in f_mt_call_establish() It can happen that the MSC sends a paging request quicker than function f_ran_register_imsi() returns (e.g. when a node executing the testsuite is under significant load). In this case the BSSMAP PAGING message is dropped by the RAN_Emulation CT: CommonBssmapUnitdataCallback: IMSI/TMSI not found in table This can be avoided by calling f_ran_register_imsi() *before* sending the MNCC SETUP.req, which is triggering paging. This patch fixes sporadic failures of: * TC_lu_and_mt_call * TC_lu_and_mt_call_ipv6 * TC_lu_and_mt_call_no_dlcx_resp Change-Id: Ie8b69c3b59ea61e01adb24c71c1376335a5ddde6 --- M msc/BSC_ConnectionHandler.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/38913/1 diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn index b7d1b94..4444f37 100644 --- a/msc/BSC_ConnectionHandler.ttcn +++ b/msc/BSC_ConnectionHandler.ttcn @@ -1420,12 +1420,12 @@ function f_mt_call_establish(inout CallParameters cpars) runs on BSC_ConnHdlr { + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); /* Initiate the call via MNCC */ f_mt_call_initiate(cpars); /* BSC <- MSC: Expect paging. FIXME: By TMSI or not? */ - f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); f_expect_paging() /* Complete the call via BSSAP */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie8b69c3b59ea61e01adb24c71c1376335a5ddde6 Gerrit-Change-Number: 38913 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based
by laforge 23 Nov '24

23 Nov '24

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/38912?usp=email ) Change subject: esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based ...................................................................... esim.saip.ProfileElementUSIM: Fix IMSI decode if [only] template based In case the fileDescriptor of EF.IMSI is purely template based and only the file content is given in the actual profile, we must pass a template reference to the File() constructor before we can read the IMSI. This fixes the following exception for some profiles: ValueError: File(ef-imsi): No fileDescriptor found in tuple, and none set by template before Change-Id: I14157a7b62ccd9b5b42de9b8060f2ebc5f91ebb3 --- M pySim/esim/saip/__init__.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/38912/1 diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 658810a..b65b398 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -1080,7 +1080,8 @@ @property def imsi(self) -> Optional[str]: - f = File('ef-imsi', self.decoded['ef-imsi']) + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + f = File('ef-imsi', self.decoded['ef-imsi'], template.files_by_pename.get('ef-imsi', None)) return dec_imsi(b2h(f.body)) class ProfileElementOptUSIM(FsProfileElement): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38912?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I14157a7b62ccd9b5b42de9b8060f2ebc5f91ebb3 Gerrit-Change-Number: 38912 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in android-apdu-proxy[master]: layout/main.xml: save some screen space
by laforge 23 Nov '24

23 Nov '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38903?usp=email ) Change subject: layout/main.xml: save some screen space ...................................................................... layout/main.xml: save some screen space Let's save some screen space by putting the buttons and the copyright notice closer together. Related: OS#6367 Change-Id: Ia565729b2726d6f361d17c0312c16a98a73c2b5c --- M app/src/main/res/layout/main.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/app/src/main/res/layout/main.xml b/app/src/main/res/layout/main.xml index 9d6f5b3..de2beb5 100644 --- a/app/src/main/res/layout/main.xml +++ b/app/src/main/res/layout/main.xml @@ -80,7 +80,7 @@ android:text="8002" /> <Button - android:layout_marginTop="40dp" + android:layout_marginTop="30dp" android:id="@+id/btnConnect" android:layout_width="match_parent" android:layout_height="wrap_content" @@ -102,7 +102,7 @@ android:text="exit" /> <TextView - android:layout_marginTop="40dp" + android:layout_marginTop="30dp" android:id="@+id/lblInfo" android:layout_width="match_parent" android:layout_height="wrap_content" -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Ia565729b2726d6f361d17c0312c16a98a73c2b5c Gerrit-Change-Number: 38903 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in android-apdu-proxy[master]: README.md: update supported android device list
by laforge 23 Nov '24

23 Nov '24

laforge has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38902?usp=email ) Change subject: README.md: update supported android device list ...................................................................... README.md: update supported android device list Related: OS#6367 Change-Id: I2edcc2e9c1e6a8677535caf55b2eeb5f68c46cfd --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/README.md b/README.md index 797478e..cc8e34f 100644 --- a/README.md +++ b/README.md @@ -288,6 +288,7 @@ | Brand | Model | Android version | API level | | -------- | ------------------------------ | --------------- | --------- | +| alcatel | 5028D | 10 | 29 | | CAT | S62Pro | 11 | 30 | | Google | Pixel4a | 14 | 34 | | Google | Pixel7a | 13 | 33 | -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I2edcc2e9c1e6a8677535caf55b2eeb5f68c46cfd Gerrit-Change-Number: 38902 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in android-apdu-proxy[master]: layout/main.xml: save some screen space
by laforge 23 Nov '24

23 Nov '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38903?usp=email ) Change subject: layout/main.xml: save some screen space ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Ia565729b2726d6f361d17c0312c16a98a73c2b5c Gerrit-Change-Number: 38903 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Nov 2024 10:22:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in android-apdu-proxy[master]: README.md: update supported android device list
by laforge 23 Nov '24

23 Nov '24

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38902?usp=email ) Change subject: README.md: update supported android device list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I2edcc2e9c1e6a8677535caf55b2eeb5f68c46cfd Gerrit-Change-Number: 38902 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 23 Nov 2024 10:21:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-netif[master]: stream_cli: Log destroy code path
by pespin 22 Nov '24

22 Nov '24

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38910?usp=email ) Change subject: stream_cli: Log destroy code path ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia371cd2d913f1d434b851809c6305301897108d9 Gerrit-Change-Number: 38910 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in libosmo-netif[master]: stream_cli: Add osmo_stream_cli_set_{ip_dscp,priority}() APIs
by pespin 22 Nov '24

22 Nov '24

Attention is currently required from: laforge, osmith, pespin. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38827?usp=email ) Change subject: stream_cli: Add osmo_stream_cli_set_{ip_dscp,priority}() APIs ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ie5954fcf7eb1276210a99baf1e445c7ad54e0bb4 Gerrit-Change-Number: 38827 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 22:26:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: esim.saip: Compute number of records from efFileSize and record_len
by fixeria 22 Nov '24

22 Nov '24

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38897?usp=email ) Change subject: esim.saip: Compute number of records from efFileSize and record_len ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0cc8e7241e37ee23df00c2622422904e7ccdca77 Gerrit-Change-Number: 38897 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 21:06:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log November 2024