November 2024 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-abis[master]: e1_input: Store new msg in llist before calling driver->want_write()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38904?usp=email ) Change subject: e1_input: Store new msg in llist before calling driver->want_write() ...................................................................... e1_input: Store new msg in llist before calling driver->want_write() This is needed for drivers handling the message synchronously during want_write() op. Until now this was not needed because probably all drivers are relying on poll based write to tx the message, which meant using the msg happened in a delayed form, asynchronously. Once we move the ipaccess driver to use libosmo-netif's stream, we'll need the msg to be available in the upper layer llist when want_write() is called, because at that time it will pop it from that llist and submit it to the lower layer stream tx_queue. Change-Id: I2b4e7bed502964fe03e3dabaeed668713b4baa7a --- M src/e1_input.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/04/38904/1 diff --git a/src/e1_input.c b/src/e1_input.c index d4e9e88..145fccf 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -307,12 +307,12 @@ return -EINVAL; } e1i_ts = sign_link->ts; + msgb_enqueue(&sign_link->tx_list, msg); if (!osmo_timer_pending(&e1i_ts->sign.tx_timer)) { /* notify the driver we have something to write */ e1inp_driver = sign_link->ts->line->driver; e1inp_driver->want_write(e1i_ts); } - msgb_enqueue(&sign_link->tx_list, msg); /* we only need to write a 'Fake LAPD' packet here, if the * underlying driver hides LAPD from us. If we use the -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I2b4e7bed502964fe03e3dabaeed668713b4baa7a Gerrit-Change-Number: 38904 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-bts[master]: bts-omldummy: print category names instead of hex values

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38883?usp=email ) Change subject: bts-omldummy: print category names instead of hex values ...................................................................... bts-omldummy: print category names instead of hex values Change-Id: I6082409f25e33cdf4480455bae16b5ac6c5bc1a4 --- M src/osmo-bts-omldummy/main.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/osmo-bts-omldummy/main.c b/src/osmo-bts-omldummy/main.c index 088fa52..8701895 100644 --- a/src/osmo-bts-omldummy/main.c +++ b/src/osmo-bts-omldummy/main.c @@ -132,6 +132,8 @@ msgb_talloc_ctx_init(tall_bts_ctx, 10*1024); osmo_init_logging2(tall_bts_ctx, &bts_log_info); + log_set_print_category(osmo_stderr_target, 1); + log_set_print_category_hex(osmo_stderr_target, 0); parse_cmdline(argc, argv); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6082409f25e33cdf4480455bae16b5ac6c5bc1a4 Gerrit-Change-Number: 38883 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-bts[master]: Fix missing quote char in log line

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38901?usp=email ) Change subject: Fix missing quote char in log line ...................................................................... Fix missing quote char in log line Change-Id: Ie272a268be8986210f7f6de0d28626789f28f4bb --- M src/common/main.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/main.c b/src/common/main.c index e57885a..2bdd8ce 100644 --- a/src/common/main.c +++ b/src/common/main.c @@ -361,7 +361,7 @@ /* TODO: move this to gsm_bts_alloc() */ if (g_bts->gsmtap.remote_host != NULL) { LOGP(DLGLOBAL, LOGL_NOTICE, - "Setting up GSMTAP Um forwarding '%s->'%s:%u'\n", + "Setting up GSMTAP Um forwarding '%s'->'%s:%u'\n", g_bts->gsmtap.local_host, g_bts->gsmtap.remote_host, GSMTAP_UDP_PORT); g_bts->gsmtap.inst = gsmtap_source_init2(g_bts->gsmtap.local_host, 0, g_bts->gsmtap.remote_host, GSMTAP_UDP_PORT, 1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie272a268be8986210f7f6de0d28626789f28f4bb Gerrit-Change-Number: 38901 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-bts[master]: Fix missing quote char in log line

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/38901?usp=email ) Change subject: Fix missing quote char in log line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie272a268be8986210f7f6de0d28626789f28f4bb Gerrit-Change-Number: 38901 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 18:03:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in osmo-bts[master]: bts-omldummy: print category names instead of hex values

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/38883?usp=email ) Change subject: bts-omldummy: print category names instead of hex values ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6082409f25e33cdf4480455bae16b5ac6c5bc1a4 Gerrit-Change-Number: 38883 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 18:03:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[S] Change in libosmocore[master]: ctrl: logging improvements

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38885?usp=email ) Change subject: ctrl: logging improvements ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id555fe0dc27e49af3c931ffb33124a15784ccfb3 Gerrit-Change-Number: 38885 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Nov 2024 18:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

7 months

1
0
0 0

[XS] Change in android-apdu-proxy[master]: layout/main.xml: save some screen space

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38903?usp=email ) Change subject: layout/main.xml: save some screen space ...................................................................... layout/main.xml: save some screen space Let's save some screen space by putting the buttons and the copyright notice closer together. Related: OS#6367 Change-Id: Ia565729b2726d6f361d17c0312c16a98a73c2b5c --- M app/src/main/res/layout/main.xml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/03/38903/1 diff --git a/app/src/main/res/layout/main.xml b/app/src/main/res/layout/main.xml index 9d6f5b3..de2beb5 100644 --- a/app/src/main/res/layout/main.xml +++ b/app/src/main/res/layout/main.xml @@ -80,7 +80,7 @@ android:text="8002" /> <Button - android:layout_marginTop="40dp" + android:layout_marginTop="30dp" android:id="@+id/btnConnect" android:layout_width="match_parent" android:layout_height="wrap_content" @@ -102,7 +102,7 @@ android:text="exit" /> <TextView - android:layout_marginTop="40dp" + android:layout_marginTop="30dp" android:id="@+id/lblInfo" android:layout_width="match_parent" android:layout_height="wrap_content" -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38903?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Ia565729b2726d6f361d17c0312c16a98a73c2b5c Gerrit-Change-Number: 38903 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in android-apdu-proxy[master]: README.md: update supported android device list

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/38902?usp=email ) Change subject: README.md: update supported android device list ...................................................................... README.md: update supported android device list Related: OS#6367 Change-Id: I2edcc2e9c1e6a8677535caf55b2eeb5f68c46cfd --- M README.md 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/02/38902/1 diff --git a/README.md b/README.md index 797478e..cc8e34f 100644 --- a/README.md +++ b/README.md @@ -288,6 +288,7 @@ | Brand | Model | Android version | API level | | -------- | ------------------------------ | --------------- | --------- | +| alcatel | 5028D | 10 | 29 | | CAT | S62Pro | 11 | 30 | | Google | Pixel4a | 14 | 34 | | Google | Pixel7a | 13 | 33 | -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/38902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I2edcc2e9c1e6a8677535caf55b2eeb5f68c46cfd Gerrit-Change-Number: 38902 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in osmo-bts[master]: Fix missing quote char in log line

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/38901?usp=email ) Change subject: Fix missing quote char in log line ...................................................................... Fix missing quote char in log line Change-Id: Ie272a268be8986210f7f6de0d28626789f28f4bb --- M src/common/main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/01/38901/1 diff --git a/src/common/main.c b/src/common/main.c index e57885a..2bdd8ce 100644 --- a/src/common/main.c +++ b/src/common/main.c @@ -361,7 +361,7 @@ /* TODO: move this to gsm_bts_alloc() */ if (g_bts->gsmtap.remote_host != NULL) { LOGP(DLGLOBAL, LOGL_NOTICE, - "Setting up GSMTAP Um forwarding '%s->'%s:%u'\n", + "Setting up GSMTAP Um forwarding '%s'->'%s:%u'\n", g_bts->gsmtap.local_host, g_bts->gsmtap.remote_host, GSMTAP_UDP_PORT); g_bts->gsmtap.inst = gsmtap_source_init2(g_bts->gsmtap.local_host, 0, g_bts->gsmtap.remote_host, GSMTAP_UDP_PORT, 1); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie272a268be8986210f7f6de0d28626789f28f4bb Gerrit-Change-Number: 38901 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

[XS] Change in libosmo-netif[master]: stream_cli: Log all code paths ending up in close/reconnect

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38892?usp=email ) Change subject: stream_cli: Log all code paths ending up in close/reconnect ...................................................................... stream_cli: Log all code paths ending up in close/reconnect This way it's possible to track why a connection was closed od/and reconnected (depending on reconnect config set by user). Change-Id: I6debc5de193d99919fe858befd905223ef965d81 --- M src/stream_cli.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/stream_cli.c b/src/stream_cli.c index 757de1c..25dda4f 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -353,11 +353,13 @@ OSMO_ASSERT(fd >= 0); if (ret < 0) { + LOGSCLI(cli, LOGL_ERROR, "connect failed (%d)\n", res); osmo_stream_cli_reconnect(cli); return; } ret = getsockopt(fd, SOL_SOCKET, SO_ERROR, &error, &len); if (ret >= 0 && error > 0) { + LOGSCLI(cli, LOGL_ERROR, "connect so_error (%d)\n", error); osmo_stream_cli_reconnect(cli); return; } @@ -895,6 +897,7 @@ } if (ret < 0) { + LOGSCLI(cli, LOGL_ERROR, "connect: socket creation error (%d)\n", ret); if (reconnect) osmo_stream_cli_reconnect(cli); return ret; @@ -1001,6 +1004,7 @@ } if (ret < 0) { + LOGSCLI(cli, LOGL_ERROR, "connect: socket creation error (%d)\n", ret); osmo_stream_cli_reconnect(cli); return ret; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38892?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6debc5de193d99919fe858befd905223ef965d81 Gerrit-Change-Number: 38892 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2024