October 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-iuh[master]: fix memleak in ran_decode: free after aper_decode() on error
by laforge 07 Oct '24

07 Oct '24

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email ) Change subject: fix memleak in ran_decode: free after aper_decode() on error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Idd1d10c523eddcf6d0c1d54346982d6ef6fc3799 Gerrit-Change-Number: 38333 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 05:47:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-iuh[master]: support RAB Assignment Response 'unsuccessfulOutcome'
by neels 07 Oct '24

07 Oct '24

Attention is currently required from: daniel, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email ) Change subject: support RAB Assignment Response 'unsuccessfulOutcome' ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-iuh/+/37393/comment/bde17021_00cd426c?usp… : PS2, Line 30: cn_ranap_rx_successful_msg_co(). > Decoding is also present in cn_ranap_rx_outcome_msg_co() I figured out the mixup, now it makes sense -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ifec566a98cb6141d27b9e5e33d5a78f8b1530658 Gerrit-Change-Number: 37393 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 07 Oct 2024 02:39:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-iuh[master]: support RAB Assignment Response 'unsuccessfulOutcome'
by neels 07 Oct '24

07 Oct '24

Attention is currently required from: daniel, laforge, neels. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by daniel, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: support RAB Assignment Response 'unsuccessfulOutcome' ...................................................................... support RAB Assignment Response 'unsuccessfulOutcome' Already present before this patch: - decoding 'successfulOutcome' in cn_ranap_rx_successful_msg_co() - decoding 'outcome' in cn_ranap_rx_outcome_msg_co() In this patch, add: - decoding 'unsuccessfulOutcome' in cn_ranap_rx_unsuccessful_msg_co() Context: A RAB Assignment response is indicated as 'successfulOutcome' or 'unsuccessfulOutcome' or 'outcome'. 3GPP TS 25.413 specifies RAB Assignment as a "Class 3 Elementary Procedure", but doesn't seem to specify which of these three 'outcome' types to use for Class 3. In the field we've seen 'successfulOutcome' and 'outcome'. A RAB Assignment response may actually contain responses for multiple RABs, and each of them can have a separate success or failure status. It seems that 'outcome' might be intended for such mixed responses. Either one is fine, because the included RAB Assignment Response IEs are always in the same format, regardless of the outcome type. Change-Id: Ifec566a98cb6141d27b9e5e33d5a78f8b1530658 --- M src/ranap_common_cn.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/93/37393/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/37393?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ifec566a98cb6141d27b9e5e33d5a78f8b1530658 Gerrit-Change-Number: 37393 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in osmo-iuh[master]: fix memleak in ran_decode: free after aper_decode() on error
by neels 07 Oct '24

07 Oct '24

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email ) Change subject: fix memleak in ran_decode: free after aper_decode() on error ...................................................................... fix memleak in ran_decode: free after aper_decode() on error Same fix as recently [1] applied to ranap_cn_rx_co_decode() now also applied to ranap_ran_rx_co_decode() [1] 48e1f1833ff06088c875157cc912dc25c5a01c29 I03ed2376e520ec6dbcc2bae22f9291e211c7cca9 Change-Id: Idd1d10c523eddcf6d0c1d54346982d6ef6fc3799 --- M src/ranap_common_ran.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/33/38333/1 diff --git a/src/ranap_common_ran.c b/src/ranap_common_ran.c index 048a5df..828587e 100644 --- a/src/ranap_common_ran.c +++ b/src/ranap_common_ran.c @@ -300,13 +300,15 @@ dec_ret = aper_decode(NULL, &asn_DEF_RANAP_RANAP_PDU, (void **)&pdu, data, len, 0, 0); if (dec_ret.code != RC_OK) { LOGP(DRANAP, LOGL_ERROR, "Error in RANAP ASN.1 decode\n"); - return -1; + rc = -1; + goto error_free; } message->direction = pdu->present; rc = _ran_ranap_rx_co(ctx, pdu, message); +error_free: ASN_STRUCT_FREE(asn_DEF_RANAP_RANAP_PDU, pdu); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38333?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Idd1d10c523eddcf6d0c1d54346982d6ef6fc3799 Gerrit-Change-Number: 38333 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: trau 8k decode: set fr->type correctly
by fixeria 06 Oct '24

06 Oct '24

Attention is currently required from: falconia, laforge. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email ) Change subject: trau 8k decode: set fr->type correctly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3160e458e49b8c439c6483d6141623ba68866173 Gerrit-Change-Number: 38332 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Oct 2024 18:14:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau: detect 8k AMR 7.40k frames correctly for decoding
by fixeria 06 Oct '24

06 Oct '24

Attention is currently required from: falconia, laforge. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email ) Change subject: trau: detect 8k AMR 7.40k frames correctly for decoding ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iad527d4141cf4d76feea56399ea1916813e1e941 Gerrit-Change-Number: 38331 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 06 Oct 2024 18:14:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau: detect 8k AMR 7.40k frames correctly for decoding
by pespin 06 Oct '24

06 Oct '24

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email ) Change subject: trau: detect 8k AMR 7.40k frames correctly for decoding ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iad527d4141cf4d76feea56399ea1916813e1e941 Gerrit-Change-Number: 38331 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 05 Oct 2024 21:47:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau 8k decode: set fr->type correctly
by pespin 06 Oct '24

06 Oct '24

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email ) Change subject: trau 8k decode: set fr->type correctly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3160e458e49b8c439c6483d6141623ba68866173 Gerrit-Change-Number: 38332 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 05 Oct 2024 21:46:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: trau: detect 8k AMR 7.40k frames correctly for decoding
by falconia 05 Oct '24

05 Oct '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email ) Change subject: trau: detect 8k AMR 7.40k frames correctly for decoding ...................................................................... trau: detect 8k AMR 7.40k frames correctly for decoding osmo_trau_frame_decode_8k() detects different possible frame structures by their sync pattern bits. The distinctive sync pattern of AMR 7.40k format was checked incorrectly, thereby precluding decoding of such frames. Change-Id: Iad527d4141cf4d76feea56399ea1916813e1e941 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/31/38331/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 966c794..8347303 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1454,7 +1454,7 @@ /*!< check sync pattern for AMR 7.4kBit/s */ static bool is_amr_74(const ubit_t *bits) { - if (bits[0] != 0 || bits[1] != 0 || bits[2] != 0) + if (bits[0] != 0 || bits[1] != 0 || bits[2] != 1) return false; if (bits[8] != 0) return false; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iad527d4141cf4d76feea56399ea1916813e1e941 Gerrit-Change-Number: 38331 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in libosmo-abis[master]: trau 8k decode: set fr->type correctly
by falconia 05 Oct '24

05 Oct '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email ) Change subject: trau 8k decode: set fr->type correctly ...................................................................... trau 8k decode: set fr->type correctly osmo_trau_frame_decode_16k() sets fr->type to the correct OSMO_TRAU* frame type before tail-calling the respective decoding function; osmo_trau_frame_decode_8k() was failing to do likewise, resulting in fr->type not being set correctly. Fix it. Change-Id: I3160e458e49b8c439c6483d6141623ba68866173 --- M src/trau/trau_frame.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/32/38332/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 8347303..21e4f00 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1484,28 +1484,37 @@ if (dir == OSMO_TRAU_DIR_UL) { switch (cbits5) { /* Section 5.2.4.1.1 */ case 0x02: + fr->type = OSMO_TRAU8_SPEECH; return decode8_hr(fr, bits, dir); case 0x07: + fr->type = OSMO_TRAU8_DATA; return decode8_data(fr, bits, dir); case 0x0B: + fr->type = OSMO_TRAU8_OAM; return decode8_oam(fr, bits, dir); } } else { /* Downlink */ switch (cbits5 >> 2) { /* Section 5.2.4.1.2 */ case 0: + fr->type = OSMO_TRAU8_SPEECH; return decode8_hr(fr, bits, dir); case 1: + fr->type = OSMO_TRAU8_DATA; return decode8_data(fr, bits, dir); case 2: + fr->type = OSMO_TRAU8_OAM; return decode8_oam(fr, bits, dir); } } } else if (is_amr_low(bits)) { + fr->type = OSMO_TRAU8_AMR_LOW; return decode8_amr_low(fr, bits, dir); } else if (is_amr_67(bits)) { + fr->type = OSMO_TRAU8_AMR_6k7; return decode8_amr_67(fr, bits, dir); } else if (is_amr_74(bits)) { + fr->type = OSMO_TRAU8_AMR_7k4; return decode8_amr_74(fr, bits, dir); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38332?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I3160e458e49b8c439c6483d6141623ba68866173 Gerrit-Change-Number: 38332 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0