October 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: trau_frame: D145_SYNC does not follow EDATA format
by laforge 05 Oct '24

05 Oct '24

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38324?usp=email ) Change subject: trau_frame: D145_SYNC does not follow EDATA format ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7c743996fc620227438225ffda419217881034d1 Gerrit-Change-Number: 38324 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 05 Oct 2024 08:42:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: TRAU frame output EDATA: set sync pattern bits
by laforge 05 Oct '24

05 Oct '24

Attention is currently required from: falconia, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email ) Change subject: TRAU frame output EDATA: set sync pattern bits ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 Gerrit-Change-Number: 38323 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 05 Oct 2024 08:42:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: TRAU frame output EDATA: set sync pattern bits
by falconia 05 Oct '24

05 Oct '24

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email ) Change subject: TRAU frame output EDATA: set sync pattern bits ...................................................................... Patch Set 2: (2 comments) File src/trau/trau_frame.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/6f142a84_79097287… : PS1, Line 680: memset(trau_bits, 0, 16); > This memset is not 0-initialization, it is the sync pattern. See the frame structure table in TS 48. […] Done https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/c6e3664e_f8540e81… : PS1, Line 681: trau_bits[17] = 1; > Oops, I was setting the wrong bit - good catch! Fixed in the new patch revision. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 Gerrit-Change-Number: 38323 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Oct 2024 22:27:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in upf-benchmark[master]: Initial version of improved osmo-pfcp-tool from osmo-upf.git.
by pespin 05 Oct '24

05 Oct '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email ) Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > tbh I don't think it's worth it, since then we'd also need to spend time moving code around into dif […] Just to be clear, I even want to rename the osmo-pfcp-tool since the current state is not really that of the old osmo-pfcp-tool in osmo-upf.git. I plan to do so in a follow-up commit. -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1 Gerrit-Change-Number: 38327 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Oct 2024 22:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: TRAU frame output EDATA: set sync pattern bits
by pespin 05 Oct '24

05 Oct '24

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email ) Change subject: TRAU frame output EDATA: set sync pattern bits ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 Gerrit-Change-Number: 38323 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 04 Oct 2024 22:12:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in upf-benchmark[master]: Initial version of improved osmo-pfcp-tool from osmo-upf.git.
by pespin 05 Oct '24

05 Oct '24

Attention is currently required from: laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email ) Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > shouldn't we start with an import of the project history using "git filter-branch" or related tools? tbh I don't think it's worth it, since then we'd also need to spend time moving code around into differnet directiories, dropping/stripping out sutff not needed, etc. From osmo-upf.git master afaik there's only an old osmo-pfcp-tool which was used as a base to add a lot more features which are kept in a separate WIP in branch (not really cleaned up) which Neels started and which I squashed with my own changes I did (again with an unstructured changeset while testing stuff). So I think doing a proper import will take us a lot of time for no real good benefit. -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1 Gerrit-Change-Number: 38327 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Oct 2024 22:09:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-abis[master]: TRAU frame output EDATA: set sync pattern bits
by falconia 04 Oct '24

04 Oct '24

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email ) Change subject: TRAU frame output EDATA: set sync pattern bits ...................................................................... Patch Set 2: (2 comments) File src/trau/trau_frame.c: https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/989e4901_6fe2c951… : PS1, Line 680: memset(trau_bits, 0, 16); > did you check if it makes sense that this function expects the trau_bits to be 0 initialized? Eg exi […] This memset is not 0-initialization, it is the sync pattern. See the frame structure table in TS 48.060 section 5.3.2: the sync pattern consists of the first 16 bits being all zeros, then a single one. "Regular" data and speech frames have more sync pattern bits, but E-TRAU (or EDATA) frames have a reduced sync pattern. The other encoding functions under `osmo_trau_frame_encode` call `encode_sync16` helper, but because we have to produce the reduced sync pattern here, I am doing it directly. https://gerrit.osmocom.org/c/libosmo-abis/+/38323/comment/6ed8fe88_9f3d96f8… : PS1, Line 681: trau_bits[17] = 1; > isn't this overwritten by the memcpy below? Oops, I was setting the wrong bit - good catch! Fixed in the new patch revision. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 Gerrit-Change-Number: 38323 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Oct 2024 17:20:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: TRAU frame output EDATA: set sync pattern bits
by falconia 04 Oct '24

04 Oct '24

Attention is currently required from: falconia. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: TRAU frame output EDATA: set sync pattern bits ...................................................................... TRAU frame output EDATA: set sync pattern bits osmo_trau_frame_encode() for OSMO_TRAU16_FT_EDATA previously failed to set the sync pattern bits in the generated output. Fix it. Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 --- M src/trau/trau_frame.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/23/38323/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 Gerrit-Change-Number: 38323 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org>

1 0

[XL] Change in upf-benchmark[master]: Initial version of improved osmo-pfcp-tool from osmo-upf.git.
by laforge 04 Oct '24

04 Oct '24

Attention is currently required from: neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email ) Change subject: Initial version of improved osmo-pfcp-tool from osmo-upf.git. ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: shouldn't we start with an import of the project history using "git filter-branch" or related tools? -- To view, visit https://gerrit.osmocom.org/c/upf-benchmark/+/38327?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: upf-benchmark Gerrit-Branch: master Gerrit-Change-Id: I179d575f53ef5797f296e13cd4d52a043fc4c1c1 Gerrit-Change-Number: 38327 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Oct 2024 16:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: jobs: gerrit-verifications.yml: Add job for upf-benchmark.git
by laforge 04 Oct '24

04 Oct '24

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/38330?usp=email ) Change subject: jobs: gerrit-verifications.yml: Add job for upf-benchmark.git ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7212e8f88c731993af01e0e42ddaad6dd7291c37 Gerrit-Change-Number: 38330 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Oct 2024 16:11:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0