October 2024 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: trau_frame: D145_SYNC does not follow EDATA format
by falconia 04 Oct '24

04 Oct '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38324?usp=email ) Change subject: trau_frame: D145_SYNC does not follow EDATA format ...................................................................... trau_frame: D145_SYNC does not follow EDATA format 14.5 kbit/s data service uses a special protocol: the CCU and the TRAU exchange D145_SYNC frames first, conveying only alignment of 320-bit TRAU frames, then switch to EDATA frames that can carry payload. (EDATA frames don't have enough sync pattern bits to be reliable against false alignment.) Per TS 48.060 section 5.5.3, D145_SYNC frames are structured like "regular" (lower rates) data frames with all payload bits set to 1, _not_ like EDATA frames. Therefore: * osmo_trau_frame_decode_16k() should decode D145_SYNC frames like regular data frames, not like EDATA; * osmo_trau_frame_encode() given OSMO_TRAU16_FT_D145_SYNC should produce a frame with correct sync pattern and all-1 payload bits, but with control bits up to C15 per TS 48.060 section 5.5.3. Change-Id: I7c743996fc620227438225ffda419217881034d1 --- M src/trau/trau_frame.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/24/38324/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 4719bd0..a8668b3 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -650,6 +650,22 @@ return 40 * 8; } +/* TS 48.060 section 5.5.3 */ +static int encode16_d145_sync(ubit_t *trau_bits, const struct osmo_trau_frame *fr) +{ + encode_sync16(trau_bits); + + /* C1 .. C5 */ + memcpy(trau_bits + 17, ft_d145s_bits, 5); + /* C6 .. C15 */ + memcpy(trau_bits + 17 + 5, fr->c_bits + 5, 15 - 5); + + /* This frame is for sync only, all data bits filled with 1s */ + memset(trau_bits + 4 * 8, 1, (40 - 4) * 8); + + return 40 * 8; +} + /* TS 08.60 3.3.2 */ static int decode16_edata(struct osmo_trau_frame *fr, const ubit_t *trau_bits, enum osmo_trau_frame_direction dir) @@ -1285,6 +1301,7 @@ case OSMO_TRAU16_FT_DATA: return encode16_data(bits, fr); case OSMO_TRAU16_FT_D145_SYNC: + return encode16_d145_sync(bits, fr); case OSMO_TRAU16_FT_EDATA: return encode16_edata(bits, fr); case OSMO_TRAU8_SPEECH: @@ -1355,7 +1372,7 @@ return decode16_edata(fr, bits, dir); case TRAU_FT_D145_SYNC: fr->type = OSMO_TRAU16_FT_D145_SYNC; - return decode16_edata(fr, bits, dir); + return decode16_data(fr, bits, dir); default: return -EINVAL; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38324?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7c743996fc620227438225ffda419217881034d1 Gerrit-Change-Number: 38324 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in libosmo-abis[master]: TRAU frame output EDATA: set sync pattern bits
by falconia 04 Oct '24

04 Oct '24

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email ) Change subject: TRAU frame output EDATA: set sync pattern bits ...................................................................... TRAU frame output EDATA: set sync pattern bits osmo_trau_frame_encode() for OSMO_TRAU16_FT_EDATA previously failed to set the sync pattern bits in the generated output. Fix it. Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 --- M src/trau/trau_frame.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/23/38323/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 43b0e6b..4719bd0 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -676,6 +676,10 @@ else cbits5 = ft_edata_bits; + /* sync pattern */ + memset(trau_bits, 0, 16); + trau_bits[17] = 1; + /* C1 .. C5 */ memcpy(trau_bits + 17, cbits5, 5); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/38323?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iacd391cb6d389d8320c8ed767878eed144ee9d69 Gerrit-Change-Number: 38323 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[XS] Change in osmo-bts[master]: l1sap: move struct osmo_rlp_frame_decoded to the if-scope
by fixeria 03 Oct '24

03 Oct '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: l1sap: move struct osmo_rlp_frame_decoded to the if-scope ...................................................................... l1sap: move struct osmo_rlp_frame_decoded to the if-scope Change-Id: Ide99b35192246b0f7b2a4f31281e2d84984a9795 --- M src/common/l1sap.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved falconia: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 63be237..3157807 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -1857,7 +1857,6 @@ { struct gsm_bts_trx *trx = lchan->ts->trx; struct gsmtap_inst *inst = trx->bts->gsmtap.inst; - struct osmo_rlp_frame_decoded rlpf; pbit_t *rlp_buf; uint16_t arfcn; int byte_len; @@ -1913,6 +1912,7 @@ } if (trx->bts->gsmtap.rlp_skip_null) { + struct osmo_rlp_frame_decoded rlpf; int rc = osmo_rlp_decode(&rlpf, 0, rlp_buf, byte_len); if (rc == 0 && rlpf.ftype == OSMO_RLP_FT_U && rlpf.u_ftype == OSMO_RLP_U_FT_NULL) return; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide99b35192246b0f7b2a4f31281e2d84984a9795 Gerrit-Change-Number: 38315 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-bts[master]: l1sap: prevent buffer overflow in l1sap_rtp_rx_cb()
by fixeria 03 Oct '24

03 Oct '24

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/38313?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: l1sap: prevent buffer overflow in l1sap_rtp_rx_cb() ...................................................................... l1sap: prevent buffer overflow in l1sap_rtp_rx_cb() Change-Id: I214070ecf7458202922475505a8747950bedf930 Fixes: d1f8f3429 "l1sap: proper rate adaptation for CSD" --- M src/common/l1sap.c 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: falconia: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 5a900f8..63be237 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -2460,7 +2460,9 @@ OSMO_ASSERT(0); } - msg = l1sap_msgb_alloc(512); +#define L1SAP_MSGB_L2LEN_TCH 512 + + msg = l1sap_msgb_alloc(L1SAP_MSGB_L2LEN_TCH); if (!msg) return; @@ -2479,6 +2481,12 @@ return; } } else { + if (OSMO_UNLIKELY(rtp_pl_len > L1SAP_MSGB_L2LEN_TCH)) { + LOGPLCHAN(lchan, DL1P, LOGL_ERROR, + "%s(): incoming RTP truncated: %u -> %u\n", + __func__, rtp_pl_len, L1SAP_MSGB_L2LEN_TCH); + rtp_pl_len = L1SAP_MSGB_L2LEN_TCH; /* truncate */ + } memcpy(msgb_put(msg, rtp_pl_len), rtp_pl, rtp_pl_len); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I214070ecf7458202922475505a8747950bedf930 Gerrit-Change-Number: 38313 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-bts[master]: l1sap: move struct osmo_rlp_frame_decoded to the if-scope
by laforge 03 Oct '24

03 Oct '24

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email ) Change subject: l1sap: move struct osmo_rlp_frame_decoded to the if-scope ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide99b35192246b0f7b2a4f31281e2d84984a9795 Gerrit-Change-Number: 38315 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Oct 2024 15:42:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in pysim[master]: tests: sanitize all cards before running tests
by laforge 03 Oct '24

03 Oct '24

Attention is currently required from: dexter, fixeria, osmith. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email ) Change subject: tests: sanitize all cards before running tests ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/38254/comment/ba9a9eca_cc3bfbbb?usp=em… : PS4, Line 14: let's reset the cards to a defined state before : running the actual tests I don't think this patch actually executes anything "before running the test"? It seems to merely add functionality that is not used/executed by anything iside this patch? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I42eaf61280968518164f2280245136fd30a603ce Gerrit-Change-Number: 38254 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Oct 2024 15:28:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in pysim[master]: tests: sanitize all cards before running tests
by laforge 03 Oct '24

03 Oct '24

Attention is currently required from: dexter, fixeria, osmith. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email ) Change subject: tests: sanitize all cards before running tests ...................................................................... Patch Set 4: (1 comment) Patchset: PS1: > I think we should merge this patch for now and do the multi threading patch in a followup patch. […] We can merge single-threaded card sanitizion functionality, as long as it is only triggered by the nightly/manual job that @osmith has been working on, and not automatically for every gerrit patch verification job. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38254?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I42eaf61280968518164f2280245136fd30a603ce Gerrit-Change-Number: 38254 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Oct 2024 15:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: jobs/master-builds: add param EMAIL_NOTIFICATIONS
by laforge 03 Oct '24

03 Oct '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38320?usp=email ) Change subject: jobs/master-builds: add param EMAIL_NOTIFICATIONS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38320?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia8fa57f1efd04684f08db4377c42358c534faff9 Gerrit-Change-Number: 38320 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Oct 2024 15:25:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/master-builds: add param BRANCH
by laforge 03 Oct '24

03 Oct '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38319?usp=email ) Change subject: jobs/master-builds: add param BRANCH ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5fb64024dc4ad70cb3dd019bd505aacc58d14380 Gerrit-Change-Number: 38319 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Oct 2024 15:24:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: jobs/simtester-sanitize: new job
by laforge 03 Oct '24

03 Oct '24

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38318?usp=email ) Change subject: jobs/simtester-sanitize: new job ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie1846b031224a2a9604c22e7d81016c08e217bbc Gerrit-Change-Number: 38318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Oct 2024 15:24:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0